mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-06-29 15:31:05 +08:00
fix(agent): restore be_output and test DeepL error return (#16363)
## Summary #16332 fixed the missing `return` in DeepL's except branch, but `ComponentBase.be_output` was removed during the agent refactor (#9113) while several components still call it. DeepL (and other tools) would raise `AttributeError` before any error message could be returned. - Restore `ComponentBase.be_output` as `pd.DataFrame([{"content": v}])` (same as pre-refactor behavior) - Add regression test that `_run` returns the `**Error**:` message when translation fails Related to #16329 ## Test plan - [x] `test_run_returns_error_on_translation_failure` - [x] Existing `test_deepl.py` check() tests still pass --------- Co-authored-by: Harsh Kashyap <harshkashyap@Harshs-MacBook-Pro.local> Co-authored-by: Zhichang Yu <yuzhichang@gmail.com>
This commit is contained in:
@@ -562,6 +562,10 @@ class ComponentBase(ABC):
|
||||
return None
|
||||
return self._param.inputs[key].get("value")
|
||||
|
||||
@staticmethod
|
||||
def be_output(v):
|
||||
return pd.DataFrame([{"content": v}])
|
||||
|
||||
def get_component_name(self, cpn_id) -> str:
|
||||
return self._canvas.get_component(cpn_id)["obj"].component_name.lower()
|
||||
|
||||
|
||||
@@ -14,12 +14,26 @@
|
||||
# limitations under the License.
|
||||
#
|
||||
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
# DeepL component imports the `deepl` SDK at module load; skip where absent.
|
||||
pytest.importorskip("deepl")
|
||||
|
||||
from agent.tools.deepl import DeepLParam # noqa: E402
|
||||
from agent.tools.deepl import DeepL, DeepLParam # noqa: E402
|
||||
|
||||
|
||||
class _Canvas:
|
||||
def is_canceled(self):
|
||||
return False
|
||||
|
||||
|
||||
def _deepl(param=None):
|
||||
cpn = DeepL.__new__(DeepL)
|
||||
cpn._canvas = _Canvas()
|
||||
cpn._param = param or DeepLParam()
|
||||
return cpn
|
||||
|
||||
|
||||
def test_check_passes_with_defaults():
|
||||
@@ -40,3 +54,16 @@ def test_check_rejects_invalid_target_lang():
|
||||
param.target_lang = "XX"
|
||||
with pytest.raises(ValueError):
|
||||
param.check()
|
||||
|
||||
|
||||
@pytest.mark.p1
|
||||
def test_run_returns_error_on_translation_failure():
|
||||
cpn = _deepl()
|
||||
cpn._param.inputs = {"content": {"value": ["hello"]}}
|
||||
|
||||
with patch.object(DeepL, "get_input", return_value={"content": ["hello"]}):
|
||||
with patch("agent.tools.deepl.deepl.Translator") as translator_cls:
|
||||
translator_cls.return_value.translate_text.side_effect = RuntimeError("boom")
|
||||
result = cpn._run([])
|
||||
|
||||
assert "**Error**:boom" in result.iloc[0]["content"]
|
||||
|
||||
Reference in New Issue
Block a user