mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-06-29 15:31:05 +08:00
6a4de82a80
## Summary #16332 fixed the missing `return` in DeepL's except branch, but `ComponentBase.be_output` was removed during the agent refactor (#9113) while several components still call it. DeepL (and other tools) would raise `AttributeError` before any error message could be returned. - Restore `ComponentBase.be_output` as `pd.DataFrame([{"content": v}])` (same as pre-refactor behavior) - Add regression test that `_run` returns the `**Error**:` message when translation fails Related to #16329 ## Test plan - [x] `test_run_returns_error_on_translation_failure` - [x] Existing `test_deepl.py` check() tests still pass --------- Co-authored-by: Harsh Kashyap <harshkashyap@Harshs-MacBook-Pro.local> Co-authored-by: Zhichang Yu <yuzhichang@gmail.com>
70 lines
2.0 KiB
Python
70 lines
2.0 KiB
Python
#
|
|
# Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
# DeepL component imports the `deepl` SDK at module load; skip where absent.
|
|
pytest.importorskip("deepl")
|
|
|
|
from agent.tools.deepl import DeepL, DeepLParam # noqa: E402
|
|
|
|
|
|
class _Canvas:
|
|
def is_canceled(self):
|
|
return False
|
|
|
|
|
|
def _deepl(param=None):
|
|
cpn = DeepL.__new__(DeepL)
|
|
cpn._canvas = _Canvas()
|
|
cpn._param = param or DeepLParam()
|
|
return cpn
|
|
|
|
|
|
def test_check_passes_with_defaults():
|
|
# Regression: check() validated an undefined self.top_n and always raised
|
|
# AttributeError, so a DeepL component could never pass validation.
|
|
DeepLParam().check()
|
|
|
|
|
|
def test_check_rejects_invalid_source_lang():
|
|
param = DeepLParam()
|
|
param.source_lang = "XX"
|
|
with pytest.raises(ValueError):
|
|
param.check()
|
|
|
|
|
|
def test_check_rejects_invalid_target_lang():
|
|
param = DeepLParam()
|
|
param.target_lang = "XX"
|
|
with pytest.raises(ValueError):
|
|
param.check()
|
|
|
|
|
|
@pytest.mark.p1
|
|
def test_run_returns_error_on_translation_failure():
|
|
cpn = _deepl()
|
|
cpn._param.inputs = {"content": {"value": ["hello"]}}
|
|
|
|
with patch.object(DeepL, "get_input", return_value={"content": ["hello"]}):
|
|
with patch("agent.tools.deepl.deepl.Translator") as translator_cls:
|
|
translator_cls.return_value.translate_text.side_effect = RuntimeError("boom")
|
|
result = cpn._run([])
|
|
|
|
assert "**Error**:boom" in result.iloc[0]["content"]
|