mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-08-01 13:33:48 +08:00
8fc20dd9ca
### Summary Aligns Go and Python error codes/messages so both backends honor the same RESTful API contract, removing implementation-specific error leaks (MySQL errors, `ValueError`, `AttributeError`, Gin validator format) in favor of clean business error codes. **Chat list** — invalid `orderby` now returns code 101 (was: raw Python `AttributeError` code 100); invalid `page`/`page_size` values fall back to defaults (was: raw `ValueError`/`ProgrammingError` code 100). **Dataset create/update/delete** — adds UUID validation (101), extra-field rejection (101), duplicate-id detection (101), content-type / JSON-syntax / object-shape checks (101), and "lacks permission" for nonexistent datasets (IDOR). Create auto-deduplicates dataset names. Pagerank updates tolerate a missing ES index. List response includes `parser_config` and `pagerank`. **Session list/update** — adds filtering, sorting, and pagination support. Empty payloads are valid no-ops. Authorization errors map to code 109. **Chunk list** — doc object uses Python key names (`chunk_count`, `dataset_id`, `chunk_method`, run text status). Add validates list element types. **Document update** — adds `chunk_method` alias, pydantic-style Field error messages, metadata index auto-create with refresh, and "These documents do not belong to dataset" messages. List validates `metadata_condition` and reports ownership errors for unmatched name/id filters. **Search completion** — `kb_ids` ownership failure returns code 102 instead of 109. Released 31 contract tests from `GO_ONLY_SKIPS` (all verified passing on both Go and Python backends with real LLM keys).
77 lines
2.3 KiB
Go
77 lines
2.3 KiB
Go
package handler
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"ragflow/internal/common"
|
|
"ragflow/internal/entity"
|
|
"ragflow/internal/service"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
func TestChatSessionHandlerUpdateMessageFeedback_RejectsEmptyBody(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := gin.CreateTestContext(recorder)
|
|
ctx.Request = httptest.NewRequest(http.MethodPut, "/api/v1/chats/chat-1/sessions/session-1/messages/msg-1/feedback", nil)
|
|
ctx.Params = gin.Params{
|
|
{Key: "chat_id", Value: "chat-1"},
|
|
{Key: "session_id", Value: "session-1"},
|
|
{Key: "msg_id", Value: "msg-1"},
|
|
}
|
|
ctx.Set("user", &entity.User{ID: "user-1"})
|
|
|
|
handler := NewChatSessionHandler(service.NewChatSessionService(), nil)
|
|
handler.UpdateMessageFeedback(ctx)
|
|
|
|
if recorder.Code != http.StatusOK {
|
|
t.Fatalf("status=%d", recorder.Code)
|
|
}
|
|
|
|
var body map[string]interface{}
|
|
if err := json.Unmarshal(recorder.Body.Bytes(), &body); err != nil {
|
|
t.Fatalf("decode response body: %v", err)
|
|
}
|
|
if got := body["code"]; got != float64(common.CodeArgumentError) {
|
|
t.Fatalf("code=%v", got)
|
|
}
|
|
if got := body["message"]; got != "Request body cannot be empty" {
|
|
t.Fatalf("message=%v", got)
|
|
}
|
|
}
|
|
|
|
func TestChatSessionHandlerUpdateMessageFeedback_RejectsEmptyJSONObject(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := gin.CreateTestContext(recorder)
|
|
ctx.Request = httptest.NewRequest(http.MethodPut, "/api/v1/chats/chat-1/sessions/session-1/messages/msg-1/feedback", strings.NewReader(`{}`))
|
|
ctx.Request.Header.Set("Content-Type", "application/json")
|
|
ctx.Params = gin.Params{
|
|
{Key: "chat_id", Value: "chat-1"},
|
|
{Key: "session_id", Value: "session-1"},
|
|
{Key: "msg_id", Value: "msg-1"},
|
|
}
|
|
ctx.Set("user", &entity.User{ID: "user-1"})
|
|
|
|
handler := NewChatSessionHandler(service.NewChatSessionService(), nil)
|
|
handler.UpdateMessageFeedback(ctx)
|
|
|
|
var body map[string]interface{}
|
|
if err := json.Unmarshal(recorder.Body.Bytes(), &body); err != nil {
|
|
t.Fatalf("decode response body: %v", err)
|
|
}
|
|
if got := body["code"]; got != float64(common.CodeArgumentError) {
|
|
t.Fatalf("code=%v", got)
|
|
}
|
|
if got := body["message"]; got != "Request body cannot be empty" {
|
|
t.Fatalf("message=%v", got)
|
|
}
|
|
}
|