mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-06-29 23:41:12 +08:00
## Summary
Aligns the **Go agent runtime/canvas/components/tools** behavior with
the **Python `agent/` implementation** so the same stored canvas DSL
produces the same execution result on either side. Every component,
tool, and runtime primitive in `internal/agent/` is now driven by the
same semantics as its Python counterpart — variable resolution, template
substitution, control flow, error reporting, retry/cancel, and stream
event shapes.
The **retrieval component is the one explicit exception** in this PR. It
is being reworked in a separate change and is excluded from this
alignment pass; the wrapper slot (`universe_a_wrappers.go →
newRetrievalComponent`) is preserved.
## Scope of alignment
### Components (all aligned with `agent/component/`)
`Begin` · `Message` · `LLM` (incl. ChatTemplateKwargs,
MessageHistoryWindowSize, VisualFiles, Cite, OutputStructure,
JSONOutput, TopP, MaxRetries, DelayAfterError, credentials) · `Agent`
(react + tool artifact capture + `Reset()` interface-assert) · `Switch`
(12/12 operators, Python-equivalent semantics) · `Categorize` · `Invoke`
· `Iteration` · `Loop` (macro-expansion through `workflowx.AddLoopNode`)
· `UserFillUp` (Python-equivalent interrupt/resume via eino
`compose.Interrupt`/`ResumeWithData`) · `FillUp` · `DataOperations` ·
`ListOperations` · `StringTransform` · `VariableAggregator` ·
`VariableAssigner` · `Browser` (full stagehand runtime parity) ·
`DocsGenerator` · `ExcelProcessor`.
### Tools (all aligned with `agent/tools/`)
`Retrieval` (wrapper slot only — logic out of scope) · `MCPToolAdapter`
(streamable-HTTP) · `CodeExec` (sandbox bridge with
`code_exec_contract.go` matching Python contract) · `AkShare` · `ArXiv`
· `Crawler` · `DeepL` · `DuckDuckGo` · `Email` · `ExeSQL` · `GitHub` ·
`Google` · `GoogleScholar` · `Jin10` · `PubMed` · `QWeather` · `SearXNG`
· `Tavily` · `Tushare` · `Wencai` · `Wikipedia` · `YahooFinance` —
uniform `eino tool.InvokableTool` interface, SSRF protection, shared
HTTP client.
### Canvas execution engine (`internal/agent/canvas/`)
Aligned with Python's `agent/canvas.py`:
- **Scheduler** (`scheduler.go`): state pre/post handlers, node lambdas,
per-component timeout resolver (4-level: per-class env → per-class table
→ uniform env → 600s fallback), `legacyNoOpNames`.
- **Loop subgraph** (`loop_subgraph.go`): Python-equivalent
`AddLoopNode` macro expansion + condition translation.
- **Multibranch** (`multibranch.go`): `Switch` / `Categorize` routing
via `compose.NewGraphMultiBranch` — same branch selection semantics as
Python.
- **Parallel subgraph** (`parallel_subgraph.go`): matches Python's
parallel fan-out contract.
- **Interrupt/Resume** (`interrupt_resume.go`): `UserFillUpNodeBody` /
`IsInterruptError` / `ExtractInterruptContexts` — replaces the
deprecated Python sentinel chain with eino's native interrupt API,
preserving the same external behavior.
- **Checkpoint** (`checkpoint_store.go`): `RedisCheckPointStore`
Get/Set/Delete, with business metadata (status / canvas_id /
parent_run_id) on a parallel Redis Hash.
- **RunTracker** (`run_tracker.go`): Start / MarkSucceeded / MarkFailed
/ MarkCancelled / AttachCheckpoint — same lifecycle as the Python run
record.
- **Cancel** (`cancel.go`): Redis pub/sub watch.
- **Stream** (`stream.go`): SSE channel with `messages` / `waiting` /
`errors` / `done` events, same shape as Python's `agent.canvas.RunEvent`
payload.
### DSL bridge (`internal/agent/dsl/`)
- `normalize.go`: v1↔v2 collapsed into a single wire format — Python and
Go consume the same stored JSON.
- `reset.go`: per-run state reset matches Python's `Canvas.reset()`
semantics.
- Testdata mirrors Python's `agent_msg.json` / `all.json` / etc.
### Runtime (`internal/agent/runtime/`)
- `CanvasState` / `NewCanvasState` / `GetVar` / `SetVar` / `ReadVars`:
same `{{cpn_id@param}}` resolution model.
- `ResolveTemplate` (regex fast path + gonja fallback) — Python
Jinja-style semantics.
- `selector.go`, `metrics.go`, `component.go`: shared runtime contracts.
## Out of scope (intentionally)
- **`Retrieval` component logic** — wrapped only; full parity lands in a
follow-up PR.
- **Frontend** — only minor dsl-bridge / canvas UX fixes ride along.
- **CLI / admin / model registry** — orthogonal to agent behavior.
## How alignment is verified
`internal/service/agent_run_e2e_test.go` exercises the **full production
chain** against real Python-shaped DSL fixtures:
```
loadCanvasForUser → versionDAO.GetLatest → decodeCanvasFromDSL →
canvas.Compile → cc.Workflow.Invoke → answer extraction
```
using in-memory SQLite + miniredis (no Docker). Covers:
- `TestRunAgent_RealCanvas_BeginMessage` — happy path, `{{sys.query}}`
resolution
- `TestRunAgent_RealCanvas_WaitForUserResume` — two-run resume cycle
(Python-equivalent)
- `TestRunAgent_RealCanvas_CompileFails` — unknown component name →
sanitized error (Python-equivalent)
- `TestRunAgent_RealCanvas_InvokeFails` — unresolvable template ref
(Python-equivalent)
- `TestRunAgent_RunTracker_AttachCheckpoint_CallSequence` —
Start→AttachCheckpoint→MarkSucceeded lifecycle
`internal/handler/agent_test.go` — SSE streaming parity (`Content-Type:
text/event-stream`, `data: {…}\n\n`, trailing `data: [DONE]\n\n`,
OpenAI-compatible non-stream `choices`).
`internal/agent/canvas/fixture_compile_test.go` + per-component tests
pin the Python-equivalent outputs.
```
go test -count=1 -v -run 'TestRunAgent_RealCanvas|TestRunAgent_RunTracker' ./internal/service/
```
## Design reference
`docs/develop/agent-go-port-design.md` (1329 lines, last cross-checked
2026-06-17) — module layout, per-component / per-tool inventory,
corner-case catalogue, and the actionable backlog (Section 14, including
the retrieval alignment follow-up).
---------
Co-authored-by: Claude <noreply@anthropic.com>
176 lines
5.3 KiB
Go
176 lines
5.3 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
package component
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"ragflow/internal/agent/canvas"
|
|
)
|
|
|
|
// TestStringTransform_SplitBasic: "a,b;c" with delimiters=[",", ";"] → ["a", "b", "c"].
|
|
func TestStringTransform_SplitBasic(t *testing.T) {
|
|
c, err := NewStringTransformComponent(map[string]any{
|
|
"method": "split",
|
|
"delimiters": []string{",", ";"},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("NewStringTransformComponent: %v", err)
|
|
}
|
|
state := canvas.NewCanvasState("run-1", "task-1")
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, map[string]any{"line": "a,b;c"})
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
got, _ := out["result"].([]string)
|
|
want := []string{"a", "b", "c"}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("split: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_SplitNoDelim: "abc" with delimiters=[","] → ["abc"].
|
|
func TestStringTransform_SplitNoDelim(t *testing.T) {
|
|
c, _ := NewStringTransformComponent(map[string]any{
|
|
"method": "split",
|
|
"delimiters": []string{","},
|
|
})
|
|
state := canvas.NewCanvasState("run-2", "task-2")
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, map[string]any{"line": "abc"})
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
got, _ := out["result"].([]string)
|
|
want := []string{"abc"}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("split: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_Merge: script="{{x}} and {{y}}", inputs={x: "foo", y: "bar"} → "foo and bar".
|
|
func TestStringTransform_Merge(t *testing.T) {
|
|
c, _ := NewStringTransformComponent(map[string]any{
|
|
"method": "merge",
|
|
"delimiters": []string{","},
|
|
"script": "{{x}} and {{y}}",
|
|
})
|
|
state := canvas.NewCanvasState("run-3", "task-3")
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, map[string]any{"x": "foo", "y": "bar"})
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
if got, want := out["result"], "foo and bar"; got != want {
|
|
t.Errorf("merge: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
func TestStringTransform_MergeIterationAliases(t *testing.T) {
|
|
c, _ := NewStringTransformComponent(map[string]any{
|
|
"method": "merge",
|
|
"delimiters": []string{","},
|
|
"script": "{index}: {item}",
|
|
})
|
|
state := canvas.NewCanvasState("run-iter", "task-iter")
|
|
state.Globals["__item__"] = "beta"
|
|
state.Globals["__index__"] = 1
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, map[string]any{})
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
if got, want := out["result"], "1: beta"; got != want {
|
|
t.Errorf("merge iteration aliases: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_SplitFromStateRef: when "line" is absent, the
|
|
// component reads the value from state[split_ref].
|
|
func TestStringTransform_SplitFromStateRef(t *testing.T) {
|
|
c, _ := NewStringTransformComponent(map[string]any{
|
|
"method": "split",
|
|
"delimiters": []string{","},
|
|
"split_ref": "cpn_0@x",
|
|
})
|
|
state := canvas.NewCanvasState("run-4", "task-4")
|
|
state.Outputs["cpn_0"] = map[string]any{"x": "alpha,beta,gamma"}
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, nil)
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
got, _ := out["result"].([]string)
|
|
want := []string{"alpha", "beta", "gamma"}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("split from state: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_MergeMissingPlaceholder: a placeholder not in
|
|
// inputs or state resolves to "" (matches Python's v is None branch).
|
|
func TestStringTransform_MergeMissingPlaceholder(t *testing.T) {
|
|
c, _ := NewStringTransformComponent(map[string]any{
|
|
"method": "merge",
|
|
"delimiters": []string{","},
|
|
"script": "hello {{name}}",
|
|
})
|
|
state := canvas.NewCanvasState("run-5", "task-5")
|
|
ctx := canvas.WithState(context.Background(), state)
|
|
|
|
out, err := c.Invoke(ctx, map[string]any{})
|
|
if err != nil {
|
|
t.Fatalf("Invoke: %v", err)
|
|
}
|
|
if got, want := out["result"], "hello "; got != want {
|
|
t.Errorf("merge missing: got %q, want %q", got, want)
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_ParamCheck: bad method rejected.
|
|
func TestStringTransform_ParamCheck(t *testing.T) {
|
|
_, err := NewStringTransformComponent(map[string]any{
|
|
"method": "bogus",
|
|
"delimiters": []string{","},
|
|
})
|
|
if err == nil {
|
|
t.Fatal("expected error for bad method, got nil")
|
|
}
|
|
}
|
|
|
|
// TestStringTransform_Registered: factory lookup.
|
|
func TestStringTransform_Registered(t *testing.T) {
|
|
c, err := New("StringTransform", map[string]any{
|
|
"method": "split",
|
|
"delimiters": []string{","},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("registry lookup: %v", err)
|
|
}
|
|
if c.Name() != "StringTransform" {
|
|
t.Errorf("Name()=%q, want StringTransform", c.Name())
|
|
}
|
|
}
|