Files
ragflow/internal/agent/component/browser.go
Zhichang Yu 3f805a64f1 feat(agent): align Go agent behavior with Python (except retrieval component) (#16225)
## Summary

Aligns the **Go agent runtime/canvas/components/tools** behavior with
the **Python `agent/` implementation** so the same stored canvas DSL
produces the same execution result on either side. Every component,
tool, and runtime primitive in `internal/agent/` is now driven by the
same semantics as its Python counterpart — variable resolution, template
substitution, control flow, error reporting, retry/cancel, and stream
event shapes.

The **retrieval component is the one explicit exception** in this PR. It
is being reworked in a separate change and is excluded from this
alignment pass; the wrapper slot (`universe_a_wrappers.go →
newRetrievalComponent`) is preserved.

## Scope of alignment

### Components (all aligned with `agent/component/`)
`Begin` · `Message` · `LLM` (incl. ChatTemplateKwargs,
MessageHistoryWindowSize, VisualFiles, Cite, OutputStructure,
JSONOutput, TopP, MaxRetries, DelayAfterError, credentials) · `Agent`
(react + tool artifact capture + `Reset()` interface-assert) · `Switch`
(12/12 operators, Python-equivalent semantics) · `Categorize` · `Invoke`
· `Iteration` · `Loop` (macro-expansion through `workflowx.AddLoopNode`)
· `UserFillUp` (Python-equivalent interrupt/resume via eino
`compose.Interrupt`/`ResumeWithData`) · `FillUp` · `DataOperations` ·
`ListOperations` · `StringTransform` · `VariableAggregator` ·
`VariableAssigner` · `Browser` (full stagehand runtime parity) ·
`DocsGenerator` · `ExcelProcessor`.

### Tools (all aligned with `agent/tools/`)
`Retrieval` (wrapper slot only — logic out of scope) · `MCPToolAdapter`
(streamable-HTTP) · `CodeExec` (sandbox bridge with
`code_exec_contract.go` matching Python contract) · `AkShare` · `ArXiv`
· `Crawler` · `DeepL` · `DuckDuckGo` · `Email` · `ExeSQL` · `GitHub` ·
`Google` · `GoogleScholar` · `Jin10` · `PubMed` · `QWeather` · `SearXNG`
· `Tavily` · `Tushare` · `Wencai` · `Wikipedia` · `YahooFinance` —
uniform `eino tool.InvokableTool` interface, SSRF protection, shared
HTTP client.

### Canvas execution engine (`internal/agent/canvas/`)
Aligned with Python's `agent/canvas.py`:
- **Scheduler** (`scheduler.go`): state pre/post handlers, node lambdas,
per-component timeout resolver (4-level: per-class env → per-class table
→ uniform env → 600s fallback), `legacyNoOpNames`.
- **Loop subgraph** (`loop_subgraph.go`): Python-equivalent
`AddLoopNode` macro expansion + condition translation.
- **Multibranch** (`multibranch.go`): `Switch` / `Categorize` routing
via `compose.NewGraphMultiBranch` — same branch selection semantics as
Python.
- **Parallel subgraph** (`parallel_subgraph.go`): matches Python's
parallel fan-out contract.
- **Interrupt/Resume** (`interrupt_resume.go`): `UserFillUpNodeBody` /
`IsInterruptError` / `ExtractInterruptContexts` — replaces the
deprecated Python sentinel chain with eino's native interrupt API,
preserving the same external behavior.
- **Checkpoint** (`checkpoint_store.go`): `RedisCheckPointStore`
Get/Set/Delete, with business metadata (status / canvas_id /
parent_run_id) on a parallel Redis Hash.
- **RunTracker** (`run_tracker.go`): Start / MarkSucceeded / MarkFailed
/ MarkCancelled / AttachCheckpoint — same lifecycle as the Python run
record.
- **Cancel** (`cancel.go`): Redis pub/sub watch.
- **Stream** (`stream.go`): SSE channel with `messages` / `waiting` /
`errors` / `done` events, same shape as Python's `agent.canvas.RunEvent`
payload.

### DSL bridge (`internal/agent/dsl/`)
- `normalize.go`: v1↔v2 collapsed into a single wire format — Python and
Go consume the same stored JSON.
- `reset.go`: per-run state reset matches Python's `Canvas.reset()`
semantics.
- Testdata mirrors Python's `agent_msg.json` / `all.json` / etc.

### Runtime (`internal/agent/runtime/`)
- `CanvasState` / `NewCanvasState` / `GetVar` / `SetVar` / `ReadVars`:
same `{{cpn_id@param}}` resolution model.
- `ResolveTemplate` (regex fast path + gonja fallback) — Python
Jinja-style semantics.
- `selector.go`, `metrics.go`, `component.go`: shared runtime contracts.

## Out of scope (intentionally)

- **`Retrieval` component logic** — wrapped only; full parity lands in a
follow-up PR.
- **Frontend** — only minor dsl-bridge / canvas UX fixes ride along.
- **CLI / admin / model registry** — orthogonal to agent behavior.

## How alignment is verified

`internal/service/agent_run_e2e_test.go` exercises the **full production
chain** against real Python-shaped DSL fixtures:
```
loadCanvasForUser → versionDAO.GetLatest → decodeCanvasFromDSL →
canvas.Compile → cc.Workflow.Invoke → answer extraction
```
using in-memory SQLite + miniredis (no Docker). Covers:
- `TestRunAgent_RealCanvas_BeginMessage` — happy path, `{{sys.query}}`
resolution
- `TestRunAgent_RealCanvas_WaitForUserResume` — two-run resume cycle
(Python-equivalent)
- `TestRunAgent_RealCanvas_CompileFails` — unknown component name →
sanitized error (Python-equivalent)
- `TestRunAgent_RealCanvas_InvokeFails` — unresolvable template ref
(Python-equivalent)
- `TestRunAgent_RunTracker_AttachCheckpoint_CallSequence` —
Start→AttachCheckpoint→MarkSucceeded lifecycle

`internal/handler/agent_test.go` — SSE streaming parity (`Content-Type:
text/event-stream`, `data: {…}\n\n`, trailing `data: [DONE]\n\n`,
OpenAI-compatible non-stream `choices`).

`internal/agent/canvas/fixture_compile_test.go` + per-component tests
pin the Python-equivalent outputs.

```
go test -count=1 -v -run 'TestRunAgent_RealCanvas|TestRunAgent_RunTracker' ./internal/service/
```

## Design reference

`docs/develop/agent-go-port-design.md` (1329 lines, last cross-checked
2026-06-17) — module layout, per-component / per-tool inventory,
corner-case catalogue, and the actionable backlog (Section 14, including
the retrieval alignment follow-up).

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-06-22 11:58:29 +08:00

400 lines
14 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Package component — Browser (T3).
//
// Browser is an LLM-driven single-shot web extraction canvas node
// built on `github.com/browserbase/stagehand-go/v3` in local mode.
// It uses `RunExtract` (not the multi-step agent `RunTask`) to
// navigate to a page and extract structured content against a
// `{"type": "string"}` JSON schema.
//
// It mirrors the Python `agent/component/browser.py` param surface
// (`llm_id`, `prompts`, `max_steps`, `headless`, `persist_session`,
// `upload_sources`, etc.) so the v1 fixture
// (`internal/agent/dsl/testdata/browser.json`) loads without
// fixture-side changes.
//
// LLM dispatch is delegated to `StagehandInvoker` (see
// `stagehand_runtime.go`), which owns the stagehand-server child
// process and the session lifecycle. The component itself is a thin
// orchestrator: parse → resolve template → look up tenant model
// config → call runtime.RunExtract → emit Python-shaped outputs.
//
// File upload / download and persistent session management are
// not supported; see [`.claude/plans/tingly-weaving-orbit.md`]
// for the full deferral list.
package component
import (
"context"
"encoding/json"
"errors"
"fmt"
"regexp"
"strings"
"ragflow/internal/agent/runtime"
"ragflow/internal/dao"
"ragflow/internal/entity"
)
const componentNameBrowser = "Browser"
// browserParam is the static DSL param surface for the Browser
// component. Mirrors Python `browser.py:LLMParam + browser knobs`:
//
// llm_id, model_id (alias), prompts, prompt (alias),
// max_steps, headless, enable_default_extensions,
// chromium_sandbox, persist_session, upload_sources.
//
// Go-only fields kept for backward compat with the existing test
// file and the optional-URL form some operators still wire up:
//
// url, timeout.
//
// v1 does not act on the v1-deferred params; Update accepts them so
// the v1 fixture loads.
type browserParam struct {
LLMID string `json:"llm_id"`
ModelID string `json:"model_id"` // alias for llm_id
Prompts string `json:"prompts"`
Prompt string `json:"prompt"` // alias for prompts
MaxSteps int `json:"max_steps"`
Headless *bool `json:"headless"`
EnableDefaultExt *bool `json:"enable_default_extensions"`
ChromiumSandbox *bool `json:"chromium_sandbox"`
PersistSession *bool `json:"persist_session"`
// Go-only fields (kept for backward compat with the existing
// test file; not used by the stagehand path).
URL string `json:"url"`
Timeout int `json:"timeout"`
}
// llmIDPattern matches `ModelName@Factory`. The factory part is
// optional; when absent, the caller's tenant lookup will be
// `GetByTenantAndModelName` instead of
// `GetByTenantFactoryAndModelName`.
var llmIDPattern = regexp.MustCompile(`^(.+)@(.+)$`)
// resolveLLMID splits `llm_id` (e.g. "deepseek-v4-pro@DeepSeek") into
// `(modelName, factory)`. When no `@` is present, factory is empty
// and the caller must use a single-key lookup.
//
// Mirrors the contract of `dao.splitModelNameAndFactory` (private);
// re-implemented here to keep the component free of an import
// dependency on a DB-validating private helper.
func resolveLLMID(llmID string) (modelName, factory string) {
m := llmIDPattern.FindStringSubmatch(strings.TrimSpace(llmID))
if m == nil {
return strings.TrimSpace(llmID), ""
}
return strings.TrimSpace(m[1]), strings.TrimSpace(m[2])
}
// Update copies a fresh param map into the receiver. The
// `llm_id`/`model_id` and `prompts`/`prompt` alias pairs collapse
// onto the same field; the first non-empty value wins.
func (p *browserParam) Update(conf map[string]any) error {
if conf == nil {
conf = map[string]any{}
}
if v, ok := stringFrom(conf, "llm_id"); ok && v != "" {
p.LLMID = v
}
if v, ok := stringFrom(conf, "model_id"); ok && v != "" && p.LLMID == "" {
p.LLMID = v
}
if v, ok := stringFrom(conf, "prompts"); ok && v != "" {
p.Prompts = v
}
if v, ok := stringFrom(conf, "prompt"); ok && v != "" && p.Prompts == "" {
p.Prompts = v
}
if v, ok := intFrom(conf, "max_steps"); ok {
p.MaxSteps = v
} else {
p.MaxSteps = 0
}
if v, ok := boolFrom(conf, "headless"); ok {
p.Headless = &v
}
if v, ok := boolFrom(conf, "enable_default_extensions"); ok {
p.EnableDefaultExt = &v
}
if v, ok := boolFrom(conf, "chromium_sandbox"); ok {
p.ChromiumSandbox = &v
}
if v, ok := boolFrom(conf, "persist_session"); ok {
p.PersistSession = &v
}
if v, ok := stringFrom(conf, "url"); ok {
p.URL = v
}
if v, ok := intFrom(conf, "timeout"); ok {
p.Timeout = v
} else {
p.Timeout = 0
}
return nil
}
// Check validates the param. The accepted-but-ignored Python
// fields are NOT validated here — the v1 fixture is allowed to set
// them; we only reject structurally invalid values for fields we
// actually use (`llm_id`, `prompts`).
func (p *browserParam) Check() error {
if p.LLMID == "" {
return &ParamError{Field: "llm_id", Reason: "required (or model_id alias)"}
}
if p.Prompts == "" {
return &ParamError{Field: "prompts", Reason: "required (or prompt alias)"}
}
if p.MaxSteps < 0 {
return &ParamError{Field: "max_steps", Reason: "must be non-negative"}
}
if p.Timeout < 0 {
return &ParamError{Field: "timeout", Reason: "must be non-negative"}
}
return nil
}
// AsDict returns the param as a plain map (for serialization / debug).
func (p *browserParam) AsDict() map[string]any {
out := map[string]any{
"llm_id": p.LLMID,
"model_id": p.LLMID, // alias echoed
"prompts": p.Prompts,
"prompt": p.Prompts, // alias echoed
"max_steps": p.MaxSteps,
"url": p.URL,
"timeout": p.Timeout,
}
if p.Headless != nil {
out["headless"] = *p.Headless
}
if p.EnableDefaultExt != nil {
out["enable_default_extensions"] = *p.EnableDefaultExt
}
if p.ChromiumSandbox != nil {
out["chromium_sandbox"] = *p.ChromiumSandbox
}
if p.PersistSession != nil {
out["persist_session"] = *p.PersistSession
}
return out
}
// BrowserComponent is the canvas Browser node. Owns its static
// param; delegates the multi-step agent run to StagehandInvoker.
type BrowserComponent struct {
name string
param browserParam
}
// NewBrowserComponent constructs a Browser from the DSL param map.
func NewBrowserComponent(params map[string]any) (Component, error) {
p := &browserParam{}
if err := p.Update(params); err != nil {
return nil, fmt.Errorf("Browser: param update: %w", err)
}
if err := p.Check(); err != nil {
return nil, fmt.Errorf("Browser: param check: %w", err)
}
return &BrowserComponent{
name: componentNameBrowser,
param: *p,
}, nil
}
// Name returns the registered component name.
func (b *BrowserComponent) Name() string { return b.name }
// Invoke dispatches a single-shot extraction task via
// StagehandInvoker.RunExtract with a `{"type": "string"}` schema.
// The flow:
//
// 1. Pull tenant_id from `state.Sys["user_id"]`.
// 2. Resolve the `prompts` template via `runtime.ResolveTemplate`.
// 3. Split `llm_id` → `(modelName, factory)` and look up the
// tenant LLM config (apiKey, baseURL) from the DAO.
// 4. Build `RunExtractRequest` with `ModelName = "openai/<model>"`,
// the resolved apiKey/baseURL/instruction, and
// `Schema = {"type": "string"}`.
// 5. Call `DefaultRuntime.RunExtract` → raw JSON string.
// 6. Unmarshal the JSON string to get the plain text content.
// 7. Emit the Python-shaped outputs (`content`,
// `downloaded_files`) plus Go-native compat keys.
//
// File upload/download and session persistence are not supported
// in this component; they are v1-deferred.
func (b *BrowserComponent) Invoke(ctx context.Context, inputs map[string]any) (map[string]any, error) {
state, _, err := runtime.GetStateFromContext[*runtime.CanvasState](ctx)
if err != nil {
return nil, fmt.Errorf("Browser: %w", err)
}
if state == nil {
return nil, errors.New("Browser: nil canvas state")
}
tenantID, _ := state.Sys["user_id"].(string)
if tenantID == "" {
return nil, errors.New("Browser: tenant_id missing from canvas state (state.Sys[\"user_id\"])")
}
// 1. Resolve prompts template.
resolvedPrompts, err := runtime.ResolveTemplate(b.param.Prompts, state)
if err != nil {
return nil, fmt.Errorf("Browser: resolve prompts template: %w", err)
}
// 2. Look up tenant model config.
modelName, factory := resolveLLMID(b.param.LLMID)
apiKey, baseURL, err := resolveTenantLLM(tenantID, modelName, factory)
if err != nil {
return nil, fmt.Errorf("Browser: tenant llm lookup (%q, factory=%q): %w", b.param.LLMID, factory, err)
}
// 3. Build RunExtractRequest with single-string schema.
req := RunExtractRequest{
TenantID: tenantID,
LLMID: b.param.LLMID,
ModelName: "openai/" + modelName,
BaseURL: baseURL,
APIKey: apiKey,
Headless: b.param.Headless,
Instruction: resolvedPrompts,
Schema: map[string]any{"type": "string"},
}
// 4. Dispatch via the runtime's RunExtract.
invoker := getDefaultStagehandInvoker()
rawJSON, err := invoker.RunExtract(ctx, req)
if err != nil {
return nil, fmt.Errorf("Browser: stagehand extract: %w", err)
}
// 5. Unmarshal the JSON-string result to get the plain text.
var content string
if err := json.Unmarshal([]byte(rawJSON), &content); err != nil {
return nil, fmt.Errorf("Browser: unmarshal extract result: %w", err)
}
// 6. Build the output map.
out := map[string]any{
"content": content,
"downloaded_files": []map[string]any{},
"url": "",
"status": 0,
"size": len(content),
"model_id": b.param.LLMID,
"prompt": b.param.Prompts,
}
return out, nil
}
// Stream mirrors Invoke; Browser is a single-shot generator.
func (b *BrowserComponent) Stream(ctx context.Context, inputs map[string]any) (<-chan map[string]any, error) {
out, err := b.Invoke(ctx, inputs)
if err != nil {
return nil, err
}
ch := make(chan map[string]any, 1)
ch <- out
close(ch)
return ch, nil
}
// Inputs returns the parameter metadata for tooling.
func (b *BrowserComponent) Inputs() map[string]string {
return map[string]string{
"llm_id": "Required: tenant model id, e.g. \"deepseek-v4-pro@DeepSeek\". model_id accepted as alias.",
"prompts": "Required: natural-language extraction task. {sys.query} and other canvas refs are resolved. prompt accepted as alias.",
"max_steps": "Accepted for fixture compat; ignored at Invoke.",
"headless": "Browser launch mode (default true).",
"enable_default_extensions": "Accepted for fixture compat; ignored at Invoke.",
"chromium_sandbox": "Accepted for fixture compat; ignored at Invoke.",
"persist_session": "Accepted for fixture compat; ignored at Invoke.",
"url": "Go-only; not used (kept for backward compat).",
"timeout": "Go-only; not used (kept for backward compat).",
}
}
// Outputs returns the response surface.
func (b *BrowserComponent) Outputs() map[string]string {
return map[string]string{
"content": "Extracted plain text (Sessions.Extract result with schema {\"type\":\"string\"}).",
"downloaded_files": "Always [] (file download not supported).",
"url": "Go-native compat key; always \"\".",
"status": "Go-native compat key; always 0.",
"size": "Bytes in content.",
"model_id": "Resolved llm_id (echoed back).",
"prompt": "Resolved prompts (echoed back).",
}
}
// resolveTenantLLM looks up the tenant LLM config and returns
// (apiKey, baseURL, modelName). baseURL may be empty when the
// tenant's provider doesn't configure a custom endpoint (the
// stagehand server will then use its openai-compat default).
//
// Tests override the lookup via `tenantLLMLookupForTest` (a
// package-level function variable) so they don't need a real DB.
// Production code leaves the variable unset.
//
// TODO(v2): this helper can move to `internal/dao` so the LLM
// component (`llm.go`) and other future components can share it.
func resolveTenantLLM(tenantID, modelName, factory string) (apiKey, baseURL string, err error) {
if tenantLLMLookupForTest != nil {
return tenantLLMLookupForTest(tenantID, modelName, factory)
}
dao := dao.NewTenantLLMDAO()
var (
row *entity.TenantLLM
)
if factory != "" {
row, err = dao.GetByTenantFactoryAndModelName(tenantID, factory, modelName)
} else {
// No factory suffix on llm_id; fall back to a single-key
// lookup (errors if the model is registered under multiple
// factories — caller must use the explicit form).
row, err = dao.GetByTenantAndModelName(tenantID, "", modelName)
}
if err != nil {
return "", "", err
}
if row == nil {
return "", "", fmt.Errorf("tenant LLM not found")
}
if row.APIKey != nil {
apiKey = *row.APIKey
}
if row.APIBase != nil {
baseURL = *row.APIBase
}
return apiKey, baseURL, nil
}
// tenantLLMLookupForTest is the test seam for `resolveTenantLLM`.
// When non-nil, it's called instead of the real DAO lookup.
// Production leaves this nil; tests set it via `defer ... = nil`.
var tenantLLMLookupForTest func(tenantID, modelName, factory string) (apiKey, baseURL string, err error)
func init() {
Register(componentNameBrowser, NewBrowserComponent)
}