fix(go-models): fix MiniMax driver requests (#15527)

## Summary
- keep MiniMax chat calls in non-streaming mode and streaming calls in
SSE mode
- make MiniMax model listing and connection checks use a bodyless GET
/v1/models
- add focused MiniMax request/response regression tests
This commit is contained in:
oktofeesh
2026-06-08 04:32:01 -07:00
committed by GitHub
parent 25df0a6725
commit e0dc7af5dd
2 changed files with 429 additions and 96 deletions

View File

@@ -25,7 +25,6 @@ import (
"fmt"
"io"
"net/http"
"ragflow/internal/common"
"strings"
"time"
)
@@ -61,11 +60,23 @@ func (m *MinimaxModel) Name() string {
return "minimax"
}
func validateMinimaxModelName(modelName string) (string, error) {
if strings.TrimSpace(modelName) == "" {
return "", fmt.Errorf("model name is required")
}
return strings.TrimSpace(modelName), nil
}
// ChatWithMessages sends multiple messages with roles and returns response
func (m *MinimaxModel) ChatWithMessages(modelName string, messages []Message, apiConfig *APIConfig, chatModelConfig *ChatConfig) (*ChatResponse, error) {
if err := m.baseModel.APIConfigCheck(apiConfig); err != nil {
return nil, err
}
apiKey := strings.TrimSpace(*apiConfig.ApiKey)
modelName, err := validateMinimaxModelName(modelName)
if err != nil {
return nil, err
}
if len(messages) == 0 {
return nil, fmt.Errorf("messages is empty")
}
@@ -102,10 +113,6 @@ func (m *MinimaxModel) ChatWithMessages(modelName string, messages []Message, ap
reqBody["max_tokens"] = *chatModelConfig.MaxTokens
}
if chatModelConfig.Stream != nil {
reqBody["stream"] = *chatModelConfig.Stream
}
if chatModelConfig.TopP != nil {
reqBody["top_p"] = *chatModelConfig.TopP
}
@@ -141,8 +148,8 @@ func (m *MinimaxModel) ChatWithMessages(modelName string, messages []Message, ap
return nil, fmt.Errorf("failed to create request: %w", err)
}
req.Header.Add("Content-Type", "application/json")
req.Header.Add("Authorization", fmt.Sprintf("Bearer %s", *apiConfig.ApiKey))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", apiKey))
resp, err := m.baseModel.httpClient.Do(req)
if err != nil {
@@ -166,7 +173,7 @@ func (m *MinimaxModel) ChatWithMessages(modelName string, messages []Message, ap
}
choices, ok := result["choices"].([]interface{})
if !ok {
if !ok || len(choices) == 0 {
return nil, fmt.Errorf("no choices in response")
}
@@ -209,10 +216,17 @@ func (m *MinimaxModel) ChatStreamlyWithSender(modelName string, messages []Messa
if err := m.baseModel.APIConfigCheck(apiConfig); err != nil {
return err
}
apiKey := strings.TrimSpace(*apiConfig.ApiKey)
modelName, err := validateMinimaxModelName(modelName)
if err != nil {
return err
}
if len(messages) == 0 {
return fmt.Errorf("messages is empty")
}
if sender == nil {
return fmt.Errorf("sender is required")
}
resolvedBaseURL, err := m.baseModel.GetBaseURL(apiConfig)
if err != nil {
@@ -237,39 +251,37 @@ func (m *MinimaxModel) ChatStreamlyWithSender(modelName string, messages []Messa
"temperature": 1,
}
if modelConfig.Stream != nil {
reqBody["stream"] = *modelConfig.Stream
}
if modelConfig != nil {
if modelConfig.MaxTokens != nil {
reqBody["max_tokens"] = *modelConfig.MaxTokens
}
if modelConfig.MaxTokens != nil {
reqBody["max_tokens"] = *modelConfig.MaxTokens
}
if modelConfig.Temperature != nil {
reqBody["temperature"] = *modelConfig.Temperature
}
if modelConfig.Temperature != nil {
reqBody["temperature"] = *modelConfig.Temperature
}
if modelConfig.TopP != nil {
reqBody["top_p"] = *modelConfig.TopP
}
if modelConfig.TopP != nil {
reqBody["top_p"] = *modelConfig.TopP
}
if modelConfig.DoSample != nil {
reqBody["do_sample"] = *modelConfig.DoSample
}
if modelConfig.DoSample != nil {
reqBody["do_sample"] = *modelConfig.DoSample
}
if modelConfig.Stop != nil {
reqBody["stop"] = *modelConfig.Stop
}
if modelConfig.Stop != nil {
reqBody["stop"] = *modelConfig.Stop
}
if modelConfig != nil && modelConfig.Thinking != nil {
if *modelConfig.Thinking {
reqBody["thinking"] = map[string]interface{}{
"type": "adaptive",
}
reqBody["reasoning_split"] = true
} else {
reqBody["thinking"] = map[string]interface{}{
"type": "disabled",
if modelConfig.Thinking != nil {
if *modelConfig.Thinking {
reqBody["thinking"] = map[string]interface{}{
"type": "adaptive",
}
reqBody["reasoning_split"] = true
} else {
reqBody["thinking"] = map[string]interface{}{
"type": "disabled",
}
}
}
}
@@ -288,7 +300,8 @@ func (m *MinimaxModel) ChatStreamlyWithSender(modelName string, messages []Messa
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", *apiConfig.ApiKey))
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", apiKey))
req.Header.Set("Accept", "text/event-stream")
resp, err := m.baseModel.httpClient.Do(req)
if err != nil {
@@ -306,7 +319,6 @@ func (m *MinimaxModel) ChatStreamlyWithSender(modelName string, messages []Messa
scanner.Buffer(make([]byte, 64*1024), 1024*1024)
for scanner.Scan() {
line := scanner.Text()
common.Info(line)
// SSE data line start with data:
if !strings.HasPrefix(line, "data:") {
@@ -380,6 +392,7 @@ func (m *MinimaxModel) ListModels(apiConfig *APIConfig) ([]string, error) {
if err := m.baseModel.APIConfigCheck(apiConfig); err != nil {
return nil, err
}
apiKey := strings.TrimSpace(*apiConfig.ApiKey)
resolvedBaseURL, err := m.baseModel.GetBaseURL(apiConfig)
if err != nil {
@@ -387,24 +400,16 @@ func (m *MinimaxModel) ListModels(apiConfig *APIConfig) ([]string, error) {
}
url := fmt.Sprintf("%s/%s", resolvedBaseURL, m.baseModel.URLSuffix.Models)
// Build request body
reqBody := map[string]interface{}{}
jsonData, err := json.Marshal(reqBody)
if err != nil {
return nil, fmt.Errorf("failed to marshal request: %w", err)
}
ctx, cancel := context.WithTimeout(context.Background(), nonStreamCallTimeout)
defer cancel()
req, err := http.NewRequestWithContext(ctx, "GET", url, bytes.NewBuffer(jsonData))
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", *apiConfig.ApiKey))
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", apiKey))
req.Header.Set("Accept", "application/json")
resp, err := m.baseModel.httpClient.Do(req)
if err != nil {
@@ -418,21 +423,27 @@ func (m *MinimaxModel) ListModels(apiConfig *APIConfig) ([]string, error) {
}
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("API requestssss failed with status %d: %s : %s", resp.StatusCode, string(body), url)
return nil, fmt.Errorf("API request failed with status %d: %s", resp.StatusCode, string(body))
}
// Parse response
var result map[string]interface{}
var result struct {
Data []struct {
ID string `json:"id"`
} `json:"data"`
}
if err = json.Unmarshal(body, &result); err != nil {
return nil, fmt.Errorf("failed to parse response: %w", err)
}
if result.Data == nil {
return nil, fmt.Errorf("models response missing data")
}
// convert result["data"] to []map[string]interface{}
models := make([]string, 0)
for _, model := range result["data"].([]interface{}) {
modelMap := model.(map[string]interface{})
modelName := modelMap["id"].(string)
models = append(models, modelName)
models := make([]string, 0, len(result.Data))
for _, model := range result.Data {
if strings.TrimSpace(model.ID) == "" {
return nil, fmt.Errorf("models response contains empty id")
}
models = append(models, strings.TrimSpace(model.ID))
}
return models, nil
@@ -443,43 +454,8 @@ func (m *MinimaxModel) Balance(apiConfig *APIConfig) (map[string]interface{}, er
}
func (m *MinimaxModel) CheckConnection(apiConfig *APIConfig) error {
if err := m.baseModel.APIConfigCheck(apiConfig); err != nil {
return err
}
resolvedBaseURL, err := m.baseModel.GetBaseURL(apiConfig)
if err != nil {
return err
}
url := fmt.Sprintf("%s/%s", resolvedBaseURL, m.baseModel.URLSuffix.Files)
ctx, cancel := context.WithTimeout(context.Background(), nonStreamCallTimeout)
defer cancel()
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
if err != nil {
return fmt.Errorf("failed to create request: %w", err)
}
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", *apiConfig.ApiKey))
resp, err := m.baseModel.httpClient.Do(req)
if err != nil {
return fmt.Errorf("failed to send request: %w", err)
}
defer resp.Body.Close()
body, err := io.ReadAll(resp.Body)
if err != nil {
return fmt.Errorf("failed to read response: %w", err)
}
if resp.StatusCode != http.StatusOK {
return fmt.Errorf("API request failed with status %d: %s", resp.StatusCode, string(body))
}
return nil
_, err := m.ListModels(apiConfig)
return err
}
// Rerank calculates similarity scores between query and documents

View File

@@ -0,0 +1,357 @@
package models
import (
"encoding/json"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
)
func newMinimaxServer(t *testing.T, handler func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter)) *httptest.Server {
t.Helper()
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if got := r.Header.Get("Authorization"); got != "Bearer test-key" {
t.Errorf("expected Authorization=Bearer test-key, got %q", got)
return
}
var body map[string]interface{}
if r.Method == http.MethodPost {
if got := r.Header.Get("Content-Type"); !strings.HasPrefix(got, "application/json") {
t.Errorf("expected Content-Type to start with application/json, got %q", got)
return
}
raw, err := io.ReadAll(r.Body)
if err != nil {
t.Errorf("read body: %v", err)
return
}
if err := json.Unmarshal(raw, &body); err != nil {
t.Errorf("unmarshal: %v\nraw=%s", err, string(raw))
return
}
} else {
if r.ContentLength > 0 {
t.Errorf("expected %s request without body, ContentLength=%d", r.Method, r.ContentLength)
return
}
raw, err := io.ReadAll(r.Body)
if err != nil {
t.Errorf("read body: %v", err)
return
}
if len(raw) != 0 {
t.Errorf("expected %s request without body, got %q", r.Method, string(raw))
return
}
}
handler(t, r, body, w)
}))
}
func newMinimaxForTest(baseURL string) *MinimaxModel {
return NewMinimaxModel(
map[string]string{"default": baseURL},
URLSuffix{
Chat: "v1/text/chatcompletion_v2",
Models: "v1/models",
Files: "v1/files/list",
},
)
}
func TestMinimaxNewInstancePreservesConfig(t *testing.T) {
model := NewMinimaxModel(
map[string]string{"default": "http://old.example"},
URLSuffix{Chat: "chat", Models: "models"},
)
instance, ok := model.NewInstance(map[string]string{"default": "http://new.example"}).(*MinimaxModel)
if !ok {
t.Fatalf("NewInstance type=%T, want *MinimaxModel", instance)
}
if instance.baseModel.BaseURL["default"] != "http://new.example" {
t.Errorf("BaseURL=%q", instance.baseModel.BaseURL["default"])
}
if instance.baseModel.URLSuffix.Chat != "chat" || instance.baseModel.URLSuffix.Models != "models" {
t.Errorf("URLSuffix=%+v", instance.baseModel.URLSuffix)
}
if instance.baseModel.httpClient == nil {
t.Error("httpClient is nil")
}
}
func TestMinimaxChatForcesNonStreaming(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodPost {
t.Errorf("method=%s, want POST", r.Method)
}
if r.URL.Path != "/v1/text/chatcompletion_v2" {
t.Errorf("path=%s, want /v1/text/chatcompletion_v2", r.URL.Path)
}
if body["model"] != "MiniMax-M3" {
t.Errorf("model=%v, want MiniMax-M3", body["model"])
}
if body["stream"] != false {
t.Errorf("stream=%v, want false", body["stream"])
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"choices": []map[string]interface{}{{
"message": map[string]interface{}{
"content": "pong",
"reasoning_content": "\nthought",
},
}},
})
})
defer srv.Close()
apiKey := " test-key "
stream := true
thinking := true
resp, err := newMinimaxForTest(srv.URL).ChatWithMessages(
" MiniMax-M3 ",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
&ChatConfig{Stream: &stream, Thinking: &thinking},
)
if err != nil {
t.Fatalf("ChatWithMessages: %v", err)
}
if resp.Answer == nil || *resp.Answer != "pong" {
t.Errorf("Answer=%v, want pong", resp.Answer)
}
if resp.ReasonContent == nil || *resp.ReasonContent != "thought" {
t.Errorf("ReasonContent=%v, want thought", resp.ReasonContent)
}
}
func TestMinimaxChatRejectsEmptyChoices(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
_ = json.NewEncoder(w).Encode(map[string]interface{}{"choices": []map[string]interface{}{}})
})
defer srv.Close()
apiKey := "test-key"
_, err := newMinimaxForTest(srv.URL).ChatWithMessages(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
nil,
)
if err == nil || !strings.Contains(err.Error(), "no choices in response") {
t.Fatalf("expected choices error, got %v", err)
}
}
func TestMinimaxStreamForcesStreaming(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodPost {
t.Errorf("method=%s, want POST", r.Method)
}
if r.URL.Path != "/v1/text/chatcompletion_v2" {
t.Errorf("path=%s, want /v1/text/chatcompletion_v2", r.URL.Path)
}
if body["stream"] != true {
t.Errorf("stream=%v, want true", body["stream"])
}
if got := r.Header.Get("Accept"); got != "text/event-stream" {
t.Errorf("Accept=%q, want text/event-stream", got)
}
w.Header().Set("Content-Type", "text/event-stream")
_, _ = io.WriteString(w, strings.Join([]string{
`data: {"choices":[{"delta":{"reasoning_content":"thinking"}}]}`,
`data: {"choices":[{"delta":{"content":"hello"}}]}`,
`data: [DONE]`,
``,
}, "\n"))
})
defer srv.Close()
apiKey := "test-key"
stream := false
var content, reasoning []string
err := newMinimaxForTest(srv.URL).ChatStreamlyWithSender(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
&ChatConfig{Stream: &stream},
func(answer, reason *string) error {
if answer != nil {
content = append(content, *answer)
}
if reason != nil {
reasoning = append(reasoning, *reason)
}
return nil
},
)
if err != nil {
t.Fatalf("ChatStreamlyWithSender: %v", err)
}
if got := strings.Join(content, ""); got != "hello[DONE]" {
t.Errorf("content=%q, want hello[DONE]", got)
}
if got := strings.Join(reasoning, ""); got != "thinking" {
t.Errorf("reasoning=%q, want thinking", got)
}
}
func TestMinimaxStreamAcceptsNilConfig(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if body["stream"] != true {
t.Errorf("stream=%v, want true", body["stream"])
}
w.Header().Set("Content-Type", "text/event-stream")
_, _ = io.WriteString(w, "data: [DONE]\n")
})
defer srv.Close()
apiKey := "test-key"
err := newMinimaxForTest(srv.URL).ChatStreamlyWithSender(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
nil,
func(*string, *string) error { return nil },
)
if err != nil {
t.Fatalf("ChatStreamlyWithSender: %v", err)
}
}
func TestMinimaxListModelsUsesBodylessGet(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodGet {
t.Errorf("method=%s, want GET", r.Method)
}
if r.URL.Path != "/v1/models" {
t.Errorf("path=%s, want /v1/models", r.URL.Path)
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"data": []map[string]string{
{"id": "MiniMax-M3"},
{"id": " minimax-m2.7 "},
},
})
})
defer srv.Close()
apiKey := "test-key"
models, err := newMinimaxForTest(srv.URL).ListModels(&APIConfig{ApiKey: &apiKey})
if err != nil {
t.Fatalf("ListModels: %v", err)
}
if got := strings.Join(models, ","); got != "MiniMax-M3,minimax-m2.7" {
t.Errorf("models=%q", got)
}
}
func TestMinimaxListModelsRejectsMalformedResponse(t *testing.T) {
apiKey := "test-key"
for name, response := range map[string]interface{}{
"missing data": map[string]interface{}{"object": "list"},
"empty id": map[string]interface{}{"data": []map[string]string{{"id": ""}}},
} {
t.Run(name, func(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
_ = json.NewEncoder(w).Encode(response)
})
defer srv.Close()
if _, err := newMinimaxForTest(srv.URL).ListModels(&APIConfig{ApiKey: &apiKey}); err == nil {
t.Fatal("expected malformed response error")
}
})
}
}
func TestMinimaxCheckConnectionUsesListModels(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodGet {
t.Errorf("method=%s, want GET", r.Method)
}
if r.URL.Path != "/v1/models" {
t.Errorf("path=%s, want /v1/models", r.URL.Path)
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"data": []map[string]string{{"id": "MiniMax-M3"}},
})
})
defer srv.Close()
apiKey := "test-key"
if err := newMinimaxForTest(srv.URL).CheckConnection(&APIConfig{ApiKey: &apiKey}); err != nil {
t.Fatalf("CheckConnection: %v", err)
}
}
func TestMinimaxValidatesInputs(t *testing.T) {
apiKey := "test-key"
emptyKey := " "
send := func(*string, *string) error { return nil }
tests := []struct {
name string
run func() error
want string
}{
{
name: "chat api key",
run: func() error {
_, err := newMinimaxForTest("http://unused").ChatWithMessages("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &emptyKey}, nil)
return err
},
want: "api key is required",
},
{
name: "chat model",
run: func() error {
_, err := newMinimaxForTest("http://unused").ChatWithMessages(" ", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil)
return err
},
want: "model name is required",
},
{
name: "stream api key",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, nil, nil, send)
},
want: "api key is required",
},
{
name: "stream model",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender(" ", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil, send)
},
want: "model name is required",
},
{
name: "stream sender",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil, nil)
},
want: "sender is required",
},
{
name: "models api key",
run: func() error {
_, err := newMinimaxForTest("http://unused").ListModels(&APIConfig{})
return err
},
want: "api key is required",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := tt.run()
if err == nil || !strings.Contains(err.Error(), tt.want) {
t.Fatalf("expected %q error, got %v", tt.want, err)
}
})
}
}