zlei6/ragflow
1
0
Fork 0
mirror of https://github.com/infiniflow/ragflow.git synced 2026-09-08 10:14:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(go-document): keep upload partial success data as array (#16661)

Browse Source 
### Summary

Keep `data` as the uploaded document array when dataset document upload
partially succeeds.

This matches the Python API behavior and allows parse-on-creation to run
for successfully uploaded files when other files in the same folder are
unsupported.
This commit is contained in:
Hz_
2026-07-06 19:15:29 +08:00
committed by GitHub
parent 7e0ccee7e2
commit 8ee3f097b9
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/handler/document.go
+2 -2
View File
@@ -912,7 +912,7 @@ func (h *DocumentHandler) uploadLocalDocuments(c *gin.Context, kb *entity.Knowle
if strings.ToLower(c.DefaultQuery("return_raw_files", "false")) == "true" { if strings.ToLower(c.DefaultQuery("return_raw_files", "false")) == "true" {
if len(errMsgs) > 0 { if len(errMsgs) > 0 {
common.SuccessNoMessage(c, gin.H{"documents": data, "errors": errMsgs}) common.ResponseWithCodeData(c, common.CodeServerError, data, strings.Join(errMsgs, "\n"))
return return
} }
common.SuccessNoMessage(c, data) common.SuccessNoMessage(c, data)
@@ -923,7 +923,7 @@ func (h *DocumentHandler) uploadLocalDocuments(c *gin.Context, kb *entity.Knowle
mapped[i] = mapDocKeysWithRunStatus(d) mapped[i] = mapDocKeysWithRunStatus(d)
} }
if len(errMsgs) > 0 { if len(errMsgs) > 0 {
common.SuccessNoMessage(c, gin.H{"documents": mapped, "errors": errMsgs}) common.ResponseWithCodeData(c, common.CodeServerError, mapped, strings.Join(errMsgs, "\n"))
return return
} }
common.SuccessNoMessage(c, mapped) common.SuccessNoMessage(c, mapped)
internal/handler/document_test.go
+7 -7
View File
@@ -692,15 +692,15 @@ func TestUploadDocumentsHandler_LocalReturnsPartialSuccess(t *testing.T) {
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil { if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
t.Fatalf("unmarshal response: %v", err) t.Fatalf("unmarshal response: %v", err)
} }
if resp["code"] != float64(common.CodeSuccess) { if resp["code"] != float64(common.CodeServerError) {
t.Fatalf("expected success for partial upload, got %v", resp) t.Fatalf("expected server error code for partial upload, got %v", resp)
} }
data := resp["data"].(map[string]interface{}) data := resp["data"].([]interface{})
if len(data["documents"].([]interface{})) != 1 { if len(data) != 1 {
t.Fatalf("expected one successful document, got %v", data["documents"]) t.Fatalf("expected one successful document, got %v", data)
} }
if len(data["errors"].([]interface{})) != 1 { if !strings.Contains(resp["message"].(string), "bad.exe") {
t.Fatalf("expected one file error, got %v", data["errors"]) t.Fatalf("expected failed file in message, got %v", resp["message"])
} }
} }