diff --git a/internal/handler/document.go b/internal/handler/document.go index 2ccec89a4..e04218338 100644 --- a/internal/handler/document.go +++ b/internal/handler/document.go @@ -912,7 +912,7 @@ func (h *DocumentHandler) uploadLocalDocuments(c *gin.Context, kb *entity.Knowle if strings.ToLower(c.DefaultQuery("return_raw_files", "false")) == "true" { if len(errMsgs) > 0 { - common.SuccessNoMessage(c, gin.H{"documents": data, "errors": errMsgs}) + common.ResponseWithCodeData(c, common.CodeServerError, data, strings.Join(errMsgs, "\n")) return } common.SuccessNoMessage(c, data) @@ -923,7 +923,7 @@ func (h *DocumentHandler) uploadLocalDocuments(c *gin.Context, kb *entity.Knowle mapped[i] = mapDocKeysWithRunStatus(d) } if len(errMsgs) > 0 { - common.SuccessNoMessage(c, gin.H{"documents": mapped, "errors": errMsgs}) + common.ResponseWithCodeData(c, common.CodeServerError, mapped, strings.Join(errMsgs, "\n")) return } common.SuccessNoMessage(c, mapped) diff --git a/internal/handler/document_test.go b/internal/handler/document_test.go index b06ab23c7..06887a0bb 100644 --- a/internal/handler/document_test.go +++ b/internal/handler/document_test.go @@ -692,15 +692,15 @@ func TestUploadDocumentsHandler_LocalReturnsPartialSuccess(t *testing.T) { if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil { t.Fatalf("unmarshal response: %v", err) } - if resp["code"] != float64(common.CodeSuccess) { - t.Fatalf("expected success for partial upload, got %v", resp) + if resp["code"] != float64(common.CodeServerError) { + t.Fatalf("expected server error code for partial upload, got %v", resp) } - data := resp["data"].(map[string]interface{}) - if len(data["documents"].([]interface{})) != 1 { - t.Fatalf("expected one successful document, got %v", data["documents"]) + data := resp["data"].([]interface{}) + if len(data) != 1 { + t.Fatalf("expected one successful document, got %v", data) } - if len(data["errors"].([]interface{})) != 1 { - t.Fatalf("expected one file error, got %v", data["errors"]) + if !strings.Contains(resp["message"].(string), "bad.exe") { + t.Fatalf("expected failed file in message, got %v", resp["message"]) } }