zlei6/ComfyUI
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI.git synced 2026-08-23 09:39:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Strip process narration from comments

Browse Source 
Comments carried decision dates, contract cross-references, and review
context. Keep only the constraints the code cannot show, one line each.
This commit is contained in:
Simon Pinfold
2026-08-05 13:55:51 -07:00
parent cca4da6e00
commit fff2f15b33
2 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/api/routes.py
View File

@@ -125,10 +125,7 @@ class InvalidTagFilterError(Exception):
self.details = details
# Applies to every tag-filter list, legacy spellings included — unlike the
# combination validation below, which only runs when a new-name parameter is
# present. Deliberate exception to legacy byte-identity (decision 2026-08-05):
# an unbounded list fans out into one EXISTS per tag on page and count queries.
# Caps the per-tag EXISTS fan-out; deliberately covers the legacy spellings too.
MAX_TAG_FILTER_TAGS = 100
@@ -143,9 +140,7 @@ def _resolve_tag_filters(
the legacy names keep their historical behaviour, including degenerate
combinations like include_tags=a&exclude_tags=a.
"""
# model_dump instead of attribute access: the fields are deprecated, and
# pydantic's per-access DeprecationWarning is aimed at API clients, not at
# this remap shim reading them on every request.
# model_dump, not attribute access: deprecated fields warn on every attribute read.
legacy = q.model_dump(include={"include_tags", "exclude_tags"})
include_tags = normalize_tags(legacy["include_tags"])
exclude_tags = normalize_tags(legacy["exclude_tags"])

12
tests-unit/assets_test/test_list_filter.py
View File

@@ -613,9 +613,8 @@ def test_list_assets_cross_slot_old_new_combinations(http, api_base, asset_facto
def test_list_assets_repeated_query_keys_concatenate(http, api_base, asset_factory, make_asset_bytes):
"""Core concatenates repeated occurrences of a tag param before the CSV
split. (Contract note: repeated keys are outside the cross-platform
contract; this pins Core's own behavior.)"""
"""Repeated occurrences of a tag param concatenate before the CSV split
(Core-local behavior, not a cross-platform guarantee)."""
scope = f"lf-repeat-{uuid.uuid4().hex[:6]}"
t = ["models", "model_type:checkpoints", "unit-tests", scope]
alpha, beta = f"{scope}-alpha", f"{scope}-beta"
@@ -698,9 +697,7 @@ def test_tags_refine_mixed_spellings_rejected_and_legacy_conflict_kept(http, api
def test_list_assets_tag_values_case_sensitive(http, api_base, asset_factory, make_asset_bytes):
"""Tag values are opaque byte-strings: case-distinct tags are distinct
(prod carries live pairs like SEEDVR2/seedvr2 that resolve differently),
and the all/none conflict check is byte-exact, not case-folded."""
"""Case-distinct tags are distinct; the all/none conflict check is byte-exact."""
scope = f"lf-case-{uuid.uuid4().hex[:6]}"
t = ["models", "model_type:checkpoints", "unit-tests", scope]
upper, lower = f"{scope}-ALPHA", f"{scope}-alpha"
@@ -720,8 +717,7 @@ def test_list_assets_tag_values_case_sensitive(http, api_base, asset_factory, ma
def test_tag_list_cap_applies_to_all_spellings(http, api_base):
"""The 100-tag cap covers legacy spellings too — the one deliberate
exception to legacy byte-identity (decision 2026-08-05)."""
"""The cap covers the legacy spellings too."""
big = ",".join(f"cap-{i}" for i in range(101))
for param in ("tags_any", "include_tags"):
r = http.get(api_base + "/api/assets", params={param: big}, timeout=120)