zlei6/ComfyUI
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI.git synced 2026-08-23 01:31:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Address video save review findings

Browse Source
This commit is contained in:
bymyself
2026-08-20 12:36:54 -07:00
parent 43eeb06239
commit 49a8ab4aef
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
comfy_api/latest/_input_impl/video_types.py
View File

@@ -636,7 +636,7 @@ class VideoFromFile(VideoInput):
)
continue
logging.warning(
"The %s container cannot store %s, so the whole file is being re-encoded to H.264/AAC. "
"The %s container cannot store %s, so the whole file is being re-encoded. "
"Any additional audio streams will be dropped; subtitles the output container "
"can store are kept.",
format_name, codec_name,

10
tests-unit/comfy_api_test/video_types_test.py
View File

@@ -1404,13 +1404,19 @@ def mov_text_payload(text: str) -> bytes:
return len(encoded).to_bytes(2, "big") + encoded
def add_test_subtitle_stream(container, codec):
if not hasattr(container, "add_mux_stream"):
pytest.skip("PyAV 17 or newer is required to synthesize subtitle packets")
return container.add_mux_stream(codec)
def create_subtitled_source(subtitle_codec="mov_text", container_format="mp4", frames=90, fps=30):
buffer = io.BytesIO()
with av.open(buffer, mode="w", format=container_format) as container:
video_stream = container.add_stream("mpeg4", rate=fps)
video_stream.width = video_stream.height = 64
video_stream.pix_fmt = "yuv420p"
subtitle_stream = container.add_mux_stream(subtitle_codec)
subtitle_stream = add_test_subtitle_stream(container, subtitle_codec)
subtitle_stream.time_base = Fraction(1, 1000)
for i in range(frames):
frame = av.VideoFrame.from_ndarray(
@@ -1489,7 +1495,7 @@ def test_save_to_remux_fallback_keeps_subtitles():
video_stream.pix_fmt = "yuv420p"
audio_stream = container.add_stream("pcm_u8", rate=44100)
audio_stream.sample_rate = 44100
subtitle_stream = container.add_mux_stream("mov_text")
subtitle_stream = add_test_subtitle_stream(container, "mov_text")
subtitle_stream.time_base = Fraction(1, 1000)
for i in range(30):
frame = av.VideoFrame.from_ndarray(