Files
vercel__next.js/test/e2e/script-loader/script-loader.test.ts
Tim Neutkens 8141dcf12e Convert test/integration to isolated tests (#93247)
### What?

Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.

- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
  - `test/e2e/` — 175
  - `test/production/` — 130
  - `test/development/` — 43
  - `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly

### Why?

`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.

The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.

Removing `test/integration/` lets us:

- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)

### How?

Mechanical conversion per suite, with targeted clean-ups:

1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
   - `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
   - Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`

2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.

3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.

4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.

5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.

6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
2026-05-11 13:55:47 +02:00

256 lines
8.1 KiB
TypeScript

import { nextTestSetup } from 'e2e-utils'
import { retry } from 'next-test-utils'
describe('script-loader', () => {
const { next, isNextDev, isTurbopack } = nextTestSetup({
files: __dirname,
})
// TODO: We will refactor the next/script to be strict mode resilient
// Don't skip the test case for development mode (strict mode) once refactoring is finished
it('priority afterInteractive', async () => {
const browser = await next.browser('/')
async function test(scriptID: string) {
await retry(async () => {
const script = await browser.elementByCss(`script#${scriptID}`)
const dataAttr = await script.getAttribute('data-nscript')
const endScripts = await browser.elementsByCss(
`#__NEXT_DATA__ ~ script#${scriptID}`
)
expect(script).toBeDefined()
expect(dataAttr).toBeDefined()
expect(endScripts.length).toBe(1)
})
}
// afterInteractive script in page
await test('scriptAfterInteractive')
// afterInteractive script in _document
await test('documentAfterInteractive')
})
it('priority lazyOnload', async () => {
const browser = await next.browser('/page3')
await browser.waitForElementByCss('#onload-div', { state: 'attached' })
async function test(scriptId: string, css?: string) {
await retry(async () => {
const script = await browser.elementByCss(`script#${scriptId}`)
const dataAttr = await script.getAttribute('data-nscript')
const endScripts = await browser.elementsByCss(
`#__NEXT_DATA__ ~ #${scriptId}`
)
expect(script).toBeDefined()
expect(dataAttr).toBeDefined()
if (css) {
const cssTag = await browser.elementByCss(`link[href="${css}"]`)
expect(cssTag).toBeDefined()
}
expect(endScripts.length).toBe(1)
})
}
// lazyOnload script in page
await test(
'scriptLazyOnload',
'https://cdn.jsdelivr.net/npm/bootstrap@5.3.0/dist/css/bootstrap.min.css'
)
// lazyOnload script in _document
await test('documentLazyOnload')
})
it('priority beforeInteractive', async () => {
const $ = await next.render$('/page1')
function test(id: string) {
const script = $(`#${id}`)
expect(script.length).toBe(1)
expect(script.attr('data-nscript')).toBeDefined()
let scriptCount: number
if (isTurbopack) {
if (isNextDev) {
scriptCount =
$(
`#${id} ~ script[src^="/_next/static/chunks/%5Broot-of-the-server%5D__"]`
).length +
$(
`#${id} ~ script[src^="/_next/static/immutable/chunks/%5Broot-of-the-server%5D__"]`
).length
} else {
scriptCount =
$(`#${id} ~ script[src^="/_next/static/chunks/"]`).length +
$(`#${id} ~ script[src^="/_next/static/immutable/chunks/"]`).length
}
} else {
scriptCount = $(
`#${id} ~ script[src^="/_next/static/chunks/main"]`
).length
}
expect(scriptCount).toBeGreaterThan(0)
}
test('scriptBeforeInteractive')
})
// Warning - Will be removed in the next major release
it('priority beforeInteractive - older version', async () => {
const $ = await next.render$('/page6')
function test(id: string) {
const script = $(`#${id}`)
expect(script.length).toBe(1)
expect(script.attr('data-nscript')).toBeDefined()
let scriptCount: number
if (isTurbopack) {
if (isNextDev) {
scriptCount =
$(
`#${id} ~ script[src^="/_next/static/chunks/%5Broot-of-the-server%5D__"]`
).length +
$(
`#${id} ~ script[src^="/_next/static/immutable/chunks/%5Broot-of-the-server%5D__"]`
).length
} else {
scriptCount =
$(`#${id} ~ script[src^="/_next/static/chunks/"]`).length +
$(`#${id} ~ script[src^="/_next/static/immutable/chunks/"]`).length
}
} else {
scriptCount = $(
`#${id} ~ script[src^="/_next/static/chunks/main"]`
).length
}
expect(scriptCount).toBeGreaterThan(0)
}
test('scriptBeforePageRenderOld')
})
it('priority beforeInteractive on navigate', async () => {
const browser = await next.browser('/')
// beforeInteractive scripts should load once
let documentBIScripts = await browser.elementsByCss(
'[src$="scriptBeforeInteractive"]'
)
expect(documentBIScripts.length).toBe(2)
await browser.waitForElementByCss('[href="/page1"]').click()
await browser.waitForElementByCss('.container')
// Ensure beforeInteractive script isn't duplicated on navigation
documentBIScripts = await browser.elementsByCss(
'[src$="scriptBeforeInteractive"]'
)
expect(documentBIScripts.length).toBe(2)
})
it('onload fires correctly', async () => {
const browser = await next.browser('/page4')
await retry(async () => {
const text = await browser.elementById('onload-div-1').text()
expect(text).toBe('initialaaabbbccc')
})
// Navigate to different page and back
await browser.waitForElementByCss('[href="/page9"]').click()
await browser.waitForElementByCss('[href="/page4"]').click()
await browser.waitForElementByCss('#onload-div-1')
const sameText = await browser.elementById('onload-div-1').text()
// onload should only be fired once, not on sequential re-mount
expect(sameText).toBe('initial')
})
it('priority beforeInteractive with inline script', async () => {
const $ = await next.render$('/page5')
const script = $('#inline-before')
expect(script.length).toBe(1)
// css bundle is only generated in production, so only perform inline script position check in production
if (!isNextDev) {
expect(
$(`#inline-before ~ link[href^="/_next/static/"]`).filter(
(i, element) => $(element).attr('href')?.includes('.css')
).length +
$(`#inline-before ~ link[href^="/_next/static/immutable/"]`).filter(
(i, element) => $(element).attr('href')?.includes('.css')
).length
).toBeGreaterThan(0)
}
})
it('priority beforeInteractive with inline script should execute', async () => {
const browser = await next.browser('/page7')
await retry(async () => {
const logs = await browser.log()
// not only should inline script run, but also should only run once
expect(
logs.filter((log) =>
log.message.includes('beforeInteractive inline script run')
).length
).toBe(1)
})
})
it('Does not duplicate inline scripts', async () => {
const browser = await next.browser('/')
// Navigate away and back to page
await browser.waitForElementByCss('[href="/page5"]').click()
await browser.waitForElementByCss('[href="/"]').click()
await browser.waitForElementByCss('[href="/page5"]').click()
await browser.waitForElementByCss('.container')
await retry(async () => {
const text = await browser.elementById('text').text()
expect(text).toBe('abc')
})
})
it('onReady fires after load event and then on every subsequent re-mount', async () => {
const browser = await next.browser('/page8')
await retry(async () => {
const text = await browser.elementById('text').text()
expect(text).toBe('aaa')
})
// Navigate to different page and back
await browser.waitForElementByCss('[href="/page9"]').click()
await browser.waitForElementByCss('[href="/page8"]').click()
await browser.waitForElementByCss('.container')
await retry(async () => {
const sameText = await browser.elementById('text').text()
expect(sameText).toBe('aaa')
})
})
// https://github.com/vercel/next.js/issues/39993
it('onReady should only fires once after loaded (issue #39993)', async () => {
const browser = await next.browser('/page10')
await retry(async () => {
expect(await browser.eval(`window.remoteScriptsOnReadyCalls`)).toBe(1)
expect(await browser.eval(`window.inlineScriptsOnReadyCalls`)).toBe(1)
})
})
})