mirror of
https://github.com/vercel/next.js.git
synced 2026-09-20 02:25:18 +08:00
Cong-Cong Pan
eacb749030
## Summary - upgrade `@rspack/core` to `2.0.0-rc.0` - sync the in-tree next rspack Rust binding/toolchain with newer rspack releases - align Next server runtime selection so `NEXT_RSPACK` uses the turbo-like app runtime path - include missing compiled `@next/react-refresh-utils` output in `ncc-compiled` ## What is done - `@next/rspack` Rust binding builds locally - `packages/next` builds locally - rspack-related tests are running and have been reduced to deeper runtime compatibility failures ## Rspack test investigation Latest checked CI run: `build-and-test` run `27129243230` at head `484e7bf1b30655a9f94d0855b9e00774b4b38cd0`. Confirmed Rspack / webpack parity gaps: - `test/e2e/edge-runtime-configurable-guards/edge-runtime-configurable-guards.test.ts`: Rspack does not expose the webpack parser hooks used by `MiddlewarePlugin`. The current Rspack path falls back to SWC analysis in `finishModules`, which can report diagnostics but cannot apply the parser-time transforms that wrap `eval` / `new Function`, track `InnerGraph` usage for used vs unused dynamic code, or apply `unstable_allowDynamic` with webpack parity. Dev therefore misses the expected dynamic-code runtime warnings and also reports false `process.cwd` Edge warnings from Next internals; prod fails allowed/unused dynamic-code cases. - `test/development/middleware-overrides-node.js-api/middleware-overrides-node.js-api.test.ts`: same parser-hook limitation. Webpack can observe that `process.cwd` is overwritten before use, while the Rspack SWC fallback statically flags `process.cwd` as an unsupported Edge Node API. - `test/production/css-features/css-compilation.test.ts`: the CSS is minified and prefixed as expected, but the Rspack lightningcss path currently does not expose/control source map generation the way this test expects, so emitted CSS has no `sourceMappingURL` comment or `.map` file to assert. - `test/e2e/app-dir/server-source-maps/server-source-maps.test.ts`: invalid source maps are not handled with the same graceful diagnostic as webpack/Node source-map handling. Rspack logs the raw `webpack-internal` frame for the damaged map case instead of surfacing the expected `Invalid source map. Only conformant source maps...` message with the cause. - `test/e2e/app-dir/parallel-routes-revalidation/parallel-routes-revalidation.test.ts`: raw CI output observed a dev-mode timeout waiting for `networkidle` after refresh/back/forward lazy fetching. This was not the final structured failure in the latest run, but it remains a Rspack dev parity follow-up around router cache lazy fetches and network settling. - `test/e2e/middleware-src/middleware-src.test.ts`: after the test adds root middleware files, Rspack dev still lets `src/middleware` participate; the expected behavior is that only the root middleware runs. - `test/e2e/env-config/env-config.test.ts`: changing `.env` logs `Reload env:` but the client keeps the previous `NEXT_PUBLIC_` value, pointing at an Rspack dev env invalidation/HMR gap. - `test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts`: after enabling the `useCache` flag, the dev server does not finish restarting, pointing at build-error recovery/restart parity. - `test/development/app-dir/server-navigation-error/server-navigation-error.test.ts`: middleware navigation-error cases hit `ERR_CONNECTION_REFUSED`, consistent with the Rspack dev server exiting or restarting unexpectedly during those error flows. - `test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts`: the custom-server dev process exits before the SDK handle is initialized, then cleanup fails on `shutdown`; this needs follow-up in Rspack dev/custom-server startup. - `test/e2e/next-image-new/app-dir/app-dir.test.ts`: after toggling image source, `onLoadingComplete` still reports the previous image dimensions/source, pointing at an Rspack dev image/HMR or asset invalidation parity issue. - `test/e2e/node-cli-args/node-cli-args.test.ts`: on Node `20.19.x`, `node --experimental-network-inspection` resolves instead of rejecting. This looks like a Node-version behavior change rather than an Rspack compiler issue. Not attributed to this Rspack upgrade: - `test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts` was marked by `scripts/pr-status.js` as a known flaky test across branches. - `test/production/app-dir/build-output-prerender/build-output-prerender.test.ts` ran in the webpack prod job and only differs by prerender error ordering in the inline snapshot. <!-- NEXT_JS_LLM_PR --> --------- Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>