2 Commits

Author	SHA1	Message	Date
Cong-Cong Pan	eacb749030	chore: upgrade next-rspack to rspack 2.0 (#92222) ... ## Summary - upgrade `@rspack/core` to `2.0.0-rc.0` - sync the in-tree next rspack Rust binding/toolchain with newer rspack releases - align Next server runtime selection so `NEXT_RSPACK` uses the turbo-like app runtime path - include missing compiled `@next/react-refresh-utils` output in `ncc-compiled` ## What is done - `@next/rspack` Rust binding builds locally - `packages/next` builds locally - rspack-related tests are running and have been reduced to deeper runtime compatibility failures ## Rspack test investigation Latest checked CI run: `build-and-test` run `27129243230` at head `484e7bf1b30655a9f94d0855b9e00774b4b38cd0`. Confirmed Rspack / webpack parity gaps: - `test/e2e/edge-runtime-configurable-guards/edge-runtime-configurable-guards.test.ts`: Rspack does not expose the webpack parser hooks used by `MiddlewarePlugin`. The current Rspack path falls back to SWC analysis in `finishModules`, which can report diagnostics but cannot apply the parser-time transforms that wrap `eval` / `new Function`, track `InnerGraph` usage for used vs unused dynamic code, or apply `unstable_allowDynamic` with webpack parity. Dev therefore misses the expected dynamic-code runtime warnings and also reports false `process.cwd` Edge warnings from Next internals; prod fails allowed/unused dynamic-code cases. - `test/development/middleware-overrides-node.js-api/middleware-overrides-node.js-api.test.ts`: same parser-hook limitation. Webpack can observe that `process.cwd` is overwritten before use, while the Rspack SWC fallback statically flags `process.cwd` as an unsupported Edge Node API. - `test/production/css-features/css-compilation.test.ts`: the CSS is minified and prefixed as expected, but the Rspack lightningcss path currently does not expose/control source map generation the way this test expects, so emitted CSS has no `sourceMappingURL` comment or `.map` file to assert. - `test/e2e/app-dir/server-source-maps/server-source-maps.test.ts`: invalid source maps are not handled with the same graceful diagnostic as webpack/Node source-map handling. Rspack logs the raw `webpack-internal` frame for the damaged map case instead of surfacing the expected `Invalid source map. Only conformant source maps...` message with the cause. - `test/e2e/app-dir/parallel-routes-revalidation/parallel-routes-revalidation.test.ts`: raw CI output observed a dev-mode timeout waiting for `networkidle` after refresh/back/forward lazy fetching. This was not the final structured failure in the latest run, but it remains a Rspack dev parity follow-up around router cache lazy fetches and network settling. - `test/e2e/middleware-src/middleware-src.test.ts`: after the test adds root middleware files, Rspack dev still lets `src/middleware` participate; the expected behavior is that only the root middleware runs. - `test/e2e/env-config/env-config.test.ts`: changing `.env` logs `Reload env:` but the client keeps the previous `NEXT_PUBLIC_` value, pointing at an Rspack dev env invalidation/HMR gap. - `test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts`: after enabling the `useCache` flag, the dev server does not finish restarting, pointing at build-error recovery/restart parity. - `test/development/app-dir/server-navigation-error/server-navigation-error.test.ts`: middleware navigation-error cases hit `ERR_CONNECTION_REFUSED`, consistent with the Rspack dev server exiting or restarting unexpectedly during those error flows. - `test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts`: the custom-server dev process exits before the SDK handle is initialized, then cleanup fails on `shutdown`; this needs follow-up in Rspack dev/custom-server startup. - `test/e2e/next-image-new/app-dir/app-dir.test.ts`: after toggling image source, `onLoadingComplete` still reports the previous image dimensions/source, pointing at an Rspack dev image/HMR or asset invalidation parity issue. - `test/e2e/node-cli-args/node-cli-args.test.ts`: on Node `20.19.x`, `node --experimental-network-inspection` resolves instead of rejecting. This looks like a Node-version behavior change rather than an Rspack compiler issue. Not attributed to this Rspack upgrade: - `test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts` was marked by `scripts/pr-status.js` as a known flaky test across branches. - `test/production/app-dir/build-output-prerender/build-output-prerender.test.ts` ran in the webpack prod job and only differs by prerender error ordering in the inline snapshot. <!-- NEXT_JS_LLM_PR --> --------- Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>	2026-06-15 23:19:53 +00:00
Tim Neutkens	8141dcf12e	Convert test/integration to isolated tests (#93247) ... ### What? Converts every test under `test/integration/` to an isolated test running through `nextTestSetup` (under `test/e2e/`, `test/production/`, `test/development/`, or `test/unit/`), then deletes `test/integration/` along with the legacy CI orchestration that was specific to it. - `test/integration/` removed entirely (~327 test suites) - New isolated suites added across the existing folders: - `test/e2e/` — 175 - `test/production/` — 130 - `test/development/` — 43 - `test/unit/` — 1 - `.github/workflows/build_and_test.yml` and `run-tests.js` no longer have any `integration` branches - `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a small number of tests that drive their own proxy/static-export server can keep using `next.browser(...)` instead of importing `next-webdriver` directly ### Why? `test/integration/` predated `nextTestSetup` and ran tests directly against the source checkout via custom helpers (`launchApp`, `nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`, …). Each suite hand-rolled its own dev/start/build orchestration, fixture mutation, and process management. The isolated test model used by the rest of the repo gives each suite an isolated working directory containing a packed `next.tgz` install, a uniform `next.start()` / `next.build()` / `next.fetch()` / `next.browser()` API, and the same lifecycle for dev, start, and deploy modes — so a single set of assertions covers all three. Deploy-mode skips and per-feature gates are expressed declaratively (`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`) instead of branching on `process.env`. Removing `test/integration/` lets us: - Delete the bespoke orchestration code in the CI workflow and `run-tests.js` - Run every converted suite consistently in dev, start, and deploy modes (where applicable) - Reproduce every test locally with the same `pnpm test-{dev,start}-{turbo,webpack}` commands; no separate `integration` path - Open the door to running `test/production` against deployments in the future (the converted suites already declare `skipDeployment` so they can be flipped on) ### How? Mechanical conversion per suite, with targeted clean-ups: 1. **Per-suite conversion.** Each `test/integration/<name>/test/index.test.{js,ts}` was rewritten into a single `<name>.test.ts` under the right folder based on what the original exercised: - `launchApp` / dev-only assertions → `test/development/` - `nextBuild` + `nextStart` / start-only assertions → `test/production/` - Both → `test/e2e/` - The one pure jsdom render check (`link-without-router`) → `test/unit/` 2. **API mapping.** Custom helpers were replaced by `nextTestSetup` equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`, `runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`, `webdriver(...)` → `next.browser(...)`. Fixture mutations switched from raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg `runWithTempContent` callback when the change has a defined scope) and `next.deleteFile`. 3. **Deploy-mode handling.** Suites that can't run in deploy mode (use `patchFile` / `next.build()` / depend on local CLI output) declare `skipDeployment: true` and early-return on the `skipped` boolean. Suites where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare `disableAutoSkewProtection: true`. 4. **`next.browser({ baseUrl })`.** A handful of tests (`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both `react-virtualized` suites) need to drive a separate server (a static-export server or an `http-proxy` instance) rather than the Next.js process. Instead of importing `next-webdriver` directly, those tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the proxy cases, the proxy was moved into `server.js` inside the fixture and `http-proxy` declared via the `dependencies` option of `nextTestSetup`, so the test runs with a fully isolated dependency graph. 5. **CI clean-up.** With `test/integration` gone, the `test integration*` jobs and `integration-tests-manifest`-related logic in `.github/workflows/build_and_test.yml` were removed, and `run-tests.js` no longer has the `integration` test-folder branch. 6. **Validation.** The PR was iterated against multiple full CI runs; the remaining failures on the latest run are pre-existing flakes (segment-cache 60s `act` timeouts in turbopack-prod) or transient infrastructure issues unrelated to the conversion.	2026-05-11 13:55:47 +02:00