Commit Graph

264 Commits

Author SHA1 Message Date
JJ Kasper 98a2448e5e Fix release stats (#45027) 2023-01-18 20:17:11 -08:00
Jan Kaifer d7307cffb7 Fix turbo usage in tests (#44715) 2023-01-18 20:35:28 +01:00
Jan Kaifer f0c7e72c77 Create new action that will auto-label issues that have some activity after we mark them as "verify-canary" or "add repro"" (#44815) 2023-01-13 17:20:59 +01:00
Jan Kaifer 6ef7f5ec5b port type: needs investigation into linear (#44823)
Port it to Linear whenever we need investigation more investigation.

Tested on my fork.
2023-01-13 10:29:09 +00:00
JJ Kasper f85340f50a Update release stats for newer pnpm version (#44828) 2023-01-12 09:27:00 -08:00
JJ Kasper 12bfabd179 Update to latest version of pnpm (#44791) 2023-01-11 17:36:52 -08:00
Jan Kaifer f83ef27538 Autolabel with linear when labeled with kind: bug (#44774)
Creates a new workflow and action that auto labels with `linear` whenever we apply `kind: bug`.
It's using JS action instead of docker, so it should be quite fast.

I tested this on my fork and it works.

Also created the action with TS so we can use it as a starting point for next actions so they can all be typed.
2023-01-11 16:48:37 +00:00
Jan Kaifer cafbe2a0ad Revert "Use turbo for packing files in test setup (#44074)" (#44566)
This reverts commit fd9ec646ac.

It seems that there is an issue with caching of inputs which uses stale
files.

We also had to disable caching of `pnpm-lock.yaml` because it requires
stable package locations chich we removed.
2023-01-04 10:23:21 -08:00
Jan Kaifer a7b046d92e Cache package lock when running tests to speed up installation (#44520) 2023-01-03 11:55:28 +01:00
Jan Kaifer fd9ec646ac Use turbo for packing files in test setup (#44074) 2022-12-22 16:36:24 +01:00
Jan Kaifer e239a41ed4 Run packing in tests in parallel (#44048)
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
2022-12-16 11:03:07 +01:00
Jan Kaifer ab328c6c39 Add tracing for testing tools (#44046) 2022-12-16 09:58:04 +01:00
Jan Kaifer bf4e6fb586 Revert "Run packing in tests in parallel"
This reverts commit df527e7aad.
2022-12-15 13:16:36 +01:00
Jan Kaifer df527e7aad Run packing in tests in parallel 2022-12-15 13:15:51 +01:00
Balázs Orbán 5e3bb45f55 chore: add repro links in "verify canary" comment (#43979)
[Slack
thread](https://vercel.slack.com/archives/C03KAR5DCKC/p1669918824743499)

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ]
[e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see
[`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-12-12 14:26:40 -08:00
Jan Kaifer 367a5df546 Clarify e2e dependency on yarn in contributin docs (#43287)
`yarn` installed with `corepack` won't run in our repo because it is configured as a `pnpm` project. `yarn` binaries installed from other sources don't care.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] [e2e](https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see [`contributing.md`](https://github.com/vercel/next.js/blob/canary/contributing.md)

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
2022-12-09 12:34:32 +00:00
Balázs Orbán b0aa73b4cf chore: disable auto-labeling 2022-11-30 17:53:53 +01:00
Balázs Orbán 7bd170387f chore: don't comment twice 2022-11-30 15:59:39 +01:00
Balázs Orbán 81aebe953b chore: fix issue verifier 2022-11-30 12:43:18 +01:00
Balázs Orbán 5003de7b2d chore: fix issue verifier issues 2022-11-30 12:15:35 +01:00
Balázs Orbán cd02e5cf18 chore: hardcode path for issue validator 2022-11-29 19:15:06 +01:00
Balázs Orbán fa26819340 chore: move comments of issue validator 2022-11-29 19:06:23 +01:00
Balázs Orbán 0d2f92a27e chore: fix issue validator 2022-11-29 19:04:08 +01:00
Balázs Orbán f0625662f4 chore: update issue verifier (#43339)
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-11-29 18:39:41 +01:00
JJ Kasper c66b8f3926 Update bench options in stats-config (#41432)
x-ref:
https://github.com/vercel/next.js/actions/runs/3252514635/jobs/5338830017
x-ref:
https://github.com/vercel/next.js/actions/runs/3250842765/jobs/5335182082
2022-10-14 18:17:45 -07:00
Jiachi Liu 3e8af93220 Align pnpm version (#41123)
Align pnpm version in build pipelines with 7.3.0 to make sure lock files
are generated correctly
2022-10-03 17:07:52 +02:00
Jiachi Liu cbfab2a3b7 Strip internal pages for pagesDir in app edge ssr (#40776)
For app edge SSR, we don't need any internal pages for it since it's
handled by app-renderer. This results around reducing 20KB from app edge
SSR

# Changes
* Strip those internal pages modules when it's in app edge SSR
* Minimize edge SSR chunk to see the tree-shake result
* Add bundle analyzer with switcher in stats-app for testing. Using
`TEST_ANAYLYSE=1` to build stats-app for testing
2022-09-21 17:18:18 -07:00
JJ Kasper 6e2738241f Update to use specific swc version for PR stats (#40237)
Currently we use one dev swc build for running release/PR stats although the latest swc build could be incompatible with previous tags/commits being compared against so this updates to use the specific version related to that tag. This also updates to omit the swc size from `node_modules` size since it's a dev build and not helpful to track. 

Fixes: https://github.com/vercel/next.js/runs/8189857273?check_suite_focus=true
2022-09-05 13:30:21 -07:00
JJ Kasper 4f36064938 Update docker image for stats action (#40032)
Noticed the stats action was leveraging the wasm fallback incorrectly
which seems to be due to the necessary glibc version not being available
in the docker image we were leveraging so this updates the base docker
image used so the wasm fallback isn't needed and the dev binary is
correctly used again.

Fixes:
https://github.com/vercel/next.js/runs/8004433626?check_suite_focus=true
Fixes:
https://github.com/vercel/next.js/runs/7988021570?check_suite_focus=true
2022-08-28 13:43:29 -05:00
Balázs Orbán 5c8183464d chore: check against npm version in issue validator (#38915)
I did some experimenting to see if we can grab the latest version from npm instead of GitHub releases since that's the version the user can actually use.

The npm registry sends the package metadata in a gigantic (~8mb for `next`) JSON response and parsing it with `res.json()` takes several seconds, but using `ReadableStream`, we only care about the first chunk. This way we can grab the relevant version information in a few ms. ~I added `undici` which implements `res.body.getReader()`.~ Using Node 18/native `fetch`.
2022-08-25 11:43:20 -05:00
Balázs Orbán 2da0ca2138 chore: tweak issue validator action 2022-07-15 14:36:06 +02:00
Balázs Orbán ef7c9a4080 chore: improve issue validator logs 2022-07-14 12:39:12 +02:00
Balázs Orbán 0ac8ad07cb chore: tweak issue validator (#38600)
- Do not comment/label if `next info` wasn't used, as we might not be able to detect the versions reliably.
- Ignore all issues that do not have the `template: bug` label or weren't labeled manually. (This might slip through a few issues that did not follow our template like [Reference in new issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-an-issue#creating-an-issue-from-a-comment) but that's minimal overhead already)
- Added note when the reproduction URL is unreachable to invite me to the private repository.
- Turned on DEBUG mode (no comments/labels, only logs) for now, so we can verify the behavior and find issues.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
2022-07-13 23:15:25 +00:00
JJ Kasper 9222ca9f3f Add dev/start timing to PR stats (#38525)
* Add dev/start timing to PR stats

* get port for dev

* add dep

* update field names
2022-07-11 14:54:57 -05:00
Balázs Orbán e6bad25b5e chore: fix issue validator paths 2022-07-04 13:54:20 +02:00
Balázs Orbán 50fa170520 chore: don't use type: "module" when building the Issue validator action (#38197)
https://github.com/vercel/next.js/runs/7130177863?check_suite_focus=true

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
2022-06-30 17:26:57 +00:00
Balázs Orbán f0b7457666 chore: compile issue validator action (#37990)
Ref:

https://github.com/vercel/next.js/runs/7042041627?check_suite_focus=true
https://github.com/vercel/next.js/runs/7042041634?check_suite_focus=true

https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
2022-06-26 21:39:19 +00:00
Balázs Orbán bee7b31549 chore: use Node 16 for issue validator action (#37982) 2022-06-24 12:27:49 +02:00
Balázs Orbán e6796bafc4 chore: add action.yml to Issue validator action (#37950)
See: https://github.com/vercel/next.js/runs/7024234103?check_suite_focus=true#step:2:1

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
2022-06-23 14:05:46 +00:00
Balázs Orbán b8c61a9c27 chore: detect no canary verification (#37788)
When triaging bug reports, we would like to make sure that our main focus is on unresolved issues. Next.js is a highly active project, and we cut new releases fairly often, under the `next@canary` tag. Some of the issues being reported might have already been fixed there, so we would like to encourage people to check them out. Once a fix is in `canary`, it will be included in the next `latest` release automatically.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
2022-06-22 14:54:11 +00:00
JJ Kasper 924582b52c Update to use latest version of pnpm (#37794)
* Update to use latest version of pnpm

* add packageManager field
2022-06-17 12:36:37 -05:00
JJ Kasper f7b81316ae Update to leverage pnpm for monorepo (#37259)
* Update to leverage pnpm for monorepo

* update compiled

* update stats action

* update ci install step

* update ci

* add test dep

* update invoking scripts

* update caching

* skip cache for now

* update dep

* update packages and fix babel

* update compiled

* update lint

* update test

* update ci

* update pnpm store caching

* update path for windows

* update restore-key config

* update caching

* remove extra build azure stage

* re-add checkout

* update setting pnpm store

* bump

* remove azure caching as pnpm is faster to download

* update contributing

* apply suggestions

* remove install-peers

* prepublish -> prepublishOnly

* prepublish -> prepublishOnly more

* more yarn -> pnpm references

* more yarn -> pnpm references take 2

* use workspace protocol for root package.json

Co-authored-by: Steven <steven@ceriously.com>
2022-05-28 23:35:16 -05:00
CommanderRoot db2567b01b chore: replace deprecated String.prototype.substr() (#35421)
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>

Co-authored-by: Steven <steven@ceriously.com>
2022-03-24 17:49:38 -04:00
Maia Teegarden a79d4fc366 Extract next-swc Rust code into its own package (#31635)
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-11-21 12:59:56 +01:00
Maia Teegarden b5a89160f7 Chore/rust workflow (#30577)
* Remove prebuilt binaries from repo

* Prefer locally built binary

* Add binary packages as optionalDependencies

* Remove build-native workflow for prebuilt binaries

* Remove binaries from checkCompiled job

* Change build-native command to default to dev

* Add build-native-dev and have tests depend on it

* Update contributing

* Run ls to make inspect artifact download

* Use correct artifact download path

* Try using reusable workflows

* Resort to duplication for now

* Inspect artifact download

* Ensure native is copied for PR stats

* Copy after ref checkout and log binaries for PR stats

* fix typo

* copy right before linking/packing

* Use fs.copy

* fix test for now

Co-authored-by: jj@jjsweb.site <jj@jjsweb.site>
2021-10-29 13:56:56 -05:00
JJ Kasper 864d5c6bd8 Update removeHash handling for stats-app (#30235) 2021-10-24 19:12:26 +02:00
Steven 094153f935 Fix repo-setup when .DS_Store exists (#30119) 2021-10-20 18:13:09 -05:00
JJ Kasper 61409dd615 Update stats-config for release stats (#29654) 2021-10-05 17:49:24 -05:00
Tim Neutkens 7d664d5b36 Add stats config for SWC (#28883)
* Add stats config for SWC

* Remove stats for deprecated mode

* Include native binaries in local linking

* Expose minify in next-swc

* Build next-swc binaries

* Only upload changed binary artifact

* Build next-swc binaries

* Expose minify in js binding

* Use new minify function in terser plugin

* Build next-swc binaries

* Build next-swc binaries

* Build next-swc binaries

* Pass pagesDir option to SWC for next/dynamic

* Build next-swc binaries

* Add spans for next-trace-entrypoints-plugin

* Fix linting

Co-authored-by: Maia Teegarden <dev@padmaia.rocks>
Co-authored-by: padmaia <padmaia@users.noreply.github.com>
Co-authored-by: timneutkens <timneutkens@users.noreply.github.com>
2021-09-14 18:13:11 +02:00
JJ Kasper a92a5caec2 Update test set-up to leverage playwright when able to (#28634)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-09-13 14:36:25 +02:00