faefab0d9d
Fix mock span ( #64944 )
...
Seems this was incorrectly referencing the wrong instance.
x-ref: https://github.com/vercel/next.js/pull/64909
x-ref:
https://github.com/vercel/next.js/actions/runs/8806556249/job/24171671288?pr=64691#step:7:839
Closes NEXT-3210
2024-04-23 13:50:30 -07:00
a65bd31820
Speed up createNext test suite isolation ( #64909 )
...
## What?
Before: 25.71s
After: 11.05s (-57%)
## How?
Currently the system for isolation looks like this:
- Copy `packages` folder to an isolated directory
- Run `pnpm pack` for all folders in `packages`
- Collect the pack files, add them as `dependencies` in package.json of
the isolated application
- Run `pnpm install`
Because the `next-swc` (Turbopack + SWC, yes we still need to rename the
package) binary file is quite large in development (900MB+) it means we
have to copy, then zip (pnpm pack), then unzip (pnpm install) that
binary, which takes about 3+ seconds in each step.
The change in this PR is to skip the copy/zip/unzip completely by
providing the folder path for the binary directly to Next.js, as it's a
binary we don't need the special isolation for this, it's already
standalone so running it directly allows us to skip 14,6 seconds of work
that is required for each isolated test in development.
This will likely have little effect on CI times as we already do some
tricks like only running the packing at the start of the CI process.
Only thing that could be better and is probably worth doing is adopting
this change for the time it saves for unzipping, that's almost 4 seconds
per test still.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-3200
---------
Co-authored-by: JJ Kasper <jj@jjsweb.site >
2024-04-23 21:12:59 +02:00
ce69d02cf9
chore: remove unused rust dependencies ( #62176 )
...
### What?
Toolchain is updated as well.
Should improve compile times marginally, also added the new parallel
frontend.
Depends on https://github.com/vercel/turbo/pull/7409
Closes PACK-2526
2024-04-16 17:48:06 +02:00
4623eace76
chore: Update pnpm v8.15.1 to v8.15.7 ( #64479 )
...
Here are the release notes for pnpm versions v8.15.2 through v8.15.7,
- [v8.15.2 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.2 )
- [v8.15.3 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.3 )
- [v8.15.4 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.4 )
- [v8.15.5 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.5 )
- [v8.15.6 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.6 )
- [v8.15.7 Release
Notes](https://github.com/pnpm/pnpm/releases/tag/v8.15.7 )
2024-04-15 14:54:28 +00:00
e8f8c8e206
Add additional logs to next-integration-stat ( #64169 )
...
## What?
We're currently seeing a failure on this action but it's unclear why it
happens so this PR introduces additional logs.
Current failure:
https://github.com/vercel/next.js/actions/runs/8550039767/job/23427388195#step:4:110
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-3024
2024-04-08 11:04:36 +02:00
ae2fbb4ae3
Run compile for .github/actions/upload-turboyet-data ( #64025 )
...
## What?
This GitHub action wasn't running the latest code because it needs a
compile that is committed.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-2990
2024-04-04 12:12:44 +02:00
ad1dc3f8f1
retry pnpm pack ( #63519 )
...
### What?
Make CI more stable
Closes PACK-2799
2024-03-20 18:38:42 +01:00
859605a52c
Add reporting of turbopack-dev-examples-manifest.json ( #63521 )
...
## What?
Adds a manifest to track which examples have been checked with `next dev
--turbo` and reports it to areweturboyet.com
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-2878
2024-03-20 14:58:01 +01:00
b9547e74fc
Implement Turbopack build manifest update ( #63461 )
...
WIP.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-2857
2024-03-19 13:00:33 +01:00
d91e78adb7
Rename turbopack-tests-manifest to turbopack-dev-tests-manifest ( #63409 )
...
## What?
- Renames the Turbopack tests manifest to reflect that it only holds
development tests.
- Creates initial plumbing for Turbopack build tests manifest (currently
empty)
- Added running tests in the Turbopack builds test manifest on PRs
- Implements uploading the Turbopack builds manifest to areweturboyet
What this doesn't implement:
- Updating the Turbopack builds manifest
Open questions:
- Since the manifest is empty there are no test results, I had to add
handling for that in `run-tests.js`:
https://github.com/vercel/next.js/pull/63409/files#diff-269567847b110d8ecaaade3ab592df207bba02c7b446db23d72f18ff0e61d335R359
but not sure if that exit case was added for a specific special reason.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-2837
2024-03-19 10:26:14 +01:00
9c36286431
Upgrade popular-issues and popular-prs workflows ( #63436 )
...
## Changes
- Add links to source code
- Add creation dates for issues and PRs
Closes NEXT-2850
2024-03-18 22:54:32 +00:00
8478d6578d
test(manifest): upload areweturboyet kv from test manifest ( #63064 )
...
### What
context: https://vercel.slack.com/archives/C04KC8A53T7/p1709908007968319
Current test flakyness keeps changing the latest data from
areweturboyet, so instead of relying on each run's data trying to use
manifest's known good instead.
Closes PACK-2698
2024-03-08 13:17:43 -08:00
5f3b13584c
chore: update pnpm version from 8.15.1 to 8.15.4 ( #62979 )
...
Update pnpm version from 8.15.1 to 8.15.4
pnpm 8.15.4 release note
https://github.com/pnpm/pnpm/releases/tag/v8.15.4
Previous comment form reviewer
https://github.com/vercel/next.js/pull/62963#issuecomment-1982010314
2024-03-07 09:22:45 +00:00
4550faddc6
Fix handling for getting latest stable tag ( #62858 )
...
This simplifies our `getLastStable` handling to use our GitHub latest
release as the source of truth instead of trying to parse this from the
git history as that can be less reliable depending on the checkout depth
and the order of releases.
x-ref:
https://github.com/vercel/next.js/actions/runs/8149447058/job/22274305183
Closes NEXT-2704
2024-03-04 19:41:30 -08:00
23eba22d02
ci(workflow): fix 403 redirect ( #62665 )
...
### What
While running ci workflow for areweturboyet, found some log fetching
fails with 403 when it tries to redirect url. Weirdly, attaching the
auth token makes this happen suddenly. Redirected url for the log is
public anyway (should be accessible from bare fetch / curl), fixing it.
Also updated some dependencies to the latest.
Closes PACK-2618
2024-02-28 23:26:38 +00:00
49b4331e26
Reduce memory/cache overhead from over loader processing ( #62005 )
...
In `v14.0.2-canary.1` users started noticing more memory errors
especially with many edge runtime configured pages. After investigation
it seems this can be related to the additional transpiling we configured
in https://github.com/vercel/next.js/pull/59569 and
https://github.com/vercel/next.js/pull/57784
To help alleviate this we are updating the default swc loader to have an
additional check to see if no special features such as `next/font`,
`next/dynamic`, or `use server/client` directives are present and then
no-oping in the loader to avoid additional overhead for a majority of
modules.
For monitoring regressions our `stats-app` has been updated with
repeated edge-ssr routes to hopefully help us keep an eye on memory or
cache size issues.
x-ref: NEXT-2430
x-ref: NEXT-2395
x-ref: NEXT-2299
x-ref: NEXT-2324
x-ref: NEXT-2373
Closes NEXT-2479
2024-02-13 22:40:19 +00:00
2039d87007
chore(github-workflow): dynamically create pr list (> 1 +1 reaction) ( #61963 )
...
## Changes
- Filter out popular PRs that have less than 1 `+1` reaction
2024-02-12 22:09:56 +00:00
f2437df9c1
chore: Update pnpm v8.14.2 to 8.15.1 ( #61807 )
...
v8.15.1 changelog
- https://github.com/pnpm/pnpm/releases/tag/v8.15.1
- https://github.com/pnpm/pnpm/releases/tag/v8.15.0 nd Include v8.15.0
update
---------
Co-authored-by: Sam Ko <sam@vercel.com >
2024-02-09 21:46:19 +00:00
f8aa7f3af8
chore: add pull_request_popular workflow ( #61760 )
...
## Description
Add a GitHub Workflow that notifies us (internally) about the top 15
:pr:s (most reacted) in the last 90
days.
Closes NEXT-2387
2024-02-07 14:59:46 -08:00
73d2671b04
Fix areweturboyet test path ( #61314 )
...
## What?
Since moving this action to the Next.js repository the paths have been
incorrect. Seemingly because of this line. Will have to land and run it
to verify if it works correctly after the changes.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
Closes NEXT-2281
2024-01-29 11:21:59 +01:00
ebeda9d1c2
chore: update issue_popular to 90 days ( #61008 )
...
## Changes
- Update description for issue-popular workflow to 90 days
Closes NEXT-2192
2024-01-24 20:55:50 +00:00
ed4dea49ea
chore: upgrade pnpm to 8.14.2 ( #60995 )
...
## Changes
- Update all instances of pnpm to the latest v8.14.2
Closes NEXT-2188
2024-01-22 14:12:09 -08:00
3a8436b128
chore: update issue_popular workflow to 90 days ( #60860 )
...
## Changes
- Update issue_popular to 90 days for broader look at issues
Closes NEXT-2163
2024-01-19 05:52:27 +00:00
a90e5d6e4b
Fix last stable tag for release stats ( #60850 )
...
x-ref:
https://github.com/vercel/next.js/actions/runs/7576301894/job/20635069339
Closes NEXT-2159
2024-01-18 14:50:31 -08:00
e620531480
chore: remove pr_approved workflow & update popular_issues workflow ( #60584 )
...
## Changes
- Remove `pr_approved.yml`
- Update popular issues workflow, move to a different Slack channel
Closes NEXT-2089
2024-01-12 21:41:44 +00:00
cc2bd0de76
chore: update next-repo-info actions ( #60559 )
...
## Description
A few changes to
https://github.com/vercel/next.js/tree/canary/.github/actions/next-repo-info
and related workflows.
## Changes
- Update `generateBlocks()` function
- Fix Slack channel title typo
- Fix `issuesAndPullRequests({ ... })` API call
Closes NEXT-2077
2024-01-12 11:19:22 +00:00
7b73f1137b
chore: add issue_popular workflow ( #60543 )
...
## Description
Add a new GitHub workflow that outputs the top 15 :github2: issues (most reactions) in
the last month.
Closes NEXT-2071
2024-01-11 18:27:47 -08:00
2138facc12
chore: update pull_request_approved workflow ( #60537 )
...
## Description
Updating
https://github.com/vercel/next.js/blob/canary/.github/workflows/pull_request_approved.yml
and related.
## Changes
- Fix path so workflow runs
- Update cron schedule to be on a weekly basis on instead of daily
- Update Slack channel
Closes NEXT-2068
---------
Co-authored-by: JJ Kasper <jj@jjsweb.site >
2024-01-11 13:34:42 -08:00
43410c9926
chore: update pnpm to the latest (v8.14.0) ( #60295 )
...
Update <picture data-single-emoji=":pnpm:" title=":pnpm:"><img
class="emoji" width="20" height="auto"
src="https://emoji.slack-edge.com/T0CAQ00TU/pnpm/49b40aec15de9c17.png "
alt=":pnpm:" align="absmiddle"></picture> to the latest (v8.14.0).
Closes NEXT-2003
2024-01-05 22:12:04 -05:00
9ce18c4d5f
chore: update Copyright time from 2023 to 2024 ( #60071 )
...
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2024-01-02 11:06:02 -08:00
15215d4c96
ci: report daily turbo integration test results from this repo ( #58965 )
...
### What?
A follow up for #58267 and #58394 .
We no longer need the git branch for history it's stored in datadog now
and we also decided that we no longer need slack reporting.
Closes PACK-2039
---------
Co-authored-by: Tim Neutkens <tim@timneutkens.nl >
2023-12-04 16:18:42 +01:00
2a8f7ae1b1
Update Turbopack test manifest from GitHub Actions artifact ( #58394 )
...
### What?
We can use the GitHub actions artifact (which is already produced right
now) instead of a separate git branch to get the latest test results.
This also means we don't have a dependency back to the turbo repo for
the daily tests.
Closes PACK-1951
2023-11-24 16:48:12 +01:00
53b815547d
Refactor repo-setup.js ( #58131 )
...
Doesn't make any functional changes. Going through the current setup for isolated tests to figure out a better way to cache the repository setup, so that we don't have to wait ~30s+ when running tests locally.
2023-11-07 13:01:12 +00:00
54a0e05309
tweak stats action to pull in runtime sizes ( #58005 )
...
This wasn't working previously so updated the glob & script to properly track changes to our bundled next runtimes
Should now be appended to the bottom of the PR stats action, eg:
2023-11-03 23:39:37 +00:00
191faf392c
Import turbo daily integration test workflows ( #57083 )
...
As discussed this imports our daily turbo integration tests workflow
into the Next.js repo
2023-10-23 11:48:38 -07:00
abe8b1e0a8
Improve performance of String.prototype.split uses ( #56746 )
...
This PR adds the optional `limit` parameter on String.prototype.split uses.
> If provided, splits the string at each occurrence of the specified separator, but stops when limit entries have been placed in the array. Any leftover text is not included in the array at all.
[MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split#syntax )
While the performance gain may not be significant for small texts, it can be huge for large ones.
I made a benchmark on the following repository : https://github.com/Yovach/benchmark-nodejs
On my machine, I get the following results:
`node index.js`
> normal 1: 570.092ms
> normal 50: 2.284s
> normal 100: 3.543s
`node index-optimized.js`
> optmized 1: 644.301ms
> optmized 50: 929.39ms
> optmized 100: 1.020s
The "benchmarks" numbers are :
- "lorem-1" file contains 1 paragraph of "lorem ipsum"
- "lorem-50" file contains 50 paragraphes of "lorem ipsum"
- "lorem-100" file contains 100 paragraphes of "lorem ipsum"
2023-10-19 00:25:15 +00:00
523474c8be
chore: lower Node.js version requirement ( #56943 )
2023-10-17 23:15:31 +02:00
1ff7f07875
feat: drop Node.js 16 ( #56896 )
...
### What?
BREAKING CHANGE: Bump the minimum required Node.js version.
### Why?
Node.js 16 has reached end-of-life in September.
Bumped to `18.18.2` since it contained some security-related patches: https://nodejs.org/en/blog/vulnerability/october-2023-security-releases
### How?
Bumped `engines` where needed, upgraded the workflows.
This will allow us to remove quite a few polyfills, I'll open separate PRs for those.
2023-10-16 21:41:38 +00:00
35a99232c0
misc: tweak stats github action ( #56694 )
...
This PR adds a few tweaks to our Github actions PR:
- expand by default the main section
- add some heuristics to not show hash/id changes in the diff view
- add some heuristics to not show increase/decrease size when it's too small (100 bytes is noise most often)
- add rendering runtimes to the list of tracked files
after vs before
2023-10-12 08:27:44 +00:00
d73b8366af
Use node:fs instead of fs-extra in .github/actions ( #56536 )
...
Test Plan: Stats for this PR?
Closes WEB-1730
2023-10-11 00:52:55 +00:00
35f507242c
fix: next dev with edge runtime on windows ( #56502 )
...
- Reverts https://github.com/vercel/next.js/pull/44616
- Regression introduced in https://github.com/vercel/next.js/pull/51651
- Fixes https://github.com/vercel/next.js/issues/55013
2023-10-10 14:03:03 +00:00
56fe014532
chore: bump pnpm to 8.9 ( #56649 )
...
There's allegedly a bump in performance for mac for pnpm 8.9 so upgrading it in the repo.
2023-10-10 11:23:10 +00:00
edb92a30b5
test: speed up isolated next instance test setup ( #56525 )
2023-10-07 00:15:59 +02:00
d5c35a1bbb
chore: replace issue triaing actions with nissuer ( #55525 )
...
### What?
Moving maintenance to a separate repository.
### Why?
I want to make these actions reusable in other projects as they seem to work well in the Next.js repository.
### How?
The code is moved to https://github.com/balazsorban44/nissuer
I tested it on my fork, and all the following functionality is preserved: https://github.com/balazsorban44/next.js/issues/56
- [x] Close/lock/comment without a valid reproduction link
- [x] Minimize "+1"
- [x] Add labels based on user selection
- [x] Add comment based on the maintainer's label (eg.: "please add a complete reproduction")
2023-09-19 11:11:00 +00:00
c6c3891688
chore: remove replay from issue template ( #55397 )
...
### What?
Removes Replay.io as a valid reproduction link from our bug template.
### Why?
Based on issues https://github.com/vercel/next.js/issues/55181 and https://github.com/vercel/next.js/issues/55278 it looks like people are struggling to report the correct thing. Also, without source maps, replays are still harder to use for debugging than an actual code base
Ref: [Slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1694608481515339?thread_ts=1694428848.689079&cid=C04DUD7EB1B )
2023-09-18 17:05:19 +00:00
94ae5098bd
Test with latest node@18 ( #54000 )
...
Basically revert #52894 , should be able to keep testing against latest node 18
2023-09-12 21:47:51 +00:00
7decb13000
chore(ci): bump pnpm v8.6.11 to v8.7.1 ( #54873 )
...
My "pnpm@v8.7.0" was not working and I noticed it by accident and sent a PR.
Co-authored-by: Steven <229881+styfle@users.noreply.github.com >
2023-09-06 00:39:44 +00:00
180749c096
Update ready check for PR stats ( #55022 )
...
Looks liket his has been broken since
https://github.com/vercel/next.js/pull/54713 due to the text it watches
for being changed.
2023-09-05 11:12:43 -07:00
7a871a9424
chore: fix autolabeler ( #54916 )
...
### What?
Follow-up of #54824
### Why?
Correctly detect the section to look for while autolabeling. The text currently being searched is not present in the issue body, just the template. Example: #54911 where "App Router" is present but was not detected.
2023-09-02 21:05:10 +00:00
9adc7910a2
chore: update bug report template ( #54824 )
...
### What?
Follow-up of #54724
- Removed/merged some sections
- Added placeholders to hint the user what the input should be
- Reorganized the sections in terms of importance
- Made all sections but one required (we should not ask irrelevant questions to simplify the reporting process)
- Added a small guide on how to pinpoint an exact version of Next.js introducing a bug
### Why?
Clarifying the fact that a missing/invalid reproduction will result in the issue being closed to avoid confusion
[Slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1693321920087959 )
### How?
Compare the rendered issue templates:
- Before: https://github.com/vercel/next.js/issues/new?assignees=&labels=template%3A+bug&projects=&template=1.bug_report.yml
- After: https://github.com/balazsorban44/next.js/issues/new?assignees=&labels=template%3A+bug&projects=&template=1.bug_report.yml
- Autoclosing still works: https://github.com/balazsorban44/next.js/issues/52
2023-09-01 17:37:17 +00:00
JJ Kasper
