Files
software-mansion__argent/packages/tool-server/test/simulator-watcher-init-failure.test.ts
Ignacy Łątka 43d5b9d464 fix(native-devtools): let only a verdict that was reached be repeated
`indeterminate` turned terminal on `wasAdvisedToRelaunch` alone, which is a pid
change since the hand-out and nothing more — already true one `connecting`
reading after the relaunch. One unreadable `ps` in that window answered
`injection_failed` for an app two seconds into a healthy cold start, asserting an
earlier reading that measured a fresh process which never connected when the
earlier reading had said "wait a few seconds".

The verdict is now recorded when it is handed out, and `indeterminate` repeats
that record rather than inferring one. Both terminal readings share the endpoint
withdrawal too: losing the socket makes the premise a statement about the socket
for the unreadable reading exactly as for the measured one.

describe stops pairing `should_restart: true` — rendered to an agent as "call
restart-app and retry" — with a message that says no restart on either side
changes anything, and the six feature tools' `service_stale` clause gains the
caveat its `native-devtools-status` twin already carries, now that the status can
arrive with the endpoint-lost message.
2026-09-08 11:52:07 +02:00

255 lines
7.8 KiB
TypeScript

import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
const execFileMock = vi.fn();
vi.mock("node:child_process", async () => {
const actual = await vi.importActual<typeof import("node:child_process")>("node:child_process");
return {
...actual,
execFile: (
cmd: string,
args: readonly string[],
opts: unknown,
cb?: (err: Error | null, out: { stdout: string; stderr: string }) => void
) => {
const callback = typeof opts === "function" ? opts : cb!;
const result = execFileMock(cmd, args);
if (result instanceof Error) {
const e = result as Error & { stderr?: string; stdout?: string };
callback(e, { stdout: e.stdout ?? "", stderr: e.stderr ?? "" });
} else {
callback(null, result ?? { stdout: "", stderr: "" });
}
},
};
});
import type { Registry } from "@argent/registry";
import {
MAX_NATIVE_DEVTOOLS_INIT_ATTEMPTS,
type NativeDevtoolsApi,
type NativeDevtoolsInitFailure,
} from "../src/blueprints/native-devtools";
import { startSimulatorWatcher } from "../src/utils/simulator-watcher";
const UDID = "11111111-1111-1111-1111-111111111111";
function bootedListResponse(udids: string[]): { stdout: string; stderr: string } {
return {
stdout: JSON.stringify({
devices: {
"com.apple.CoreSimulator.SimRuntime.iOS-17-0": udids.map((udid) => ({
udid,
state: "Booted",
})),
},
}),
stderr: "",
};
}
function makeFailingApi(): { api: NativeDevtoolsApi; ensureCalls: () => number } {
let initFailure: NativeDevtoolsInitFailure | null = null;
let calls = 0;
const relaunchAdvised = new Set<string>();
const terminalVerdict = new Set<string>();
const api: NativeDevtoolsApi = {
isEnvSetup: () => false,
socketPath: "/tmp/mock.sock",
ensureEnvReady: async () => {
calls += 1;
if (initFailure?.givenUp) return;
const attempts = (initFailure?.attempts ?? 0) + 1;
initFailure = {
attempts,
lastError: "stub ensureEnv failure",
givenUp: attempts >= MAX_NATIVE_DEVTOOLS_INIT_ATTEMPTS,
};
throw new Error("stub ensureEnv failure");
},
reverifyEnv: async () => {},
armsEnv: true,
withdrawEnv: async () => {},
getInitFailure: () => initFailure,
isConnected: () => false,
isAppRunning: async () => false,
listConnectedBundleIds: () => [],
holdsEndpoint: () => true,
noteRelaunchAdvice: (bundleId: string) => {
relaunchAdvised.add(bundleId);
},
wasAdvisedToRelaunch: (bundleId: string) => relaunchAdvised.has(bundleId),
noteTerminalVerdict: (bundleId: string) => {
terminalVerdict.add(bundleId);
},
verdictStands: (bundleId: string) => terminalVerdict.has(bundleId),
appConnectionState: async () => "stale_process",
activateNetworkInspection: () => {},
getNetworkLog: () => [],
clearNetworkLog: () => {},
getAppState: async () => {
throw new Error("not implemented");
},
detectFrontmostBundleId: async () => null,
queryViewHierarchy: async () => ({}),
};
return { api, ensureCalls: () => calls };
}
function makeRegistry(api: NativeDevtoolsApi): {
registry: Registry;
resolveService: ReturnType<typeof vi.fn>;
disposeService: ReturnType<typeof vi.fn>;
} {
// Mimic the registry: factory runs once, subsequent resolveService calls
// return the cached api. Attempt counts only go up when the watcher itself
// calls api.ensureEnvReady().
let factoryRan = false;
const resolveService = vi.fn(async () => {
if (!factoryRan) {
factoryRan = true;
await api.ensureEnvReady().catch(() => {});
}
return api;
});
const disposeService = vi.fn(async () => {
factoryRan = false;
});
return {
registry: { resolveService, disposeService } as unknown as Registry,
resolveService,
disposeService,
};
}
beforeEach(() => {
execFileMock.mockReset();
vi.spyOn(process.stderr, "write").mockImplementation(() => true);
});
afterEach(() => {
vi.restoreAllMocks();
});
describe("simulator-watcher with api-owned init failure state", () => {
it("stops calling ensureEnvReady after the api reports givenUp", async () => {
const bootedUdids: string[] = [UDID];
execFileMock.mockImplementation((cmd: string) => {
if (cmd === "xcrun") return bootedListResponse(bootedUdids);
return { stdout: "", stderr: "" };
});
const { api, ensureCalls } = makeFailingApi();
const { registry } = makeRegistry(api);
vi.useFakeTimers();
try {
const { ready, stop } = startSimulatorWatcher(registry);
await ready;
while ((api.getInitFailure()?.attempts ?? 0) < MAX_NATIVE_DEVTOOLS_INIT_ATTEMPTS) {
await vi.advanceTimersByTimeAsync(10_000);
}
const failure = api.getInitFailure();
expect(failure?.attempts).toBe(MAX_NATIVE_DEVTOOLS_INIT_ATTEMPTS);
expect(failure?.givenUp).toBe(true);
const callsAtCap = ensureCalls();
await vi.advanceTimersByTimeAsync(10_000);
await vi.advanceTimersByTimeAsync(10_000);
expect(ensureCalls()).toBe(callsAtCap);
stop();
} finally {
vi.useRealTimers();
}
});
it("makes no further ensureEnvReady calls for a healthy UDID after init", async () => {
const bootedUdids: string[] = [UDID];
execFileMock.mockImplementation((cmd: string) => {
if (cmd === "xcrun") return bootedListResponse(bootedUdids);
return { stdout: "", stderr: "" };
});
let calls = 0;
const relaunchAdvised = new Set<string>();
const terminalVerdict = new Set<string>();
const api: NativeDevtoolsApi = {
isEnvSetup: () => true,
socketPath: "/tmp/mock.sock",
ensureEnvReady: async () => {
calls += 1;
},
reverifyEnv: async () => {},
armsEnv: true,
withdrawEnv: async () => {},
getInitFailure: () => null,
isConnected: () => false,
isAppRunning: async () => false,
listConnectedBundleIds: () => [],
holdsEndpoint: () => true,
noteRelaunchAdvice: (bundleId: string) => {
relaunchAdvised.add(bundleId);
},
wasAdvisedToRelaunch: (bundleId: string) => relaunchAdvised.has(bundleId),
noteTerminalVerdict: (bundleId: string) => {
terminalVerdict.add(bundleId);
},
verdictStands: (bundleId: string) => terminalVerdict.has(bundleId),
appConnectionState: async () => "stale_process",
activateNetworkInspection: () => {},
getNetworkLog: () => [],
clearNetworkLog: () => {},
getAppState: async () => {
throw new Error("not implemented");
},
detectFrontmostBundleId: async () => null,
queryViewHierarchy: async () => ({}),
};
const { registry } = makeRegistry(api);
vi.useFakeTimers();
try {
const { ready, stop } = startSimulatorWatcher(registry);
await ready;
const callsAfterInit = calls;
await vi.advanceTimersByTimeAsync(10_000);
await vi.advanceTimersByTimeAsync(10_000);
expect(calls).toBe(callsAfterInit);
stop();
} finally {
vi.useRealTimers();
}
});
it("disposes the service when the UDID leaves the booted set", async () => {
let bootedUdids: string[] = [UDID];
execFileMock.mockImplementation((cmd: string) => {
if (cmd === "xcrun") return bootedListResponse(bootedUdids);
return { stdout: "", stderr: "" };
});
const { api } = makeFailingApi();
const { registry, disposeService } = makeRegistry(api);
vi.useFakeTimers();
try {
const { ready, stop } = startSimulatorWatcher(registry);
await ready;
expect(disposeService).not.toHaveBeenCalled();
bootedUdids = [];
await vi.advanceTimersByTimeAsync(10_000);
expect(disposeService).toHaveBeenCalledWith(`NativeDevtools:${UDID}`);
stop();
} finally {
vi.useRealTimers();
}
});
});