Files
software-mansion__argent/packages/tool-server/test/android-profiler-external-device.test.ts
Mateusz Aliyev 6e9e45c9f0 feat: attach to devices offered by external providers (#735)
This pull request lets Argent drive a simulator or emulator another
process is already running, attaching to its simulator-server rather
than spawning a second one.

A provider writes a JSON descriptor to `~/.argent/providers/` listing
the devices it offers and the mechanisms Argent may use on each. They
appear in `list-devices` with an `ext:` id and work with the existing
tools. The file is re-read on every call, so a withdrawal or a narrowed
grant applies immediately.

`ios.additionalDeviceSets` (#600) already makes such a simulator
reachable by UDID. What changes is ownership. `boot-device` and
`stop-simulator-server` refuse these devices, anything the provider did
not grant is refused with a message naming it and Argent uses only the
endpoints its own simulator-server build serves. A grant binds to the
device rather than to one of its names, so the real udid or serial is
gated exactly like the `ext:` id. Android emulators are covered too and
a device visible to both a provider and `adb`/`simctl` is listed once.

The contract ships as `schemas/device-provider-v1.json`, validated by
`argent providers check`, and is documented in
`docs/reference/device-providers.mdx`. Includes unit tests and an e2e
phase where the harness acts as its own provider.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added support for discovering and connecting to externally managed
devices.
* Added `argent providers` commands for listing, validating, publishing,
withdrawing, and pruning providers.
* Added provider-aware simulator, debugger, profiler, native tools, and
device listings.
* Added capability controls, endpoint validation, revocation handling,
and provider-specific diagnostics.
  * Added automatic CLI discovery for provider integrations.
* **Bug Fixes**
  * Improved service recovery and paused-runtime error reporting.
  * Improved simulator keyboard and paste command reliability.
* **Documentation**
* Documented provider descriptors, capabilities, lifecycle rules, and
CLI usage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-04 22:02:57 +02:00

163 lines
4.6 KiB
TypeScript

import { describe, it, expect, afterEach, beforeEach, vi } from "vitest";
import * as fs from "node:fs";
import * as os from "node:os";
import * as path from "node:path";
import { startPerfetto } from "../src/utils/android-profiler/capture";
import { makeExternalId } from "../src/utils/external-devices";
/**
* Perfetto is the one `adb` caller that spawns for itself: the trace config
* goes in on stdin and the daemon's PID comes back on stdout, which `runAdb`
* (whose contract is "run to completion, give me the output") cannot express.
* So it is also the one place `adb` can be handed a serial `runAdb` never
* substituted.
*
* The substitution also enforces the `adb` grant, so the external cases here
* publish a real descriptor.
*/
/** Every `adb` the capture spawns, so its argv can be asserted on. */
const rec = vi.hoisted(() => ({ spawned: [] as { file: string; args: string[] }[] }));
/**
* An `adb shell perfetto --background-wait` that prints a PID and exits, which
* is all `startPerfetto` waits for.
*/
const fakeAdb = vi.hoisted(() => () => {
const stdoutListeners: ((chunk: Buffer) => void)[] = [];
/**
* `startPerfetto` subscribes twice (once to accumulate the output, once to
* parse it), so the PID goes out after both have registered rather than on
* each subscription. `error` and `exit` stay unwired, reaching them would
* mean the start failed.
*/
setImmediate(() => {
for (const listener of stdoutListeners) listener(Buffer.from("4242\n"));
});
return {
kill: () => true,
on: () => {},
once: () => {},
stderr: { on: () => {} },
stdin: { end: () => {}, on: () => {}, write: () => true },
stdout: {
on: (_event: string, listener: (chunk: Buffer) => void) => {
stdoutListeners.push(listener);
},
},
};
});
vi.mock("child_process", () => ({
execFile: (
_file: string,
_args: string[],
_options: unknown,
callback: (err: Error | null, result: { stdout: string; stderr: string }) => void
) => {
callback(null, { stderr: "", stdout: "" });
},
spawn: (file: string, args: string[]) => {
rec.spawned.push({ args, file });
return fakeAdb();
},
}));
vi.mock("../src/utils/android-binary", () => ({
resolveAndroidBinary: async () => "adb",
__resetAndroidBinaryCacheForTesting: () => {},
}));
const SERIAL = "emulator-5554";
const DEVICE_ID = makeExternalId("acme-3f2a9c", SERIAL);
let temporaryDirectory: string;
function publishDescriptor(capabilities: string[]): void {
const descriptorPath = path.join(temporaryDirectory, "acme.json");
fs.writeFileSync(
descriptorPath,
JSON.stringify({
devices: [
{
capabilities,
kind: "emulator",
name: "Pixel 8",
nativeId: SERIAL,
platform: "android",
state: "device",
},
],
id: "acme-3f2a9c",
name: "Acme IDE",
schemaVersion: 1,
})
);
process.env.ARGENT_DEVICE_PROVIDERS = descriptorPath;
delete process.env.ARGENT_DISABLE_DEVICE_PROVIDERS;
}
beforeEach(() => {
rec.spawned.length = 0;
temporaryDirectory = fs.mkdtempSync(path.join(os.tmpdir(), "argent-perfetto-"));
});
afterEach(() => {
delete process.env.ARGENT_DEVICE_PROVIDERS;
process.env.ARGENT_DISABLE_DEVICE_PROVIDERS = "1";
fs.rmSync(temporaryDirectory, { recursive: true, force: true });
});
describe("perfetto on a provider's emulator", () => {
it("targets the serial adb knows, not the argent-side id", async () => {
publishDescriptor(["adb", "native-profiler"]);
const { pid } = await startPerfetto({
appPackage: "com.example.app",
serial: DEVICE_ID,
timestamp: "20260804-120000",
});
expect(pid).toBe(4242);
const [adb] = rec.spawned;
expect(adb.file).toBe("adb");
expect(adb.args[adb.args.indexOf("-s") + 1]).toBe(SERIAL);
expect(adb.args.filter((argument) => argument.includes("ext:"))).toEqual([]);
});
/**
* Withholding `adb` blocks the capture, whatever other grants the device
* carries.
*/
it("refuses to start when the provider withheld adb", async () => {
publishDescriptor(["native-profiler"]);
await expect(
startPerfetto({
appPackage: "com.example.app",
serial: DEVICE_ID,
timestamp: "20260804-120000",
})
).rejects.toThrow(/'adb' capability/);
expect(rec.spawned).toEqual([]);
});
it("leaves a plain serial exactly as it was given", async () => {
await startPerfetto({
appPackage: "com.example.app",
serial: SERIAL,
timestamp: "20260804-120000",
});
const [adb] = rec.spawned;
expect(adb.args[adb.args.indexOf("-s") + 1]).toBe(SERIAL);
});
});