`flow-yaml.md` ended its three-TV-family paragraph with "Delete an existing value
with repeated backspaces, or use the field's own clear affordance". The `keyboard`
tool rejects `key` outright on a TV target, so repeated backspaces are available
on Vega alone; on Apple TV and Android TV the field's own affordance is the only
way. Both halves were offered to all three families.
The clear-only parse test justified itself with "empty the box, then assert the
empty state", but there is no such assert: `equals: ""` and `contains: ""` are
rejected at parse time and `matches: '^$'` never fires, because absent or empty
text is not a haystack — as `references/asserting-field-values.md` already says in
words. The comment now names the reasons a clear-only step is legitimate on its
own, and points at that reference for what can actually be asserted afterwards.
The post-dispatch abort re-check sits before the submit gate, so nothing stood
between the Enter dispatch and `return { ok: true }`. `dispatchOrAbort`
reclassifies only a dispatch that REJECTS under an aborted signal, and the
Android backend takes no signal at all, so a cancel landing mid-Enter left the
call to resolve and handed back `true`. The same cancellation window therefore
flipped a step between `pass` and `skip` on which of its two keyboard calls
happened to be in flight — and the `pass` arm is the one where the submit really
was sent after the caller gave up, which is what the re-check above exists to
prevent.
Driven through the real runner with a signal-less keyboard mock: `{ text }` with
`submit` defaulting on reported `type:pass` with both dispatches issued, and
reports `type:skip` now. An explicit `submit: true` clear-only step, where the
Enter is likewise the last dispatch, is pinned alongside it.
Also corrects two claims the same block makes:
- the backends that take no signal. Chromium now honours one, so Android is the
only one that takes none — and the two that DO only narrow the window rather
than close it, since each checks between keystrokes.
- the `runType` parenthetical's premise. `scrollIncrement` is not "one call per
step": a `scroll-to` calls it up to MAX_SCROLL_ITERATIONS times through
`scrollToVisible`, which guards the signal at the head of every iteration
itself — so the dispatch is safe to leave bare, but not for the stated reason.
`dispatchOrAbort` reclassifies only a dispatch that REJECTS while the
signal is aborted, and the Android and Chromium keyboard backends take
no signal at all — so a cancel landing mid-call leaves the call to
resolve and returns `true`. The re-check that catches that lived inside
the `if (step.submit ?? step.text !== undefined)` block, which is false
for a clear-only step, so the two shapes diverged: cancel a run during a
`{ into, clear: true }` step's one dispatch and it reported `pass`, while
the identical cancellation on a step with text reported `skip`.
The check moves out of the submit gate. The submitting path is unchanged
— it still runs before the Enter dispatch — and the clear-only path
gains it.
`flow-abort.test.ts` grows the twin of its existing clear-only case: the
existing one mocks the keyboard to throw, which `if (!sent)` already
caught; this one resolves inside the cancelled window, and asserts the
clear DID go out so it cannot pass by the step never reaching the
keyboard. It fails with `type:pass` before this change.
Two review findings on the same file that are documentation, not
behaviour:
- The `FocusOutcome` docblock named the FOCUS_REPORTING_SOURCES guard as
a producer of "unobservable". No flow can reach it: `type` runs only on
ios, android and chromium, and each hard-codes a source already in the
set. It is kept as a forward guard — a new platform would otherwise
poll the full timeout on every type step — and the docblock now says
which of the two producers is live.
- `focusedFromInside`'s containment conjunct was pinned by nothing: every
fixture pairing an out-of-target focused node with a small enough frame
is refused by the namesake counts first, so dropping `frameWithin`
reddened no test. The new fixture puts a same-`resource-id` sibling
outside the container's box, where both counts hold and containment is
the only thing left to refuse on — the ordinary Android shape, since a
resource-id names the layout slot. Verified by mutation: dropping the
conjunct now fails that test and only that test.
Three corrections, all from the same cause: `keyboard` rejects `text`
and `key` in one call, so a recorded type-then-submit is ALWAYS two
steps and the polish rules have to read them as a pair.
`live-authoring.md`'s two carry-across rules contradicted each other on
exactly that shape. "Carry a recorded `key: "enter"` across as
`submit: true`" covers the Enter step; "a recorded step with `text` but
no `key` needs `submit: false`" covers the text step — and always will,
since no recorded text step can carry a key. Following both produced
`submit: false` for a recording that did submit, so the cleaned login
flow never fired the form; following only the first and leaving the raw
Enter step in place submitted twice. The rules are now one table over
the whole run of `keyboard` steps on a field, which is the unit the
conversion actually operates on, with the two failure modes named under
it. The conversion table further down defers to it rather than giving a
second, shorter answer.
`keyboard`'s `clear` parameter said a swallowed select-all leaves the
field "one character shorter … and a combined `text` then appends to
that". Per the caret rule in the same sentence, that holds on iOS only:
on Android the surviving delete acts as a backspace at the caret the tap
left mid-value, and the text is spliced there. `flow-yaml.md` already
documented the splice per platform, so the two disagreed on Android.
`asserting-field-values.md` did not mention that Chromium truncates
every accessible name at 200 characters — Chromium alone. An `equals`
against a longer value cannot match, and a long pre-filled field is one
of the shapes `clear` exists for.
New coverage for each fix, every one of them mutation-checked (revert the fix,
the named test goes red):
- an editing host holding identified or password content beside the named
paragraph refuses, while the bare `<div contenteditable><p>…</p></div>`
still clears;
- the tapped element unmounting while a namesake holds focus refuses, and
the same page with it mounted still clears;
- the three ways a focused node borrowed another element's evidence — a
namesake the tap creates, a container that grows onto a field the tap never
reached, a focused field that renames itself out of the namesake set — plus
the control that keeps the name;
- a slow-but-answering tree source is not reported as an outage;
- the chromium walker keeps an invisible element that holds the caret (and
one that contains it), still prunes when the caret is elsewhere, never
resurrects a display:none subtree, and keeps a box-less focused node.
And the gaps the sweep listed:
- no test parsed a non-object `type` body, so the message could name one of
the two valid shapes and stay green;
- no test covered a non-abort `gesture-tap` rejection in `runType`;
- nothing bounded the focus window from ABOVE;
- the skill docs' `clear` YAML examples were outside the parse guard's slice;
- `carriesFocus`'s recursion fixture put the flag at depth 0, where a
non-recursive check reads the same — give the shadow wrapper an id;
- four weak assertions: `toBeDefined()` on a `findById` that returns null,
an `?.identifier` that reads undefined when nothing resolved, a `toBe`
between two strings that pass as `"" === ""`, and a flat-leaf invariant
omitting `focused`, which is now producible.
Also drops the wall-clock half of the early-exit test: `elapsed < 3000` timed
the whole step — temp dir, device resolution, the settle, two keyboard
dispatches — so it measured the host and failed at 3066ms and 3388ms under
load, while the read count beside it pins the exit exactly at any speed.
- `live-authoring.md`'s Replay section said a `type:` whose focus was never
confirmed is scored a pass. True of a plain `type`; a `clear` fails.
- `flow-yaml.md` said the clear dispatches on three findings and no others.
There is a fourth — the window where no read saw focus — which the same
paragraph goes on to describe.
- The residual behind that fourth is materially bigger than "nothing was
focused, so nothing can be lost", in both `flow-yaml.md` and `runType`'s
comment. An audit of the prunes in the adapters gives at least four more
shapes: an off-screen or scroll-clipped frame, iOS's `hidden`/`alpha` prune,
Android's system-UI prune (the notification direct-reply field, the
bouncer), and a truncated tree on any source. Each is a field the step never
named, and the step reports a pass.
- `dispatchOrAbort`'s docblock said android and chromium check the signal
between keypresses like iOS. They check once, at their per-device queue, and
neither `runAndroidPhoneType` nor `runChromium` takes a signal — cancel a run
mid-`type` there and the whole text is still typed.
- The same block said `gesture-tap`'s platform handlers discard the context.
It has no platform handlers, and `execute` declares no context parameter.
- `waitForFrameAndTree` said its stale-tree window opens only when a read fails
outright; `settleTree` also returns best-effort when every read succeeded and
no two matched.
- `describe/contract.ts` said platforms other than Vega leave `focused` unset.
All three set it, and the flow focus wait reads nothing else.
- `flow-run.ts`'s description never said a `clear` can hard-fail the step, and
mentioned `submit` only for the clear-only default.
- `flow-finish-recording.ts` described `type.submit` in the one direction that
no longer matters.
- `reliability-and-recovery.md` prescribed "assert the committed value" with no
pointer to the reference that says when it hard-fails.
- `argent-qa-flows` never mentioned `clear`, though running the same YAML twice
with no manual data reset is exactly what it is for.
- `focusedFromInside`'s trailing `underTap.every(...)` is unreachable as false
once the `controls` rule holds, so drop it and state why it is implied.
- A `type:` step with no `into` rendered its entry as the bare word `undefined`,
which in a multi-step flow does not say which step is broken. Catch it in the
type arm and echo the step, the way the `claer` typo path already does.
- The two clear refusals blamed an overlay or a sibling for what is routinely a
field OVERHANGING the container the selector names — default content-box
sizing does it for a few pixels, and neither message admitted the
possibility. Reproduced and re-read on Chrome 151.
- `chromium.ts` claimed the focus flag reaches every describe consumer:
`hasContent` does not list `focused`, so a node whose only signal is focus is
dropped from the agent-facing render. Verified — an anonymous empty focused
contenteditable is absent, the same editor holding a `<p>` is shown.
- It also claimed focus inside an iframe leaves the tree with no flag at all.
True in the light DOM; inside an OPEN shadow root the HOST is flagged, since
the excluded iframe is the root's activeElement. Verified both ways.
- The zero-frame sibling drop now consults `focusedSelf` like the two
structural collapses beside it — same class of drop, same consequence.
Every focus poll is given whatever is left of the window as its read budget, so
a read started too late is abandoned mid-flight — and `giveUp` books that
abandonment as darkness. The step then failed telling the author "the device's
tree source is down" while every read in the window had answered, and because
crossing FOCUS_DARK_TAIL_TOLERANCE_MS depends on how the read time divides into
the 3000ms window, the verdict was not monotonic in latency.
Reproduced on Chrome 151 against the branch tool-server, on a page whose focus
the tree cannot report and whose reads were slowed uniformly: 0ms and 150ms
passed, 250ms failed as an outage, 300ms and 400ms passed again. No read failed
in any run. Android's `getHierarchy` sits in that band — 2.85s / 0.29s / 0.46s
/ 0.30s across four consecutive idle describes on this host — which is what
turns it into a flaky step rather than a consistently wrong one.
A read the window cannot afford is no longer started, measured against what the
last successful read on this device cost. The same band now passes at every
latency, 250ms three times over, while a source whose read never completes
inside the window is still reported as an outage.
The walker prunes an invisible subtree before focus is ever considered, so the
field that is invisible BY DESIGN — the capture input under rendered OTP/PIN
boxes, a barcode-scanner sink, a styled file input — left the tree with no
focus flag anywhere. The type directive's focus wait reads that as "nothing is
focused", which is the one non-confirmed outcome it dispatches a destructive
clear on, and the field the caret is in is very often the one holding the
secret.
Reproduced on Chrome 151 against the branch tool-server: rendered OTP boxes
over an opacity:0 capture input holding `SECRET-OTP-123456`, a step naming the
visible box — tree focus flags NONE, step pass, secret rewritten. The identical
page at opacity:1 refused. It now refuses at both, with the secret intact.
opacity:0 does not stop an element being focused, so the prune now asks whether
the element is (or contains) the caret's element first. With nothing focused,
opacity:0 and display:none subtrees are pruned exactly as before.
`focusedFromInside` joins its two halves by name — the focused node comes from
the current tree and the current container box, the evidence about it from the
pre-tap tree and the pre-tap box — and only the pre-tap side was checked for
ambiguity. A focused node could therefore borrow the evidence collected for a
different element. Three ways in, all reproduced on Chrome 151 against the
branch tool-server:
- a namesake the TAP CREATES: a wrapper that appends a second `row_input` on
focus and focuses it passed, and rewrote the field the step never named;
- a container that GROWS: a 44px row growing to 140px on focus swallowed a
field that was never a tap candidate, and cleared it;
- a focused field that RENAMES ITSELF out of the namesake set (a currency
input dropping its separators), leaving the sibling under the tap as the
unique pre-tap match — the amount-row mis-target the docs say is refused.
All three leave two namesakes inside the container in the current tree, so
deciding on that too refuses all three, with nothing emptied. The controls that
remove the growth, the late namesake or the rename still refuse, and the
legitimate wrapper clears still pass — a testID box over one input, both with
the tap centre on the input and with it on a tall label.
`trackTarget`'s last resort re-runs the SELECTOR, so what it hands back has no
relation to the element the step touched — while `waitForFocus`'s identity arm
trusts it absolutely, ahead of the two arms that check a node against
`tapCandidates`. When the tapped element stops being findable and a different
element answering the same selector holds focus, that element was confirmed
and cleared.
Reproduced on Chrome 151 against the branch tool-server: `aria-label="Email"`
removed on `mousedown`, `aria-label="Email address"` focused beside it — the
step passed and `DRAFT-DO-NOT-ERASE` became `replaced-by-clear`. It now
refuses and the draft survives.
The fallback exists for a re-render that renames a node carrying no
identifier, and a re-render happens in place: an anonymous field that swaps its
`aria-label` on focus is still followed and still cleared, verified on the same
page.
`focusedOwnsTargetText` confirmed a clear whenever the focused node's hoisted
text equalled the target's. The hoist is not a full account of what the node
holds: an identified descendant — or a password field — shields its own text
out of every ancestor's `subtreeText`, so a composer holding the named
paragraph PLUS any amount of identified content compared equal and took the
clear, which is a select-all over the whole editing host.
Reproduced on Chrome 151 against the branch tool-server: an editor holding
`<p>Draft body paragraph</p>` beside `<div id="signature">` passed, wiped the
editor to the replacement and destroyed the signature; `data-testid` and an
`<input type=password>` did the same. Making the sibling anonymous refused,
which is the shield being the only discriminator.
Count the content from the flat tree instead, where the shielded node is still
its own leaf. Same three pages now: identified, testid and password siblings
all refuse and leave the editor intact, while the bare
`<div contenteditable><p>…</p></div>` the guard exists for still passes.
Each of these was verified by mutation: apply the pre-fix code, the named test
goes red; revert, green. Thirteen mutations, thirteen killed.
New coverage for the fixes:
- a focus read that HANGS past the window rather than throwing (H1), asserting
both the outage refusal and that the step answered while the read was still
outstanding - the bound is what keeps "within 3000ms" true;
- a container with a GAP down the middle, once with two controls and once with
one (H3), so what decides is the number of controls and not the gap;
- a focused wrapper around one anonymous FIELD (M3), the editing host's twin;
- `type: { clear: true }` with no `into` as a validation failure, not a crash (L1);
- a replaced getRootNode still reporting focus (L3), and a page describing in
full with ShadowRoot set to a non-constructor (L5).
And the gaps the review named:
- T1 the enclosing-pad sweep now starts at 1px, where the defect lived;
- T4 an UNIDENTIFIED field's draft hoisting into its container's text and
out-ranking a real control for a tap - the three tests beside it all give
their field a placeholder or an id, so they pinned the shielded case while
reading as proof of the general property;
- T5 the new asserting-field-values reference gets a parser guard: `equals: ""`
and `contains: ""` really are rejected, `matches: "^$"` really does parse;
- T6/T7 the ambiguity fixtures now exercise the gates they name. The anonymous
row put focus on the field the tap MISSED, which later gates refuse on their
own, so both arms passed with the ambiguity gate deleted; it now differs in
the colliding name alone, and the same-id re-layout gets the tree order where
"first match wins" would hand back the focused row.
L1 - `type: { clear: true }` with no `into` crashed with "Cannot read
properties of undefined" instead of failing validation: JSON.stringify returns
undefined for undefined, and badEntry read .length off it. The crash predates
the branch, but `clear` in the allowlist is a new door onto it - at the merge
base the same flow failed cleanly as an unknown key. Both `clear` and `text`
forms now return FLOW_ENTRY_UNRECOGNIZED naming `type.into`.
L3 - a page that REPLACES Element.prototype.getRootNode (ShadyDOM,
webcomponents.js) hands back an object that is neither a ShadowRoot nor the
document, and the focus read answered null for it: verified on Chrome 151, the
flag vanished from every node on the page, which is the no-focus tree a
destructive clear goes through on. It falls back to the document's
activeElement - the read this had at the merge base. Focus survives the
replacement now, and an open shadow root still flags the inner element only.
L4 - the iframe descent is dead in a renderer (walk() bails on an inner
documentElement, whose constructor belongs to the inner realm), so it is gone
along with the file header's claim to walk subdocuments. Verified before and
after: an <iframe srcdoc> leaves no trace either way. Its only test passed
because the harness is single-realm, so it went too (T8).
L5 - `typeof ShadowRoot === "undefined"` does not cover a page assigning a
non-constructor. With window.ShadowRoot = null, ShadowRoot.prototype threw
before a single node was walked and describe failed for the whole page
(reproduced). Both that read and the instanceof test now require a function.
L6, L7, L8 - three comments corrected against what the code does: preTapTree is
the last read that SUCCEEDED and can predate the tap by a failed read's whole
timeout; the plain-type early exit deliberately does not fire on a tree that
flags focus nowhere, so that shape still pays the full wait; and no flow report
is written to disk - the reason travels to stdout and the agent's context,
which is reason enough to name no element text.
focusedOwnsTargetText asked only that the focused node carry no text of its own
and that the target's text be all it shows. A focused non-editable wrapper
around ONE unidentified field satisfies that exactly: the field's value is its
accessible name, an anonymous field does not shield, so the value hoists into
the wrapper and the wrapper has no text of its own either. The docblock's
android.webkit.WebView argument only rules out a WebView carrying a whole form;
one wrapping a single field - hosted payment fields are one input per iframe -
went through.
Reproduced on Chrome 151: a <div tabindex=0> focus-trapped around an
unidentified <input value="hello-target"> CONFIRMED the gate, and only the
keyboard tool's "the focused element DIV#wrap is not a text field" stopped the
clear. iOS and Android dispatch a clear at whatever holds focus, so nothing
catches it there.
The discriminator the trees do carry is that an editing host's content is
static: a paragraph or a text node, never a control. The trapped wrapper now
refuses in the flow itself, with the message that already exists, while a
contenteditable holding <p>hello-target</p> still clears and is rewritten -
both verified live. Where a source reports no controls at all (iOS never sets
clickable) the residual stands, and the docblock now says so.
live-authoring said a clear "fails on an unconfirmed poll", which reads as every
poll that never confirmed focus. runType refuses on three of them and dispatches
on the fourth: a window in which every read succeeded and none reported focus
anywhere - the deliberate iOS-without-firstResponder path flow-yaml.md states
correctly, so the skill contradicted itself.
Confirmed live on Chromium: a page whose tap is preventDefault'ed and whose
caret never moves leaves the focus wait with nothing to see, and the step
dispatched the clear - only the keyboard tool's own "no editable element has
focus" stopped it.
The new asserting-field-values reference told authors that a field's contents
never hoist into a container, so a container text assert reads the page and not
the draft in the box. That holds only for a field carrying an id/testID - the
id is what shields. An unlabelled field with no id puts its contents in the
node's accessible name, and the name hoists.
Measured on Chrome 151 through flow-execute, against unidentified <textarea>s:
`text: { in: <chat>, contains: "unsent draft" }` PASSED with the message list
empty, and `tap: { on: { text: "Save" } }` focused a note holding the word
"Save" instead of the Save button. Adding an id to the composer flips the same
assert to a fail. An author following the old sentence writes a clear-proof
that passes on the value it exists to catch.
The walker's own comment made the same claim for the three harms it lists.
Only the hoist depends on the identifier; a selector match and the resolver's
exact-field ranking read the label directly, so an unidentified field leaks
through all three whatever the walker does.
The inert-chrome arm asked whether anything under the tap point was a control.
underTap holds only what COVERS that point, so any gap between two children - a
flex gap, space-between, a margin, a divider the adapter does not emit - leaves
the container's centre covering nothing and the every() passes vacuously. The
clear then landed on whichever sibling already held focus, chosen by layout
arithmetic rather than by the gesture.
Reproduced on Chrome 151 through flow-execute: a row of two inputs with a 30px
gap, its centre falling between them and the LEFT one focused before the step,
passed and rewrote that left input while the report named only the row. Closing
the gap sends the same clear to the input under the tap, which is correct.
So the arm now requires what its own commit title and references/flow-yaml.md
already promised: exactly one control inside the container, and that control is
the one reporting focus. The target itself is excluded from the count, which is
what the comment claimed and the old sentinel did not do - a clickable
container satisfied it on its own.
Verified live: the gapped row refuses with both fields intact, the ungapped row
still clears the input the tap hit, and a tall label holding a container's
centre over its one input still passes.
frameNoLargerThan carried the same per-dimension slack frameWithin applies per
edge, so a focused node padded symmetrically around the target by half the
threshold satisfied both and took the clear. On a 900px window that is a trap
one pixel larger on every edge: reproduced on Chrome 151, where a focusin trap
holding DRAFT-do-not-erase over an <input> passed the step, was emptied and
rewritten with the new address, and left the named input holding its old value.
There is no tolerance that fixes it. A trap enclosing the field by 1px and a
child overhanging its wrapper by 1px are the same geometry, and the flow trees
carry no ancestry to tell them apart - flattenHoisting returns leaves under one
root on every platform. So the size test is exact: equal frames still confirm
(the everyday wrapper-around-input shape, verified live), and any overhang
refuses, which fails the step loudly instead of emptying a field the step never
named.
The overhang sweep moves with the contract: pad 0 is now the admitting case and
1-3px refuse, where the 1-2px arm previously pinned the tolerance this defect
lived in.
A tree source goes down by hanging, not by throwing fast. The dark-tail guard
counted consecutive FAILED polls, and the counter can only reach two when the
failures come back cheaply: every transport's own timeout (15s android
getHierarchy, 10s per CDP call, 5s per ViewInspector RPC) outlasts the whole
3000ms focus window, so one hang ended the window with the counter at one. The
verdict fell through to "unobservable" - the one non-confirmed outcome runType
dispatches a destructive clear on.
Reproduced on Chrome 151 through flow-execute: a page that blocks its own main
thread for 12s from the focusing tap's mousedown took the step from a refusal
to a pass that emptied a field the step never named, and the step ran 13.9s
while its report claimed a 3000ms window. The same page blocking 200ms refused.
So the read is bounded by what is left of the window, the way waitForIdle
already bounds its own, and darkness is measured in elapsed milliseconds from
the moment the first unanswered read STARTED as well as in polls. The repro
now refuses with the outage message and finishes in 3.8s; the 200ms control is
unchanged and an ordinary clear still passes.
The two comments justifying a poll count with the cost of a `uiautomator dump`
went with it: the flow tree never uses uiautomator - fetchFlowTree routes
Android to the android-devtools getHierarchy RPC.
- `flow-yaml.md` described two confirm paths for the clear; there are three, and
it named none of the conditions the fixes in this PR added. It now states all
three — the element you named, the input the tap landed on (or the container's
only control, where the tap landed on its own chrome), and the editing host
whose whole content is what you named — plus the naming-is-not-identity
refusal, and the narrowed "nothing focused" residual: only a window in which
NO read saw focus still clears.
- `flow-actions.ts` named only Android and iOS as flattening to leaves, which
reads as exhaustive and implies Chromium keeps ancestry. It does not —
`flow-chromium-tree` runs the same `flattenHoisting` — and every reproduction
cited in that same docblock comes from Chrome, where the agent-facing
`describe` DOES print a nested tree, so a reader is invited to conclude the
sharper structural test was available there.
- Two comments in this PR gave opposite answers about the iframe descent, and
`chromium.ts`'s was the wrong one: it justified excluding a host <iframe> on
the grounds that the inner element carries the flag instead. The descent is
dead — `el instanceof Element` rejects the inner `documentElement`, whose
constructor belongs to the OUTER realm — so focus in a subdocument reaches the
tree from neither side. Verified on Chrome 151: an `<iframe srcdoc>` with a
unique marker leaves no trace in describe, and focusing an input inside it
leaves the tree with no focus flag anywhere. The exclusion is still right; its
stated reason was not available.
- "Android and Chromium splice at the caret, iOS appends" appeared in four
places with nothing behind it — no test, constant or recorded measurement, and
`grep -rn caret` over `src/` returns only prose. What is measurable is the
mechanism, and it is not per-platform: the caret lands where the focusing tap
put it, so a value long enough to reach the field's middle splices (measured
again here on Chrome 151 — forty `A`s typed with `ZZZ` came back
`AAA…ZZZ…AAA`) and a shorter one appends because the tap fell past its end.
All four sites now say that instead.
`asserting-field-values.md`'s two DOCS findings — the "always exposes its live
contents" claim and the undermined "assert the consequence instead" advice —
went with the textarea fix, which also removed the `equals`-vs-`contains` trap
the Chromium bullet gave no guidance for.
Every pin below was mutation-checked: the pre-fix code was restored in
`flow-actions.ts` / `chromium.ts` and each named test went red.
- `sameElement`'s LABEL fallback had no coverage, and it is the whole
name-is-not-an-identity defect. Every fixture in the runner file gives its
nodes a resource-id, so the anonymous path — the everyday React Native and
plain-DOM shape — never ran. `anonymousRowXml` runs it both ways: a namesake
and a differently named sibling.
- `trackTarget`'s proximity tie-break had none either. `twoSameIdRowsXml` is the
re-layout that made it adopt the wrong namesake.
- `focusedOwnsTargetText` needed the trap whose OWN text equals the target's;
the existing editor fixture only ever exercised the arm that should confirm.
- `requireEvidence`'s safety half was unpinned AND the test written for it did
not reach it: `overlayFocusXml` carries no `email-wrapper`, so every overlay
read was consumed by selector resolution before the tap went out and the focus
poll's first read already confirmed. `overlayOverWrapperXml` carries the
wrapper, so the clear really has to poll past an overlapping read.
- The textarea change had no coverage past the walker itself. Four cases now run
the real walker THROUGH the real flow adapter and matcher: the container
hoist, the page-wide `visible` check, the tap ranking, and the clear-only
proof that still has to work on an unlabelled composer — plus an
`<input>`-vs-`<textarea>` spelling case.
- `describe-chromium-script.test.ts` certified behaviour that cannot happen: it
asserted focus inside a same-origin iframe is carried by the inner element.
The walker never descends — `el instanceof Element` rejects the inner
`documentElement`, whose constructor belongs to the OUTER realm — and the mock
passed only because it is single-realm. Verified live on Chrome 151: an
`<iframe srcdoc>` with a unique marker leaves no trace in describe, and
focusing the inner input leaves the tree with NO focus flag at all. That is
the "unobservable" state a destructive clear dispatches on, so the test now
pins it as such.
- The refusal tests ran at ~75% of vitest's 5000ms default (measured
3757-3760ms) on the one file whose names would make a load-induced timeout
look like a real destructive-clear regression. They get their own testTimeout.
- A page that removes `Element.prototype.shadowRoot` took describe down
entirely. `protoGetter` falls back to a direct property read when the
descriptor is absent — this file's own documented threat model — so a `<form>`
holding `<input name="shadowRoot">` hands the CONTROL element to the new
ShadowRoot `activeElement` accessor, and Blink throws `Illegal invocation` for
the whole page. Verified live: `CHROMIUM_DESCRIBE_FAILED` for every element
until the descriptor was restored, and clean with the `isShadowRoot` guard the
same function already applies to `root` two lines down. The base could not
throw here — it only ever read `shadow.children`. The mock ShadowRoot's
accessor is brand-checked now, so a test can see this at all.
- A focused node whose frame EQUALS the target's was classified as "encloses".
`frameWithin`'s slack is per-edge, so identical frames satisfy it, and the
refusal then tells the author to point the selector at the input itself when
it already does. `frameNoLargerThan` — added by this PR for exactly this
distinction — is now consulted here as it is in `focusedOwnsTargetText`.
- The focus wait could overrun its stated budget by a whole tree read. The
deadline was checked only AFTER `fetchFlowTree`, while the sleep is capped to
land exactly on it, so one more read always started past it — 1-2s of a
`uiautomator dump` beyond the 3000ms every refusal message claims the window
was.
- The `FlowStep` union admitted a `type` step with neither `text` nor `clear`:
it serializes to YAML the parser rejects, labels itself `⇐ (clear only)` in a
recording summary, and dispatches no keyboard call at all — a silently passing
no-op. Pairing the two fields in the union keeps the parser the only thing
that can build one.
The remaining LOW findings need no change: a labelled `<textarea>`'s 200-char
truncation and its live contents feeding the settle fingerprint both went with
the textarea fix, which stops the contents becoming node text at all.
`accessibleName` whitespace-normalized a `<textarea>`'s value where the
`<input>` path deliberately did not, so the same typed text was assertable back
in one element type and not the other: `equals: " hello "` matched at the base
and stopped matching, and a two-line value came back spelled as one line while
the identical string in an `<input>` came back raw. Nothing warned an author
which spelling applied to which element.
The normalization was there because the walker also emitted the value as node
text, and two spellings of one value cannot both be quoted by a failing assert.
The contents now reach the tree as exactly one string, so that string is the one
the field holds. Verified live: an `equals` on `" hello "` passes against a
textarea and an input alike.
`tapCandidates` probes exactly one point — the container's geometric centre —
and a container is not laid out to put its input there. When the selector names
a wrapper (a testID container, the documented and supported shape) and the tap
on it legitimately moves focus to the input inside, the clear was refused unless
the input happened to sit under that one point. Nothing else failed: the tap
worked, the right element ended up focused, and the same step without `clear`
succeeded. The refusal then misdirected, blaming an overlay or a sibling row,
neither of which existed.
Measured on Chrome 151 against this branch's tool-server, sweeping only the
label's height on one page (the input is ~34px tall): 16/24/32px pass, 40/48/60px
fail. It flips exactly where the label grows taller than the input, i.e. where
the container's centre crosses out of it — so a two-line label, a label with
vertical padding, or a label plus helper text is enough. The React Native
`Pressable`-wrapping-a-`TextInput` shape does it with no label at all.
So when nothing under the tap point could have taken the keys itself, the app
routing focus to the container's one control is the honest consequence of the
gesture. A control under the point is the whole difference from the row this
gate refuses — there the tap DID reach something that takes focus. Verified live:
the 60px label and the RN wrapper both clear now, while the two-input row still
refuses whether its inputs share a name or not.
The relaxation needs positive evidence that the source reports controls at all:
the iOS full-hierarchy adapter never sets `clickable`, so "nothing under the
point is a control" would be a statement about the adapter there and would wave
every sibling through. Without that evidence this stays the refusal it is today.
`lastRead` is only ever written by a read that SUCCEEDED, so the "unreadable"
outcome fired only when EVERY read in the window threw. One successful poll
disarmed it permanently — including the first, which is the one most likely to
report "no focus yet", because the app's focus round-trip has not finished. That
maps to "unobservable", the one non-confirmed outcome `runType` deliberately
lets a destructive clear through on. A transient tree-source outage in the tail
of the window therefore converted a correct refusal into a blind clear.
Reproduced on Chrome 151 against this branch's tool-server: nothing focused at
the first poll, the tree read poisoned from t+600ms, focus landing on `#other`
at t+900ms where no read could see it. The step passed and wrote `WIPED` into
`#other`, a field it never named; the same page with the reads left alone
refused, and so did the same page poisoned before the first read.
The file already states the rule 700 lines up — `CONDITION_DARK_TAIL_TOLERANCE_MS`,
"a verdict narrated from the reads before the darkness would describe a screen
nobody saw at the deadline". This applies it to the one place where that stale
verdict authorises a destructive action, counted in consecutive failed polls
rather than in milliseconds: one poll costs a whole `uiautomator dump` on
Android, so an elapsed-time budget would read a slow device as an outage. One
failure is still the last-poll blip the tolerance exists to absorb.
The refusal now says the tree stopped answering rather than that it could not be
read at all, which was only ever true of the every-read-failed case.
The focus wait classified an empty `focused[]` as the observation "no-focus",
which `giveUp` maps to "unobservable" — the one non-confirmed outcome `runType`
lets a destructive clear through on. `lastRead` is latest-read-wins with no
floor, so a single read in which the focused element's leaf is simply MISSING
erased everything the earlier reads had established. Nothing throws; the tree is
complete and still holds the target. Both flow adapters produce exactly that for
a frame clipping to zero area, which is what keyboard avoidance does to a field
it scrolls away, and on Android what a healthy `uiautomator` dump reports for a
focused view whose bounds have collapsed.
Reproduced on Chrome 151 against this branch's tool-server: `#other` holds the
caret and never loses it; the tap on the target does not move focus; collapsing
`#other`'s box 1500ms into the wait took the step from "focus never reached" to
a pass that emptied `#other` and wrote `WIPED` into it — with `#other` still
`document.activeElement` at the end. The same page without the collapse refuses.
So a read that saw nothing no longer overwrites one that saw where focus is.
Latest-read-wins still decides between sightings, which is what keeps a blur on
the focusing tap from being answered with history, and a window in which NO read
ever saw focus is still "unobservable" — verified live that a page with nothing
focused still dispatches the clear, which is what keeps the directive working on
an iOS build whose injected framework omits `firstResponder`.
The residual `runType` documents narrows accordingly: an app that blurs, or a
field that scrolled away, now only reads as unobservable when it happened before
the first read.
The walker gave a `<textarea>` its live `el.value` as the node's own text. That
fixed the real problem it was aimed at — child text is the markup DEFAULT and
never tracks the value — but node text is what the page DISPLAYS: it hoists into
an ancestor's `subtreeText`, a `text` selector matches it, and the resolver
ranks an exact field match on it above a substring hit. A draft sitting in a
composer therefore behaved like text the page was showing.
Measured on Chrome 151 against this branch's tool-server, each against the same
page with only this hunk changed:
- `assert: { text: { in: { id: chat }, contains: "hello team" } }` PASSED with
the message list empty and the draft still in the box, so a saved regression
test written that way can never go red;
- `assert: { visible: "Alpha" }` PASSED on the composer holding "Alpha" — the
very "assert the consequence instead" pattern the new reference prescribes;
- `tap: { text: "Save" }` landed in a note whose draft was the word "Save",
not on the Save button, whose label is the only "Save" on the page.
A field's contents are not the page's text and there is no third channel to tell
them apart in, so a `<textarea>` now reads its contents back exactly as an
`<input>` does: through `accessibleName`'s value fallback, which an aria-label
or a placeholder pre-empts. All three repros are refusals again, a `tap` lands
on the button, and the clear-only proof still works on an unlabelled composer
(`hidden` fails before the clear, passes after).
Two MEDIUMs fall out with it: a >200-character value can no longer be reported
twice (the dedup compared an unsliced text to an already-sliced name), and a
labelled textarea's contents no longer reach a failing assert's quoted text, so
a secret typed into one stays out of the flow report.
`focusedOwnsTargetText` let any enclosing focused node confirm a destructive
clear as soon as its text equalled the target's. That re-opened the "encloses"
shape the same wait refuses: a `focusin` focus trap holding a `<textarea>` over
the field confirms whenever its draft happens to equal the field's value.
Reproduced on Chrome 151 against this branch's tool-server — the step passed,
the TEXTAREA was emptied and rewrote with `new@example.com`, and the `#email`
the step named kept its old value throughout. The same page with any other draft
in the textarea refused.
The coincidence is structural, not lucky: an anonymous target does not shield,
so its text hoists into every enclosing node's `subtreeText`.
An editing host is distinguishable without ancestry, which the flattened flow
trees do not carry: it has no text of its OWN. Quill/ProseMirror/Lexical render
an editable with no id, no accessible name and no own text, so the only text on
it is the target's, hoisted. A trapped textarea fails that — an unlabelled one's
value IS its accessible name — and so does a focused WebView carrying a whole
form's text. Verified both ways on the live build: the composer the arm was
written for still clears and replaces, the trap no longer can.
`trackTarget` follows the element the step tapped rather than re-running the
selector — the right instinct — but "the same element" is `sameElement`, a name
test. When several nodes answered to the name it fell through to "nearest to
where the tap landed", and any re-layout between the tap and the focus poll can
put a different namesake nearest. Keyboard avoidance, the everyday movement this
function exists to follow, is exactly such a re-layout. The identity arm in
`waitForFocus` then trusts that node absolutely, bypassing `focusedFromInside`
and the under-the-tap gate entirely.
Reproduced on Chrome 151 against this branch's tool-server: two rows sharing a
`data-testid`, the selector resolving to the row holding `KEEP-ME`, and a 100px
scroll during the focus wait moving the second row to where the first had been.
The step passed and emptied the row holding `SECRET-B` — a field the selector
never resolved to. The same page with distinct testids refused.
An ambiguous name now yields no target node at all, not even the selector's own
pick: that ranks by frame and reading order, so it would hand back one of the
same namesakes on a tie-break. With no target there is nothing to confirm
against, which is a refusal for a `clear` and the best-effort path a plain
`type` was already on.
`focusedFromInside` is the only path by which a node that is not the target can
confirm a destructive clear, and its whole discriminator was "is this focused
node one of the elements the tap could have hit". That question was answered by
`sameElement`, which compares role + identifier and falls back to the label —
names, not identities. Two elements sharing a name were therefore
interchangeable, so the focused node only had to be a NAMESAKE of whatever sat
under the tap.
That is the currency/amount row and the OTP row the gate's own docblock says it
refuses. Reproduced on Chrome 151 against this branch's tool-server: a row of
two anonymous inputs both reading "Amount", the tap landing on the right one and
the app forcing focus to the left one, cleared and rewrote the LEFT field and
reported a pass on the row; the identical page with the second input named
"Currency" refused. On Android it needs no coincidence of labels — `identifier`
is the raw resource-id, which names the layout slot.
So the name must resolve, in the tree the tap was dispatched from, to exactly
one candidate inside the tapped box, and that candidate is the one that must
have been under the tap. `nodesUnderTap` becomes `tapCandidates` and returns
both lists from one walk, since the ambiguity scope and the hit test are two
questions about the same set.
Comments and skill pages that describe something other than what happens. No
behaviour change.
- `live-authoring.md` told an agent to KEEP a recorded `tool: keyboard` clear
raw, on the false premise that `type:` accepts only `into`/`text`/`submit`
(`flow-utils.ts` allowlists `clear`) and pointing at a table exception this PR
deleted. It is the raw form that is unsafe: it replays with no focus tap and
no focus check. Converting it is the whole mitigation, and that paragraph
said not to.
- The same page claimed an unconfirmed poll falls through to typing. It does
for a plain `type`; a `clear` hard-fails, which is what `flow-yaml.md`
already says.
- `dispatchOrAbort`'s docstring said `keyboard` discards the `ToolContext`. All
three platforms `clear` supports forward the signal and check it between
keypresses, so an abort-driven rejection is the designed common case there —
which is what makes the wrapper load-bearing rather than defensive.
- The `requireEvidence` fast path was justified by uiautomator flagging a
WebView instead of the EditText inside it. Surveyed across eight screens on
API 36 / WebView 151, including a real in-app WebView, the WebView is
`focused="false"` and the leaf EditText carries the flag. The exit stays; its
stated reason does not.
- `FOCUS_REPORTING_SOURCES` said a source outside the set never reports focus,
naming Vega. Vega's source-parser does set it and `flow-vega-tree` preserves
it; it is excluded because `runDirective` refuses `type` there first.
- The Android TV comment had a `clear` step failing at the first keyboard
dispatch, which presupposes the focus gate passed. `android-devtools` is in
the reporting set, so the wait reports "unconfirmed" and the refusal returns
before any dispatch — as `flow-yaml.md` says.
- `flow-run.ts` cited `(down)` as a sibling option echo twenty lines above the
branch that suppresses exactly that value.
- `asserting-field-values.md` described the textarea case as either/or, gave an
over-broad rule for when an `<input>` exposes its value (`accessibleName`
gates on truthy/resolving, so `aria-label=""` still falls through), and
recommended `assert: { hidden: … }` as working on every platform when it
passes vacuously on exactly the platforms where the contents never reach the
tree. It now also states the secret exposure a `<textarea>` carries.
- `flow-keyboard-clear.test.ts`'s header still gave the allowlist as the reason
the round trip is worth pinning. The round trip is; that reason is not.
Every focus fixture held the tree constant across polls and split its rows
unevenly, which is what let five defects through a suite that was otherwise
green. Each test below fails against the code as it stood one commit before its
fix, and each ships with the control that keeps the fix from being a blanket
refusal.
- an EVENLY split row whose focused half is not the one the tap hit refuses,
and the same row with focus on the half the tap DID hit still clears;
- a focused input overhanging its wrapper by 1-2px still clears, and 3px — six
pixels of extra width on a 1080px screen — refuses, which pins both sides of
the containment epsilon instead of only the far one;
- an overlay appearing over the tap point AFTER the tap refuses, and the same
overlay already there at tap time still clears;
- a named container that GROWS between the tap and the poll still clears;
- a selector that re-resolves to a better-ranked node after the tap still
clears;
- a rich-text composer whose only text sits in a child node clears, and the
same editor holding a second paragraph refuses;
- a `<textarea>` holding a newline reports its contents once, not once raw and
once normalized.
Also pinned, all three of which a mutation survived: a `clear` keeps polling
past an intermediate overlap read instead of refusing on it (the safety half of
`requireEvidence`, whose perf half was already covered), the focus flag is
suppressed on a shadow host when the flag sits NESTED inside its subtree rather
than one level down, and no refusal reason quotes the focused element's own
text — the invariant that keeps a field's value out of a report on disk, until
now asserted only in a comment.
The walker gives a `<textarea>`'s node text its live value, whitespace-
normalized. `accessibleName` already fell through to `el.value` for an
unlabelled textarea, but returned it RAW. For any value holding a newline or a
run of spaces the two strings differ, so the walker emitted both — the raw
value as the node's label and the normalized value as its value — and the
flow's text matching concatenated them. An `equals` assert on the field's real
contents then matched neither spelling, which is the assert the skill
prescribes as the proof a clear landed.
Normalize the textarea fall-through the same way, so the two agree and only one
is emitted.
Reproduced and re-run on Chrome 42: `line one\nline two` in a `<textarea>`
rendered as `textarea "line one\nline two" value="line one line two"` and the
prescribed assert failed quoting the contents twice; it now renders once and
the assert passes. The single-line control passed before and still does.
Quill, ProseMirror and Lexical render `<div contenteditable><p>…</p></div>`.
The editable node carries no id, no accessible name and no own text, so the
only text in the tree belongs to the block child and every selector that can
name the editor's content resolves to something INSIDE the focused node. That
classified as "encloses" and was refused with advice — point the selector at
the input itself — that nothing on the page can satisfy.
Confirm when EVERY focus flag sits on an element whose entire content is what
the selector named. Equality is what keeps the shapes "encloses" exists for out
of it: a focused `android.webkit.WebView` wrapping a form, and a focus trap
holding a `<textarea>` over the field, both show text of their own beyond the
target's. Tree ancestry would ask this more directly, but the flow adapters
flatten to leaves under one root, so the hoisted `subtreeText` is what survives.
Reproduced and re-run on Chrome 42: the Quill shape and the Lexical shape (a
`<span>` inside the `<p>`) both went fail + editor untouched, and now pass with
the editor replaced. Both negative controls still refuse with the field intact
— a focus trap that keeps focus on a `<textarea>` covering the target, and an
editor holding a second paragraph the selector did not name.
`waitForFocus` re-resolved the selector from scratch on every post-tap read.
The `tappedFrame` fallback covered a round where the selector failed to resolve
at all, but not one where it resolved to a DIFFERENT, better-ranked element
than the one that was tapped. Both confirming arms then tested focus against an
element the step never touched, so a clear was refused with a message saying
focus never reached the target while focus was exactly where the flow put it.
The trigger is ordinary: a field that opens a typeahead list on focus where a
suggestion repeats the field's current value. The chip is smaller than the
input and `selectorToNode` ranks smallest-frame-wins, so the chip takes the
match.
`trackTarget` follows the tapped element by name instead, keeping the selector
as the fallback for a round it cannot be found in, so a field that keyboard
avoidance scrolls away is still recognised where it now is.
Reproduced and re-run on Chrome 42: `into: { text: "Paris" }` with a suggestion
reading "Paris" went fail + field untouched, and now passes with the field
replaced. The control that changes only the suggestion's text still passes, and
so does the same step without `clear`.
`focusedFromInside` recomputed the tap point from the target's CURRENT frame
every round, on the argument that keyboard avoidance cannot then stale it. That
is true of a container that MOVES and false of one that GROWS. An autocomplete
wrapper rendering its listbox inside itself on focus gets taller after the tap,
so the recomputed centre leaves the input and lands in the option list, and the
clear is refused with a reason naming an overlay or a sibling row — neither of
which is on the page. Downshift, HeadlessUI and most React Native autocompletes
render the list inside the wrapper, and the wrapper is where a testID sits.
The pre-tap record added for the overlay fix already answers the question the
recompute was asking, and answers it against the tree the gesture was actually
dispatched from, so drop the per-round geometry and keep the identity match.
A field that keyboard avoidance scrolls away still matches itself, because
`sameElement` follows the element rather than its box.
Reproduced and re-run on Chrome 42: a combobox wrapper whose listbox opens on
focus went fail + `#city-input` untouched, and now passes with the field
replaced. The control with the listbox handler removed still passes, and the
whole seam/overlay battery from the two previous commits is unchanged.
Not fixed by this, and distinct: a wrapper that is ALREADY more than twice the
field's height before the tap (a two-line validation message under a 40px
input) makes the focusing tap miss the input itself, so nothing takes focus and
the keyboard tool refuses the clear. That is wrapper targeting, not focus
confirmation, and it predates `clear`.
`focusedFromInside` accepted any focus-flagged node covering the tap point, and
the comment justifying it argued that such a node IS what the tap hit. That
holds only for an overlay already on screen when the gesture was dispatched. An
overlay rendered in RESPONSE to the tap — an @-mention list, an inline picker,
a formatting bar with its own input — was hit by nothing, and taking focus was
enough to make it swallow the clear while the composer kept its draft and the
step reported a pass on the composer.
Keep the settled tree the frame was resolved from, and match a focus-flagged
node against the elements that were under the tap point in it (`nodesUnderTap`,
`sameElement`). Matching by role + identifier rather than by frame is what lets
the field move — keyboard avoidance scrolling it away from where it was tapped
— without losing its identity across reads.
Reproduced and re-run on Chrome 42 through the branch tool-server: a popover
opened by the composer's own `focus` handler went pass + `#mention` destroyed,
and now fails with both fields intact. The two controls still pass — the same
page with no popover clears the composer, and the same popover ALREADY open and
holding focus at tap time still takes the clear, which is the case the old
comment was right about.
`focusedFromInside` confirmed a clear when the focus-flagged node covered the
point the tap landed on, and asked `frameContains`, which is inclusive on all
four edges. A container split evenly between two children puts its centre ON
the seam, so BOTH halves contain it and the test discriminated nothing: the
clear emptied and overwrote whichever half held focus, and the step reported a
pass on the container.
The OS routes the tap itself to exactly one child — left/top inclusive,
right/bottom exclusive in `Rect.contains`, `CGRectContainsPoint` and Chrome's
`elementFromPoint` alike — so ask the same question with `frameCoversTap`.
Reproduced and re-run on Chrome 42 through the branch tool-server, one variable
at a time: a 50/50 row whose LEFT input takes focus via a `focusin` redirect
went pass + `#first` destroyed, and now fails with both fields intact; the same
row with no redirect still passes and still types into the tapped half; the
same page at 30/70 still refuses; a wrapper over a single input still passes.
The line promised that `clear` "is rejected - loudly, before anything is
typed - on TV targets", and named that rejection as the reason not to use
it there. On an Android TV the author never sees it: `runDirective` gates
only Vega upfront, Android TV is `platform: "android"` and takes the
touch path, its `android-devtools` tree source DOES report focus, and a
`type` step issues no `tv-remote` - so D-pad focus stays wherever the
remote left it, the focus wait reports `unconfirmed`, and the step fails
telling the author to fix a selector that already resolves to the field.
That is the ordinary state of a leanback screen.
The three families fail three different ways and the line now says so,
with the real advice up front: use `tool: tv-remote` + `tool: keyboard`
on a TV. The `clear` rejection is the `keyboard` TOOL's, which is what a
flow actually reaches there, so it is attributed to the tool.
"empty the box, then assert the empty state" is the reason `text` became
optional, and it is the one shape the flow language cannot express. Both
spellings fail, on opposite sides:
- `equals: ""` / `contains: ""` are rejected at parse time - "assert
text needs a non-empty `equals`".
- `matches: '^$'` parses and then cannot match: `regexMatchesNonEmpty`
treats absent or empty text as a non-haystack, so the pattern is
false for exactly the state it describes.
Measured on Chrome 151 through the branch tool-server, `<input
id="plain-input" value="OLD PLAIN">` emptied by the directive: the assert
fails reporting `its text was ""`, with the element's value genuinely "".
What does work on the same page is asserting the OLD value's absence -
`assert: { hidden: "OLD PLAIN" }` passes - so a clear-only step IS
verifiable, just not the way the comment or the skill said. Both now say
the spelling that works.
`references/asserting-field-values.md` also gets the Chromium bullet
corrected for the textarea fix earlier in this branch: a `<textarea>` now
always exposes its live contents, so the label-only limitation is an
`<input>` one.
`1ab12bd2` corrected "typing appends" everywhere in this branch except
here. The test NAME - which is what shows up in suite output, so it is
read outside the file - said "instead of silently appending", and its
comment "an append, which fails much later at an assert". A third copy in
`flow-tools.test.ts` glossed `←` as "(append)" while documenting a
production comment that says the opposite: `flow-finish-recording.ts`
renders it as "types into whatever is already there - NOT necessarily
appending".
The measured behaviour is per-platform: on Android and Chromium the
focusing tap lands the caret mid-field and the new text is spliced INTO
the old value; only on iOS does the caret jump to the end and append.
"On an Android TV target this call is also the one that fails: `typeTv`
rejects `key` unconditionally, so the text lands and the submit errors" -
true for a plain type, and false for the `clear: true` step the comment
sits directly under. `typeTv` throws on `params.clear` before it reaches
`api.type(text)`, so for a clear the FIRST dispatch - the `{ clear, text }`
call the block above merged - is the one that fails, nothing is typed,
and this Enter dispatch is never reached. One keyboard call, not three.
Both cases are now stated.
The justification for having no post-clear read-back cited "a Chromium
`<textarea>` exposes its default content once `el.value` empties". Two
commits in this same PR moved that: `2f8d2ffe` stopped the markup default
reaching the node at all, and the textarea fix after it made the node
carry the LIVE value. The reader was pointed at a failure mode that no
longer exists.
The one that does is a field carrying aria-label / aria-labelledby /
placeholder: `accessibleName` returns those long before it falls through
to `el.value`, so an emptied field reports its LABEL - the same shape as
the Android hint already named beside it, and what
`references/asserting-field-values.md` documents.
The docblock said "the two callers" and then covered `gesture-rotate` and
`keyboard`. The `gesture-tap` focus tap this PR routed through the helper
was described by neither, so the docblock did not answer "can this
dispatch surface a cancelled run as a tool failure?" for the caller the
same change added.
`gesture-tap` honours no signal, like `keyboard`, so it belongs in that
paragraph - and naming it is what makes the reason `runType` wraps all
three legible: without it one cancelled step reported `error` or `skip`
depending on which dispatch was in flight.
The bullet listing the shapes an overlap test cannot tell from a
confirmation described an open shadow root as one where "document.
activeElement is the host and never the inner element". After the
describe walker started reading the activeElement of an element's own
ROOT (in this same PR), that is no longer what the tree shows: the inner
element carries the flag and the host is excluded. Verified on Chrome 151
- describe renders `div [focused]` inside `#shost`, not the host.
It does still hold for a CLOSED root, where `el.shadowRoot` is null so
the walker can neither descend nor read the root's activeElement. That is
now what the bullet says.
`argent-create-flow` carried the same example where an agent reads it, so
it says "closed shadow host" too - and the same sentence now names the
sibling-inside-the-container refusal alongside the covering ones, which
is the other half of what the step refuses.
`lastRead`'s comment said a window in which every read throws "stays
`unobservable`". `giveUp()`, five lines below, returns "unreadable" for
exactly that state, and its own comment says why: reporting it as
"unobservable" "would let a clear through on the strength of a window in
which nothing was seen at all". "unobservable" is the one non-confirmed
outcome `runType` DOES dispatch a clear on, so the two comments answered
the question this guard exists to settle in opposite ways.
The code is right; the first comment now points at `giveUp` instead of
contradicting it.
`2f8d2ffe` stopped a `<textarea>` emitting its markup default - correct,
since child text is the authored content and never tracks `el.value` -
but did it by dropping the text entirely, on the grounds that "the
accessible name already carries the live value". That only holds for a
textarea with no aria-label, no aria-labelledby and no placeholder:
`accessibleName` returns those first and only then falls through to
`el.value`. With any of them the node carried NEITHER - the name was the
label and the text was "" - so the field's contents reached no describe
consumer at all.
Reading `el.value` fixes both: the live contents are what the field
shows, which is what every other element's own text already means, and
an unlabelled textarea still de-duplicates against its name exactly as
an `<input>` does.
On Chrome 151 through the branch tool-server:
textarea "Notes" id="t1" <- before, contents gone
textarea "Notes" value="initial content one" id="t1" <- after
assert { text: { in: { id: t1 }, contains: "initial content" } }
before -> fail, 'its text was "Notes"'
after -> pass
and the case `2f8d2ffe` exists for still holds: clear + type "final" on
`<textarea id=t3>initial content three</textarea>` leaves an
`equals: "final"` assert passing, with the default gone.
The test added with that commit exercised the labelled case specifically -
the one where nothing was left behind - and could not see it, because the
mock built a plain element that the script's `instanceof
HTMLTextAreaElement` branches never recognised.
The focus block ran at the END of walk() - after both collapse returns -
so an element the walker collapses never reached it. The host was already
suppressed on the assumption that the inner element would carry the flag,
and when the shadow root's activeElement was collapsible BOTH candidates
disappeared and the tree carried no focus at all. `runType` reads that as
"nothing was focused", the one non-confirmed outcome it dispatches a
destructive clear on.
The collapsible-and-focusable shape is the standard rich-text composer: a
bare `<div contenteditable><p>…</p></div>`, which is what Quill /
ProseMirror / Lexical render on a single-paragraph document - box-less,
one child, no id, role or own text. Put it in an open shadow root (any
Lit/Polymer component) and both halves apply at once.
Two changes. The flag is computed ahead of the collapses and keeps the
node alive like a name or an id does - being the caret's element is
targeting information in its own right. And the host is suppressed only
once its shadow subtree has ACTUALLY produced the flag, so a pruned or
collapsed inner element leaves the host reporting rather than nobody.
On Chrome 151 with a `focusin` trap holding the shadow editor:
1 paragraph, before -> pass, editor's draft replaced, #q untouched
1 paragraph, after -> describe shows `div [focused]` inside #shost,
step fails, both intact
2 paragraphs -> refused either way (the editor survives collapse)
Hubert Gancarczyk