1096 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
zhengzhijie	6c9126e8de	fix(sheets): validate chart data sources in layout check	2026-08-26 16:22:04 +08:00
xiongyuanwen-byted	971e639622	feat(sheets): relax local-office token length check from 28 to >=25 (#2509) ... The local-office token format is changing from 28 to 27 characters per the new rule (OFL0X + 21 random + 1 office type enum). Relax the guard from to so 27-char tokens can reach the OFL0X interleaved marker check. All legacy detection paths (fake_office_ prefix, local_office_ prefix, OFL0X marker) are preserved unchanged.	2026-08-26 15:44:50 +08:00
ViperCai	d0158ab289	fix(docs): recover PowerShell-dequoted presentation JSON (#2501) ... * fix(docs): recover PowerShell-dequoted presentation JSON * fix(docs): recover quoted-key shell JSON	2026-08-26 15:09:17 +08:00
xiaoxiangyu-123	0f9553385c	feat(im): add chat AppLink output (#2491) ... Add chat AppLink fields to IM chat outputs and update lark-im guidance to prefer CLI-provided links.	2026-08-26 10:55:59 +08:00
lark-cli-external-pr-digest[bot]	c8f06cd167	chore: release v1.0.90 (#2503) v1.0.90	2026-08-25 22:07:14 +08:00
liangshuo-1	8493800ebf	feat(config): support keychain-backed tenant access tokens (#2488)	2026-08-25 21:39:50 +08:00
dc-bytedance	36c7291cc1	fix(auth): exclude im:message.send_as_user from batch scope sets (#2471) ... * fix(auth): exclude im:message.send_as_user from batch scope sets * test(auth): isolate requested-scope cache in batch-exclusion test * fix(auth): validate --exclude against pre-filter scope universe The batch-exclusion filter dropped im:message.send_as_user before --exclude was validated, so `--domain im --exclude im:message.send_as_user` returned invalid_argument and never sent the device authorization request. That broke automations relying on --exclude to skip the send-as-user approval. Validate --exclude against the selected universe (post recommend/common filter, pre batch exclusion) plus --scope; the wire request still uses the batch-filtered effective scopes. Excluding a batch-withheld scope is now a valid no-op, while excluding a scope outside the selection still errors so typos are not widened. * test(auth): assert exact scope membership in exclude regression test	2026-08-25 21:13:57 +08:00
caojie0621	083f0f4719	feat(drive): support appid in member-remove (#2499)	2026-08-25 20:30:39 +08:00
sang-neo03	6952d3aa7f	feat(extension): add business command extension v1 (#2308) ... * feat(shortcuts): import typed shortcut framework from c07b64621 * feat(extension): add public command contract * feat(extension): compile and register business commands * feat(cmd): assemble business command sets * fix(auth): derive login domains from shortcuts * test(extension): add business command test runtime * ci: verify generated Go sources * test(auth): match help and interactive domains * fix(extension): validate command path segments * fix(extension): satisfy generator and error guards * fix(extension): follow generated domain naming contract * fix(command): complete extension runtime contracts * test(command): cover public extension surface * fix(command): remove unused typed runtime APIs * fix(command): address follow-up review findings * fix(command): enforce extension v1 contracts * fix(command): remove unreachable compatibility wrappers * fix(auth): keep scope-less domains addressable via --domain, matching main Move the declared-scope filter from allKnownDomains to the interactive selector only. On main, a scope-less shortcut domain (event) passes --domain validation and fails later with "no matching scopes found"; the previous unified filter changed that to "unknown domain" and dropped it from the --help list. The interactive picker still hides scope-less domains — selecting one can only fail. * feat(command): add PathSegment for user-provided path values Business code concatenates IDs into request paths but had no public escape helper (internal/validate.EncodePathSegment is unreachable from extension/command). Mirror its url.PathEscape semantics, use it in the business command examples, and pin the traversal defense: the validator decodes percent-encoding before the canonical check, so both raw and escaped dot sequences fail same-origin validation. * docs(command): add runnable chat-brief distribution example Mirror the audit-observer precedent: a buildable wrapper main under examples/ showing WithCommandSets against the real distribution shape (plugins, strict mode, and service commands stay enabled). Covers the single-read command (Validate, shared DryRun request, CallJSON, PathSegment, Tips) and a Page[T] list command whose pagination flags come from the compiler. The testdata/wrapper fixture stays test-only. Verified offline: --help renders tag-driven parameters, +chat-brief-list exposes --page-all/--page-limit/--page-delay, and --dry-run previews the request with a fake env token and no network access. * fix(command): normalize page envelopes and bound CollectAllPages Two pagination contract fixes from the extension design (owner plan §8.3): Page decoding accepted only a literal "items" array, so endpoints that spell their list field differently (drive uses files, some responses use records) walked every page while decoding nothing — CollectAllPages then returned an empty set marked complete, and downstream writes ran against it. Each page now normalizes its single top-level array field into Page.Items; zero or multiple array fields fail closed with a typed invalid-response error. CollectAllPages previously reused the user-facing --page-limit maximum (1000) as its walk bound. A complete-set collection holds every page in memory before the workflow's writes run, so it now uses the design's dedicated workflow bound of 100 pages. * feat(commandhost): note bounded repetition in Page dry-run previews A Page[T] command's dry-run can only show the first request; fabricating response-dependent page tokens is forbidden. Append the bounded-repeat explanation to the previewed request (preserving any business description), matching the design's dry-run contract. Also give the example's list command a --page-token resume flag seeded into the request, documenting the resume convention: the framework owns --page-all/--page-limit/--page-delay while the starting cursor is a business-declared input, independent of --page-all. * docs(command): generate domain constants with English comments The generator emitted Chinese titles while the rest of the public extension packages document in English. Switch the generator to the "en" service title and regenerate. The generator already rejects a domain missing either locale, so the switch keeps its own guard. * docs(command): mark the host adapter read surface The Host* types, InspectCommand, InspectDomain and CloneSets exist for lark-cli's host adapter, not for business commands, but nothing said so at the symbols themselves. They cannot move to a subpackage: a Command holds its declaration unexported, so a sibling package has no way to reach it, and moving the wire types to internal/ would cycle back through CommandMetadata and CommandContext. Also correct HostPagination, which is not adapter-only -- ContextOptions and commandtest both carry it. * refactor(command): type CommandMetadata.Service as DomainName A set already declares its domain through ExtendDomain(DomainIm), yet every command repeated the same domain as a bare string that only the host compiler checked. Typing the field points authors at the generated enum and forces an explicit conversion when the value comes from a string variable. This does not make a mistyped literal a compile error -- an untyped constant still converts to DomainName -- so the mismatch check in CompileSets stays the actual net. The example and the wrapper fixture now declare command.DomainIm. The chat-brief example was also not gofmt-clean, which the CI format gate would have caught. * refactor(command): extract the command-set assembly steps buildInternalWithConfig is an orchestrator, and the business command sets were compiled inline inside it. Move that step to resolveShortcutSnapshot so the entry point reads as one call and the built-in/external merge has a name. newCommand carried six near-identical blocks that each nil-checked a hook and wrapped it in the same type assertion. Split them into one binder per hook shape; Normalize and Validate now share bindArgsHook since their signatures match. The behaviour is unchanged: an undeclared hook still erases to nil, and an empty renderer map still yields nil. * perf(shortcuts): stop re-cloning an already-isolated snapshot AllShortcuts deep-copies because a Shortcut carries slice fields whose backing arrays a shallow copy would share: an external distribution mutating registered[0].Flags[0] would corrupt the process-global list. That copy is worth its ~165us over 500+ shortcuts. Paying it four times per startup is not. auth, schema and the mount path each cloned the snapshot again, but they receive it from AllShortcutsWithExternal with no third-party code in between, and nothing in this repository mutates a shortcut element -- mountDeclarative takes a value receiver and only replaces slice headers. Drop those three copies and document the boundary on AllShortcuts so the next reader does not reintroduce them. Startup drops from four full clones to one. Benchmarks pin the remaining cost so a regression points at a new clone rather than at growth in the shortcut set. * fix(command): align the commandtest page bound and escape wrapper paths Two review findings, both of which let a business command pass its tests and then misbehave in production. The commandtest recorder walked 1000 pages for a complete-set collection while the host adapter stops at 100, so a command tested against 300 pages of fixtures would fail its first real --page-all run with PaginationLimitError. The bound now lives in internal/pagination, which both sides already import, and the hard-limit test scripts itself from that constant instead of restating 1000 -- the literal was what let the two drift apart. The testdata wrapper concatenated args.ID straight into the request path, contradicting PathSegment's own documented rule and the chat-brief example. ValidateRequestView does not cover this: "abc/other-users-file" cleans to itself, so an unescaped separator silently retargets the request. Since testdata is what an integrator copies first, route both call sites through one readRequest helper, mirroring chat-brief. The e2e assertion could not have caught it either -- PathSegment("chat_1") is "chat_1", so the check passed with or without the call. It now sends "chat/1" and asserts %2F reaches the wire; removing PathSegment fails it. * fix(command): deny network to the pre-confirmation hooks and four review findings Normalize and Validate run before the high-risk confirmation gate, and both received the full CommandContext, so a high-risk business command could POST or DELETE from Validate and leave remote side effects behind before the user was ever asked to confirm. Moving the gate earlier would contradict the documented hook order and would also make --dry-run require --yes. The design already forbids this from the other side -- Validate is specified as parameter checking that issues no request -- so enforce that instead: Normalize and Validate get a context whose CallJSON and CollectPages refuse, while PreflightScopes stays available. The guard sits in CommandContext rather than in the wiring, so a future adapter that wires the callbacks anyway still cannot reach the API. commandtest mirrors it, otherwise a command would pass its tests and fail only in production. Page.Items now starts non-nil. It is declared required;nonnullable, but a zero-item collection encoded as {"items":null}, which a caller generating types from the published schema would reject. NewCmdAuthWithRecovery and NewCmdSchemaWithVisibility are restored as wrappers. Both were dropped for shortcut-aware variants, and both are reachable from outside this module: CommandVisibility is an ordinary exported func type, and *recovery.Projector cannot be named by an outside caller but can be passed as nil. A signature test now pins them. The path-traversal fixture said "../../secret", which the deterministic gate rejects as a generic credential assignment -- the reason CI is currently red. The filename carries no meaning; it is now "../../outside". * test(cmd): exercise the retained constructors instead of naming them The compatibility wrappers restored for outside callers are unreachable from inside this repository by construction, so the incremental dead-code gate rejected them. A signature-only assertion did not help: taking a function value and discarding it leaves the body unreachable, and it proved nothing about whether the wrapper still builds a working command. Call each one and assert the command it returns. NewCmdAuthWithRecovery is called with a nil projector, which is the exact call an outside module can make and the reason the wrapper has to keep compiling. Verified with the same deadcode version CI runs: neither function is reported, and no other function in this branch's files is either. * docs(command): document the hook contract and pin dry-run note idempotency Hooks is the first type a business author reads and carried no field documentation, so the rules lived only in the design doc: which of DryRun and DryRunE to set, that setting both fails to compile, that Execute owns the API call and must not write stdout, and that Normalize and Validate run before the confirmation gate and therefore get no network. The choice between DryRun and DryRunE is not old-versus-new -- neither is legacy. It follows from whether building the preview can fail, which is now what the field docs say. Also pin the dry-run note as idempotent. convertDryRun writes the bounded-repeat note into the projection it builds, never back into the hook's *DryRun, and DryRunAPI.Desc assigns rather than appends, so a hook that caches and returns the same preview cannot accumulate the note. Both properties were true and neither was tested. * refactor(command): settle the dry-run constructor, tips, and domain enum Three narrowings of the V1 business-command contract, none of which has a published compatibility surface: extension/command does not exist on main. Preview and NewDryRun were the same constructor twice -- one empty, one seeded with requests. Fold them into a variadic NewDryRun. Every existing NewDryRun() call keeps compiling, and the domain word in the contract is now spelled one way. The type DryRun already owns that identifier in this package, so naming the constructor DryRun outright cannot compile. Drop Metadata.Tips. It was pure passthrough into common.Shortcut.Tips and nothing in the execution path read it, so business commands lose only the ability to declare help tips; the repository's own typed shortcuts keep theirs. The mount test asserted a tip reached the rendered help as proof that metadata survives the extension -> commandhost -> common.Shortcut -> help conversion; it now asserts the risk line, which travels the same path. Hand-write the domain enumeration and delete the generator. Generating from shortcuts.AllShortcuts silently omitted approval, attendance and mindnotes: all three are published under `lark-cli --help` and served by typed and raw API commands, they just own no shortcut. The enum is now the 23 domains the CLI actually exposes. Those three would otherwise have been constants that compile and always fail, because CompileSets derived its mountable domains from the same shortcut list. It now reads the service registry, and shortcuts/register.go already creates a domain command group on demand when no built-in occupies it, so a business command can mount under a shortcut-less domain. * ci: stop generating extension/command The domain enumeration is hand-written now and extension/command holds no go:generate directive, so the path was a no-op that still read as if the package carried generated files. * refactor(command): drop DryRunE and let the preview render like a built-in DryRunE has no counterpart in the shipped CLI: `git show main:shortcuts/common/types.go` has no such field, it arrived with the typed-shortcut framework this branch imported, and no shortcut in the repository sets one. Business commands get the single DryRun hook that built-in shortcuts have. Validate already runs before it and owns the error channel, so a preview that cannot be built still fails there with a typed error -- which is what the repointed tests now assert, end to end through --dry-run and through commandtest.Preview. Also stop appending the bounded-repeat note. convertDryRun added "with --page-all, repeats with the returned page_token until exhaustion or --page-limit" to every Page[T] preview, so an external command's dry-run carried a sentence its author never wrote. Built-in paginated shortcuts say this themselves when they want it (im_chat_members_list.go calls dry.Desc), and external commands now do the same: the framework renders the description it was given and nothing else. The dry-run context keeps refusing requests -- runner.go does the same for built-ins, so removing that would be the divergence, not the alignment. Only the word changes: "offline" was our own vocabulary for what the rest of the CLI calls dry-run. * refactor(command): drop the partial-failure outcome from the contract Business commands now return Success only. Partial, OutcomeDefinition, PartialFailureDefinition and FailedItemDefinition leave the public surface along with Execution.Partial and the host adapter's receipt conversion. Result keeps its outcome field. It is no longer a choice -- Success is the only value -- but it is also how the host tells a returned Result apart from the zero value that accompanies an error, which is the check commandtest.Execute makes before reporting "returned both Result and error". Collapsing it to nothing would delete that signal. The exemplar commands that returned Partial keep their scenarios: a best-effort scope failure still marks every item failed and appends the snapshot, and the multi-call audit still records the owner it could not resolve. That information lives in the command's own Data (Items[].State plus Failures), not in the outcome, so the tests assert the same facts and only the outcome assertion is gone. The deep-copy test moved its nested JSON exemplar from FailedValues to InputDefault.Value, keeping cloneJSONValue covered. shortcuts/common still defines PartialFailure for built-in typed shortcuts. That is the imported framework, untouched here. * refactor(shortcuts): walk pages once for built-in and external commands Commit 4d0c6ea61 added internal/pagination, moved PaginateInto onto it, and then wrote a second caller for externally declared commands. Both assembled the same Walk options, cloned the same params, read the same cursor and mapped the same walk error; only the policy source, the call path and the accumulator ever differed. Those three now parameterize one pageWalk. PaginateInto keeps calling through the RuntimeContext and keeps its per-page progress line; external commands keep CallTypedAPI, the walker's context and their undecoded pages, which the public contract needs because it decodes them into its own Page[T]. Behavior is unchanged on both sides -- the external walk still leaves Wait nil, which internal/pagination fills with WaitContext, so --page-delay works exactly as before. pageWalk is deliberately generic-free so one struct serves both callers; the typed half of the built-in path moved to addDecodedPage. * refactor(shortcuts): make the external page walk PaginateInto's twin CollectCommandPages now differs from PaginateInto only where the context type forces it. It takes the same PageAccumulator, decodes each page into T through the same addDecodedPage, returns the same *output.PaginationMeta and reads the same state out of the same walk, in the same order. What is left is what the interface cannot supply. An externally declared command compiles in the business module, so it holds a CommandContext rather than a *RuntimeContext: the context arrives as a parameter because the interface carries none, the call goes through CallTypedAPI, and there is no progress line because deciding to print one needs StderrIsTerminal, JqExpr and Format, none of which the interface exposes. The all parameter stays. It is the complete-set policy CollectAllPages depends on -- collect to exhaustion under the hard page bound instead of obeying --page-all and --page-limit -- and PaginateInto has no way to express it, since resolvePaginationPolicy only ever reads flags. Dropping it would quietly turn a command that must see the whole set into one a user can truncate with --page-limit 1. CommandPageCollection is gone with it: pages accumulate in commandhost's own accumulator, the way every built-in shortcut already accumulates its own. One consequence of sharing the decode: a page whose response carries no data object is now an error on this path too, as it always was for built-ins. * fix(shortcuts): reject recursive Data and Args types during compilation shapeForType and compileStructShape called each other without recording the Go types already being walked, so a self-referential type recursed forever. The walk ran during command registration and ended in a stack overflow -- a fatal runtime error rather than a panic, so no recover boundary could contain it and one extension command took the whole CLI down before --help, schema, or any unrelated command could run. That also broke CompileErasedDefinition's documented promise to compile without panic. Thread the struct types open on the current recursion path through both functions and return a compile error on a repeat visit, pointing at the explicit Shape escape hatch. Membership is scoped to the path, not the whole walk, so a type reused as a sibling or at another depth stays legal. Covers self-reference through a slice and through a pointer, mutual recursion through two types, the JSON-encoded Args path, and the public CompileErasedDefinition contract. * fix(command): share one result protocol between the host and commandtest commandtest.Execute only checked that Data carried the expected type. Generic erasure leaves a correctly typed zero Data behind, so a business command that returned Result{} instead of Success(data) passed the type assertion and the test reported success. Production rejects the same result, which left extension authors with green tests and a command that failed on every real invocation -- exactly the guarantee commandtest exists to provide. Add ValidateHostResult in extension/command and call it from both commandtest.Execute and the host adapter's execute hook, so the two surfaces cannot drift. It rejects an empty or unsupported outcome and mirrors the pagination receipt checks the host already applies: declared Page output, pages of at least one, non-negative items, and next-token state consistent with completeness. RunWithFlags is covered because it delegates to Execute. * feat(command): expose reusable download capabilities * test(command): make the chat-brief example testable and cover its hooks The example declared both commands as inline Definition literals handed straight to Define. Define erases the type parameters and returns an opaque Command that cannot hand its Definition back, while commandtest.Execute takes the Definition -- so the shape the example demonstrated could not be unit tested at all. Neither shipped example had a test file, so nobody had walked the copy-the-example-then-add-a-test path. Lift both declarations into Definition-returning functions, the shape the repository's own commandtest suites already use, and keep the compiled Commands as package vars so main is unchanged. The configuration bodies are untouched. Add the tests that shape exists for: the single-read projection and its Validate rejection, plus the Page[T] contract for default single-page reads and a --page-all walk through RunWithFlags. All four run offline through the commandtest recorder. * test(commandtest): cover the ordered URL download script Recorder.ReplyURL shipped without a caller, so the incremental dead code gate flagged it as new unreachable code and blocked the branch. The existing URL download test uses the unordered RespondFile constructor, which never exercises the URL assertion ReplyURL exists for. Mirror the ReplyJSON pair: one test walks two scripted URLs in order and checks the recorded source URLs, content types, and artifacts; the other points DownloadURL at an unscripted URL and expects the mismatch error. * feat(command): accept @file input for external commands V1 rejected the file value source, leaving external commands with inline flags and stdin only. A process has one stdin, so a command whose body is too large or too quoted for the shell -- an XML document update is the case that surfaced this -- had no second way to receive it, and the caller had to fall back to shell escaping. Nothing downstream was missing: resolveInputFlags already resolves @path and the @@ escape through the invocation's FileIO, help renders the "@file" affordance, and legacyInputSources maps the source onto the compiled flag. The gap was the public constant and the host allow-list. Export SourceFile and let it through compilation. Unknown sources still fail the same way, which the rewritten host test now pins alongside the compiled flag actually carrying both extra sources -- silently dropping a declared source is the regression worth catching. Give the wrapper fixture a command whose content flag declares all three sources, and drive it end to end: @file and stdin both reach the request body, and the help text advertises them. * revert(content): drop the default content exports from the extension surface Exporting the repository's embedded skills and affordance trees turned two content directories into Go packages, because go:embed cannot reach up out of a package directory and the repository root is package main. That cost two things: a .go file living inside an authored-content tree, where a future content type is silently omitted until someone edits the glob, and an embed directive per tree where the root previously covered both in one. The need it served does not exist. The distribution driving this work ships its own skills and does not consume the official set, and a wrapper that does want them can supply a tree through cmd.SetEmbeddedSkillContent, which is what extension/platform already documents. Restore content_embed.go, the SkillsOverlay comments, and the platform README to their main state, and delete the two exporting packages. The example and fixture wrappers now ship no embedded content, which is what a wrapper that does not compile the repository root actually gets; the e2e assertion that depended on inheriting lark-doc goes with it. * fix(command): close the review findings on API surface and storage commit Five findings from the extension-v1 review, each verified by a test that fails against the previous implementation. Source compatibility of auth.LoginOptions. The shortcut snapshot was an unexported field on a struct that appears in the exported runF signature, which ends positional literals for every caller outside this module. It becomes a closure capture plus an explicit authLoginRun parameter, and the six domain helpers collapse into domainResolver methods, removing five xxxWithShortcuts twins that only tests reached. common.Shortcut.DryRunE goes too: it was a new exported field with no production caller. The unexported typed field stays, so Shortcut itself is still not positional-literal compatible -- that is a deliberate remaining gap, since relocating it would need a global mutable map or a wider signature change. One canonical wire projection. queryValues stringified and dropped nils for the live call while the dry-run preview and the pagination walk forwarded raw values, so a preview could describe a request the runtime would never send. canonicalQuery is now the only projection and all three consumers derive from it. Dry-run output for numeric parameters therefore reads "20" instead of 20, matching what the query string actually carries. No-clobber as a storage guarantee. IfExistsFail checked existence, downloaded, then committed with a rename that replaces unconditionally, so a target created during the transfer was silently overwritten. The commit step is now an optional ExclusiveFileIO capability: content lands in a temp file and is published with Link, which refuses an existing target and never exposes a partial file. A provider without the capability is refused rather than served a guarantee it cannot keep. V1 public surface. Removes NewDomain and its options (host compilation rejected them), HostDomain.IsNew, reservedRootNames, and the unproducible ResultMetaDefinition.Count; narrows Hooks.Renderers to a single PrettyRenderer, since pretty was the only key the compiler accepted; and demotes the generic authoring layer in shortcuts/common to unexported, as no production code outside that package used it. commandtest runs the production compiler. Execute, RunWithFlags and Preview now share compileForTest, so a wrong tag, Shape or relation fails in the unit test instead of at CLI startup. Applying this surfaced two long-standing contract violations in the package's own fixture. * refactor(command): keep a single authoring contract * revert(schema): keep the schema command blind to shortcuts The schema command serves the generated API catalog only, matching main. Drop the shortcut contract lookup and completion from cmd/schema and restore the constructor surface. ShortcutSchema stays on the sealed commandbridge surface, where the host compiler tests assert the contract; the CLI itself no longer consumes it. The surface scenario and wrapper e2e pin the boundary from the other side: schema resolution and completion must not see mounted shortcuts. --------- Co-authored-by: sang-neo03 <266690410+sang-neo03@users.noreply.github.com> Co-authored-by: liangshuo-1 <266696938+liangshuo-1@users.noreply.github.com>	2026-08-25 20:22:13 +08:00
zhengzhijiej-tech	5f35c72bd3	feat(sheets): combine chart workflows and special chart types (#2374) ... * feat(sheets): support partial chart snapshot schemas * feat(sheets): add semantic chart shortcuts * feat(sheets): improve semantic chart workflows * fix(sheets): prefer semantic chart shortcuts * fix(sheets): normalize chart range and flag inputs * fix(sheets): normalize irregular chart ranges * feat(sheets): add chart data update shortcut * feat(sheets): harden chart update workflows * feat(sheets): improve chart creation dimension handling * feat(sheets): add dedicated chart batch shortcuts * fix(sheets): allow chart color theme patches * fix(sheets): persist chart color theme updates * feat(sheets): simplify batch chart operations * fix(sheets): preserve batch scope and cross-sheet chart ranges * feat(sheets): support bubble waterfall and pareto charts * fix(sheets): sync special chart tool schema * feat(sheets): add semantic bubble chart indexes * docs(sheets): sync combined chart workflow guidance * fix(sheets): align combined chart artifacts * feat(sheets): add x-axis number interpretation flag * docs(sheets): validate chart axis semantics * fix(sheets): allow recursive chart update patches * test(sheets): isolate chart create schema check * feat(sheets): refine semantic chart creation * docs(sheets): sync semantic chart guidance * docs(sheets): remove unrelated label position guidance * fix(sheets): support all chart data label combinations * fix(sheets): support numeric x-axis bounds * feat(sheets): support chart y-axis bounds * feat(sheets): add last-point chart label flag * fix(sheets): preserve disabled waterfall stacking * fix(sheets): nest last-point chart label property * fix(sheets): resolve lint and dead-code CI failures - lark_sheet_chart.go: drop redundant chartConfigUpdateInput / chartDataUpdateInput calls in Execute whose result is immediately overwritten by the *FromSnapshot variant (ineffassign); the snapshot variants already re-run the same validation internally. - lark_sheet_chart_test.go: remove Go 1.22+ redundant loop-variable copies (copyloopvar). - batch_op_dispatch.go / lark_sheet_batch_update.go: remove unreachable allowedBatchShortcuts and batchUpdateInput; callers use the lower-level allowedShortcuts and buildBatchUpdatePlan directly. * fix(sheets): validate chart config updates * fix(sheets): sync skill specs and chart schema validation * fix(sheets): resolve chart review follow-ups * fix(sheets): restore the two-color contract * fix(sheets): require at least two chart colors * docs(sheets): expose advanced chart shortcut flags * fix(sheets): address chart review feedback * fix(sheets): surface ignored batch locators * chore(sheets): bump skill version to 3.1.6 * fix(sheets): surface batch warnings consistently * test(sheets): satisfy copyloopvar lint * docs(sheets): sync skill from spec * fix(sheets): harden chart batch updates * fix(sheets): tighten chart update validation * fix(sheets): canonicalize chart ranges and batch targets	2026-08-25 18:53:47 +08:00
wangweiming-01	62f270afd6	fix(skills): scope markdown routing to Lark resources (#2497)	2026-08-25 18:37:13 +08:00
wangweiming-01	faa2f8d3e0	fix(docs): continue media downloads on permission scope errors (#2498)	2026-08-25 18:33:35 +08:00
BD-ZERO	36cd24aa73	fix(slides): avoid PID variable in examples (#2496) ... Replace `$PID` with `$PRES_ID` in Slides Skill examples to avoid conflicts with PowerShell’s read-only `$PID` variable. This only updates embedded Skill documentation. CLI flags, API fields, runtime behavior, and historical Skills remain unchanged. Validation: - Skill format check passed - Quality gate passed	2026-08-25 17:55:03 +08:00
liujinkun2025	f09414f9d5	fix(wiki): keep node-get stderr machine-readable (#2449)	2026-08-25 17:27:41 +08:00
zhangjun-bytedance	aec659c461	feat: words replace and minutes fix (#2490)	2026-08-25 17:18:07 +08:00
wangweiming-01	e668fff669	fix(drive): continue downloads on permission scope errors (#2494)	2026-08-25 16:59:27 +08:00
ethan-zhx	a06d87333d	feat(slides): add marginRight attribute to <p> element schema (#2493) ... Add marginRight property to the paragraph element in slides XML schema definition, matching the existing marginLeft attribute to support right-side paragraph indentation. This resolves the xml_lint error "unsupported SXSD attribute "marginRight" on <p>".	2026-08-25 16:11:49 +08:00
R0bynZhu	1d24a39659	fix(slides): strip stale <note> id in +update-slide to avoid backend crash (#2475) ... * fix(slides): strip stale <note> id in +update-slide to avoid backend crash A +update-slide carrying a <note id="..."> that is not the page's current note block makes RewriteSlideBySXSD reject the whole page with "block is not NoteBlock". This happens when the XML is copied from another page, or written over a page that was re-created (add-slide reassigns ids, so the note block's id no longer matches). Drop only the <note> id before sending. The backend then targets the page's own note block and the write succeeds. Every visible element keeps its id, so it is updated in place rather than rebuilt — text layout is preserved and there is no risk to svg-internal id references. * fix(slides): strip single-quoted and spaced note id too The note-id strip only matched id="...". A single-quoted or spaced form (id='...', id = "...") slipped through. Both are valid XML, and the backend accepts single-quoted markup — verified on ppe: an all-single-quote page updates fine, and a single-quoted stale note id reproduces the exact "block is not NoteBlock" crash this strip is meant to prevent, while the double-quoted equivalent is stripped and succeeds. Widen the regex to `\s+id\s*=\s*("[^"]*"|'[^']*')` so any quote style and whitespace around '=' are covered. Still a targeted edit on the <note> tag, not a re-serialization, so the caller's bytes are otherwise preserved. Add regression cases: single quotes, whitespace around '=', single-quote attribute order, and a single-quoted visible-element id left untouched. Addresses CodeRabbit review on #2475. * test(slides): assert the note id attribute is removed, not just a value The strip tests checked that a specific id value ("blw") disappeared, which would also pass if the implementation swapped the id for another value. Assert on the <note> opening tag carrying no id attribute at all (any quote style / spacing) via a noteTagHasID helper, so the removal itself is verified. Addresses CodeRabbit review on #2475. * fix(slides): locate the <note> tag with the XML tokenizer before stripping id The raw regex parsed XML as plain text, so it could miss or mis-edit valid input: an id after an attribute whose value contains '>', and note-like text inside comments or CDATA. It also had no notion of where the note sat in the tree. Walk the document with encoding/xml to find the start tag of the <note> that is a direct child of the root <slide>, then delete the id attribute by editing only that tag's bytes. Nothing is re-serialized, so quote style, attribute order, whitespace, and every other element (notably inline <svg> namespaces, whose round-tripping is a known source of "embed missing inner svg") survive untouched — the same byte-preservation contract ensureXMLRootID keeps. This covers the cases the regex could not: '>' in an attribute value, and comment/CDATA text that merely looks like a <note>; and it scopes the edit to the slide-level note only. Regression cases added for each. Addresses CodeRabbit review on #2475. * test(slides): assert everything but the note id survives byte-for-byte Existing tests spot-checked that individual elements survived. Add exact-equality cases asserting the output equals the input with only the one note id removed — proving nothing else moves: inline svg subtrees, CDATA, a '>'-bearing attribute, quote style, attribute order, and whitespace all stay verbatim. Addresses CodeRabbit review on #2475. * style: gofmt slides_update_slide.go * test(slides): cover numeric char refs — InputOffset must not drift the note span	2026-08-25 14:36:16 +08:00
zhicong666-bytedance	35bd5ecfcd	feat(vc): add agent meeting control shortcuts (#2466) ... * feat(vc): add agent calendar meeting actions * feat(vc): add meeting screenshot shortcut for visual context * feat(vc): add meeting countdown commands and events * fix(skills): avoid screenshot recall from meeting description * fix(vc): omit screenshot log ID on success --------- Co-authored-by: renaocheng <renaocheng@bytedance.com> Co-authored-by: shike.11 <shike.11@bytedance.com>	2026-08-24 21:26:44 +08:00
wanghm25	0679884761	fix(base): hide dashboard auto analysis setting (#2465)	2026-08-24 20:18:33 +08:00
ethan-zhx	7874dc144b	feat(slides): add media download shortcut (#2446)	2026-08-24 18:26:23 +08:00
ethan-zhx	8ebdc3f193	feat(slides): un-deprecate +replace-pages shortcut (#2470) ... Remove deprecation markers from +replace-pages: the command is now a supported shortcut again, not a deprecated compatibility shim. Delete the deprecation-note constant and the "deprecated" output field from dry-run, validate-only, and real-run envelopes, update the command description and comments, and remove the deprecation-specific test.	2026-08-24 18:23:50 +08:00
chenxingyang1019	e0e90a4e1b	fix(apps): classify the online DDL ban and the file storage quota failure (#2460) ... * fix(apps): classify the online DDL/DCL ban on +db-execute Running DDL against the online branch of a multi-env app came back as api/server_error with exit 1, hinted "fix the SQL and re-run", and carried a statement position that did not exist. All three point the caller the wrong way: - server_error means "upstream 5xx, retryable"; this is a product rule and no number of retries changes it; - the SQL is fine — the target environment is what has to change; - "(at statement 1 of 1)" is fabricated. The server pre-validates the whole batch and returns a single ERROR sentinel, so a 5-statement request with the DDL in position 4 still rendered as "1 of 1". The CLI does not split the SQL, so it cannot know the real count and cannot detect the mismatch generally — only codes known to be batch-level rejections can drop the suffix. Give code 4000001 its own arm: validation/failed_precondition (exit 2, "change the environment, do not retry"), a hint pointing at dev plus +db-env-migrate, and no statement position. Every other code keeps its current classification, wording and position suffix; a test pins that. 4000001 is a dedicated server-side code (ErrOnlineEnvForbidDDLDCL, client-error band), raised only by the pre-validation pass when env==online on a multi-env workspace. Syntax errors and PG errors use different codes, so keying on it is safe. Matching on the numeric value also covers the "k_dl_4000001" wire form, since codeString already strips that prefix — both forms are tested. "No statements were applied" is stated rather than inferred here: the validator walks every statement and rejects the batch on the first DDL, so nothing lands. The default arm would have inferred the opposite for a DDL in a later position ("Earlier statements were committed"), which is wrong for this code. * fix(apps): classify tenant file storage quota exceeded +file-upload against a tenant whose file storage is full returned api/unknown with no hint at all, so a caller could not tell "the quota is full, stop" from "the upstream had a bad minute, retry" — and had no next step either. Register 400000055 as api/quota_exceeded. That is a dedicated server-side code (ErrTenantStorageQuotaExceeded, client-error band) raised only on the upload path, and the subtype already carries "retrying will not help", so the framework's existing quota wording is enough and no domain-specific hint is added. Left in CategoryAPI (exit 1) rather than Validation (exit 2): a full quota is not something a different argument fixes, and exit 2 would imply it is. The test asserts the hint is non-empty on purpose. The wording comes from the shared APIHint table, so if quota_exceeded is ever dropped from there this fails and says the code now needs its own wording, instead of silently shipping an empty hint.	2026-08-24 16:49:33 +08:00
R0bynZhu	1f53f6e2f5	refactor(slides): assert dry-run parent_type instead of deriving it from a placeholder (#2461) ... * refactor(slides): assert dry-run parent_type instead of deriving it from a placeholder A wiki --presentation cannot be resolved during a dry-run: the real presentation token only exists after a get_node call a preview must not make, so parent_node shows a "<resolved_slides_token>" placeholder. appendSlidesUploadDryRun derived parent_type from parent_node, which sent that placeholder through the office-token check. The value it produced was correct. A placeholder matches no office token shape, so it fell through to slide_file, and slide_file is right here: a wiki ref that reaches an upload is native by construction, because resolvePresentationID rejects any wiki node whose obj_type is not "slides" and an imported office deck sits in drive as a "file" node. It was correct by accident, though, which left the preview hostage to the placeholder's spelling and to every rule later added to isOfficePresentation. Pass parent_type in explicitly instead, so slidesDryRunParentType states the wiki case as a decision with its reason recorded, and the placeholder is never classified. No behaviour change: dry-run output is byte-identical for native tokens, imported office tokens, legacy office prefixes, slides URLs, wiki URLs, and +create, across +media-upload / +add-slide / +update-slide. Tests pin the contract the refactor protects, including a wiki ref whose node token is itself office-shaped -- a wiki node token and the deck token it points at are different tokens in different namespaces, so classifying ref.Token would be wrong for a wiki ref even though it is right for every other kind. That is the regression this makes impossible. * test(slides): use the fixture hostname for the wiki dry-run probes domaincontract rejects "bytedance.larkoffice.com": it is in neither allowlist, and a real tenant host does not belong in a fixture. Use example.feishu.cn, already in fixture-domains.txt and the hostname the rest of the slides wiki tests use. The URL is only a parse fixture -- nothing resolves it -- so only the hostname changes.	2026-08-24 15:55:37 +08:00
bubbmon233	b624948e48	Support repeated mail compose flags (#2271) ... * feat: support repeated mail compose flags * fix(mail): address review feedback for repeatable inline flags Change-Type: ci-fix * test(mail): cover inline validation and upload assertions Change-Type: ci-fix * test(mail): assert inline validation category Change-Type: ci-fix * fix(mail): preserve inline compatibility cases * test(mail): strengthen inline compatibility coverage * docs(mail): prefer one repeatable flag form * docs(mail): keep skill references unchanged * docs(mail): drop skill reference edits * docs(mail): document repeatable mail flags consistently * docs(mail): standardize quoted flag examples * docs(mail): keep inline flag constraints in help * fix(mail): validate template inline cids * fix(mail): preserve recipient names and validate template cids * fix(mail): support repeated recipient parsing Normalize repeated recipient values through ParseMailboxList for every flag occurrence so legacy comma lists still split, quoted display-name commas stay intact, and Unicode display names remain raw before final header rendering. Local check: gofmt -l shortcuts/mail/helpers.go shortcuts/mail/mail_repeatable_flags_test.go * fix(mail): scope template inline update validation --------- Co-authored-by: bubbmon233 <272202079+bubbmon233@users.noreply.github.com>	2026-08-24 15:38:30 +08:00
yballul-bytedance	33cfa46a8f	feat(base): document app default page reuse (#2436) ... Co-authored-by: yballul-bytedance <273011618+yballul-bytedance@users.noreply.github.com>	2026-08-24 14:53:46 +08:00
zhangjun-bytedance	56ad837c3d	feat: event organizer transfer bot to user (#2448)	2026-08-23 14:44:17 +08:00
lark-cli-external-pr-digest[bot]	423e81fcc6	chore: release v1.0.89 (#2447) v1.0.89	2026-08-21 19:12:19 +08:00
wangweiming-01	52f970f23e	refactor(shortcuts): remove MCP text location paths (#2439)	2026-08-21 17:27:18 +08:00
Vee	fbd1aa49cd	feat: add IM read status shortcuts (#2318)	2026-08-21 16:47:49 +08:00
R0bynZhu	b343e67639	feat(slides): use office_slide_file parent_type for imported office presentations (#2441) ... Image uploads to a presentation hard-coded parent_type=slide_file at every entry point. Imported "office" presentations carry either a legacy synthetic token prefix ("fake_office_" / "local_office_") or a 28-character token whose interleaved product/region marker is "OFL0X", and for those the drive backend requires parent_type=office_slide_file. This mirrors the office_sheet_file rule the sheets domain already applies: the token shapes are identical, because an imported office file is an imported office file whether it backs a spreadsheet or a deck. Funnel the selection through one slides-domain helper so the rule lives in a single place and every image-upload path stays consistent with its own dry-run preview. As in sheets, the rule stays inside the domain rather than leaking into common.UploadDriveMediaAllTyped, which mail/doc/drive/base/calendar share. - Replace the slidesMediaParentType const with slidesMediaParentType(token), backed by isOfficePresentation(token); keep the native and office values as named constants. - Route both parent_type call sites through it: uploadSlidesMedia (the Execute path shared by +media-upload and the <img src="@path"> placeholder pipeline behind +create / +add-slide / +update-slide) and appendSlidesUploadDryRun. - Known gap, documented at the helper: when --presentation is a wiki URL the dry-run only has a "<resolved_slides_token>" placeholder, since the real token needs a get_node call the preview must not make, so such a preview shows slide_file regardless. Execute is unaffected -- it resolves first. The negative half of the mapping is what the tests weight most heavily. The backend does not validate parent_node against parent_type, so a native deck misread as office still uploads successfully and only surfaces later as an image that will not render, far from its cause; the marker check is therefore pinned at its exact length and offsets rather than a looser "contains OFL0X". Tests: - shortcuts/slides/slides_media_parent_type_test.go: 14-case pure-function table (off-by-one length, prefix appearing mid-string, wiki placeholder), a real-multipart Execute assertion across four token shapes, and the +add-slide / +update-slide placeholder dry-run previews. - tests/cli_e2e/slides/slides_image_upload_dryrun_test.go: five cases through the built binary, covering every surface a local file can enter through. - Verified non-vacuous: short-circuiting the office branch fails all three package tests plus the e2e lane. Evidence note: office_slide_file is confirmed accepted by upload_all, and the symmetry with office_sheet_file is exact, but this has not been exercised against a real imported-pptx presentation to confirm slide_file fails there.	2026-08-21 15:12:35 +08:00
ethan-zhx	cc015bac28	feat(skills): extend slides XML schema (#2442)	2026-08-21 15:08:46 +08:00
yballul-bytedance	79b8647196	feat(base): add template discovery and form question field reuse (#2340) ... Co-authored-by: yballul-bytedance <273011618+yballul-bytedance@users.noreply.github.com> Co-authored-by: TRAE CLI <noreply@bytedance.com>	2026-08-21 13:22:24 +08:00
bytedance-zhangbinkai	42060154dd	feat(base): support button workflow bindings (#2437)	2026-08-21 10:50:37 +08:00
zhaoleibd	e525beb8d6	feat(skills): unify meeting related skills (#2387) ... * feat(skills): unify meeting guidance * fix(meeting): restore domain boundary guidance * docs(meeting): remove agent rollout qualification guidance * docs(meeting): front-load skill routing description * docs(meeting): refine identity and command guidance * docs(meeting): clarify identity and pagination guidance * docs(meeting): fix minutes todo detail command * fix(meeting): clarify artifact query routing * fix(meeting): improve live meeting skill recall * fix(qualitygate): generate valid minute token placeholders * fix(meeting): address unified skill review findings * docs(meeting): add minutes permission guidance * docs(lark-meeting): 更新SKILL.md并新增会议问答引导脚本 1. 优化SKILL.md表格排版与快速行动章节内容，新增批量获取当日会议脚本的使用说明 2. 新增meeting_qa_bootstrap.py脚本，实现一站式采集当日进行中、已结束会议及未来日程，生成可直接执行的命令引导 * docs(calendar): clarify today's meeting lookup * revert(meeting): remove meeting Q&A bootstrap guidance * fix(skills): register lark-meeting suite keywords --------- Co-authored-by: maozhixiang <maozhixiang@bytedance.com>	2026-08-21 10:49:46 +08:00
wanghm25	da371dc242	feat(base): add dashboard and form share shortcuts (#2282) ... - preserve explicit false values and validate partial share updates - add dry-run and deployment-gated live E2E coverage - document share routing in the bundled Base skill	2026-08-20 22:23:40 +08:00
Yuxuan Zhao	bbcdf65110	test(drive): retry transient async cleanup contention (#2397)	2026-08-20 20:46:07 +08:00
Neseria	f28a418019	feat(base): add --position and statistics number_format to dashboard-block create/update (#2118) ... * feat(base): add --position and statistics number_format to dashboard-block create/update Add an optional top-level --position flag ({x,y,w,h} JSON, parsed but not coordinate-validated, passed through as a sibling of name/type/data_config) and optional statistics data_config.number_format ({formatName,precision}) with light enum + 0-9 integer validation. Both are backward compatible. Body assembly is unified in a shared buildDashboardBlockBody helper so DryRun and Execute stay isomorphic. Adds toIntStrict for strict precision parsing, focused helper/execute/dry-run tests, an E2E dry-run test, and syncs the lark-base dashboard + data-config skill references. Co-authored-by: TRAE CLI <noreply@bytedance.com> * fix(base): validate number_format on update path and add symmetry tests The dashboard-block-update command parsed data_config but never ran the statistics number_format check, so an illegal formatName/precision slipped through locally while create rejected it — violating the SSOT + backend-design §4.5 promise of CLI-side interception on BOTH paths. Update has no --type flag (block type is immutable) and intentionally skips strong type validation, so it now reuses the shared validateNumberFormat sub-validator that validateBlockDataConfig delegates to, keeping create/update symmetric without demanding table_name/series on a number_format-only update. Also: add tests for the --no-validate bypass on create+update, a combined update carrying position + number_format + name, and extend the DryRun/Execute body isomorphism assertion to the update path. Clarify the --position flag Desc that coordinate bounds are advisory (not validated locally or server-side) and sync the lark-base SKILL.md routing table for --position / number_format. Co-authored-by: TRAE CLI <noreply@bytedance.com> * fix(base): align dashboard block validation paths Validate dashboard block JSON consistently across dry-run and execute paths, enforce statistics number_format boundaries, and add layout precision workflow coverage and documentation. * fix(base): resolve dashboard layout doc contradictions and harden isomorphism test Follow-up to the --position / number_format feature, addressing review findings. Docs (SSOT contradictions): - SKILL.md:135 and lark-base-dashboard.md still told agents that dashboard shortcuts cannot set x/y/w/h and to offer auto-layout instead, which would have left --position unreachable through the skill. Both statements are now scoped to +dashboard-arrange, which genuinely cannot take coordinates. - number_format was documented as supporting sub-field merge on update. That contradicts the update Tips and lark-base-dashboard.md's own data_config rule ("每个传入的字段内部是全量替换"). Documented as whole-key replacement and made the update Tip example carry formatName back. - Trimmed both reference sections: dropped the duplicated field table, the restated validation blockquote, the standalone bash example and the 4-column comparison table; kept the enum table and the two load-bearing gotchas. Reformatted the example to the file's multi-line JSON style, and generalized the 场景 3 --position argument to '{...}' like its neighbours. Tests: - The isomorphism check called buildDashboardBlockBody twice with the same arguments, so it could never fail. Replaced with an end-to-end comparison of the --dry-run preview body against the body captured from Execute; verified it fails under single-path fault injection. - The live workflow now updates to values distinct from the create call and asserts them on read-back, instead of asserting substrings that the created state already satisfied. Dropped the position read-back assertion: this iteration does not contract get to echo coordinates. - Filled in the two missing --no-validate cells (create data-config, update position). Cleanup: - Deleted the inline DryRun closures; both commands now point at the dryRunDashboardBlock* functions, matching the DryRun: dryRunX convention used across the package and removing the second body-assembly site. - Rewrote the update comment that referenced review-round codenames and an external design doc section to be self-contained. * fix(base): keep dashboard dry-run previews free of empty identifiers Wiring the block create/update commands to the shared dryRunDashboardBlock* functions routed them through dryRunDashboardBase, which Set all three identifiers unconditionally. A create preview has no block_id yet, so it began advertising "block_id": "" — an argument that reads as failed to resolve. Skip empty values in the shared helper rather than special-casing create, which also clears the same pre-existing noise from the +dashboard-arrange preview. Pinned with a test asserting a create preview carries base_token and dashboard_id and no block_id. * fix(base): require complete --position objects and close the arrange/position gap Round-2 review follow-up. Three findings, all one-liners in effect, that compounded into a real failure mode: an agent told to "move this chart to the right half" could send a partial position, have it accepted, and silently resize the block to nothing — with no coordinate read-back to diagnose it. - --position now requires all four of x/y/w/h. The server fills missing coordinates with zero rather than leaving them alone, so a partial object is a resize disguised as a move. Only the object's shape is checked; coordinate VALUES stay unvalidated (out-of-range, negative and overlapping still pass through) as documented. The check is semantic, so --no-validate skips it while the JSON parse still runs — the same split the rest of this command pair already uses. Rejected the alternative of validating ranges too: that would contradict the documented dws-aligned pass-through contract. - +dashboard-arrange's Tips now point at --position. The cross-reference was one-directional: create/update told agents about arrange, but arrange — the command an agent reaches for first when asked to "fix the layout" — never mentioned that exact placement had become possible. - Documented that coordinates are write-only this iteration. The reference doc offered "replicate an existing dashboard's layout" as a use case while the PR itself scopes out coordinate read-back, sending agents to look for x/y/w/h that get/list do not return. Also from the same review: - The dry-run builders no longer discard buildDashboardBlockBody's error. It is unreachable while Validate parses the same flags first, but returning nil makes the runner fail loudly instead of previewing a body with a field silently missing. - Added precision cases that run through the real command. The existing table-driven ones decode with UseNumber and hit toIntStrict's json.Number branch, which production never takes — parseJSONObject uses a plain json.Unmarshal, so precision always arrives as float64. - coverage.md now says which four commands rest solely on the credential-gated live test that has not been executed yet. - Marked the number_format fallback claim as unverified against the backend. * fix(base): close the position guard's null hole and the contract drift it left behind Round-3 review follow-up. Two of these were introduced by the previous follow-up commit, not by the original feature. - The --position completeness guard only asked whether the key was present, and a JSON null key IS present. `{"x":6,"y":null,"w":null,"h":null}` sailed through the very check meant to stop it — the exact scenario the guard's own comment describes. Each coordinate must now actually decode as a number, so null, strings, objects and bools are rejected alongside missing keys. This is still a shape check: out-of-range, negative and fractional values keep passing through as documented. The package's neighbours (`cfg["text"].(string)`, `table_name`) already validate required fields with a type assertion; this was the one place that did not. Mutation-verified: reverting the assertion turns the explicit-nulls case red. - coverage.md claimed `+dashboard-block-get` "reads back position" while the test it cites deliberately stopped asserting coordinates — a line the previous commit invalidated and did not update. It now says number_format only. The `+dashboard-block-update` row also claimed dry-run coverage for number_format that only the unexecuted live test provides. - dashboard-block-data-config.md still said the update path does no local validation, which commit bb7d8fbc made false in this same PR. An agent reading it would not expect exit 2 and might reach for --no-validate, which now also disables the position guard. Also from that review: - --no-validate's flag Desc only mentioned data_config; it silently covers the --position check too. Said so, in both commands. - Four places stated unverified backend behaviour as fact — including a claim that the server zeroes missing coordinates, which was the guard's entire premise, and a "backend defaults to digital" line 23 lines above a blockquote saying that very fallback was unverified. All reworded to what is actually known; the guard's rationale is now stated in terms of the request we send. - E2E dry-run assertions were whole-output substring matches (`"w": 6` could match anywhere); switched to clie2e.DryRunGet path assertions like the sibling suites, which also lets them prove position is a top-level sibling rather than nested in data_config. - Documented that formatName is case-sensitive, unlike rollup which is normalized — same object, two conventions, worth saying out loud. - The --position canonical rewrite's comment claimed it kept Validate/DryRun/ Execute consistent; they re-parse anyway. Its real job is folding @file input inline so the two paths cannot read a changed file. Comment now says that. - Named buildDashboardBlockBody's bool at the call sites; covered all three branches of the identifier skip, not just block_id. * fix(base): stop dry-run previews leaking route templates; finish the unverified-claim sweep Round-4 review follow-up. Both findings trace back to earlier follow-up commits rather than the original feature, and both are the same failure shape: fixing the instance instead of the class. - 68bdaccd made dryRunDashboardBase skip empty identifiers, but Set() doubles as the substitution source for :param placeholders in the URL. Skipping a declared-but-empty identifier therefore printed the raw route template — `.../blocks/:block_id` — while also removing `"block_id": ""`, the one signal that told the caller their argument was empty. An agent whose `$BLOCK_ID` did not expand would see a preview that looks like the CLI failed to substitute, with nothing pointing at the real cause. The condition is now whether the command declares the flag, which is what the comment claimed all along: create genuinely has no block-id, and that is the case worth omitting. Not fixed here: a declared-but-empty required identifier still reaches the wire as a request to the collection endpoint (`baseV3Path` drops empty segments). That predates this PR and spans the whole base package — worth its own change rather than guarding two commands and leaving nine inconsistent. - The isomorphism test only compared bodies, so a preview could target a different endpoint than Execute and still pass. It now compares method and URL as well, and rejects any leftover ":" placeholder — that is the mechanism that would have caught the above. - 82f72540's message claimed all four unverified backend statements had been reworded; five survived, three of them in `--help`, where the --position Desc said server-side acceptance was unverified two lines above a Tip asserting overlaps are not server-checked. All five now match the wording already used in lark-base-dashboard.md, and the PR body Summary no longer contradicts its own Known limitations. The rejected-alternative for the first item: guarding empty required identifiers in Validate would be the root-cause fix, but applying it to the two commands this PR owns while nine sibling dashboard commands keep the old behaviour trades one inconsistency for another. * fix(base): stabilize dashboard block validation inputs * docs(base): clarify precise dashboard layout workflow * docs(base): align dashboard live coverage status * docs(base): soften absolute dashboard layout phrasing in skill Replace "run exactly once / stop" wording for +dashboard-arrange and --position with intent-based guidance (prefer whole-dashboard arrange, generally no need to re-read position) so the skill routes agents away from per-block churn and useless retries without forbidding legitimate user-driven follow-up adjustments. Co-authored-by: TRAE CLI <traecli@bytedance.com> * docs(base): clarify dashboard layout guidance * docs(skills): move dashboard layout guidance to reference * docs(base): verify dashboard number format defaults --------- Co-authored-by: wanglei.75 <wanglei.75@bytedance.com> Co-authored-by: TRAE CLI <noreply@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>	2026-08-20 19:26:27 +08:00
chenxingyang1019	ca35f60616	fix(apps): make cache-clear ask first, and make apps failures classifiable (#2415) ... * docs(skills): require explicit confirmation before apps +cache-clear Asked to clear an app's online cache, an agent read `Risk: high-risk-write` from --help and then supplied `--yes` itself on the first call, wiping production cache without ever hitting the confirmation gate. The CLI gate is fine: no --yes -> exit 10 confirmation_required, and --dry-run -> exit 0 without triggering it. The wording was not. It only forbade appending `--yes` *after* an exit-10, and said "已明确授权可直接带 --yes" without defining authorization — so "clear my cache" read as authorization. - `+cache-clear` gets a CAUTION block: never self-supply `--yes` on the first call; without confirmation, either --dry-run or ask, then stop and wait. exit 10 is not a signal to retry with --yes. - Add a zero-ambiguity table separating a *request* to clear ("clear the online cache") from a *confirmation* ("我确认清 dev"), so blocking the accidental wipe does not also kill the cases that were already correct: an explicit confirmation still goes straight to `--yes`, and a request with no environment named still has to ask instead of picking one. - Note that online needs a confirmation phrase even when named explicitly. `+cache-delete` gains the response field an agent has to read (`deleted_key_count`): 0 means the key never existed, not "deleted successfully", plus the get -> delete -> get chain needed to prove a delete took effect — a single miss afterwards cannot tell the two apart. SKILL.md: add +cache-clear to 禁止预授权判定底线, the one list a pre-authorized run cannot skip; a reference-level rule alone would be bypassed there. The routing table is left alone — no other row annotates risk, including +file-delete, +role-delete and +member-remove. * fix(apps): stop attaching request-shaped hints to precondition failures `+db-execute` against a tenant that never activated Miaoda returns code 221800 "miaoda UAT not activated" with the hint "verify table/column names with `+db-table-get` ... target the dev database with --environment dev". Neither step can help: the failure is tenant-level, so a caller following the hint loops over table lookups and env retries that fail identically. Two causes. 221800 was unregistered, so it degraded to api/unknown — nothing in the envelope distinguished "your tenant is not activated, stop" from "your SQL was wrong, fix it and retry". And withAppsHint filled the caller's hint whenever the server sent none, without looking at what failed: the hints are command-scoped ("verify --app-id", "verify table/column names", "list releases"), so every one of them describes the request, and the request is exactly what failed_precondition says was fine. Register 221800 as validation/failed_precondition (same shape as 400002465 "app has no database yet") and gate the hint fallback on the subtype. Blast radius is two codes, since that is all the subtype covers here: - 221800 — now withheld; message and code still carry the meaning. - 400002655 "no running container" — only when it reaches a non-observability command; the observability pair rewrites it first, and "verify --app-id" was never the fix for an undeployed app. 400002465 / 500002759 are intercepted by the isAppNoDatabaseError branch above the gate, and 400002479 is served by withDBSyncHint, which does not delegate here. The other 78 call sites take the original path for every input. Gate on the one subtype, not on Category: this package asserts on purpose that an authentication failure on +role-list (99991663) keeps the app-access hint and a 503 on credential issuance keeps the developer-access hint. Those hints are broad enough to survive a caller-standing failure; only the precondition class is misdescribed by construction. A test pins that, so widening the gate to Category fails loudly instead of silently dropping those hints. The gate is asserted on the real classification path (BuildAPIError -> the code table -> withAppsHint), not only on a hand-built Problem. Constructing SubtypeFailedPrecondition directly feeds the gate the input it wants and passes whether or not 221800 is registered, so the registration itself has to be part of what the test covers. No recovery hint for 221800 — the activation path is a product procedure, and guessing one is what made this failure misleading in the first place. * fix(apps): classify file-storage and app-level failures Five Spark business codes reached the CLI unregistered, so every one of them came out as api/unknown with exit 1: a caller could not tell "your app id is wrong" from "you lack permission" from "the upstream is having a bad minute", and the exit code offered no way to branch either. 400002484 app not found -> validation/invalid_argument exit 2 400002467 no admin/developer perm -> authorization/permission_denied exit 3 500002761 ditto, pre-4xx renumber -> same 400000034 file not found/no access -> api/not_found exit 1 500000034 ditto, pre-4xx renumber -> same 400002467 is not file-specific: db commands (+db-table-list, +db-table-get, +db-quota-get, +db-changelog-list) return it for an app the caller cannot access, so registering it fixes both domains at once. 400002484 covers a well-formed id that does not exist AND a malformed one ("notanappid", "app_1" return it too), so the argument itself is the failure -> invalid_argument, whose exit 2 separates "you passed the wrong id" from an upstream fault. Environments that have not picked it up answer with 400002465 instead, conflating it with "app has no database yet"; the CLI cannot tell those apart on the old code, so nothing here keys on that. Both the current and the pre-4xx number are registered for each file failure. The domain is moving its client-class errors from the 5xxxxxxxx band into 4xxxxxxxx, rolled out per environment, so both are live at once and dropping the old one would silently return the un-migrated half to api/unknown — the same trap that made the no-database recovery flow disappear when the server renumbered it (see appNoDatabaseCode). The new number is not derivable from the old either: 500002761 became 400002467, tail digits included. No hints added: permission_denied already has framework recovery wording, and a domain-specific one would have to invent a remedy.	2026-08-20 17:36:08 +08:00
zhangjun-bytedance	755daa4de3	feat: add minutes transcript degradation logic (#2404)	2026-08-19 17:25:04 +08:00
guokexin.02	de45ec61e6	fix: honor recovered E2E retries (#2400)	2026-08-19 15:31:05 +08:00
lark-cli-external-pr-digest[bot]	2829ecd188	chore: release v1.0.88 (#2394) v1.0.88	2026-08-18 21:44:31 +08:00
guokexin.02	e0867e6ebb	feat: support separate and suite skill layouts (#2211)	2026-08-18 20:59:31 +08:00
陈家名	679ebd5289	fix(api): reject query strings and fragments in paths (#2375)	2026-08-18 16:49:00 +08:00
huarenmin13	9b231d9825	fix(base): improve record history output and validation (#2298) ... * fix(base): make record history queries explicit and readable 1. Require an explicit confirmed record ID and document deterministic record resolution 2. Add shared-format pretty history output and projection aliases without changing default JSON 3. Reject explicitly non-positive history cursors and cover request, help, formatting, and dry-run behavior ```ai-signature 改动范围: 将 Codebase MR 1438 的最终十文件差异移植到 GitHub PR 2298，覆盖 record history 命令、record list 投影别名、Base 引导文档与对应单元及 dry-run 回归测试 思考过程: 以 GitHub 最新 main 为基线执行三方内容合并，保留 GitHub 独立演进；删除原 PR 针对 base_history_003 的 Skill 改动，并仅按 GitHub 当前分母重算 coverage 指标 改动原因: GitHub PR 原先承载的是已确认应撤回的单题文档方案，需要由已评审的 MR 1438 最终通用实现完整替换，同时避免复制 Codebase 的多轮提交与 revert 历史 Break Change: 行为 breaking | record history 要求显式确认的 record ID，且显式非正 --max-version 现在返回 typed validation error ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: 5bf66267670f435c7d577d2444b61b209322eb5a73f15e47e671a5b8dd2603bf * fix(base): validate history cursors and NDJSON dry runs 1. Reject missing or invalid next_max_version values before emitting pagination guidance 2. Use the execution page size in NDJSON dry runs and assert the requested output path 3. Cover valid and invalid history cursors and prove a 2000-row request is capped to a 500-row first page ```ai-signature 改动范围: shortcuts/base/record_history_list.go、record_ops.go 及邻近单元和 dry-run E2E 测试，仅处理 PR 2298 中有效 CodeRabbit 评论，不新增 live E2E 或修改主 Skill 思考过程: 分页提示只接受解码后的正整数游标；NDJSON dry-run 复用执行阶段的五百行页大小，并以两千行请求验证真实截断而非相等值偶然通过，同时直接断言导出路径契约 改动原因: 原实现可能把不可用的服务端游标打印成命令，同时 dry-run 对 201 到 500 条请求报告的首屏大小与真实执行不一致，初版测试也未真正证明五百行上限或 search 输出路径 Break Change: 否 ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: a362c47d739d6de5676b87431fbc015d1eaa3d47d46d711e2535baa4dad7ffce * docs(base): simplify record history prerequisites 1. Condense the record history prerequisites into generic record selection rules. 2. Remove the positive and negative examples from the reference. ```ai-signature 改动范围: 仅修改 skills/lark-base/references/lark-base-record-history-list.md，精简使用前置并删除正反例章节。 思考过程: 保留调用前确认同表 record_id、不得自行选择记录或扩展整表扫描的核心约束，移除具体链接、视图位置和命令示例以提升通用性。 改动原因: 用户要求使用前置更精简、表述更通用，并删除正反例；本次不涉及命令行为或测试。 Break Change: 否 ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: 7e69951d47c1535cd5fe0fa9ebd7018af2e17373e5851c229dac46d68eaefa84 * fix(base): align history guidance with affordance * fix(base): keep history guidance in the existing reference 1. Remove the new Base affordance file and its Markdown-only tests 2. Keep selection and field quoting guidance in the existing record history reference 3. Restore the pre-existing command tips and retain only behavior-focused regressions ```ai-signature 改动范围: 删除新增 affordance/base.md 与对应 source/help 文案测试，调整 record-history 现有 reference、覆盖说明和原命令 Tips 思考过程: 用户要求不新增 Base affordance 文件且 Markdown 不需要专门测试，因此保留运行时代码测试，把跨命令选行和字段引号说明收敛到已有 reference 改动原因: 新增 affordance 与文案测试扩大了 PR 改动面，并重复承载已有 history reference 的 agent 工作流说明 Break Change: 否 ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: 4c7e3db10025f412d4b2cb4443d94724b5997b72b7e8f97fafdae2f08633b5a2 * docs(base): clarify record history target selection 1. Describe the record ID as uniquely resolving the user-selected target 2. Avoid implying that users must confirm an opaque internal record ID directly ```ai-signature 改动范围: 仅调整现有 lark-base record-history reference 的一处目标记录选择表述 思考过程: CLI 运行时只要求有效 record_id，agent 工作流要求用户确认目标而不是直接确认内部 ID，因此需要区分产品事实和操作约束 改动原因: 原表述可能被误解为 base-cli 能验证 record_id 的用户确认来源，与实际产品边界不一致 Break Change: 否 ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: bd6c9584cc38689e1c3d9f26514425e3e38ffe2f2cff7b2bb0c65ff316aaf8dc * docs(base): preserve serial history queries --------- Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local>	2026-08-18 12:06:02 +08:00
ethan-zhx	27ed082520	feat(slides): add kickoff reminder for empty presentations (#2367)	2026-08-18 11:58:50 +08:00
zhaojunlin0405	b6d04738e5	test(docs): align fetch help comment expectations (#2363) ... * fix(docs): restore fetch comment help guidance * test(docs): align fetch help comment expectations	2026-08-17 17:07:25 +08:00
leave330	327874c8f4	docs(lark-shared): split SKILL.md into a slim core plus references (#2226) ... * docs(lark-shared): split SKILL.md into a slim core plus references lark-shared is force-loaded by nearly every lark-* skill (26 skills, 190 references), so its body is paid on almost every task. Split the 211-line monolith into a slim always-loaded core plus references/ that are read only when relevant. This is deliberately a move, not a rewrite. Existing wording is carried over as-is wherever possible so the change stays easy to regression-test. The core keeps the rules whose violation is silent or has no self-announcing trigger: identity semantics, the ok == true success contract, non-blocking auth split-flow, QR forwarding, write/delete intent confirmation, the exit-10 approval gate, path handling and the no-secrets rule. Mechanics, field paths and step-by-step flows move to references/. New references, all carrying over existing text: - lark-shared-identity-and-permissions.md - lark-shared-auth-split-flow.md - lark-shared-high-risk-approval.md - lark-shared-output-contract.md - lark-shared-update-notice.md - lark-shared-config-init.md Wording changes are confined to lark-shared-high-risk-approval.md, where the exit-10 guidance was generalized to match the implementation: the recovery flag is read from hint rather than assumed to be --yes, and --dry-run is suggested only where the target command supports it. * docs(lark-shared): tighten the resident rule set Regroup the always-loaded body so the safety rules read as one block: the no-secrets rule leads, write/delete intent confirmation and --dry-run preview follow, and the exit-10 approval gate and path handling close it out. Trim wording that restated consequences already covered by the linked reference, and align a few reference passages with the command surface (`config init` without the flag, envelope phrasing). * docs(lark-shared): make reference loading trigger-driven Replace the loose "other scenarios" link list with an explicit trigger index: each row names the conditions that oblige the agent to open that reference before taking the next step, and the table covers all six references rather than the three the list happened to mention. Trigger conditions beat prose pointers here because the failure mode is an agent that never opens the reference at all — a link it reads as optional is a link it skips. Emphasis markers on individual rules are dropped in favour of plain arrows, since the obligation now lives in the index. * docs(lark-shared): describe the notice trigger by effect Name what the three `_notice` keys mean for the agent rather than listing the keys themselves, so the trigger reads as a condition to recognize instead of a field spec to memorize. * docs(lark-shared): phrase triggers the way tasks arrive Restate the identity trigger in the terms an agent actually encounters ("who am I", "get the fields of the current identity") rather than in diagnostic vocabulary, and gloss high-risk-write so the row is readable without already knowing the term. Use MUST for the read obligation, matching how the rest of the skill set marks non-negotiable steps. * docs(lark-shared): scope the credential-reuse ban to across flows The split-flow steps require carrying device_code from the first turn into the second, so a flat ban on caching it contradicted the procedure it accompanied. Scope the ban to reuse across flows, which is the case that actually matters. Also match the trigger table to the field name the error envelope carries (missing_scopes), keeping it consistent with the reference it routes to. * docs(lark-shared): restore the silent-empty warning and complete the scope flags Bring back the note that a bot reading user resources returns an empty success rather than an error. That failure is silent, so it belongs in the body: an agent that never learns it reads the empty result as "the user has no data". Also list --recommend alongside --scope and --domain as a way to specify the authorization range, matching what auth login actually accepts. * docs(lark-shared): fold the split-flow steps into identity-and-permissions Auth split-flow and identity/permission recovery are consulted in the same situation — an agent about to obtain or repair authorization — so a separate file bought a second hop without buying separation. Merge the split-flow steps into identity-and-permissions as its agent-initiated-auth section, and route its trigger row there. The non-blocking rule leaves the resident body with this merge; the trigger index already forces the read before any auth login is initiated, which is the moment the rule matters. Also reword the _notice.skills gloss to "out of sync" — the mismatch is bidirectional, not only the skills lagging the CLI. * docs(lark-shared): make the identity-continuity kernel resident Omitting --as does not keep the current identity — it hands the choice back to the profile default, and nothing errors when that happens. That silent switch is exactly the class of rule the resident body exists for, so state the kernel in rule 2; the mechanics and examples stay in the identity-and-permissions reference brought in from main. * docs(lark-shared): show full reference filenames in link text Weaker models transcribe the visible link text when deciding what to read, and short aliases made them reconstruct the real filename — a step that misspells. Display the exact filename everywhere so copying the visible text yields a resolvable path. * docs(lark-shared): route --as selection questions to the identity reference The resident body states that identity is workflow state but keeps the selection mechanics in the reference, so an agent asking "which --as here" had no trigger word to match. Name it in the identity row. * docs(lark-shared): distill identity continuity, drop the ACL table State identity continuity as its decision rule — omitting --as hands the choice to the CLI (whoami shows the outcome and why), so spell --as out whenever one identity must persist — instead of restating the resolution chain, whose details belong to the implementation. Route the new trigger word to the reference. Drop the missing-scope vs resource-ACL recovery table: resource-ACL recovery is domain-specific, not a cross-cutting rule, so it does not belong in the shared skill. Update the lark-minutes pointers that named the removed table. * docs(lark-vc): update the last pointer to the removed recovery table Same companion fix as the lark-minutes references: the recording error table pointed readers at the recovery table that left lark-shared, so name the surviving permission-management section instead.	2026-08-17 11:36:31 +08:00
SunPeiYang996	525a98270f	feat(docs): support comments and block mutation ranges (#2341) ... * feat(docs): support comments and block mutation ranges * fix(docs): address CI and review feedback	2026-08-15 00:58:51 +08:00
tianyouskrrr	0c5530dc63	feat(slides): auto-upload @path images in +update-slide (#2346) ... Bring +update-slide in line with +create and +add-slide: <img src="@local"> placeholders in --content are now extracted, validated, uploaded to the target presentation, and rewritten to file_token before the page is replaced. This removes the manual +media-upload round-trip that was tripping agents into passing unresolved local paths to the backend. - Validate rejects missing files and directory placeholders locally, before any API call, and gates docs:document.media:upload as a conditional scope. - Execute uploads once per unique path (deduped) and, on partial failure, appends a progress hint so a retry does not silently re-upload every image. - DryRun plans the upload steps ahead of the replace and reports images_to_upload so the irreversible half is visible up front. - Skill reference documents the placeholder pipeline, CWD resolution, the docs:document.media:upload scope on 1061004/403, and images_uploaded output. The command Description and skill intro stay scoped to WHAT the command does; the @path capability is surfaced through the flag help, Tips, and the reference section rather than restated in the one-line Description or a cross-command note.	2026-08-14 17:59:54 +08:00