mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
Alem Tuzlak
23a3b24a01
Adds real working Shared State (Read+Write) and Sub-Agents demos to 15 showcase integrations, mirroring the canonical langgraph-python and google-adk reference implementations. Fills rows previously empty on the showcase coverage dashboard. Packages: ag2, agno, claude-sdk-python, claude-sdk-typescript, crewai-crews, langgraph-fastapi, langgraph-typescript, langroid, llamaindex, mastra, ms-agent-dotnet, ms-agent-python, pydantic-ai, spring-ai, strands. (built-in-agent landed independently on main as PR #4321 — its variant is canonical; this PR no longer touches it.) Per-package deliverables: framework-native backend agents (preferences-injection middleware/callback + set_notes tool; supervisor + 3 sub-agents wired as tools with running -> completed /failed delegation log); frontend page.tsx + preferences-card.tsx / notes-card.tsx for SSRW and delegation-log.tsx for subagents — wired to useAgent({ updates: [OnStateChanged] }); manifest entries; runtime route registration + per-package agent server config; real QA scripts. Includes targeted hardening fixes from a 7-agent code-review loop: - Sub-agent failure paths now correctly emit status: "failed" (previously hardcoded "completed" or unreachable in mastra/strands/langgraph-fastapi/langgraph-typescript/ag2) - Parallel-tool-call delegation race fixed in langgraph-fastapi (Annotated[list, add]) and langgraph-typescript (concat reducer) - Silent data loss eliminated in claude-sdk-python/claude-sdk-typescript/crewai-crews — empty JSON.parse catches now log + emit error events - ms-agent-dotnet set_notes writes to per-thread slot via AsyncLocal - mastra working-memory writes are deterministic via src/mastra/tools/working-memory.ts helper - spring-ai tool-call envelope ids match supervisor's tc.id() and AG-UI event ordering reordered; CopyOnWriteArrayList for parallel-call safety - Stack trace + raw error message leaks scrubbed across 8+ Next.js routes — log server-side with errorId + return generic envelope - Sub-agent calls no longer block event loops in ag2 (asyncio.to_thread), langroid (llm_response_async), pydantic-ai (async run + async tools) - langroid lru_cache cross-request contamination dropped - Numerous smaller items: claude-sdk-python invalid model id, Callable annotation, /health endpoint exposed; crewai-crews supervisor no longer resets delegations every turn; pydantic-ai snapshot uses model_dump() CI fixes folded in: - crewai-crews test_forwarded_props: extend the stubbed ag_ui_crewai.endpoint module to expose add_crewai_flow_fastapi_endpoint and add stub agents.shared_state_read_write / agents.subagents modules - generate-catalog test: bump crewai-crews wired-cell expectation 28 -> 30; replace hardcoded total-wired count with an invariant (wired + stub + unshipped = 737) plus a lower-bound floor - oxfmt run on the qa/shared-state-read-write.md files in mastra + spring-ai Rebased onto latest main (post showcase/packages -> showcase/integrations rename + post built-in-agent landing). Original blitz history preserved at the blitz-pre-rebase-snapshot tag. Known follow-ups (deferred to follow-up PR): - agno sync sub_agent.run() blocks event loop (perf only) - ms-agent-python asyncio thread-fallback fragility - llamaindex initial-state coercion when UI clears state - Manifest highlight audit (langgraph-typescript headless-complete, langgraph-fastapi byoc-* missing route.ts highlights) - agno hitl-in-chat declared in demos but not features; duplicate /demos/hitl-in-chat route - langgraph-typescript server.mjs graphSpec only registers 3 graphs vs 23 in langgraph.json (pre-existing) - mastra hitl legacy demo missing from features list - claude-sdk-python agents/agent.py line 474 also has the legacy claude-opus-4-5 default - PARITY_NOTES vs manifest mismatches for hitl-in-app across spring-ai/agno/ag2 (pre-existing) - spring-ai a2ui-fixed-schema missing from generative_ui list
75 lines
2.8 KiB
Markdown
75 lines
2.8 KiB
Markdown
# QA: Sub-Agents — AG2
|
|
|
|
## Prerequisites
|
|
|
|
- Demo is deployed and accessible at `/demos/subagents`
|
|
- Agent backend is healthy (check `/api/copilotkit` GET → `agent_status: reachable`)
|
|
- Backend has `OPENAI_API_KEY` set
|
|
- The `subagents` supervisor is mounted at `/subagents` on the FastAPI
|
|
server (see `src/agent_server.py`)
|
|
|
|
## Test Steps
|
|
|
|
### 1. Page renders with delegation log + chat
|
|
|
|
- [ ] Navigate to `/demos/subagents`
|
|
- [ ] Left pane shows the **Delegation log** panel
|
|
(`data-testid="delegation-log"`)
|
|
- [ ] Header reads "Sub-agent delegations" with a counter
|
|
`data-testid="delegation-count"` showing `0 calls`
|
|
- [ ] Empty-state copy: "Ask the supervisor to complete a task. Every
|
|
sub-agent it calls will appear here."
|
|
- [ ] Right pane shows the chat with placeholder
|
|
"Give the supervisor a task..."
|
|
|
|
### 2. Single delegation chain
|
|
|
|
- [ ] Click suggestion **"Write a blog post"** (or send the equivalent
|
|
message).
|
|
- [ ] While the supervisor runs, the badge
|
|
`data-testid="supervisor-running"` ("Supervisor running") appears in
|
|
the header.
|
|
- [ ] As the supervisor delegates, entries appear in the log
|
|
(`data-testid="delegation-entry"`). Expect at least 3 entries — one
|
|
`Research`, one `Writing`, one `Critique` — in that order.
|
|
- [ ] Each entry shows:
|
|
- A `#N` index, a colored badge with the sub-agent name + emoji.
|
|
- A `Task: ...` line summarizing what was delegated.
|
|
- A `result` block containing the sub-agent's output (real LLM text,
|
|
not placeholders).
|
|
- [ ] Counter updates to `3 calls` (or more if the supervisor iterated).
|
|
|
|
### 3. Independent delegations
|
|
|
|
- [ ] Reload the page (state resets).
|
|
- [ ] Send: **"Research what causes the northern lights."**
|
|
- [ ] At least 1 `Research` delegation appears with a bulleted list of
|
|
facts in the result.
|
|
- [ ] Send: **"Now write a paragraph aimed at a 10-year-old, using those
|
|
facts."**
|
|
- [ ] A `Writing` delegation appears with a polished paragraph in the
|
|
result.
|
|
- [ ] Send: **"Critique that paragraph."**
|
|
- [ ] A `Critique` delegation appears with 2-3 actionable critiques.
|
|
|
|
### 4. Supervisor reply hygiene
|
|
|
|
- [ ] After each chain, the supervisor's chat reply is short — it
|
|
summarizes rather than re-pasting the full sub-agent output (which
|
|
already lives in the delegation log).
|
|
- [ ] The "Supervisor running" badge disappears once the run is complete.
|
|
|
|
### 5. Error handling
|
|
|
|
- [ ] Send a very short message (e.g. "Hi"). The supervisor responds
|
|
gracefully (it may not delegate for a trivial greeting).
|
|
- [ ] No console errors during normal usage.
|
|
|
|
## Expected Results
|
|
|
|
- Page loads in < 3 seconds.
|
|
- Each user request that's non-trivial produces at least one delegation
|
|
entry.
|
|
- The delegation log grows live during the run, not just at the end.
|
|
- Sub-agent results are real LLM outputs (not stubbed strings).
|