mirror of
https://github.com/Ar9av/obsidian-wiki.git
synced 2026-09-14 20:36:34 +08:00
Arnav
ea1633a8d4
* fix(tests): isolate CLI subprocess tests, and run the suite in CI
12 tests failed on a clean checkout. Neither was a product bug — both were
test-harness isolation gaps, and CI never caught them because the suite was
never run there.
1. Wrong package under test. The 18 test files that spawn
`python -m obsidian_wiki.cli` each build their own env from
os.environ.copy() and never set PYTHONPATH, so sys.path[0] was the
subprocess cwd. Any test running from a temp dir imported whatever
obsidian_wiki happened to be pip-installed instead of the working tree —
here a stale build predating `code-understand`, so all 8
test_code_understand_cli tests died at argparse with "invalid choice",
plus 4 in test_context_pack_cli. One autouse session fixture in
conftest.py now pins PYTHONPATH for every helper at once.
2. Developer .env leaking in. test_lint's `_run` and test_context_pack's
`run_cli` inherited pytest's cwd (the repo), so config resolution walked
up and found a developer's own untracked .env, pointing the run at their
real vault instead of the fixture. Both now run from the fake HOME.
Verified the fix isn't masking anything: sabotaging the config resolver makes
the relevant tests fail, and the suite passes in a venv with no obsidian_wiki
installed at all — so PYTHONPATH is genuinely doing the work.
Adds .github/workflows/tests.yml to run pytest on PRs and main. The workflows
only ran setup.sh, wheel publish, and the README-sync checker, so nothing
executed tests/ — the real reason this drifted.
Also drops the stale "RED by design / command does not exist yet" docstring
in test_code_understand_cli.py; the wiring landed in fd30720.
566 passed, 1 skipped (was 554 passed / 12 failed).
* fix(tests): make three test modules importable on Python 3.9
test_batch, test_graph_analysis and test_graphrag annotate helpers with
`int | None` / `list[str] | None` but lack `from __future__ import
annotations`, so 3.9 evaluates the union at import time and collection dies
with "unsupported operand type(s) for |". Every module under obsidian_wiki/
already has the future import; only these three tests were missing it.
Surfaced by the new pytest CI job — the 3.9 leg (the requires-python floor)
failed at collection while 3.12 passed.
245 lines
7.2 KiB
Python
245 lines
7.2 KiB
Python
"""Tests for the context-pack CLI."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
def run_cli(
|
|
home: Path, *args: str, cwd: Path | None = None
|
|
) -> subprocess.CompletedProcess[str]:
|
|
env = os.environ.copy()
|
|
env["HOME"] = str(home)
|
|
if cwd is None:
|
|
# Default to the fake HOME, not the repo: config resolution walks up
|
|
# from cwd looking for a `.env`, and a developer's own .env at the repo
|
|
# root would otherwise override the fixture config.
|
|
home.mkdir(parents=True, exist_ok=True)
|
|
cwd = home
|
|
return subprocess.run(
|
|
[sys.executable, "-m", "obsidian_wiki.cli", *args],
|
|
capture_output=True,
|
|
text=True,
|
|
env=env,
|
|
cwd=cwd,
|
|
)
|
|
|
|
|
|
def make_vault(tmp_path: Path) -> Path:
|
|
vault = tmp_path / "vault"
|
|
vault.mkdir()
|
|
(vault / "auth.md").write_text(
|
|
"# Authentication\n\nUse short-lived access tokens.\n",
|
|
encoding="utf-8",
|
|
)
|
|
return vault
|
|
|
|
|
|
def test_context_pack_uses_configured_vault(tmp_path: Path) -> None:
|
|
home = tmp_path / "home"
|
|
vault = make_vault(tmp_path)
|
|
config = home / ".obsidian-wiki" / "config"
|
|
config.parent.mkdir(parents=True)
|
|
config.write_text(f'OBSIDIAN_VAULT_PATH="{vault}"\n', encoding="utf-8")
|
|
|
|
proc = run_cli(home, "context-pack", "authentication", "--budget", "512")
|
|
|
|
assert proc.returncode == 0
|
|
assert "# Agent Context: authentication" in proc.stdout
|
|
assert "auth.md" in proc.stdout
|
|
|
|
|
|
def test_context_pack_prefers_nearest_local_env_vault(tmp_path: Path) -> None:
|
|
home = tmp_path / "home"
|
|
global_vault = tmp_path / "global-vault"
|
|
local_vault = tmp_path / "local-vault"
|
|
global_vault.mkdir()
|
|
local_vault.mkdir()
|
|
(global_vault / "global.md").write_text("# Authentication\n\nGlobal token policy.\n", encoding="utf-8")
|
|
(local_vault / "local.md").write_text("# Authentication\n\nLocal token policy.\n", encoding="utf-8")
|
|
config = home / ".obsidian-wiki" / "config"
|
|
config.parent.mkdir(parents=True)
|
|
config.write_text(f'OBSIDIAN_VAULT_PATH="{global_vault}"\n', encoding="utf-8")
|
|
project = home / "project"
|
|
nested_dir = project / "nested"
|
|
nested_dir.mkdir(parents=True)
|
|
(project / ".env").write_text(f'OBSIDIAN_VAULT_PATH="{local_vault}"\n', encoding="utf-8")
|
|
|
|
proc = run_cli(home, "context-pack", "authentication", cwd=nested_dir)
|
|
|
|
assert proc.returncode == 0
|
|
assert "local.md" in proc.stdout
|
|
assert "global.md" not in proc.stdout
|
|
|
|
|
|
def test_context_pack_stops_at_empty_nearest_local_vault_config(
|
|
tmp_path: Path,
|
|
) -> None:
|
|
home = tmp_path / "home"
|
|
global_vault = tmp_path / "global-vault"
|
|
global_vault.mkdir()
|
|
(global_vault / "global.md").write_text(
|
|
"# Authentication\n\nGlobal token policy.\n",
|
|
encoding="utf-8",
|
|
)
|
|
config = home / ".obsidian-wiki" / "config"
|
|
config.parent.mkdir(parents=True)
|
|
config.write_text(
|
|
f'OBSIDIAN_VAULT_PATH="{global_vault}"\n',
|
|
encoding="utf-8",
|
|
)
|
|
project = home / "project"
|
|
nested_dir = project / "nested"
|
|
nested_dir.mkdir(parents=True)
|
|
(project / ".env").write_text(
|
|
"OBSIDIAN_VAULT_PATH=\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
proc = run_cli(home, "context-pack", "authentication", cwd=nested_dir)
|
|
|
|
assert proc.returncode == 1
|
|
assert "vault not configured" in proc.stderr
|
|
assert "global.md" not in proc.stdout
|
|
|
|
|
|
def test_context_pack_explicit_vault_wins_over_local_and_global_config(
|
|
tmp_path: Path,
|
|
) -> None:
|
|
home = tmp_path / "home"
|
|
explicit_vault = tmp_path / "explicit-vault"
|
|
local_vault = tmp_path / "local-vault"
|
|
global_vault = tmp_path / "global-vault"
|
|
for vault, filename, detail in (
|
|
(explicit_vault, "explicit.md", "Explicit token policy."),
|
|
(local_vault, "local.md", "Local token policy."),
|
|
(global_vault, "global.md", "Global token policy."),
|
|
):
|
|
vault.mkdir()
|
|
(vault / filename).write_text(
|
|
f"# Authentication\n\n{detail}\n",
|
|
encoding="utf-8",
|
|
)
|
|
config = home / ".obsidian-wiki" / "config"
|
|
config.parent.mkdir(parents=True)
|
|
config.write_text(
|
|
f'OBSIDIAN_VAULT_PATH="{global_vault}"\n',
|
|
encoding="utf-8",
|
|
)
|
|
project = home / "project"
|
|
project.mkdir(parents=True)
|
|
(project / ".env").write_text(
|
|
f'OBSIDIAN_VAULT_PATH="{local_vault}"\n',
|
|
encoding="utf-8",
|
|
)
|
|
|
|
proc = run_cli(
|
|
home,
|
|
"context-pack",
|
|
"authentication",
|
|
"--vault",
|
|
str(explicit_vault),
|
|
cwd=project,
|
|
)
|
|
|
|
assert proc.returncode == 0
|
|
assert "explicit.md" in proc.stdout
|
|
assert "local.md" not in proc.stdout
|
|
assert "global.md" not in proc.stdout
|
|
|
|
|
|
def test_context_pack_empty_explicit_vault_never_falls_through_to_config(
|
|
tmp_path: Path,
|
|
) -> None:
|
|
home = tmp_path / "home"
|
|
local_vault = tmp_path / "local-vault"
|
|
global_vault = tmp_path / "global-vault"
|
|
for vault, filename in (
|
|
(local_vault, "local.md"),
|
|
(global_vault, "global.md"),
|
|
):
|
|
vault.mkdir()
|
|
(vault / filename).write_text(
|
|
"# Authentication\n\nConfigured token policy.\n",
|
|
encoding="utf-8",
|
|
)
|
|
config = home / ".obsidian-wiki" / "config"
|
|
config.parent.mkdir(parents=True)
|
|
config.write_text(
|
|
f'OBSIDIAN_VAULT_PATH="{global_vault}"\n',
|
|
encoding="utf-8",
|
|
)
|
|
project = home / "project"
|
|
project.mkdir(parents=True)
|
|
(project / ".env").write_text(
|
|
f'OBSIDIAN_VAULT_PATH="{local_vault}"\n',
|
|
encoding="utf-8",
|
|
)
|
|
|
|
proc = run_cli(
|
|
home,
|
|
"context-pack",
|
|
"authentication",
|
|
"--vault",
|
|
"",
|
|
cwd=project,
|
|
)
|
|
|
|
assert proc.returncode == 1
|
|
assert "vault not configured" in proc.stderr
|
|
assert "local.md" not in proc.stdout
|
|
assert "global.md" not in proc.stdout
|
|
|
|
|
|
def test_context_alias_and_explicit_vault_emit_json(tmp_path: Path) -> None:
|
|
home = tmp_path / "home"
|
|
vault = make_vault(tmp_path)
|
|
|
|
proc = run_cli(
|
|
home,
|
|
"context",
|
|
"authentication",
|
|
"--vault",
|
|
str(vault),
|
|
"--json",
|
|
"--pretty",
|
|
)
|
|
|
|
assert proc.returncode == 0
|
|
data = json.loads(proc.stdout)
|
|
assert data["schema_version"] == 1
|
|
assert data["content_trust"] == "untrusted_reference_data"
|
|
assert data["estimated_tokens"] <= data["budget_tokens"]
|
|
assert data["pages"][0]["path"] == "auth.md"
|
|
|
|
|
|
def test_recent_mode_does_not_require_topic(tmp_path: Path) -> None:
|
|
home = tmp_path / "home"
|
|
vault = make_vault(tmp_path)
|
|
|
|
proc = run_cli(home, "context-pack", "--vault", str(vault), "--recent")
|
|
|
|
assert proc.returncode == 0
|
|
assert "# Agent Context: Recent Activity" in proc.stdout
|
|
|
|
|
|
def test_topic_is_required_without_recent(tmp_path: Path) -> None:
|
|
home = tmp_path / "home"
|
|
vault = make_vault(tmp_path)
|
|
|
|
proc = run_cli(home, "context-pack", "--vault", str(vault))
|
|
|
|
assert proc.returncode == 1
|
|
assert "topic is required" in proc.stderr
|
|
|
|
|
|
def test_context_pack_requires_a_configured_vault(tmp_path: Path) -> None:
|
|
proc = run_cli(tmp_path / "home", "context-pack", "authentication")
|
|
|
|
assert proc.returncode == 1
|
|
assert "vault not configured" in proc.stderr
|