mirror of
https://github.com/angular/angular.git
synced 2026-09-14 13:54:52 +08:00
58e55495f2
The Router constructor and `setupRouter` factory mainly exist as a legacy configuration. Since the Router's creation, the style in Angular has evolved quite a bit. This commit eliminates and cleans up some unnecessary comlicated code paths related to the router constructor/factory. Note that there are edits to the `setupTestingRouter` that could be seen as breaking. However, it is not for several reasons: 1. The function is documented as a factory function. If used as documented, the parameters should match what's available in DI 2. The function is totally unused by the Router itself and is not used in g3 either. I believe it was made publicApi by an error when updating documentation annotations long ago. PR Close #48313
public-api/
This directory contains all of the public api goldens for our npm packages we publish to NPM. These are tested on all PRs and commits as part of our bazel tests.
To check or update the public api goldens, run one of the following commands:
yarn public-api:check
yarn public-api:update
packages-circular-deps.json
This golden file contains a list of all circular dependencies in the project. As part of the lint CI job we compare the current circular dependencies against this golden to ensure that we don't add more cycles. If cycles have been fixed, this file is also updated so that we can slowly burn down the number of cycles in the project.
To check or update the golden, run the following commands:
yarn ts-circular-deps:check
yarn ts-circular-deps:approve