2429 Commits

Author SHA1 Message Date
Alex Eagle 4dc066b979 docs(aio): add missing mentors for collaborators (#29142)
Also improve the presentation of the org chart

PR Close #29142
2019-04-11 08:06:19 -07:00
Alex Eagle 71c1446def docs(aio): add globegitter to Angular collaborators (#29142)
PR Close #29142
2019-04-11 08:06:19 -07:00
Alan Agius 19fe45dfdc docs: update path mappings and exports (#29810)
1) Path mappings are to be added in the workspace tsconfig files, hence the path needs to be `./` and not `../`
2) Fix export symbol as it cannot contain `-`

Fixes #29807

PR Close #29810
2019-04-10 12:17:32 -07:00
Santosh Yadav 42b7f8525b docs: redirect to schematics-for-libraries (#29780)
Fixes #29778

PR Close #29780
2019-04-10 12:16:48 -07:00
Trevor Karjanis 7f1c5f6248 docs: fix grammatical errors in the style guide (#29769)
Fix grammatical errors in the Style Guide.

There is no associated issue.

PR Close #29769
2019-04-10 12:16:31 -07:00
Trevor Karjanis 7089c20ce5 docs: fix a grammatical error in the building and serving documentation (#29768)
Fix a grammatical error in the building and serving documentation.

There is no associated issue.

PR Close #29768
2019-04-10 12:16:15 -07:00
hateonion b9609020f6 docs: fix incorrect header on custom event docs (#29784)
PR Close #29784
2019-04-09 12:24:00 -07:00
Renan Montebelo ea0f031995 docs(core): DI module-level info fix (#29756)
PR Close #29756
2019-04-09 12:23:44 -07:00
jenniferfell 2e1fc36c4e docs: update release schedule and examples of release numbers (#29714)
PR Close #29714
2019-04-09 12:23:28 -07:00
jenniferfell 47c486860e docs: update authors style guide to highlight related guidelines and position these guidelines (#28481)
PR Close #28481
2019-04-09 12:23:10 -07:00
Andrew Seguin 77ee22eb6e docs: typo fix, change "insure" to "ensure" (#29737)
PR Close #29737
2019-04-08 17:18:49 -07:00
George Kalpakas 895b0454f8 refactor(docs-infra): rename properties (blacklisted --> ignored) (#29754)
PR Close #29754
2019-04-08 09:46:35 -07:00
George Kalpakas 8febb5ac55 build(docs-infra): do not include announcements.json in sitemap (#29754)
The `announcements.json` file should not be included in the sitemap and
including it causes an error in Google Search Console (because the
generated URL does not exist).

(This is a follow-up to fbef94a8e.)

PR Close #29754
2019-04-08 09:46:35 -07:00
Brandon c15b223001 docs: add schematics guide (patch) (#29666)
PR Close #29666
2019-04-04 15:56:03 -07:00
Judy Bogart e483078d6f docs: add universal terms to glossary (#28492)
PR Close #28492
2019-04-04 14:26:38 -07:00
Pete Bacon Darwin 29481a17b1 test(docs-infra): fix eslint warnings (#29673)
```
warning  An "it" that uses an async method should handle failure (use "done.fail")  jasmine/no-promise-without-done-fail
```

PR Close #29673
2019-04-04 10:52:39 -07:00
Pete Bacon Darwin 09b374c92c build(docs-infra): support doc aliases via @alias dgeni tag (#29673)
Now, one can add an `@alias` tag to API docs, which tells dgeni that this
API element (usually a `const`) is really just an alias for some API element
defined elsewhere.

Dgeni will then look up this API element and copy over the properties from
the alias to the current doc.

For example, we would like to privately export an Enum from `@angular/core`
but then publicly export this from `@angular/common`:

**packages/core/private_exports.ts**

```ts
/**
 * Description of this document.
 */
export enum ɵSomeEnum { ... }
```

**packages/common/public_api.ts**

```ts
import {ɵSomeEnum} from '@angular/core';

 /**
 * @alias core/ɵSomeEnum
 */
export const SomeEnum = ɵSomeEnum;
```

In the generated docs there will be a page for `common/SomeEnum`, which
will be rendered as an enum, rather than a const, showing the description
extracted from the `core/ɵSomeEnum`.

---

The implementation of this feature required some refactoring of the other
processing:

1. Previously `ɵ` prefixed exports were not even considered.
2. Due to 1. some processors needed to have guards added to ignore such
   private exports (`addMetadataAliases` and `checkContentRules`).
3. The processing of package pages had to be reworked (and split) so that
   it picked up the aliased export docs after their alias proeprties had
   been copied.

See FW-1207, FW-632, #29249

PR Close #29673
2019-04-04 10:52:38 -07:00
Pete Bacon Darwin 3f6b279033 style(docs-infra): fix typo (#29673)
PR Close #29673
2019-04-04 10:52:38 -07:00
zverbeta 588a3ed79d docs: add ibm carbon ui library (#29706)
PR Close #29706
2019-04-04 10:50:07 -07:00
Dave 0930820748 docs: add angular.de to the workshops page (#28856)
undo unrelated whitespace change

PR Close #28856
2019-04-03 15:39:21 -07:00
Maxime Lafarie 96ff4971f2 docs: add ngx-smart-modal to doc resources (#29661)
PR Close #29661
2019-04-03 15:36:30 -07:00
Stephen Fluin c9b9be6c2e docs: update announcements for home page (#29671)
Updated dates, add tracking to links

PR Close #29671
2019-04-03 15:36:04 -07:00
Vani ec4dced523 docs: update examples region to match the description in the guide (#29259)
PR Close #29259
2019-04-02 16:09:20 -07:00
Kara 69786c2814 docs: add Deborah Kurata to Trusted Collaborators (#29605)
This commit adds Deborah to the Trusted Collaborators list, so she will appear in the Collaborators list on angular.io.
PR Close #29605
2019-04-02 15:53:49 -07:00
Pete Bacon Darwin 50bcaa6f5b refactor(upgrade): use Bazel packages to avoid symlinks in the source (#29656)
Previously we had to share code between upgrade/dynamic and upgrade/static
by symlinking the `src` folder, which allowed both packages to access
the upgrade/common files.

These symlinks are always problematic on Windows, where we had to run
a script to re-link them, and restore them.

This change uses Bazel packages to share the `upgrade/common` code,
which avoids the need for symlinking the `src` folder.

Also, the Windows specific scripts that fixup the symlinks have also
been removed as there is no more need for them.

PR Close #29656
2019-04-02 10:54:34 -07:00
Emilie Huet 6bf8e37827 docs: add info regarding injecting custom pipes (#28291)
Indicate that a pipe also needs to be included in the providers array

PR Close #28291
2019-04-02 10:38:38 -07:00
George Kalpakas 3580a6c986 fix(docs-infra): fix scroll position restoration error in ScrollService (#29658)
Based on Google Analytics error report, the following error happens
occasionally (15% or total errors for 2019-03):

```
Cannot read property '0' of null TypeError: at t.scrollToPosition@main.js
```

This was a result of calling [ViewportScroller#scrollToPosition()][1]
with `null`, which in turn happens when calling
[ScrollService#scrollToPosition()][2] while `this.scrollPosition` is
`null`. This can be a result of a `popstate` event without an associated
history state.

This commit fixes the error by checking whether `this.scrollPosition` is
`null`, before using it with `scrollToPosition()`.

(It also refactors away the unneeded internal `popStateFired` property.)

[1]: https://github.com/angular/angular/blob/deca6a60d/packages/common/src/viewport_scroller.ts#L101-L105
[2]: https://github.com/angular/angular/blob/deca6a60d/aio/src/app/shared/scroll.service.ts#L158-L161

PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas 67e9812c14 perf(docs-infra): avoid unnecessary JSON parsing in ScrollService (#29658)
PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas 61b08629fd refactor(docs-infra): minor clean-up of ScrollService (#29658)
PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas d727561c5e test(docs-infra): avoid click-related CI flake in e2e test (#29641)
One of the tests introduced in #29601 is susceptible to a kind of
WebDriver flake related to trying to click elements hidden behind fixed
positioned elements.
This commit works around the issue by clicking the elements directly
using JavaScript (instead of `WebElement#click()`).

PR Close #29641
2019-04-01 16:18:05 -07:00
Judy Bogart ab72e06cde docs: add custom-element ref to library overview (#28476)
PR Close #28476
2019-04-01 12:04:08 -07:00
Martin Ockovsky e8b00ec404 docs: add missing window key shortcut to language service guide (#29613)
PR Close #29613
2019-04-01 11:28:14 -07:00
Jorge Cano 94b0e8f288 docs: update Jorge Cano GDE bio (#29622)
PR Close #29622
2019-04-01 11:26:41 -07:00
George Kalpakas 157b948e6b test(docs-infra): add e2e test for the contributors page (#29601)
Previously, if the shape of data in `contributors.json` was incorrect,
there would be a runtime error (when trying to parse the data), which
would result in a blank page. The likelihood for this happening is
higher after #29553, where the shape of data changed.

This commit adds some basic e2e tests that verify the page works as
expected and there are contributors listed.

PR Close #29601
2019-04-01 11:24:44 -07:00
George Kalpakas 7b9d62b2ed docs: use smaller image for Jason Bedard (since it was already available) (#29601)
PR Close #29601
2019-04-01 11:24:43 -07:00
George Kalpakas a52123f538 docs: add missing picture of Jason Bedard (#29596)
Related to #29141.

PR Close #29596
2019-04-01 11:00:38 -07:00
George Kalpakas 572a5e4bd3 build(docs-infra): remove unused PhantomJS dependency (#29611)
PhantomJS is [not being developed any more][1] and with modern
alternatives (such as Chrome headless) there is no reason to keep it as
a dependency.

[1]: https://github.com/ariya/phantomjs/issues/15344

PR Close #29611
2019-04-01 10:57:32 -07:00
Amit Chaurasia 601fae944d docs: added complete path to the spec file (#29621)
PR Close #29621
2019-04-01 10:54:31 -07:00
Roland Rytz d46f1f28e2 docs: fix typo in description of angular.io/index.html (#29630)
change "compeling" to "compelling" in description meta tag

PR Close #29630
2019-04-01 10:54:10 -07:00
George Kalpakas a2df6031ad build(docs-infra): add check to ensure all contributor pictures exist (#29553)
PR Close #29553
2019-03-29 11:01:48 -07:00
George Kalpakas 542b7cd925 docs: add Sam Julien to GDE group as well (#29553)
PR Close #29553
2019-03-29 11:01:48 -07:00
George Kalpakas ce1b741255 feat(docs-infra): support contributors belonging to multiple groups (#29553)
PR Close #29553
2019-03-29 11:01:48 -07:00
George Kalpakas 4a1b4f17ae refactor(docs-infra): change unused classes to interfaces (#29553)
PR Close #29553
2019-03-29 11:01:48 -07:00
George Kalpakas 7ea8985500 docs: change the order of groups in contributors page (#29553)
Put "Collaborators" before "GDE", since they are semantically closer to
the core team.

PR Close #29553
2019-03-29 11:01:47 -07:00
George Kalpakas eefae6d96d docs: change heading of contributors page to avoid confusion (Collaborators --> Contributors) (#29553)
Now that "Collaborators" is a separate group in the contributors page,
having "Angular Collaborators" as the heading of the page (which also
contains the "Angular" and "GDE" groups) is confusing.
Changing the title to "Angular Contributors" to avoid confusion.

PR Close #29553
2019-03-29 11:01:47 -07:00
George Kalpakas 9f430f0ad9 docs: change contributor group name (Collaborator --> Collaborators) (#29553)
The name of the group also serves as the group tab's title in the docs
app and having "Collaborator" (singular) as a title for a list of people
didn't read well.
Changing th group name (and thus tab title) to "Collaborators" (plural).

PR Close #29553
2019-03-29 11:01:47 -07:00
Vani 6d7a4ff45e docs: move text that mention what is expected to fail up higher into the section (#27329)
PR Close #27329
2019-03-29 10:30:29 -07:00
Kapunahele Wong cfa6ab1910 docs: remove coremodule references (#28434)
PR Close #28434
2019-03-29 10:29:52 -07:00
Jun 2f930a5d44 docs(service-worker): add info about no network request for performance strategy (#29288)
PR Close #29288
2019-03-29 10:28:47 -07:00
javatutorials2016 d9b1136ba4 docs: add note about ngModel usage in structural directives guide (#29522)
When I tried one of the examples provided in the documention, encountered the " Can't bind to 'ngModel' since it isn't a known property of 'select' ” error. So to resolve it I imported the FormsModule in ngModule. If it is mentioned in the documentation, it would be handy for the beginners to try and learn. Thanks for considering.

Duplicate of pull Request# 29206, As I encountered few issues after multiple authors corrected, So I am creating the new pull request

PR Close #29522
2019-03-29 10:26:16 -07:00