12990 Commits

Author SHA1 Message Date
Alex Rickabaugh 3e992e18eb release: cut the v7.2.13 release 7.2.13 2019-04-12 11:51:08 -07:00
George Kalpakas d801941266 ci: correctly detect status 400 as failure in get-commit-range (#29839)
PR Close #29839
2019-04-11 08:20:27 -07:00
Alex Eagle 4dc066b979 docs(aio): add missing mentors for collaborators (#29142)
Also improve the presentation of the org chart

PR Close #29142
2019-04-11 08:06:19 -07:00
Alex Eagle 71c1446def docs(aio): add globegitter to Angular collaborators (#29142)
PR Close #29142
2019-04-11 08:06:19 -07:00
Peter Johan Salomonsen ca14509bfe fix(platform-browser): insert APP_ID in styles, contentAttr and hostAttr (#17745)
PR Close #17745
2019-04-11 07:59:23 -07:00
Alan Agius 19fe45dfdc docs: update path mappings and exports (#29810)
1) Path mappings are to be added in the workspace tsconfig files, hence the path needs to be `./` and not `../`
2) Fix export symbol as it cannot contain `-`

Fixes #29807

PR Close #29810
2019-04-10 12:17:32 -07:00
Santosh Yadav 42b7f8525b docs: redirect to schematics-for-libraries (#29780)
Fixes #29778

PR Close #29780
2019-04-10 12:16:48 -07:00
Trevor Karjanis 7f1c5f6248 docs: fix grammatical errors in the style guide (#29769)
Fix grammatical errors in the Style Guide.

There is no associated issue.

PR Close #29769
2019-04-10 12:16:31 -07:00
Trevor Karjanis 7089c20ce5 docs: fix a grammatical error in the building and serving documentation (#29768)
Fix a grammatical error in the building and serving documentation.

There is no associated issue.

PR Close #29768
2019-04-10 12:16:15 -07:00
hateonion b9609020f6 docs: fix incorrect header on custom event docs (#29784)
PR Close #29784
2019-04-09 12:24:00 -07:00
Renan Montebelo ea0f031995 docs(core): DI module-level info fix (#29756)
PR Close #29756
2019-04-09 12:23:44 -07:00
jenniferfell 2e1fc36c4e docs: update release schedule and examples of release numbers (#29714)
PR Close #29714
2019-04-09 12:23:28 -07:00
jenniferfell 47c486860e docs: update authors style guide to highlight related guidelines and position these guidelines (#28481)
PR Close #28481
2019-04-09 12:23:10 -07:00
Andrew Seguin 77ee22eb6e docs: typo fix, change "insure" to "ensure" (#29737)
PR Close #29737
2019-04-08 17:18:49 -07:00
Frederik Prijck 8c0c689338 docs(router): use pipe in activatedRoute example (#29752)
Copying the example, mentioned at Activated Route (https://angular.io/api/router/ActivatedRoute), to Stackblitz doesn't compile: https://stackblitz.com/edit/angular-x7pbeb?

That's because the example does not use .pipe.

I've updated the example to include `pipe`.
PR Close #29752
2019-04-08 17:18:08 -07:00
Alex Eagle f971f83f06 ci: simplify RBE execution (#29731)
Run all targets with RBE config. Previously we filtered out one target, //tools/ts-api-guardian:tests, and ran that with a different bazelrc

PR Close #29731
2019-04-08 12:03:55 -07:00
George Kalpakas 895b0454f8 refactor(docs-infra): rename properties (blacklisted --> ignored) (#29754)
PR Close #29754
2019-04-08 09:46:35 -07:00
George Kalpakas 8febb5ac55 build(docs-infra): do not include announcements.json in sitemap (#29754)
The `announcements.json` file should not be included in the sitemap and
including it causes an error in Google Search Console (because the
generated URL does not exist).

(This is a follow-up to fbef94a8e.)

PR Close #29754
2019-04-08 09:46:35 -07:00
Rado Kirov 7d6d4c436c refactor: uniformly access all index sigs with index access. (#29390)
Follow-up to https://github.com/angular/angular/pull/28937

A build-time check to enforce this is part of tsetse -
https://tsetse.info/property-renaming-safe but I don't know how to turn
it on for this repositories bazel builds.

PR Close #29390
2019-04-05 09:34:27 -07:00
Brandon c15b223001 docs: add schematics guide (patch) (#29666)
PR Close #29666
2019-04-04 15:56:03 -07:00
Judy Bogart 1423cc0ad2 docs: correct route path description (#29669)
PR Close #29669
2019-04-04 15:41:00 -07:00
Judy Bogart e483078d6f docs: add universal terms to glossary (#28492)
PR Close #28492
2019-04-04 14:26:38 -07:00
Pete Bacon Darwin 29481a17b1 test(docs-infra): fix eslint warnings (#29673)
```
warning  An "it" that uses an async method should handle failure (use "done.fail")  jasmine/no-promise-without-done-fail
```

PR Close #29673
2019-04-04 10:52:39 -07:00
Pete Bacon Darwin 09b374c92c build(docs-infra): support doc aliases via @alias dgeni tag (#29673)
Now, one can add an `@alias` tag to API docs, which tells dgeni that this
API element (usually a `const`) is really just an alias for some API element
defined elsewhere.

Dgeni will then look up this API element and copy over the properties from
the alias to the current doc.

For example, we would like to privately export an Enum from `@angular/core`
but then publicly export this from `@angular/common`:

**packages/core/private_exports.ts**

```ts
/**
 * Description of this document.
 */
export enum ɵSomeEnum { ... }
```

**packages/common/public_api.ts**

```ts
import {ɵSomeEnum} from '@angular/core';

 /**
 * @alias core/ɵSomeEnum
 */
export const SomeEnum = ɵSomeEnum;
```

In the generated docs there will be a page for `common/SomeEnum`, which
will be rendered as an enum, rather than a const, showing the description
extracted from the `core/ɵSomeEnum`.

---

The implementation of this feature required some refactoring of the other
processing:

1. Previously `ɵ` prefixed exports were not even considered.
2. Due to 1. some processors needed to have guards added to ignore such
   private exports (`addMetadataAliases` and `checkContentRules`).
3. The processing of package pages had to be reworked (and split) so that
   it picked up the aliased export docs after their alias proeprties had
   been copied.

See FW-1207, FW-632, #29249

PR Close #29673
2019-04-04 10:52:38 -07:00
Pete Bacon Darwin 3f6b279033 style(docs-infra): fix typo (#29673)
PR Close #29673
2019-04-04 10:52:38 -07:00
Paul Gschwendtner b4c77d551b build: add render3 entry-point to legacy test systemjs config (#29675)
Until the legacy job has been migrated to Bazel w/ Saucelabs, we
need to add the `render3` entry-point to the test SystemJS configuration
so that developers don't get inconsistent behavior between Bazel tests
and the legacy tests. e.g. https://circleci.com/gh/angular/angular/270102

PR Close #29675
2019-04-04 10:52:13 -07:00
zverbeta 588a3ed79d docs: add ibm carbon ui library (#29706)
PR Close #29706
2019-04-04 10:50:07 -07:00
Alex Eagle 9e33dc3e6a fix(bazel): use //:tsconfig.json as the default for ng_module (#29670) (#29711)
This matches the behavior of ts_library

PR Close #29670

PR Close #29711
2019-04-04 10:49:35 -07:00
Dave 0930820748 docs: add angular.de to the workshops page (#28856)
undo unrelated whitespace change

PR Close #28856
2019-04-03 15:39:21 -07:00
Maxime Lafarie 96ff4971f2 docs: add ngx-smart-modal to doc resources (#29661)
PR Close #29661
2019-04-03 15:36:30 -07:00
Stephen Fluin c9b9be6c2e docs: update announcements for home page (#29671)
Updated dates, add tracking to links

PR Close #29671
2019-04-03 15:36:04 -07:00
RudarDaman 736afea5f1 docs: remove trailing comma in BAZEL.md (#29682)
PR Close #29682
2019-04-03 15:30:22 -07:00
Jason Aden a14dc2d7a4 release: cut the v7.2.12 release 7.2.12 2019-04-03 13:27:46 -07:00
Vani a357daeaf7 docs: update location API docs (#27010)
PR Close #27010
2019-04-02 16:11:29 -07:00
Vani ec4dced523 docs: update examples region to match the description in the guide (#29259)
PR Close #29259
2019-04-02 16:09:20 -07:00
Kara 69786c2814 docs: add Deborah Kurata to Trusted Collaborators (#29605)
This commit adds Deborah to the Trusted Collaborators list, so she will appear in the Collaborators list on angular.io.
PR Close #29605
2019-04-02 15:53:49 -07:00
Pete Bacon Darwin 50bcaa6f5b refactor(upgrade): use Bazel packages to avoid symlinks in the source (#29656)
Previously we had to share code between upgrade/dynamic and upgrade/static
by symlinking the `src` folder, which allowed both packages to access
the upgrade/common files.

These symlinks are always problematic on Windows, where we had to run
a script to re-link them, and restore them.

This change uses Bazel packages to share the `upgrade/common` code,
which avoids the need for symlinking the `src` folder.

Also, the Windows specific scripts that fixup the symlinks have also
been removed as there is no more need for them.

PR Close #29656
2019-04-02 10:54:34 -07:00
Emilie Huet 6bf8e37827 docs: add info regarding injecting custom pipes (#28291)
Indicate that a pipe also needs to be included in the providers array

PR Close #28291
2019-04-02 10:38:38 -07:00
Ben Lesh 91f2b1e4d7 refactor(platform-browser): rename _singleTagWhitelist (#29592)
PR Close #29592
2019-04-02 10:37:30 -07:00
Ben Lesh c7075fe710 refactor(compiler): rename INTERPOLATION_BLACKLIST_REGEXPS (#29593)
PR Close #29593
2019-04-02 10:36:28 -07:00
Ben Lesh e2e0be4ac6 refactor: change error message (#29594)
Removes usage of whitelist from error messages, comments and test descriptions in ts_api_guardian

Related to #28539

PR Close #29594
2019-04-02 10:29:34 -07:00
Ben Lesh f6864cce91 refactor(compiler): update docs (#29599)
PR Close #29599
2019-04-02 10:28:53 -07:00
Ben Lesh ef038e8060 refactor(core): update docs (#29600)
PR Close #29600
2019-04-02 10:28:24 -07:00
George Kalpakas 3580a6c986 fix(docs-infra): fix scroll position restoration error in ScrollService (#29658)
Based on Google Analytics error report, the following error happens
occasionally (15% or total errors for 2019-03):

```
Cannot read property '0' of null TypeError: at t.scrollToPosition@main.js
```

This was a result of calling [ViewportScroller#scrollToPosition()][1]
with `null`, which in turn happens when calling
[ScrollService#scrollToPosition()][2] while `this.scrollPosition` is
`null`. This can be a result of a `popstate` event without an associated
history state.

This commit fixes the error by checking whether `this.scrollPosition` is
`null`, before using it with `scrollToPosition()`.

(It also refactors away the unneeded internal `popStateFired` property.)

[1]: https://github.com/angular/angular/blob/deca6a60d/packages/common/src/viewport_scroller.ts#L101-L105
[2]: https://github.com/angular/angular/blob/deca6a60d/aio/src/app/shared/scroll.service.ts#L158-L161

PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas 67e9812c14 perf(docs-infra): avoid unnecessary JSON parsing in ScrollService (#29658)
PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas 61b08629fd refactor(docs-infra): minor clean-up of ScrollService (#29658)
PR Close #29658
2019-04-02 10:26:51 -07:00
George Kalpakas d727561c5e test(docs-infra): avoid click-related CI flake in e2e test (#29641)
One of the tests introduced in #29601 is susceptible to a kind of
WebDriver flake related to trying to click elements hidden behind fixed
positioned elements.
This commit works around the issue by clicking the elements directly
using JavaScript (instead of `WebElement#click()`).

PR Close #29641
2019-04-01 16:18:05 -07:00
cexbrayat 39ecc7b5b6 docs: improve formatDate description (#29632)
PR #29289 reworded the description, making it less obvious that the value to format can be a `Date`.

PR Close #29632
2019-04-01 15:14:51 -07:00
Yun Peng 23f0a04387 build: Remove --watchfs from bazelrc file (#29635)
--watchfs is causing the build to be flaky on Windows because Bazel
doesn't have proper support for watchfs on Windows, but it doesn't seem
to bring much performance on Linux, either.

Fixes: https://github.com/angular/angular/issues/29541

PR Close #29635
2019-04-01 14:58:05 -07:00
Jason Aden e884c0cd7b fix(router): adjust setting navigationTransition when a new navigation cancels an existing one (#29636)
Prior to this change, if a navigation was ongoing and a new one came in, the router could get into a state where `router.currentNavigation` was `null` even though a navigation was executing. This change moves where we set the `currentNavigation` value so it's inside a `switchMap`. This solves the problem because the `finally` on the `switchMap` had been setting `currentNavigation` to `null` but the new `currentNavigation` value would have already been set. Essentially this was a timing problem and is resolved with this change.

Fixes #29389 #29590

PR Close #29636
2019-04-01 12:11:57 -07:00