Files
ragflow/internal/entity/models/minimax_test.go
Jack 2f99d52fb5 fix(ci): re-enable Go tests and fix compilation errors after ListModels signature change (#15862)
## Summary

This PR re-enables the Go test steps in CI that were previously
commented out, and fixes all compilation errors that have accumulated in
`internal/entity/models/` since the `ListModels` return type was changed
from `[]string` to `[]ListModelResponse`.

## Changes

### CI (`.github/workflows/tests.yml`)
- Re-enable **Prepare test resources** step (clones resource repo with
WordNet data)
- Re-enable **Test Go packages** step (runs `go test ./internal/...`)
- Fix resource path race condition by using
`/tmp/resource-${GITHUB_RUN_ID}` instead of `/tmp/resource`
- Exclude `/cli` package from Go tests (contains `main` redeclarations)

### Test fixes (16 model provider test files)
All errors were caused by the upstream change from `[]string` to
`[]ListModelResponse` in the `ListModels` interface:

- Add `joinModelNames` test helper to extract `.Name` from
`[]ListModelResponse` slices
- `strings.Join(models, ",")` → `joinModelNames(models, ",")` (11 files)
- `ids[i] != "..."` → `ids[i].Name != "..."` (cometapi, mistral)
- `got[i] != want[i]` → `got[i].Name != want[i]` (bedrock)
- `[]string` return types → `[]ListModelResponse` (google)

### Pre-existing bugs in model_test.go
Bugs introduced by the upstream `entity/` → `entity/models/` directory
rename:

- Add missing `pm := GetProviderManager()` calls in 3 test functions
- Fix `InitProviderManager` signature (`_, err :=` → `err :=`)
- Fix `MaxTokens` `*int` dereference (6 comparisons)
- Fix `readProviderConfig` relative path (3 levels up instead of 2)

### model.go
- Add `findRepoRoot()` to make `conf/all_models.json` resolution work
from any CWD, fixing `TestSiliconFlowProviderConfigLoadsLatestProModels`

### Test validation

```bash
go build ./internal/...      # 
go test ./internal/entity/models/... -count=1  #  all pass
```

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-09 21:12:15 +08:00

358 lines
10 KiB
Go

package models
import (
"encoding/json"
"io"
"net/http"
"net/http/httptest"
"strings"
"testing"
)
func newMinimaxServer(t *testing.T, handler func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter)) *httptest.Server {
t.Helper()
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if got := r.Header.Get("Authorization"); got != "Bearer test-key" {
t.Errorf("expected Authorization=Bearer test-key, got %q", got)
return
}
var body map[string]interface{}
if r.Method == http.MethodPost {
if got := r.Header.Get("Content-Type"); !strings.HasPrefix(got, "application/json") {
t.Errorf("expected Content-Type to start with application/json, got %q", got)
return
}
raw, err := io.ReadAll(r.Body)
if err != nil {
t.Errorf("read body: %v", err)
return
}
if err := json.Unmarshal(raw, &body); err != nil {
t.Errorf("unmarshal: %v\nraw=%s", err, string(raw))
return
}
} else {
if r.ContentLength > 0 {
t.Errorf("expected %s request without body, ContentLength=%d", r.Method, r.ContentLength)
return
}
raw, err := io.ReadAll(r.Body)
if err != nil {
t.Errorf("read body: %v", err)
return
}
if len(raw) != 0 {
t.Errorf("expected %s request without body, got %q", r.Method, string(raw))
return
}
}
handler(t, r, body, w)
}))
}
func newMinimaxForTest(baseURL string) *MinimaxModel {
return NewMinimaxModel(
map[string]string{"default": baseURL},
URLSuffix{
Chat: "v1/text/chatcompletion_v2",
Models: "v1/models",
Files: "v1/files/list",
},
)
}
func TestMinimaxNewInstancePreservesConfig(t *testing.T) {
model := NewMinimaxModel(
map[string]string{"default": "http://old.example"},
URLSuffix{Chat: "chat", Models: "models"},
)
instance, ok := model.NewInstance(map[string]string{"default": "http://new.example"}).(*MinimaxModel)
if !ok {
t.Fatalf("NewInstance type=%T, want *MinimaxModel", instance)
}
if instance.baseModel.BaseURL["default"] != "http://new.example" {
t.Errorf("BaseURL=%q", instance.baseModel.BaseURL["default"])
}
if instance.baseModel.URLSuffix.Chat != "chat" || instance.baseModel.URLSuffix.Models != "models" {
t.Errorf("URLSuffix=%+v", instance.baseModel.URLSuffix)
}
if instance.baseModel.httpClient == nil {
t.Error("httpClient is nil")
}
}
func TestMinimaxChatForcesNonStreaming(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodPost {
t.Errorf("method=%s, want POST", r.Method)
}
if r.URL.Path != "/v1/text/chatcompletion_v2" {
t.Errorf("path=%s, want /v1/text/chatcompletion_v2", r.URL.Path)
}
if body["model"] != "MiniMax-M3" {
t.Errorf("model=%v, want MiniMax-M3", body["model"])
}
if body["stream"] != false {
t.Errorf("stream=%v, want false", body["stream"])
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"choices": []map[string]interface{}{{
"message": map[string]interface{}{
"content": "pong",
"reasoning_content": "\nthought",
},
}},
})
})
defer srv.Close()
apiKey := " test-key "
stream := true
thinking := true
resp, err := newMinimaxForTest(srv.URL).ChatWithMessages(
" MiniMax-M3 ",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
&ChatConfig{Stream: &stream, Thinking: &thinking},
)
if err != nil {
t.Fatalf("ChatWithMessages: %v", err)
}
if resp.Answer == nil || *resp.Answer != "pong" {
t.Errorf("Answer=%v, want pong", resp.Answer)
}
if resp.ReasonContent == nil || *resp.ReasonContent != "thought" {
t.Errorf("ReasonContent=%v, want thought", resp.ReasonContent)
}
}
func TestMinimaxChatRejectsEmptyChoices(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
_ = json.NewEncoder(w).Encode(map[string]interface{}{"choices": []map[string]interface{}{}})
})
defer srv.Close()
apiKey := "test-key"
_, err := newMinimaxForTest(srv.URL).ChatWithMessages(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
nil,
)
if err == nil || !strings.Contains(err.Error(), "no choices in response") {
t.Fatalf("expected choices error, got %v", err)
}
}
func TestMinimaxStreamForcesStreaming(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodPost {
t.Errorf("method=%s, want POST", r.Method)
}
if r.URL.Path != "/v1/text/chatcompletion_v2" {
t.Errorf("path=%s, want /v1/text/chatcompletion_v2", r.URL.Path)
}
if body["stream"] != true {
t.Errorf("stream=%v, want true", body["stream"])
}
if got := r.Header.Get("Accept"); got != "text/event-stream" {
t.Errorf("Accept=%q, want text/event-stream", got)
}
w.Header().Set("Content-Type", "text/event-stream")
_, _ = io.WriteString(w, strings.Join([]string{
`data: {"choices":[{"delta":{"reasoning_content":"thinking"}}]}`,
`data: {"choices":[{"delta":{"content":"hello"}}]}`,
`data: [DONE]`,
``,
}, "\n"))
})
defer srv.Close()
apiKey := "test-key"
stream := false
var content, reasoning []string
err := newMinimaxForTest(srv.URL).ChatStreamlyWithSender(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
&ChatConfig{Stream: &stream},
func(answer, reason *string) error {
if answer != nil {
content = append(content, *answer)
}
if reason != nil {
reasoning = append(reasoning, *reason)
}
return nil
},
)
if err != nil {
t.Fatalf("ChatStreamlyWithSender: %v", err)
}
if got := strings.Join(content, ""); got != "hello[DONE]" {
t.Errorf("content=%q, want hello[DONE]", got)
}
if got := strings.Join(reasoning, ""); got != "thinking" {
t.Errorf("reasoning=%q, want thinking", got)
}
}
func TestMinimaxStreamAcceptsNilConfig(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, body map[string]interface{}, w http.ResponseWriter) {
if body["stream"] != true {
t.Errorf("stream=%v, want true", body["stream"])
}
w.Header().Set("Content-Type", "text/event-stream")
_, _ = io.WriteString(w, "data: [DONE]\n")
})
defer srv.Close()
apiKey := "test-key"
err := newMinimaxForTest(srv.URL).ChatStreamlyWithSender(
"MiniMax-M3",
[]Message{{Role: "user", Content: "ping"}},
&APIConfig{ApiKey: &apiKey},
nil,
func(*string, *string) error { return nil },
)
if err != nil {
t.Fatalf("ChatStreamlyWithSender: %v", err)
}
}
func TestMinimaxListModelsUsesBodylessGet(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodGet {
t.Errorf("method=%s, want GET", r.Method)
}
if r.URL.Path != "/v1/models" {
t.Errorf("path=%s, want /v1/models", r.URL.Path)
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"data": []map[string]string{
{"id": "MiniMax-M3"},
{"id": " minimax-m2.7 "},
},
})
})
defer srv.Close()
apiKey := "test-key"
models, err := newMinimaxForTest(srv.URL).ListModels(&APIConfig{ApiKey: &apiKey})
if err != nil {
t.Fatalf("ListModels: %v", err)
}
if got := joinModelNames(models, ","); got != "MiniMax-M3,minimax-m2.7" {
t.Errorf("models=%q", got)
}
}
func TestMinimaxListModelsRejectsMalformedResponse(t *testing.T) {
apiKey := "test-key"
for name, response := range map[string]interface{}{
"missing data": map[string]interface{}{"object": "list"},
"empty id": map[string]interface{}{"data": []map[string]string{{"id": ""}}},
} {
t.Run(name, func(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, _ *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
_ = json.NewEncoder(w).Encode(response)
})
defer srv.Close()
if _, err := newMinimaxForTest(srv.URL).ListModels(&APIConfig{ApiKey: &apiKey}); err == nil {
t.Fatal("expected malformed response error")
}
})
}
}
func TestMinimaxCheckConnectionUsesListModels(t *testing.T) {
srv := newMinimaxServer(t, func(t *testing.T, r *http.Request, _ map[string]interface{}, w http.ResponseWriter) {
if r.Method != http.MethodGet {
t.Errorf("method=%s, want GET", r.Method)
}
if r.URL.Path != "/v1/models" {
t.Errorf("path=%s, want /v1/models", r.URL.Path)
}
_ = json.NewEncoder(w).Encode(map[string]interface{}{
"data": []map[string]string{{"id": "MiniMax-M3"}},
})
})
defer srv.Close()
apiKey := "test-key"
if err := newMinimaxForTest(srv.URL).CheckConnection(&APIConfig{ApiKey: &apiKey}); err != nil {
t.Fatalf("CheckConnection: %v", err)
}
}
func TestMinimaxValidatesInputs(t *testing.T) {
apiKey := "test-key"
emptyKey := " "
send := func(*string, *string) error { return nil }
tests := []struct {
name string
run func() error
want string
}{
{
name: "chat api key",
run: func() error {
_, err := newMinimaxForTest("http://unused").ChatWithMessages("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &emptyKey}, nil)
return err
},
want: "api key is required",
},
{
name: "chat model",
run: func() error {
_, err := newMinimaxForTest("http://unused").ChatWithMessages(" ", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil)
return err
},
want: "model name is required",
},
{
name: "stream api key",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, nil, nil, send)
},
want: "api key is required",
},
{
name: "stream model",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender(" ", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil, send)
},
want: "model name is required",
},
{
name: "stream sender",
run: func() error {
return newMinimaxForTest("http://unused").ChatStreamlyWithSender("MiniMax-M3", []Message{{Role: "user", Content: "x"}}, &APIConfig{ApiKey: &apiKey}, nil, nil)
},
want: "sender is required",
},
{
name: "models api key",
run: func() error {
_, err := newMinimaxForTest("http://unused").ListModels(&APIConfig{})
return err
},
want: "api key is required",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := tt.run()
if err == nil || !strings.Contains(err.Error(), tt.want) {
t.Fatalf("expected %q error, got %v", tt.want, err)
}
})
}
}