Files
ragflow/internal/agent/tool/retrieval_test.go
Zhichang Yu 3fa15c0e2f feat(agent): Go port — canvas engine, 22 components, DSL v2, 13 endpoints (#15952)
Ports the agent canvas subsystem from Python to Go.

## What's included

### Canvas Engine (Phase 0/1)
- State engine, scheduler, variable resolver, Redis checkpoint store,
cancel protocol
- **209 tests** across canvas / component / io packages

### 22 Components (P0–P4)
| Tier | Components |
|---|---|
| P0 T1+T2+T3 | LLM, Agent, ExitLoop, Switch, Categorize, Begin,
Message, Invoke |
| P1 T3 | VariableAggregator, VariableAssigner, StringTransform,
ListOperations, DataOperations |
| P2 T3 | Iteration, IterationItem, Loop, LoopItem |
| P3 T3 | UserFillUp, Fillup |
| P4 T5 | Browser, ExcelProcessor, DocsGenerator |

### DSL v2 Schema (Phase 2.5)
- Typed v2 in-memory model with v1-to-v2 auto-detect converter
- v1 legacy field stripping per plan §2.11.7

### HTTP Endpoints & Bug Fixes (Plans PR1–PR3)
- **DELETE SQL bug fix**: gorm v2 `Where("id = ?", id).Delete(...)`
pattern
- **CreateAgent validation**: title/DSL required, duplicate check, 103
envelope
- **13 new endpoints**: templates, prompts, tags, sessions CRUD,
chat/completions (SSE + non-stream stubs), rerun, test_db_connection,
logs, webhook/logs
- **756 Go unit tests** (745 → 756, +18)
- **17 → 0 Python integration test failures** (test_agents.py +
test_session_management/)

### Tools
21 eino tools: HTTPHelper, search tools, financial/data tools, mandatory
stubs

### Infrastructure
OTel observability, NATS message queue, DeepDoc gRPC client, SSRF
guards, IDOR mitigation
2026-06-12 22:58:28 +08:00

109 lines
3.2 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package tool
import (
"context"
"encoding/json"
"errors"
"strings"
"testing"
)
func TestRetrieval_StubsErrorWhenServiceMissing(t *testing.T) {
t.Parallel()
rt := NewRetrievalTool()
out, err := rt.InvokableRun(context.Background(), `{"query":"hello"}`)
if err == nil {
t.Fatal("expected stub error, got nil")
}
if !errors.Is(err, ErrRetrievalServiceMissing) {
t.Fatalf("err = %v, want ErrRetrievalServiceMissing", err)
}
// Output is a JSON envelope with the stub error message.
var got retrievalResult
if jerr := json.Unmarshal([]byte(out), &got); jerr != nil {
t.Fatalf("output is not valid JSON: %v (raw=%s)", jerr, out)
}
if !got.Stub {
t.Errorf("Stub = false, want true")
}
if !strings.Contains(got.Error, "Phase 5 wiring") {
t.Errorf("Error = %q, want to mention 'Phase 5 wiring'", got.Error)
}
}
func TestRetrieval_RejectsUseKG(t *testing.T) {
t.Parallel()
rt := NewRetrievalTool()
out, err := rt.InvokableRun(context.Background(), `{"query":"x","use_kg":true}`)
if !errors.Is(err, ErrGraphRAGNotSupported) {
t.Fatalf("err = %v, want ErrGraphRAGNotSupported", err)
}
if !strings.Contains(out, "GraphRAG") {
t.Errorf("output %q should mention GraphRAG", out)
}
}
func TestRetrieval_InfoMatchesPythonMeta(t *testing.T) {
t.Parallel()
rt := NewRetrievalTool()
info, err := rt.Info(context.Background())
if err != nil {
t.Fatalf("Info: %v", err)
}
if info.Name != "search_my_dateset" {
t.Errorf("Name = %q, want search_my_dateset (typo preserved)", info.Name)
}
if !strings.Contains(info.Desc, "datasets") {
t.Errorf("Desc = %q, want to mention 'datasets'", info.Desc)
}
// The query param must be present and required. ToJSONSchema returns
// a *jsonschema.Schema whose Properties is an *orderedmap.Map; we use
// MarshalJSON to assert the parameter set without depending on the
// map's concrete Get signature.
params, err := info.ToJSONSchema()
if err != nil {
t.Fatalf("ToJSONSchema: %v", err)
}
raw, err := json.Marshal(params)
if err != nil {
t.Fatalf("marshal schema: %v", err)
}
if !strings.Contains(string(raw), `"query"`) {
t.Errorf("schema JSON does not contain 'query' key: %s", raw)
}
}
func TestRetrieval_EmptyArgsIsHandled(t *testing.T) {
t.Parallel()
rt := NewRetrievalTool()
// Empty arguments should still return a stub error (not panic) — the
// Python tool defaults to empty_response in this case, but in Phase 3
// batch 1 we don't have wiring, so we surface the service-missing
// error.
_, err := rt.InvokableRun(context.Background(), "")
if !errors.Is(err, ErrRetrievalServiceMissing) {
t.Fatalf("err = %v, want ErrRetrievalServiceMissing", err)
}
}