mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-03 01:01:56 +08:00
Ports the agent canvas subsystem from Python to Go.
## What's included
### Canvas Engine (Phase 0/1)
- State engine, scheduler, variable resolver, Redis checkpoint store,
cancel protocol
- **209 tests** across canvas / component / io packages
### 22 Components (P0–P4)
| Tier | Components |
|---|---|
| P0 T1+T2+T3 | LLM, Agent, ExitLoop, Switch, Categorize, Begin,
Message, Invoke |
| P1 T3 | VariableAggregator, VariableAssigner, StringTransform,
ListOperations, DataOperations |
| P2 T3 | Iteration, IterationItem, Loop, LoopItem |
| P3 T3 | UserFillUp, Fillup |
| P4 T5 | Browser, ExcelProcessor, DocsGenerator |
### DSL v2 Schema (Phase 2.5)
- Typed v2 in-memory model with v1-to-v2 auto-detect converter
- v1 legacy field stripping per plan §2.11.7
### HTTP Endpoints & Bug Fixes (Plans PR1–PR3)
- **DELETE SQL bug fix**: gorm v2 `Where("id = ?", id).Delete(...)`
pattern
- **CreateAgent validation**: title/DSL required, duplicate check, 103
envelope
- **13 new endpoints**: templates, prompts, tags, sessions CRUD,
chat/completions (SSE + non-stream stubs), rerun, test_db_connection,
logs, webhook/logs
- **756 Go unit tests** (745 → 756, +18)
- **17 → 0 Python integration test failures** (test_agents.py +
test_session_management/)
### Tools
21 eino tools: HTTPHelper, search tools, financial/data tools, mandatory
stubs
### Infrastructure
OTel observability, NATS message queue, DeepDoc gRPC client, SSRF
guards, IDOR mitigation
117 lines
3.7 KiB
Go
117 lines
3.7 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
|
|
package runtime
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/client_golang/prometheus/testutil"
|
|
dto "github.com/prometheus/client_model/go"
|
|
)
|
|
|
|
// labelsMatch reports whether the metric carries a label named "runtime"
|
|
// with the supplied value.
|
|
func labelsMatch(pairs []*dto.LabelPair, wantRuntime string) bool {
|
|
for _, p := range pairs {
|
|
if p.GetName() == "runtime" && p.GetValue() == wantRuntime {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func TestObserveRun_IncrementsCounter(t *testing.T) {
|
|
// ResetMetricsForTesting re-registers the metrics on the default
|
|
// registry so testutil can read them.
|
|
ResetMetricsForTesting()
|
|
|
|
ObserveRun(RuntimeGo, OutcomeSuccess, 250*time.Millisecond)
|
|
ObserveRun(RuntimeGo, OutcomeSuccess, 500*time.Millisecond)
|
|
ObserveRun(RuntimePython, OutcomeError, 750*time.Millisecond)
|
|
|
|
if got := testutil.ToFloat64(canvasRunsTotal.WithLabelValues("go", "success")); got != 2 {
|
|
t.Errorf("go/success counter = %v, want 2", got)
|
|
}
|
|
if got := testutil.ToFloat64(canvasRunsTotal.WithLabelValues("python", "error")); got != 1 {
|
|
t.Errorf("python/error counter = %v, want 1", got)
|
|
}
|
|
if got := testutil.ToFloat64(canvasRunsTotal.WithLabelValues("python", "success")); got != 0 {
|
|
t.Errorf("python/success counter = %v, want 0", got)
|
|
}
|
|
}
|
|
|
|
func TestObserveRun_RecordsDuration(t *testing.T) {
|
|
ResetMetricsForTesting()
|
|
|
|
ObserveRun(RuntimeGo, OutcomeSuccess, time.Second)
|
|
ObserveRun(RuntimeGo, OutcomeSuccess, 2*time.Second)
|
|
|
|
gathered, err := prometheus.DefaultGatherer.Gather()
|
|
if err != nil {
|
|
t.Fatalf("Gather: %v", err)
|
|
}
|
|
|
|
var found bool
|
|
for _, mf := range gathered {
|
|
if !strings.Contains(mf.GetName(), "canvas_run_duration_seconds") {
|
|
continue
|
|
}
|
|
for _, m := range mf.Metric {
|
|
if labelsMatch(m.Label, "go") {
|
|
found = true
|
|
if m.Histogram == nil || m.Histogram.GetSampleCount() != 2 {
|
|
t.Errorf("go histogram count = %v, want 2", m.Histogram.GetSampleCount())
|
|
}
|
|
}
|
|
}
|
|
}
|
|
if !found {
|
|
t.Fatal("did not find canvas_run_duration_seconds metric for runtime=go")
|
|
}
|
|
}
|
|
|
|
func TestObserveRun_NormalisesEmptyArgs(t *testing.T) {
|
|
ResetMetricsForTesting()
|
|
|
|
// Pin the env-driven default to Python so the test is hermetic
|
|
// regardless of the host environment. (Phase 7 default is Go, but
|
|
// the assertion is "the empty-runtime label equals Default()", so
|
|
// we set the env to make the expected value explicit.)
|
|
t.Setenv("RAGFLOW_CANVAS_DEFAULT_RUNTIME", string(RuntimePython))
|
|
ResetDefaultCache()
|
|
|
|
ObserveRun("", "", 0) // all empty — should default to python/error and not observe histogram
|
|
|
|
if got := testutil.ToFloat64(canvasRunsTotal.WithLabelValues("python", "error")); got != 1 {
|
|
t.Errorf("defaulted counter = %v, want 1", got)
|
|
}
|
|
}
|
|
|
|
// TestObserveRun_DefaultFallsToGoAfterPhase7 documents the Phase 7
|
|
// review fix (M4): the metric's empty-runtime fallback now follows
|
|
// selector.Default() (which is RuntimeGo as of Phase 7), so the
|
|
// runtime label is consistent with what Selector.Select would have
|
|
// returned for the same tenant.
|
|
func TestObserveRun_DefaultFallsToGoAfterPhase7(t *testing.T) {
|
|
ResetMetricsForTesting()
|
|
t.Setenv("RAGFLOW_CANVAS_DEFAULT_RUNTIME", "")
|
|
ResetDefaultCache()
|
|
|
|
ObserveRun("", OutcomeError, 0)
|
|
|
|
if got := testutil.ToFloat64(canvasRunsTotal.WithLabelValues(string(Default()), "error")); got != 1 {
|
|
t.Errorf("defaulted counter = %v, want 1 for runtime=%s outcome=error", got, Default())
|
|
}
|
|
}
|