Files
ragflow/internal/agent/canvas/canvas_test.go
Hz_ 1b77e3ebcd fix(go-agent): preserve canvas system state across turns (#17010)
## Summary

- Preserve request-scoped system variables such as files and user IDs
during Canvas execution.
- Persist conversation history, turn counts, and tool memory in the
session DSL across turns.
- Parse agent uploads into `sys.files` and align system variable
rendering with Python.

## Testing

- `bash build.sh --test ./internal/agent/...`
- `bash build.sh --test ./internal/service/...`

<img width="1896" height="1232" alt="image"
src="https://github.com/user-attachments/assets/b420cd97-53c3-470f-a3e1-d39cea26a213"
/>
2026-07-17 15:53:58 +08:00

144 lines
4.9 KiB
Go

// Package canvas — Begin → Message e2e smoke test.
//
// The simplest end-to-end compile+run path. Verifies:
//
// 1. BuildWorkflow returns a non-nil Workflow for a 2-node DSL.
// 2. Compile returns a CompiledCanvas.
// 3. The compiled Runnable.Invoke runs to completion (no eino wiring error).
// 4. The Message node's "{{sys.query}}" reference resolves against state
// that was seeded into Sys — even though our placeholder lambda
// doesn't actually emit a string, we exercise the variable
// resolution path by writing into Outputs via SetVar before Invoke.
//
// The placeholder lambdas echo the input map; the test asserts the
// *plumbing* (compile, run, set/get state across nodes) without
// asserting component-specific semantics.
package canvas
import (
"context"
"strings"
"testing"
)
// TestBeginToMessage_Smoke builds a Begin → Message DSL, seeds sys.query
// into state, and confirms the compiled workflow runs without error and
// the per-cpn Outputs bucket gets populated (proving the statePre/statePost
// handler chain works end-to-end).
func TestBeginToMessage_Smoke(t *testing.T) {
dsl := &Canvas{
Components: map[string]CanvasComponent{
"begin_0": {
Obj: CanvasComponentObj{ComponentName: "Begin", Params: map[string]any{}},
Downstream: []string{"message_0"},
Upstream: []string{},
},
"message_0": {
Obj: CanvasComponentObj{ComponentName: "Message", Params: map[string]any{
"text": "hello {{sys.query}}",
}},
Downstream: []string{},
Upstream: []string{"begin_0"},
},
},
Path: []string{"begin_0", "message_0"},
}
cc, err := Compile(context.Background(), dsl)
if err != nil {
t.Fatalf("Compile: %v", err)
}
if cc.Workflow == nil {
t.Fatal("compiled Workflow is nil")
}
// Pre-seed state to mirror what the Begin node would normally inject.
// With the real Begin component registered (via the blank import in
// loop_semantics_test.go), Begin reads inputs["query"] and writes it
// into state.Sys["query"] itself — so we pass the query through the
// input map instead of seeding it directly, and Begin propagates it
// into the context-attached state.
runState := NewCanvasState("run-smoke", "task-smoke")
runState.SetVar("begin_0", "request", map[string]any{"q": "world"})
// Stash runState on the context so the canvas runner can extract
// it via GetStateFromContext.
ctx := withState(context.Background(), runState)
// Invoke with the seed input. The "query" key flows into Begin's
// Invoke and is written to state.Sys["query"], where Message's
// ResolveTemplate of "{{sys.query}}" will read it.
in := map[string]any{"query": "world"}
out, err := cc.Workflow.Invoke(ctx, in)
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if out == nil {
t.Fatal("Invoke returned nil output")
}
// Variable resolution: ResolveTemplate against the seeded state must
// produce "hello world".
got, err := ResolveTemplate("hello {{sys.query}}", runState)
if err != nil {
t.Fatalf("ResolveTemplate: %v", err)
}
if got != "hello world" {
t.Fatalf("template resolve: got %q want %q", got, "hello world")
}
}
// TestBuildWorkflow_PreservesRequestSysValues verifies that per-request sys
// values take precedence over the empty defaults stored in a real Canvas DSL.
// The service parses uploads and sets user_id before Invoke; GenLocalState must
// not replace that state and let the first statePre restore stale DSL values.
func TestBuildWorkflow_PreservesRequestSysValues(t *testing.T) {
dsl := &Canvas{
Globals: map[string]any{
"sys.files": []any{},
"sys.user_id": "",
},
Components: map[string]CanvasComponent{
"begin_0": {
Obj: CanvasComponentObj{ComponentName: "Begin", Params: map[string]any{}},
Downstream: []string{"message_0"},
},
"message_0": {
Obj: CanvasComponentObj{ComponentName: "Message", Params: map[string]any{
"text": "{{sys.files}} {{sys.user_id}}",
}},
Upstream: []string{"begin_0"},
},
},
Path: []string{"begin_0", "message_0"},
}
cc, err := Compile(context.Background(), dsl)
if err != nil {
t.Fatalf("Compile: %v", err)
}
state := NewCanvasState("run-request-sys", "task-request-sys")
state.Sys["files"] = []string{"File: notes.txt\nContent as following:\nhello"}
state.Sys["user_id"] = "user-1"
ctx := withState(context.Background(), state)
if _, err := cc.Workflow.Invoke(ctx, map[string]any{"query": "hello"}); err != nil {
t.Fatalf("Invoke: %v", err)
}
files, err := state.GetVar("sys.files")
if err != nil {
t.Fatalf("GetVar(sys.files): %v", err)
}
if got, ok := files.([]string); !ok || len(got) != 1 || !strings.Contains(got[0], "notes.txt") {
t.Fatalf("sys.files = %#v, want current request upload", files)
}
userID, err := state.GetVar("sys.user_id")
if err != nil {
t.Fatalf("GetVar(sys.user_id): %v", err)
}
if userID != "user-1" {
t.Fatalf("sys.user_id = %#v, want %q", userID, "user-1")
}
}