mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-17 05:07:23 +08:00
## Summary
This PR consolidates Eino-backed Agent tools behind the shared
ToolBackedComponent implementation and aligns their Canvas
configuration,
runtime inputs, output conversion, validation, and registration.
## What changed
- Migrated these Canvas components to the unified tool-backed path:
- Tavily Search and Extract
- Execute SQL
- Google
- Yahoo Finance
- Email
- DuckDuckGo
- Wikipedia
- Google Scholar
- ArXiv
- PubMed
- BGPT
- GitHub
- WenCai
- SearXNG
- Keenable Search
- Removed superseded component wrappers and their duplicate tests.
- Added dedicated registry builders for node-level configuration and
validation.
- Kept model-emitted runtime inputs separate from Canvas node
configuration.
- Moved Email defaults, template resolution, recipient parsing, SMTP
execution, and output conversion into the owning tool.
- Added complete ToolComponent specifications for Canvas inputs,
outputs, and input forms.
- Preserved raw upstream fields where downstream workflows may depend on
them.
- Added workflow registration coverage for all migrated component names.
- Kept HTTP Request, Docs Generator, and Browser as standalone
components because they are not Eino-backed tools.
## Testing
Passed:
bash build.sh --test ./internal/agent/tool/...
bash build.sh --test ./internal/agent/component/...
bash build.sh --test ./internal/agent/runtime/...
<img width="2057" height="1111" alt="image"
src="https://github.com/user-attachments/assets/c728d7a3-9d15-4c5c-b0eb-6b77ad0e41ac"
/>
<img width="2057" height="1111" alt="image"
src="https://github.com/user-attachments/assets/ef13119a-ef92-4b43-9061-eee9511bf492"
/>
<img width="2057" height="1111" alt="image"
src="https://github.com/user-attachments/assets/f50f2c30-eab0-463c-b0b3-0a02523219f1"
/>
316 lines
9.2 KiB
Go
316 lines
9.2 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
package tool
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
"ragflow/internal/tokenizer"
|
|
)
|
|
|
|
func TestGoogle_BuildURL(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
name string
|
|
params googleParams
|
|
wantNum string
|
|
wantHost string
|
|
}{
|
|
{
|
|
name: "python defaults",
|
|
params: googleParams{APIKey: "KEY", Q: "ragflow"},
|
|
wantNum: "6",
|
|
wantHost: "serpapi.com",
|
|
},
|
|
{
|
|
name: "canvas num country language",
|
|
params: googleParams{APIKey: "K", Q: "x y", Num: 12, Start: 10, Country: "cn", Language: "zh-cn"},
|
|
wantNum: "12",
|
|
wantHost: "serpapi.com",
|
|
},
|
|
{
|
|
name: "agent aliases",
|
|
params: googleParams{APIKey: "K", Q: "x", Num: 3},
|
|
wantNum: "3",
|
|
wantHost: "serpapi.com",
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
got := buildGoogleURL(tc.params)
|
|
u, err := url.Parse(got)
|
|
if err != nil {
|
|
t.Fatalf("url.Parse(%q): %v", got, err)
|
|
}
|
|
if u.Host != tc.wantHost {
|
|
t.Errorf("host = %q, want %q", u.Host, tc.wantHost)
|
|
}
|
|
if u.Path != "/search.json" {
|
|
t.Errorf("path = %q, want /search.json", u.Path)
|
|
}
|
|
q := u.Query()
|
|
if q.Get("api_key") != tc.params.APIKey {
|
|
t.Errorf("api_key = %q, want %q", q.Get("api_key"), tc.params.APIKey)
|
|
}
|
|
if q.Get("engine") != "google" {
|
|
t.Errorf("engine = %q, want google", q.Get("engine"))
|
|
}
|
|
if q.Get("num") != tc.wantNum {
|
|
t.Errorf("num = %q, want %q", q.Get("num"), tc.wantNum)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGoogle_ParseResults(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
_, _ = w.Write([]byte(`{
|
|
"organic_results": [
|
|
{"title":"RAGFlow","link":"https://ragflow.io","snippet":"Open source RAG engine"},
|
|
{"title":"GitHub","link":"https://github.com/infiniflow/ragflow","snippet":"Source code"}
|
|
]
|
|
}`))
|
|
}))
|
|
defer srv.Close()
|
|
|
|
helper := NewHTTPHelper().WithClient(&http.Client{
|
|
Transport: rewriteHostTransport(srv.URL),
|
|
})
|
|
tool := NewGoogleToolWith(helper)
|
|
out, err := tool.InvokableRun(context.Background(),
|
|
`{"q":"ragflow","api_key":"K","num":5,"country":"us","language":"en"}`)
|
|
if err != nil {
|
|
t.Fatalf("InvokableRun: %v", err)
|
|
}
|
|
|
|
var env googleEnvelope
|
|
if jerr := json.Unmarshal([]byte(out), &env); jerr != nil {
|
|
t.Fatalf("output is not valid JSON: %v (raw=%s)", jerr, out)
|
|
}
|
|
if env.Error != "" {
|
|
t.Errorf("Error = %q, want empty", env.Error)
|
|
}
|
|
if len(env.Results) != 2 {
|
|
t.Fatalf("Results len = %d, want 2", len(env.Results))
|
|
}
|
|
if env.Results[0]["title"] != "RAGFlow" {
|
|
t.Errorf("Results[0].title = %q, want RAGFlow", env.Results[0]["title"])
|
|
}
|
|
if env.Results[1]["link"] != "https://github.com/infiniflow/ragflow" {
|
|
t.Errorf("Results[1].link = %q, want https://github.com/infiniflow/ragflow", env.Results[1]["link"])
|
|
}
|
|
}
|
|
|
|
func TestGoogle_RequiresAPIKey(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tool := NewGoogleTool()
|
|
_, err := tool.InvokableRun(context.Background(), `{"q":"x","api_key":""}`)
|
|
if err == nil {
|
|
t.Fatal("expected error for missing api_key")
|
|
}
|
|
if !strings.Contains(err.Error(), "api_key") {
|
|
t.Errorf("err = %v, want to mention api_key", err)
|
|
}
|
|
}
|
|
|
|
func TestGoogle_InfoAndInputForm(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tool := NewGoogleTool()
|
|
info, err := tool.Info(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("Info: %v", err)
|
|
}
|
|
if info.Name != "google_search" {
|
|
t.Errorf("Name = %q, want google_search", info.Name)
|
|
}
|
|
if !strings.Contains(info.Desc, "Google") {
|
|
t.Errorf("Desc = %q, want to mention Google", info.Desc)
|
|
}
|
|
form := tool.InputForm()
|
|
if _, ok := form["q"]; !ok {
|
|
t.Fatalf("InputForm missing q: %+v", form)
|
|
}
|
|
if _, ok := form["start"]; !ok {
|
|
t.Fatalf("InputForm missing start: %+v", form)
|
|
}
|
|
if _, ok := form["num"]; !ok {
|
|
t.Fatalf("InputForm missing num: %+v", form)
|
|
}
|
|
for _, configField := range []string{"api_key", "country", "language"} {
|
|
if _, exists := form[configField]; exists {
|
|
t.Fatalf("InputForm leaked node configuration %q: %+v", configField, form)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGoogle_MergeDefaultsPrefersExplicitInputs(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got := mergeGoogleDefaults(
|
|
googleParams{
|
|
APIKey: "DEFAULT_KEY",
|
|
Q: "default query",
|
|
Num: 6,
|
|
Country: "us",
|
|
},
|
|
googleParams{
|
|
Q: "agent query",
|
|
Num: 10,
|
|
},
|
|
)
|
|
|
|
if got.APIKey != "DEFAULT_KEY" {
|
|
t.Fatalf("APIKey = %q, want DEFAULT_KEY", got.APIKey)
|
|
}
|
|
if got.Q != "agent query" {
|
|
t.Fatalf("Q = %q, want agent query", got.Q)
|
|
}
|
|
if got.Num != 10 {
|
|
t.Fatalf("Num = %d, want 10", got.Num)
|
|
}
|
|
if got.Country != "us" {
|
|
t.Fatalf("Country = %q, want us", got.Country)
|
|
}
|
|
}
|
|
|
|
func TestGoogle_BuildByNameAcceptsNodeParams(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
built, err := BuildByName("google", map[string]any{
|
|
"api_key": "KEY",
|
|
"country": "cn",
|
|
"language": "zh-cn",
|
|
"num": 12,
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("BuildByName: %v", err)
|
|
}
|
|
tool, ok := built.(*GoogleTool)
|
|
if !ok {
|
|
t.Fatalf("built type = %T, want *GoogleTool", built)
|
|
}
|
|
if tool.defaults.APIKey != "KEY" {
|
|
t.Fatalf("defaults.APIKey = %q, want KEY", tool.defaults.APIKey)
|
|
}
|
|
if tool.defaults.Country != "cn" || tool.defaults.Language != "zh-cn" {
|
|
t.Fatalf("defaults locale = %q/%q, want cn/zh-cn", tool.defaults.Country, tool.defaults.Language)
|
|
}
|
|
if tool.defaults.Num != 12 {
|
|
t.Fatalf("defaults.Num = %d, want 12", tool.defaults.Num)
|
|
}
|
|
}
|
|
|
|
func TestGoogle_BuildByNameIgnoresUnrelatedCanvasParams(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
built, err := BuildByName("google", map[string]any{
|
|
"query": "ragflow",
|
|
"max_results": 5,
|
|
"outputs": map[string]any{"json": map[string]any{}},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("BuildByName rejected unrelated Canvas params: %v", err)
|
|
}
|
|
google := built.(*GoogleTool)
|
|
if google.defaults.Q != "" || google.defaults.Num != 0 {
|
|
t.Fatalf("unrelated params changed defaults: %+v", google.defaults)
|
|
}
|
|
}
|
|
|
|
func TestGoogle_ComponentReferencesAndOutputs(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
google := NewGoogleTool()
|
|
spec := google.ComponentSpec()
|
|
if query, ok := spec.InputForm["q"].(map[string]any); !ok || query["name"] != "Query" || query["type"] != "line" {
|
|
t.Fatalf("query input form = %#v", spec.InputForm["q"])
|
|
}
|
|
envelope := map[string]any{"results": []any{
|
|
map[string]any{
|
|
"title": "RAGFlow",
|
|
"link": "https://ragflow.io",
|
|
"snippet": "Go-first snippet",
|
|
"about_this_result": map[string]any{"source": map[string]any{
|
|
"description": "fallback description",
|
|
}},
|
|
"custom": "preserved",
|
|
},
|
|
map[string]any{
|
|
"title": "Fallback",
|
|
"link": "https://example.com",
|
|
"about_this_result": map[string]any{"source": map[string]any{
|
|
"description": "about content",
|
|
}},
|
|
},
|
|
}}
|
|
chunks, docAggs := google.BuildReferences(context.Background(), envelope)
|
|
if len(chunks) != 2 || len(docAggs) != 2 {
|
|
t.Fatalf("references = %#v / %#v", chunks, docAggs)
|
|
}
|
|
if chunks[0]["content"] != "Go-first snippet" || chunks[1]["content"] != "about content" || chunks[0]["similarity"] != 1 {
|
|
t.Fatalf("reference content = %#v", chunks)
|
|
}
|
|
outputs := google.BuildComponentOutputs(envelope)
|
|
results, ok := outputs["json"].([]any)
|
|
if !ok || len(results) != 2 || results[0].(map[string]any)["custom"] != "preserved" {
|
|
t.Fatalf("json output = %#v", outputs["json"])
|
|
}
|
|
rendered, _ := outputs["formalized_content"].(string)
|
|
for _, want := range []string{"Title: RAGFlow", "Go-first snippet", "about content"} {
|
|
if !strings.Contains(rendered, want) {
|
|
t.Fatalf("formalized_content missing %q: %q", want, rendered)
|
|
}
|
|
}
|
|
if _, exists := envelope["chunks"]; exists {
|
|
t.Fatalf("output conversion mutated envelope: %#v", envelope)
|
|
}
|
|
}
|
|
|
|
func TestRenderGoogleReferencesStopsBeforeOverBudgetBlock(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
chunks := []map[string]any{
|
|
{"id": "1", "document_name": "First", "url": "https://first.example", "content": "first reference content"},
|
|
{"id": "2", "document_name": "Second", "url": "https://second.example", "content": "second reference content"},
|
|
}
|
|
firstBlock := renderGoogleReferences(chunks[:1], 0)
|
|
firstTokens := tokenizer.NumTokensFromString(firstBlock)
|
|
maxTokens := (firstTokens*100 + 96) / 97
|
|
if got := renderGoogleReferences(chunks, maxTokens); got != firstBlock {
|
|
t.Fatalf("rendered = %q, want only first block %q", got, firstBlock)
|
|
}
|
|
if got := renderGoogleReferences(chunks, 1); got != "" {
|
|
t.Fatalf("over-budget first block was appended: %q", got)
|
|
}
|
|
if got := renderGoogleReferences(chunks, 0); !strings.Contains(got, "Title: First") || !strings.Contains(got, "Title: Second") {
|
|
t.Fatalf("unlimited rendering dropped blocks: %q", got)
|
|
}
|
|
}
|