mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-14 17:08:31 +08:00
## Summary - Add the GitHub Canvas component with tool registration and reference propagation. - Align the Invoke component with the Python contract for node config, input form, response output, and timing fields. - GitHub search and HTTP Invoke now work correctly in the Go Canvas runtime. ## Tests - `bash build.sh --test ./internal/agent/tool/...` - `bash build.sh --test ./internal/agent/component/...` Note: the untracked go_ragflow_cli file is not part of the PR changes. <img width="1813" height="1102" alt="image" src="https://github.com/user-attachments/assets/f69cef32-59a0-4287-a06b-6843d85198cf" /> <img width="1813" height="1102" alt="image" src="https://github.com/user-attachments/assets/b37dfc31-bc9b-4937-a38e-d2184bb157fe" />
142 lines
4.4 KiB
Go
142 lines
4.4 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
package runtime
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
)
|
|
|
|
// TestCanvasState_MarshalUnmarshalJSON pins the JSON wire shape
|
|
// introduced by the MarshalJSON hook (unblocking the eino
|
|
// interrupt path's "failed to marshal state: unknown type:
|
|
// runtime.CanvasState" error). Every field on CanvasState must
|
|
// round-trip without losing the map values, the CancelFlag bool,
|
|
// and the RunID / TaskID strings.
|
|
func TestCanvasState_MarshalUnmarshalJSON(t *testing.T) {
|
|
t.Parallel()
|
|
src := NewCanvasState("run-1", "task-1")
|
|
src.Sys["query"] = "hello"
|
|
src.Env["counter"] = 0.0
|
|
src.CancelFlag.Store(true)
|
|
src.Outputs["message_0"] = map[string]any{"content": "hi world"}
|
|
src.Path = []string{"begin_0", "message_0"}
|
|
|
|
raw, err := json.Marshal(src)
|
|
if err != nil {
|
|
t.Fatalf("Marshal: %v", err)
|
|
}
|
|
|
|
var dst CanvasState
|
|
if err := json.Unmarshal(raw, &dst); err != nil {
|
|
t.Fatalf("Unmarshal: %v", err)
|
|
}
|
|
|
|
if got, _ := dst.Sys["query"].(string); got != "hello" {
|
|
t.Errorf("Sys[query] = %q, want %q", got, "hello")
|
|
}
|
|
if !dst.CancelFlag.Load() {
|
|
t.Error("CancelFlag not preserved")
|
|
}
|
|
if got, _ := dst.Outputs["message_0"]["content"].(string); got != "hi world" {
|
|
t.Errorf("Outputs[message_0][content] = %q, want %q", got, "hi world")
|
|
}
|
|
if dst.RunID != "run-1" {
|
|
t.Errorf("RunID = %q, want %q", dst.RunID, "run-1")
|
|
}
|
|
if dst.TaskID != "task-1" {
|
|
t.Errorf("TaskID = %q, want %q", dst.TaskID, "task-1")
|
|
}
|
|
if len(dst.Path) != 2 || dst.Path[0] != "begin_0" || dst.Path[1] != "message_0" {
|
|
t.Errorf("Path = %v, want [begin_0 message_0]", dst.Path)
|
|
}
|
|
}
|
|
|
|
// TestCanvasState_MarshalJSON_DoesNotLeakMutex pins the wire-shape
|
|
// invariant: the unexported `mu sync.RWMutex` field must not appear
|
|
// in the JSON output. If a future maintainer adds a `json:"mu"` tag
|
|
// or refactors the struct so the lock ends up serialised, this test
|
|
// catches the regression — serialised mutex state is a
|
|
// deterministic-breakage risk for any consumer that caches the
|
|
// payload and unmarshals it later.
|
|
func TestCanvasState_MarshalJSON_DoesNotLeakMutex(t *testing.T) {
|
|
t.Parallel()
|
|
s := NewCanvasState("r", "t")
|
|
raw, err := json.Marshal(s)
|
|
if err != nil {
|
|
t.Fatalf("Marshal: %v", err)
|
|
}
|
|
if got := string(raw); contains(got, `"mu"`) || contains(got, `"Mu"`) {
|
|
t.Errorf("serialised state leaks the unexported mutex field: %s", got)
|
|
}
|
|
}
|
|
|
|
func TestCanvasState_SetRetrievalReferencesMergesCalls(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
state := NewCanvasState("run-1", "task-1")
|
|
state.SetRetrievalReferences(
|
|
[]map[string]any{{"id": "chunk-1"}},
|
|
[]map[string]any{{"doc_name": "doc-1", "count": 1}},
|
|
)
|
|
state.SetRetrievalReferences(
|
|
[]map[string]any{{"id": "chunk-2"}},
|
|
[]map[string]any{
|
|
{"doc_name": "doc-1", "count": 99},
|
|
{"doc_name": "doc-2", "count": 2},
|
|
},
|
|
)
|
|
|
|
chunks := state.GetRetrievalChunks()
|
|
if len(chunks) != 2 {
|
|
t.Fatalf("chunks length = %d, want 2", len(chunks))
|
|
}
|
|
if chunks[0]["id"] != "chunk-1" || chunks[1]["id"] != "chunk-2" {
|
|
t.Errorf("chunk IDs = [%v %v], want [chunk-1 chunk-2]", chunks[0]["id"], chunks[1]["id"])
|
|
}
|
|
|
|
state.mu.RLock()
|
|
rawDocAggs := state.Retrieval["doc_aggs"]
|
|
docAggs, ok := rawDocAggs.(map[string]any)
|
|
state.mu.RUnlock()
|
|
if !ok {
|
|
t.Fatalf("doc_aggs type = %T, want map[string]any", rawDocAggs)
|
|
}
|
|
if len(docAggs) != 2 {
|
|
t.Fatalf("doc_aggs length = %d, want 2", len(docAggs))
|
|
}
|
|
firstDoc, ok := docAggs["doc-1"].(map[string]any)
|
|
if !ok {
|
|
t.Fatalf("doc_aggs[doc-1] type = %T, want map[string]any", docAggs["doc-1"])
|
|
}
|
|
if firstDoc["count"] != 1 {
|
|
t.Errorf("doc_aggs[doc-1].count = %v, want first value 1", firstDoc["count"])
|
|
}
|
|
if _, ok := docAggs["doc-2"]; !ok {
|
|
t.Error("doc_aggs missing doc-2 from the second call")
|
|
}
|
|
}
|
|
|
|
func contains(s, substr string) bool {
|
|
for i := 0; i+len(substr) <= len(s); i++ {
|
|
if s[i:i+len(substr)] == substr {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|