Files
ragflow/internal/agent/component/tool_call_memory_test.go
Hz_ 1b77e3ebcd fix(go-agent): preserve canvas system state across turns (#17010)
## Summary

- Preserve request-scoped system variables such as files and user IDs
during Canvas execution.
- Persist conversation history, turn counts, and tool memory in the
session DSL across turns.
- Parse agent uploads into `sys.files` and align system variable
rendering with Python.

## Testing

- `bash build.sh --test ./internal/agent/...`
- `bash build.sh --test ./internal/service/...`

<img width="1896" height="1232" alt="image"
src="https://github.com/user-attachments/assets/b420cd97-53c3-470f-a3e1-d39cea26a213"
/>
2026-07-17 15:53:58 +08:00

124 lines
4.0 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package component
import (
"context"
"strings"
"testing"
"github.com/cloudwego/eino/schema"
"ragflow/internal/agent/runtime"
)
// TestAddToolCallMemory_NoToolCalls: when msg has no ToolCalls, the
// function returns ("", nil) — caller skips appending to history.
func TestAddToolCallMemory_NoToolCalls(t *testing.T) {
stub := &stubInvoker{resp: &ChatInvokeResponse{Content: "ok", Model: "echo"}}
withStubInvoker(t, stub)
got, err := addToolCallMemory(context.Background(), AgentParam{ModelID: "echo"}, &schema.Message{Content: "no tools"})
if err != nil {
t.Fatalf("err: %v", err)
}
if got != "" {
t.Errorf("expected empty for no tool calls, got %q", got)
}
if stub.calls != 0 {
t.Errorf("expected 0 invoker calls (no LLM needed), got %d", stub.calls)
}
}
// TestAddToolCallMemory_SummarizesAndAppendsToState: end-to-end —
// stub returns a summary; Agent.Invoke appends it to state.Memory without
// polluting the user/assistant conversation history.
func TestAddToolCallMemory_SummarizesAndAppendsToState(t *testing.T) {
stub := &stubInvoker{resp: &ChatInvokeResponse{
Content: "the assistant searched docs and found 3 results",
Model: "echo",
}}
withStubInvoker(t, stub)
withAgentRunner(t, func(_ context.Context, _ AgentParam) (*schema.Message, error) {
// Final message with one tool call.
return &schema.Message{
Role: schema.Assistant,
ToolCalls: []schema.ToolCall{{
ID: "1", Type: "function",
Function: schema.FunctionCall{
Name: "search",
Arguments: `{"q":"what is X"}`,
},
}},
}, nil
})
state := runtime.NewCanvasState("rid", "tid")
c := NewAgentComponent(AgentParam{ModelID: "echo", MaxRounds: 1})
ctx := runtime.WithState(context.Background(), state)
_, err := c.Invoke(ctx, map[string]any{"user_prompt": "do it"})
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if stub.calls != 1 {
t.Errorf("expected 1 LLM call (the memory summary), got %d", stub.calls)
}
memory := state.SnapshotMemory()
if len(memory) != 1 {
t.Fatalf("expected 1 memory entry, got %d: %+v", len(memory), memory)
}
if len(state.SnapshotHistory()) != 0 {
t.Fatalf("tool summary polluted conversation history: %+v", state.SnapshotHistory())
}
entry := memory[0]
if entry["user"] != "do it" {
t.Errorf("memory user=%v, want do it", entry["user"])
}
if !strings.Contains(entry["summary"].(string), "searched docs") {
t.Errorf("memory summary missing tool result: %q", entry["summary"])
}
}
// TestAddToolCallMemory_LLMFailure: when the summary LLM fails, the
// history is NOT appended (graceful degradation).
func TestAddToolCallMemory_LLMFailure(t *testing.T) {
stub := &stubInvoker{err: context.DeadlineExceeded}
withStubInvoker(t, stub)
withAgentRunner(t, func(_ context.Context, _ AgentParam) (*schema.Message, error) {
return &schema.Message{
Role: schema.Assistant,
ToolCalls: []schema.ToolCall{{
ID: "1", Type: "function",
Function: schema.FunctionCall{Name: "search"},
}},
}, nil
})
state := runtime.NewCanvasState("rid", "tid")
c := NewAgentComponent(AgentParam{ModelID: "echo", MaxRounds: 1})
ctx := runtime.WithState(context.Background(), state)
_, err := c.Invoke(ctx, map[string]any{"user_prompt": "do it"})
if err != nil {
t.Fatalf("Invoke should not error when memory summary fails: %v", err)
}
if len(state.SnapshotMemory()) != 0 {
t.Errorf("expected no memory entry on summary failure, got %d", len(state.SnapshotMemory()))
}
}