Files
ragflow/internal/parser/parser/pdf_parser_tcadp.go
Jack 9b0719fa94 fix: Go ingestion migration batch 5 (Parser 1.1/1.7/2.11, Chunker 1.7/1.8/2.6/2.7, Tokenizer 6x fixes) (#17419)
## Summary

Continuation of the Python→Go ingestion pipeline migration (File →
Parser → Chunker → Extractor → Tokenizer). Fixes cover Parser, Chunker,
and Tokenizer gaps identified. Fix page number (0-indexed and 1-index
mixed before fix; use 1-indexed after fix) and chunk order issues.

### Parser
- **Slides TCADP (1.7):** `pptx_tcadp.go` + TCADP branch in
`pptx_parser.go`/`ppt_parser.go` — PowerPoint files now support
`parse_method="tcadp"` via the TCADP cloud service, matching the
spreadsheet-family TCADP pattern. PPT containers pass `"PPT"` as
fileType (not hardcoded `"PPTX"`).
- **Audio default output_format (2.11):** `defaultSetups()` audio
default changed from `"text"` to `"json"`, aligning with Python
`parser.py:232` and `AllowedOutputFormat["audio"]={"json"}`.
- **PDF VLM enhancement (1.1):** `maybeDispatchPDFVisionEnhancement` in
`pdf_vision_dispatch.go` enriches image/table items with IMAGE2TEXT
model descriptions after PDF parsing, mirroring Python
`enhance_media_sections_with_vision`. Semaphore fix: acquire before
goroutine start to prevent unbounded goroutine creation.
- **json family (2.3):** reclassified as Keep Go — `json_parser.go` is a
functional enhancement, not a parity gap.
- **page number:** changed from "mixed use of 1-indexed & 0-indexed" to
"1-indexed"

### Chunker
- **BULLET_PATTERN fallback (1.7):** 4th-level fallback in
`resolveTitleLevels` (`title.go`) detects bullet/numbered-list patterns
(Chinese legal, numbering, English) when outline + regex levels produce
only bodyLevel. Guarded by `allBodyLevel` to never override existing
structure.
- **Tag/One chunker fields (1.8):** `tag.go` sets `TopInt` from source
row index; `one.go` preserves `Positions`/`PDFPositions` from source
items. TSV multi-line RowNum fix: tracks `contentStart` for correct row
attribution.
- **Overlapped_percent normalization (2.6):**
`NormalizeOverlappedPercent` in `schema/chunker.go` mirrors Python
`common/float_utils.py:50-58` — accepts `[0,1)` fraction or `[0,90]`
percent, normalizes to canonical `[0,90]`.
- **Paragraph splitting (2.7):** aligned to Python flow `naive_merge` —
`CRLF` normalization, `splitKeepingDelimiter` preserves sentence
delimiters, single-section merge with token-budget-governed chunking.
- **chunk order:** sort by reading order

### Tokenizer
- **Phantom chunk filtering (Omission 2):** `isPhantomChunk` + filter
loop in `chunksFromTokenizerUpstream` skips zero-value ChunkDocs.
- **Batch size env var (Omission 3):** `embeddingBatchSize()` reads
`TOKENIZER_EMBEDDING_BATCH_SIZE`, defaults to 16.
- **Summary empty check (Diff 5):** `TrimSpace(s) != ""` → `s != ""`,
matching Python truthy check.
- **chunk_order_int all paths (Diff 8):** set unconditionally before
full_text/embedding branching.
- **Timeout default (Diff 10):** `600s` → `60s`, matching Python
`@timeout(60)`.
- **Small maxTokens truncation (Diff 14):** `truncateForEmbedding`
returns `""` when `maxTokens <= 10`, matching Python.

### Code review fixes
- Semaphore acquire moved before goroutine in `pdf_vision_dispatch.go`
(concurrency control)
- Context propagation in `pptx_tcadp.go` (cancellation support)
- Test resolver leak fix in `media_dispatch_test.go` (defer restore)
- Migration history comments removed per AGENTS.md

## Test plan
```
bash build.sh --test ./internal/parser/parser/... ./internal/ingestion/component/...
```

## Notes
- Migration diff tracking: `docs/migration_python_go_diff.md`
- Remaining gaps: Extractor component only (21 items)
2026-07-28 11:12:52 +08:00

235 lines
6.8 KiB
Go

package parser
import (
"archive/zip"
"bytes"
"context"
"encoding/base64"
"encoding/json"
"fmt"
"io"
"net/http"
"ragflow/internal/common"
"strings"
models "ragflow/internal/entity/models"
)
func parsePDFWithTCADP(filename string, data []byte, parser *PDFParser) ParseResult {
if len(data) == 0 {
return emptyPDFResult(filename)
}
baseURL := strings.TrimSpace(parser.TCADPAPIServer)
if baseURL == "" {
baseURL = strings.TrimSpace(common.GetEnv(common.EnvTCADPApiServerURL))
}
if baseURL == "" {
return ParseResult{Err: fmt.Errorf("parser: TCADP requires tcadp_apiserver or TCADP_APISERVER")}
}
apiKey := strings.TrimSpace(parser.TCADPAPIKey)
if apiKey == "" {
apiKey = strings.TrimSpace(common.GetEnv(common.EnvTCADPApiKey))
}
requestBody := map[string]any{
"file_type": "PDF",
"file_base64": base64.StdEncoding.EncodeToString(data),
"file_start_page_number": 1,
"file_end_page_number": 1000,
"config": map[string]any{
"TableResultType": parser.TCADPTableResultType,
"MarkdownImageResponseType": parser.TCADPMarkdownImageResponseType,
},
}
resp, err := models.PostJSONRequest(context.Background(), models.NewDriverHTTPClient(), strings.TrimRight(baseURL, "/")+"/reconstruct_document", bearer(apiKey), requestBody)
if err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP submit: %w", err)}
}
defer resp.Body.Close()
raw, err := io.ReadAll(resp.Body)
if err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP read submit: %w", err)}
}
if resp.StatusCode >= 300 {
return ParseResult{Err: fmt.Errorf("parser: TCADP HTTP %d: %s", resp.StatusCode, string(raw))}
}
var payload struct {
DocumentRecognizeResultURL string `json:"DocumentRecognizeResultUrl"`
}
if err := json.Unmarshal(raw, &payload); err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP decode submit: %w", err)}
}
if payload.DocumentRecognizeResultURL == "" {
return ParseResult{Err: fmt.Errorf("parser: TCADP returned no DocumentRecognizeResultUrl")}
}
downloadReq, err := http.NewRequestWithContext(context.Background(), http.MethodGet, payload.DocumentRecognizeResultURL, nil)
if err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP download request: %w", err)}
}
if auth := bearer(apiKey); auth != "" {
downloadReq.Header.Set("Authorization", auth)
}
downloadResp, err := models.NewDriverHTTPClient().Do(downloadReq)
if err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP download: %w", err)}
}
defer downloadResp.Body.Close()
zipBytes, err := io.ReadAll(downloadResp.Body)
if err != nil {
return ParseResult{Err: fmt.Errorf("parser: TCADP read zip: %w", err)}
}
if downloadResp.StatusCode >= 300 {
return ParseResult{Err: fmt.Errorf("parser: TCADP download HTTP %d: %s", downloadResp.StatusCode, string(zipBytes))}
}
items, pageCount, err := tcadpItemsFromZip(zipBytes)
if err != nil {
return ParseResult{Err: err}
}
return pdfItemsToResult(filename, items, parser.OutputFormat, pageCount)
}
func tcadpItemsFromZip(zipBytes []byte) ([]map[string]any, int, error) {
reader, err := zip.NewReader(bytes.NewReader(zipBytes), int64(len(zipBytes)))
if err != nil {
return nil, 0, fmt.Errorf("parser: TCADP zip: %w", err)
}
items := make([]map[string]any, 0)
pageCount := 0
for _, file := range reader.File {
if strings.HasSuffix(file.Name, ".md") {
rc, err := file.Open()
if err != nil {
return nil, 0, err
}
body, err := io.ReadAll(rc)
rc.Close()
if err != nil {
return nil, 0, err
}
items = append(items, map[string]any{"text": strings.TrimSpace(string(body)), "doc_type_kwd": "text", "layout": "text"})
if strings.TrimSpace(string(body)) != "" && pageCount == 0 {
pageCount = 1
}
continue
}
if !strings.HasSuffix(file.Name, ".json") {
continue
}
rc, err := file.Open()
if err != nil {
return nil, 0, err
}
var raw any
err = json.NewDecoder(rc).Decode(&raw)
rc.Close()
if err != nil {
return nil, 0, err
}
items = append(items, tcadpAnyToItems(raw)...)
if pages := collectPDFPageNumbers(raw); len(pages) > pageCount {
pageCount = len(pages)
}
}
if len(items) == 0 {
return nil, 0, fmt.Errorf("parser: TCADP zip contained no supported content")
}
return items, pageCount, nil
}
func tcadpAnyToItems(raw any) []map[string]any {
switch v := raw.(type) {
case []any:
items := make([]map[string]any, 0)
for _, item := range v {
items = append(items, tcadpAnyToItems(item)...)
}
return items
case map[string]any:
text := strings.TrimSpace(stringValue(v["content"]))
contentType := strings.ToLower(strings.TrimSpace(stringValue(v["type"])))
page := extractTCADPPage(v)
emit := func(text, docType, layout string) []map[string]any {
m := map[string]any{"text": text, "doc_type_kwd": docType, "layout": layout}
if page > 0 {
// 1-indexed 5-tuple. AddPositions is a passthrough so
// the final position_int / page_num_int carry the same
// 1-indexed page number the caller passes. Mirrors
// Python presentation.py:148-149.
m["positions"] = []float64{float64(page), 0, 0, 0, 0}
}
return []map[string]any{m}
}
switch contentType {
case "table":
if text == "" {
text = tcadpTableRowsText(v["table_data"])
}
if text == "" {
return nil
}
return emit(text, "table", "table")
case "image":
caption := strings.TrimSpace(stringValue(v["caption"]))
if caption == "" {
caption = "[Image]"
}
return emit(caption, "image", "figure")
case "equation":
if text == "" {
return nil
}
return emit("$$"+text+"$$", "text", "equation")
default:
if text == "" {
return nil
}
return emit(text, "text", "text")
}
}
return nil
}
// extractTCADPPage returns the 1-indexed page number carried by a raw TCADP
// element, using the same key set collectPDFPageNumbers walks
// (pdf_parser_remote_common.go). It returns 0 when the element has no page
// information (e.g. spreadsheet TCADP), so callers can skip position emission
// and remain parity-correct with Python (table.py sets no page either).
func extractTCADPPage(v map[string]any) int {
for _, key := range []string{"page_number", "page_num", "page_no", "page_index", "page_idx", "page"} {
if page := int(numberValue(v[key])); page > 0 {
return page
}
}
return 0
}
func tcadpTableRowsText(raw any) string {
table, ok := raw.(map[string]any)
if !ok {
return ""
}
rows, ok := table["rows"].([]any)
if !ok {
return ""
}
lines := make([]string, 0, len(rows))
for _, rowRaw := range rows {
row, ok := rowRaw.([]any)
if !ok {
continue
}
cols := make([]string, 0, len(row))
for _, col := range row {
cols = append(cols, stringValue(col))
}
lines = append(lines, strings.Join(cols, " | "))
}
return strings.Join(lines, "\n")
}
func bearer(apiKey string) string {
if strings.TrimSpace(apiKey) == "" {
return ""
}
return "Bearer " + apiKey
}