mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-06-29 23:41:12 +08:00
cafa0f2e4f
### What problem does this PR solve? Fixes #15840. The Go HTTP server sets `WriteTimeout: 120s`, which also applies to long-lived SSE responses. Existing Go streaming handlers did not clear the per-response write deadline, so streams that run longer than the server timeout can be terminated mid-response. This PR adds a small handler helper that clears the response write deadline for SSE requests and calls it only in existing Go streaming branches: - conversation completion streaming - provider chat streaming - provider transcription streaming - provider speech streaming The global server `WriteTimeout` remains unchanged for non-streaming requests. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) ### Test plan - `/root/go/bin/go test ./internal/handler -run TestDisableWriteDeadlineForSSEAllowsLongLivedStream -count=1` - `/root/go/bin/go test ./internal/handler -count=1`
80 lines
2.0 KiB
Go
80 lines
2.0 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
package handler
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
func TestDisableWriteDeadlineForSSEAllowsLongLivedStream(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
|
|
router := gin.New()
|
|
router.GET("/stream", func(c *gin.Context) {
|
|
disableWriteDeadlineForSSE(c)
|
|
c.Header("Content-Type", "text/event-stream")
|
|
c.Writer.WriteHeader(http.StatusOK)
|
|
c.Writer.Flush()
|
|
|
|
if _, err := c.Writer.Write([]byte("data: first\n\n")); err != nil {
|
|
t.Errorf("write first chunk: %v", err)
|
|
return
|
|
}
|
|
c.Writer.Flush()
|
|
|
|
time.Sleep(120 * time.Millisecond)
|
|
|
|
if _, err := c.Writer.Write([]byte("data: second\n\n")); err != nil {
|
|
t.Errorf("write second chunk: %v", err)
|
|
return
|
|
}
|
|
c.Writer.Flush()
|
|
})
|
|
|
|
server := httptest.NewUnstartedServer(router)
|
|
server.Config.WriteTimeout = 30 * time.Millisecond
|
|
server.Start()
|
|
defer server.Close()
|
|
|
|
client := server.Client()
|
|
client.Timeout = time.Second
|
|
resp, err := client.Get(server.URL + "/stream")
|
|
if err != nil {
|
|
t.Fatalf("get stream: %v", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
bodyBytes, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
t.Fatalf("read stream body: %v", err)
|
|
}
|
|
|
|
body := string(bodyBytes)
|
|
for _, want := range []string{"data: first", "data: second"} {
|
|
if !strings.Contains(body, want) {
|
|
t.Fatalf("stream body missing %q: %q", want, body)
|
|
}
|
|
}
|
|
}
|