Files
ragflow/internal/ingestion/component/chunker/group.go
Jack 9b0719fa94 fix: Go ingestion migration batch 5 (Parser 1.1/1.7/2.11, Chunker 1.7/1.8/2.6/2.7, Tokenizer 6x fixes) (#17419)
## Summary

Continuation of the Python→Go ingestion pipeline migration (File →
Parser → Chunker → Extractor → Tokenizer). Fixes cover Parser, Chunker,
and Tokenizer gaps identified. Fix page number (0-indexed and 1-index
mixed before fix; use 1-indexed after fix) and chunk order issues.

### Parser
- **Slides TCADP (1.7):** `pptx_tcadp.go` + TCADP branch in
`pptx_parser.go`/`ppt_parser.go` — PowerPoint files now support
`parse_method="tcadp"` via the TCADP cloud service, matching the
spreadsheet-family TCADP pattern. PPT containers pass `"PPT"` as
fileType (not hardcoded `"PPTX"`).
- **Audio default output_format (2.11):** `defaultSetups()` audio
default changed from `"text"` to `"json"`, aligning with Python
`parser.py:232` and `AllowedOutputFormat["audio"]={"json"}`.
- **PDF VLM enhancement (1.1):** `maybeDispatchPDFVisionEnhancement` in
`pdf_vision_dispatch.go` enriches image/table items with IMAGE2TEXT
model descriptions after PDF parsing, mirroring Python
`enhance_media_sections_with_vision`. Semaphore fix: acquire before
goroutine start to prevent unbounded goroutine creation.
- **json family (2.3):** reclassified as Keep Go — `json_parser.go` is a
functional enhancement, not a parity gap.
- **page number:** changed from "mixed use of 1-indexed & 0-indexed" to
"1-indexed"

### Chunker
- **BULLET_PATTERN fallback (1.7):** 4th-level fallback in
`resolveTitleLevels` (`title.go`) detects bullet/numbered-list patterns
(Chinese legal, numbering, English) when outline + regex levels produce
only bodyLevel. Guarded by `allBodyLevel` to never override existing
structure.
- **Tag/One chunker fields (1.8):** `tag.go` sets `TopInt` from source
row index; `one.go` preserves `Positions`/`PDFPositions` from source
items. TSV multi-line RowNum fix: tracks `contentStart` for correct row
attribution.
- **Overlapped_percent normalization (2.6):**
`NormalizeOverlappedPercent` in `schema/chunker.go` mirrors Python
`common/float_utils.py:50-58` — accepts `[0,1)` fraction or `[0,90]`
percent, normalizes to canonical `[0,90]`.
- **Paragraph splitting (2.7):** aligned to Python flow `naive_merge` —
`CRLF` normalization, `splitKeepingDelimiter` preserves sentence
delimiters, single-section merge with token-budget-governed chunking.
- **chunk order:** sort by reading order

### Tokenizer
- **Phantom chunk filtering (Omission 2):** `isPhantomChunk` + filter
loop in `chunksFromTokenizerUpstream` skips zero-value ChunkDocs.
- **Batch size env var (Omission 3):** `embeddingBatchSize()` reads
`TOKENIZER_EMBEDDING_BATCH_SIZE`, defaults to 16.
- **Summary empty check (Diff 5):** `TrimSpace(s) != ""` → `s != ""`,
matching Python truthy check.
- **chunk_order_int all paths (Diff 8):** set unconditionally before
full_text/embedding branching.
- **Timeout default (Diff 10):** `600s` → `60s`, matching Python
`@timeout(60)`.
- **Small maxTokens truncation (Diff 14):** `truncateForEmbedding`
returns `""` when `maxTokens <= 10`, matching Python.

### Code review fixes
- Semaphore acquire moved before goroutine in `pdf_vision_dispatch.go`
(concurrency control)
- Context propagation in `pptx_tcadp.go` (cancellation support)
- Test resolver leak fix in `media_dispatch_test.go` (defer restore)
- Migration history comments removed per AGENTS.md

## Test plan
```
bash build.sh --test ./internal/parser/parser/... ./internal/ingestion/component/...
```

## Notes
- Migration diff tracking: `docs/migration_python_go_diff.md`
- Remaining gaps: Extractor component only (21 items)
2026-07-28 11:12:52 +08:00

510 lines
15 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// SCOPE (honest) for group.go:
//
// - Implements the GroupTitleChunker variant: aggregates adjacent
// text records into chunks that span multiple body records while
// staying inside one heading section.
//
// Heading detection stays sequential; grouping work is local to
// one invocation.
//
// - MIRRORS python `_build_section_ids` + `GroupTitleChunker.build_chunks`:
// consecutive records with the same (target_level-derived) sec_id
// are merged up to MIN_GROUP_TOKENS / MAX_GROUP_TOKENS, then
// emitted as one chunk per group.
//
// - No PDF-position merge is performed (mirrors TokenChunker SCOPE
// notes — those land with the deepdoc/parser port).
package chunker
import (
"context"
"encoding/json"
"fmt"
"log/slog"
"regexp"
"sort"
"strings"
"go.uber.org/zap"
"gorm.io/gorm"
"ragflow/internal/agent/runtime"
"ragflow/internal/common"
"ragflow/internal/ingestion/component/globals"
"ragflow/internal/ingestion/component/schema"
"ragflow/internal/tokenizer"
)
const ComponentNameGroupTitleChunker = "GroupTitleChunker"
// MIN_GROUP_TOKENS / MAX_GROUP_TOKENS mirror the python constants in
// group_chunker.py:22-23. They drive the merge heuristic for adjacent
// text records.
const (
minGroupTokens = 32
maxGroupTokens = 1024
)
// resolveTargetLevel mirrors common.py:resolve_target_level: pick the
// n-th smallest heading level from the per-line `levels` vector.
func resolveTargetLevel(levels []int, hierarchy int) int {
tiers := make([]int, 0, len(levels))
seen := make(map[int]bool)
for _, l := range levels {
if l > 0 && l < bodyLevel && !seen[l] {
seen[l] = true
tiers = append(tiers, l)
}
}
if len(tiers) == 0 {
return 0
}
// ascending
for i := 1; i < len(tiers); i++ {
for j := i; j > 0 && tiers[j-1] > tiers[j]; j-- {
tiers[j-1], tiers[j] = tiers[j], tiers[j-1]
}
}
if hierarchy < 1 {
hierarchy = 1
}
if hierarchy > len(tiers) {
hierarchy = len(tiers)
}
return tiers[hierarchy-1]
}
// _buildSectionIDs computes, for each input level, the section id
// (`sid`) under which that record falls. Each heading encounter
// increments sid by 1; body lines share the active sid.
func buildSectionIDs(levels []int, targetLevel int) []int {
secIDs := make([]int, len(levels))
sid := 0
for i, lvl := range levels {
if i > 0 && targetLevel > 0 && lvl <= targetLevel {
sid++
}
secIDs[i] = sid
}
return secIDs
}
// invokeGroup runs the GroupTitleChunker strategy against the
// supplied inputs. Detected headings + adjacent merges happen in two
// goroutines (heading detection sequential, then a fan-out over
// record-buckets for the merge pass).
func invokeGroup(parentCtx context.Context, db *gorm.DB, inputs map[string]any, p *titleChunkerParam) (map[string]any, error) {
records := extractLineRecords(inputs)
common.Debug("chunker stage",
zap.String("component", "Chunker"),
zap.String("variant", "group"),
zap.Int("records", len(records)),
)
if len(records) == 0 {
return emptyOutputs(), nil
}
ctx := newLevelContext(records, outlineFromInputs(inputs), p)
levels := ctx.Levels()
// Count heading level distribution for debugging.
headingCounts := make(map[int]int)
for _, lvl := range levels {
if lvl < bodyLevel {
headingCounts[lvl]++
}
}
bodyCount := len(levels)
for _, c := range headingCounts {
bodyCount -= c
}
common.Debug("chunker stage",
zap.String("component", "Chunker"),
zap.String("variant", "group"),
zap.Int("records", len(records)),
zap.Int("body_level", bodyCount),
zap.Any("heading_levels", headingCounts),
)
// Mirror python group_chunker._resolve_group_target_level: when
// `hierarchy` is unset the target level is `most_level` directly
// (NOT resolve_target_level — that would re-rank the distinct
// heading levels and pick the wrong depth when the heading levels
// are not contiguous from 1). When `hierarchy` is set, it defers to
// resolve_target_level.
targetLevel := resolveGroupTargetLevel(levels, p, ctx.mostLevel)
secIDs := buildSectionIDs(levels, targetLevel)
groups := groupRecords(records, secIDs, p)
common.Debug("chunker stage",
zap.String("component", "Chunker"),
zap.String("variant", "group"),
zap.Int("groups", len(groups)),
)
chunks := buildChunksFromRecordGroups(groups, p, isPlainTextFormat(inputs))
common.Debug("chunker stage",
zap.String("component", "Chunker"),
zap.String("variant", "group"),
zap.Int("chunks", len(chunks)),
zap.Bool("plain_text", isPlainTextFormat(inputs)),
)
// On-demand PDF preview cropping for image/table/text chunks,
// mirroring the TokenChunker JSON path (token.go:513). Best-effort:
// a missing or unreadable PDF simply skips cropping.
if upstream, uErr := decodeChunkerFromUpstream(inputs); uErr == nil {
engine, eErr := newPDFEngineFromUpstream(parentCtx, db, upstream)
if eErr != nil {
slog.Warn("GroupTitleChunker: could not open PDF for on-demand cropping", "err", eErr)
}
if engine != nil {
defer engine.Close()
chunks = cropTitleChunks(parentCtx, engine, chunks)
}
}
if len(chunks) == 0 {
return emptyOutputs(), nil
}
out := map[string]any{
"output_format": "chunks",
"chunks": chunks,
}
return out, nil
}
// groupRecords mirrors `GroupTitleChunker.build_chunks`: merges
// adjacent text records while staying inside the same logical section
// (matching last_sid) and token-budget constraints.
func groupRecords(records []lineRecord, secIDs []int, p *titleChunkerParam) [][]lineRecord {
if len(records) == 0 {
return nil
}
var recordGroups [][]lineRecord
var currentGroup []lineRecord
tkCnt := 0
lastSID := -2
for i, rec := range records {
secID := secIDs[i]
if !rec.isText() {
if len(currentGroup) > 0 {
recordGroups = append(recordGroups, append([]lineRecord(nil), currentGroup...))
}
recordGroups = append(recordGroups, []lineRecord{rec})
currentGroup = currentGroup[:0]
tkCnt = 0
lastSID = -2
continue
}
text := trim(rec.text)
if text == "" {
continue
}
tokenCount := tokenizer.NumTokensFromString(text)
shouldMerge := len(currentGroup) > 0 &&
currentGroup[0].isText() &&
(tkCnt < minGroupTokens || (tkCnt < maxGroupTokens && secID == lastSID))
if shouldMerge {
currentGroup = append(currentGroup, rec)
tkCnt += tokenCount
} else {
if len(currentGroup) > 0 {
recordGroups = append(recordGroups, append([]lineRecord(nil), currentGroup...))
}
currentGroup = []lineRecord{rec}
tkCnt = tokenCount
}
lastSID = secID
}
if len(currentGroup) > 0 {
recordGroups = append(recordGroups, currentGroup)
}
return recordGroups
}
// joinGroupText mirrors python's `"".join(record["text"] + "\n" for
// record in records)` — every record's text followed by a newline
// (including the last), matching the python text join exactly.
func joinGroupText(g []lineRecord) string {
var sb strings.Builder
for _, r := range g {
sb.WriteString(r.text)
sb.WriteByte('\n')
}
return sb.String()
}
// isPlainTextFormat mirrors the `output_format in ["markdown", "text",
// "html"]` branch of common.py:build_chunks_from_record_groups. Plain
// payloads emit only "text"; structured payloads (chunks/json) also
// carry doc_type_kwd and img_id.
func isPlainTextFormat(inputs map[string]any) bool {
if f, ok := inputs["output_format"].(string); ok {
return f == "markdown" || f == "text" || f == "html"
}
return false
}
// buildChunksFromRecordGroups mirrors common.py:build_chunks_from_record_groups
// (minus the deepdoc-only remove_tag / merge_pdf_positions steps):
// - plain payloads: {"text": joined}
// - structured payloads: text plus doc_type_kwd / img_id from the
// group's leading record.
//
// root_chunk_as_heading is applied here, exactly as python does (post
// materialisation): the root chunk's text is prepended to every
// following chunk and the root chunk is dropped.
func buildChunksFromRecordGroups(groups [][]lineRecord, p *titleChunkerParam, plain bool) []map[string]any {
chunks := make([]map[string]any, 0, len(groups))
for _, g := range groups {
if len(g) == 0 {
continue
}
// Strip parser-emitted position tags (`@@...##`) from the
// joined text (diff 1.6 / 2.8). Mirrors common.py:255
// `RAGFlowPdfParser.remove_tag("".join(...))`.
chunk := map[string]any{"text": removeTag(joinGroupText(g))}
if !plain {
first := g[0]
if first.docType != "" {
chunk["doc_type_kwd"] = first.docType
}
if first.imgID != nil {
chunk["img_id"] = *first.imgID
}
}
// Merge PDF coordinate matrices across the merged records
// instead of keeping only the leading record's (diff 1.6).
// Mirrors pdf_chunk_metadata.py:127 merge_pdf_positions.
var pdfSrc, posSrc []json.RawMessage
for _, r := range g {
if len(r.pdfPositions) > 0 {
pdfSrc = append(pdfSrc, r.pdfPositions)
}
if len(r.positions) > 0 {
posSrc = append(posSrc, r.positions)
}
}
if m := mergePositionMatrix(pdfSrc...); m != nil {
chunk["_pdf_positions"] = m
}
if m := mergePositionMatrix(posSrc...); m != nil {
chunk["positions"] = m
}
chunks = append(chunks, chunk)
}
if p.RootChunkAsHeading && len(chunks) > 1 {
rootText := toString(chunks[0]["text"])
for i := 1; i < len(chunks); i++ {
chunks[i]["text"] = rootText + "\n" + toString(chunks[i]["text"])
}
chunks = chunks[1:]
}
return chunks
}
// posTagRemove matches parser-emitted position tags of the form
// `@@<page>\t<left>\t<right>\t<top>\t<bottom>##`. Mirrors Python
// pdf_parser.py:1934 `re.sub(r"@@[\t0-9.-]+?##", "", txt)`.
var posTagRemove = regexp.MustCompile(`@@[\t0-9.-]+?##`)
// removeTag strips parser-emitted position tags from a chunk's text.
// Mirrors deepdoc RAGFlowPdfParser.remove_tag.
func removeTag(text string) string {
return posTagRemove.ReplaceAllString(text, "")
}
// mergePositionMatrix aggregates multiple PDF coordinate matrices into a
// single de-duplicated, sorted matrix. Mirrors Python
// pdf_chunk_metadata.py:127 merge_pdf_positions: rows are 5-tuples
// [page,left,right,top,bottom]; duplicates (by the first five columns)
// are dropped and rows are sorted by (page, top, left). Returns nil when
// no source carries any usable coordinates.
func mergePositionMatrix(sources ...json.RawMessage) [][]float64 {
var out [][]float64
seen := make(map[string]bool)
for _, src := range sources {
if len(src) == 0 {
continue
}
var mat [][]float64
if err := json.Unmarshal(src, &mat); err != nil {
continue
}
for _, row := range mat {
if len(row) < 5 {
continue
}
key := fmt.Sprintf("%v|%v|%v|%v|%v", row[0], row[1], row[2], row[3], row[4])
if seen[key] {
continue
}
seen[key] = true
out = append(out, row)
}
}
if len(out) == 0 {
return nil
}
sort.Slice(out, func(i, j int) bool {
if out[i][0] != out[j][0] {
return out[i][0] < out[j][0]
}
if out[i][3] != out[j][3] {
return out[i][3] < out[j][3]
}
return out[i][1] < out[j][1]
})
return out
}
// extractLineRecords reads the chunker inputs in the same order the
// python BaseTitleChunker.extract_line_records uses:
//
// 1. If upstream emitted chunks (output_format == "chunks") OR
// upstream emitted JSON, normalise from the list payload.
// 2. Otherwise, treat text/markdown/html as a "one record per line"
// stream (preserving indentation for non-text formats, strip-only
// for the text format).
func extractLineRecords(inputs map[string]any) []lineRecord {
if docs := chunksFromInputs(inputs); docs != nil {
return recordsFromStructured(docs)
}
text, _ := stringFromInputs(inputs, "text", "content", "markdown", "html")
if text == "" {
return nil
}
return lineRecordsFromText(text)
}
func recordsFromStructured(items []schema.ChunkDoc) []lineRecord {
out := make([]lineRecord, 0, len(items))
for _, it := range items {
text := itemTextOrFallback(it)
if text == "" {
continue
}
dt := it.DocType
if dt == "" {
dt = "text"
}
var imgID *string
if it.ImgID != "" {
img := it.ImgID
imgID = &img
}
meta := make(map[string]any)
if it.ContentLtks != "" {
meta["content_ltks"] = it.ContentLtks
}
if it.ContentSmLtks != "" {
meta["content_sm_ltks"] = it.ContentSmLtks
}
if it.ContentWithWeight != "" {
meta["content_with_weight"] = it.ContentWithWeight
}
if it.TitleTks != "" {
meta["title_tks"] = it.TitleTks
}
if it.TitleSmTks != "" {
meta["title_sm_tks"] = it.TitleSmTks
}
for k, v := range it.Extra {
meta[k] = json.RawMessage(v)
}
out = append(out, lineRecord{
text: text,
docType: dt,
imgID: imgID,
layout: it.Layout,
ckType: it.CKType,
pdfPositions: it.PDFPositions,
positions: it.Positions,
parentMeta: meta,
})
}
return out
}
// resolveGroupTargetLevel mirrors group_chunker._resolve_group_target_level:
// when `hierarchy` is set (>0) the target depth is resolve_target_level,
// otherwise it is the frequency-derived `most_level` directly.
func resolveGroupTargetLevel(levels []int, p *titleChunkerParam, mostLevel int) int {
if p.Hierarchy != nil && *p.Hierarchy > 0 {
return resolveTargetLevel(levels, *p.Hierarchy)
}
return mostLevel
}
// GroupTitleChunkerComponent is the standalone variant entry point.
// It is registered separately so canvas authors can pick the strategy
// directly. TitleChunker's dispatcher routes to invokeGroup /
// invokeHierarchy as well.
type GroupTitleChunkerComponent struct {
name string
param titleChunkerParam
}
// NewGroupTitleChunker constructs the variant component with method
// pre-set to "group".
func NewGroupTitleChunker(params map[string]any) (runtime.Component, error) {
conf := map[string]any{"method": "group"}
for k, v := range params {
conf[k] = v
}
p := defaultsTitle()
p.Update(conf)
if err := p.TitleChunkerParam.Validate(); err != nil {
return nil, fmt.Errorf("GroupTitleChunker: %w", err)
}
return &GroupTitleChunkerComponent{
name: ComponentNameGroupTitleChunker,
param: p,
}, nil
}
func (c *GroupTitleChunkerComponent) Inputs() map[string]string {
return ChunkerInputs
}
func (c *GroupTitleChunkerComponent) Outputs() map[string]string {
return ChunkerOutputs
}
func (c *GroupTitleChunkerComponent) Invoke(ctx context.Context, db *gorm.DB, inputs map[string]any) (map[string]any, error) {
if inputs == nil {
inputs = map[string]any{}
}
// `name` is read from the workflow-wide Globals bag (seeded at
// pipeline start, published by the File component), not from the
// upstream output map.
name := globals.GlobalOrInput(ctx, inputs, "name", "")
if name == "" {
return map[string]any{
"output_format": "chunks",
"chunks": []map[string]any{},
"_ERROR": "GroupTitleChunker: missing required upstream field \"name\"",
}, nil
}
return invokeGroup(ctx, db, withName(inputs, name), &c.param)
}
// init registers GroupTitleChunker under CategoryIngestion.
func init() {
MustRegisterChunker(ComponentNameGroupTitleChunker)
}