mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-08-03 22:30:31 +08:00
9b0719fa94
## Summary
Continuation of the Python→Go ingestion pipeline migration (File →
Parser → Chunker → Extractor → Tokenizer). Fixes cover Parser, Chunker,
and Tokenizer gaps identified. Fix page number (0-indexed and 1-index
mixed before fix; use 1-indexed after fix) and chunk order issues.
### Parser
- **Slides TCADP (1.7):** `pptx_tcadp.go` + TCADP branch in
`pptx_parser.go`/`ppt_parser.go` — PowerPoint files now support
`parse_method="tcadp"` via the TCADP cloud service, matching the
spreadsheet-family TCADP pattern. PPT containers pass `"PPT"` as
fileType (not hardcoded `"PPTX"`).
- **Audio default output_format (2.11):** `defaultSetups()` audio
default changed from `"text"` to `"json"`, aligning with Python
`parser.py:232` and `AllowedOutputFormat["audio"]={"json"}`.
- **PDF VLM enhancement (1.1):** `maybeDispatchPDFVisionEnhancement` in
`pdf_vision_dispatch.go` enriches image/table items with IMAGE2TEXT
model descriptions after PDF parsing, mirroring Python
`enhance_media_sections_with_vision`. Semaphore fix: acquire before
goroutine start to prevent unbounded goroutine creation.
- **json family (2.3):** reclassified as Keep Go — `json_parser.go` is a
functional enhancement, not a parity gap.
- **page number:** changed from "mixed use of 1-indexed & 0-indexed" to
"1-indexed"
### Chunker
- **BULLET_PATTERN fallback (1.7):** 4th-level fallback in
`resolveTitleLevels` (`title.go`) detects bullet/numbered-list patterns
(Chinese legal, numbering, English) when outline + regex levels produce
only bodyLevel. Guarded by `allBodyLevel` to never override existing
structure.
- **Tag/One chunker fields (1.8):** `tag.go` sets `TopInt` from source
row index; `one.go` preserves `Positions`/`PDFPositions` from source
items. TSV multi-line RowNum fix: tracks `contentStart` for correct row
attribution.
- **Overlapped_percent normalization (2.6):**
`NormalizeOverlappedPercent` in `schema/chunker.go` mirrors Python
`common/float_utils.py:50-58` — accepts `[0,1)` fraction or `[0,90]`
percent, normalizes to canonical `[0,90]`.
- **Paragraph splitting (2.7):** aligned to Python flow `naive_merge` —
`CRLF` normalization, `splitKeepingDelimiter` preserves sentence
delimiters, single-section merge with token-budget-governed chunking.
- **chunk order:** sort by reading order
### Tokenizer
- **Phantom chunk filtering (Omission 2):** `isPhantomChunk` + filter
loop in `chunksFromTokenizerUpstream` skips zero-value ChunkDocs.
- **Batch size env var (Omission 3):** `embeddingBatchSize()` reads
`TOKENIZER_EMBEDDING_BATCH_SIZE`, defaults to 16.
- **Summary empty check (Diff 5):** `TrimSpace(s) != ""` → `s != ""`,
matching Python truthy check.
- **chunk_order_int all paths (Diff 8):** set unconditionally before
full_text/embedding branching.
- **Timeout default (Diff 10):** `600s` → `60s`, matching Python
`@timeout(60)`.
- **Small maxTokens truncation (Diff 14):** `truncateForEmbedding`
returns `""` when `maxTokens <= 10`, matching Python.
### Code review fixes
- Semaphore acquire moved before goroutine in `pdf_vision_dispatch.go`
(concurrency control)
- Context propagation in `pptx_tcadp.go` (cancellation support)
- Test resolver leak fix in `media_dispatch_test.go` (defer restore)
- Migration history comments removed per AGENTS.md
## Test plan
```
bash build.sh --test ./internal/parser/parser/... ./internal/ingestion/component/...
```
## Notes
- Migration diff tracking: `docs/migration_python_go_diff.md`
- Remaining gaps: Extractor component only (21 items)
66 lines
2.5 KiB
Go
66 lines
2.5 KiB
Go
//go:build cgo
|
|
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package chunker
|
|
|
|
import (
|
|
"context"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestCropTitleChunks_CropsPositionedChunk pins residual A: chunks
|
|
// produced by the Title/Group/Hierarchy chunkers must be cropped on demand
|
|
// (mirroring the TokenChunker JSON path). The chunk shape mirrors the real
|
|
// Group/Hierarchy output: it carries doc_type_kwd + positions but NO ck_type
|
|
// (buildChunksFromRecordGroups never sets ck_type). cropTitleChunks must
|
|
// derive ck_type from doc_type_kwd so needsCrop (pdfcrop_cgo.go:151) fires.
|
|
// A text chunk with positions gets a rendered preview; a chunk without
|
|
// positions is left untouched; and the derived ck_type must not leak into
|
|
// the returned chunk shape.
|
|
func TestCropTitleChunks_CropsPositionedChunk(t *testing.T) {
|
|
ctx := context.Background()
|
|
pos := jsonPositions(t, []float64{1, 10, 100, 10, 100})
|
|
in := []map[string]any{
|
|
{"text": "page text", "doc_type_kwd": "text", "positions": pos},
|
|
{"text": "no coords", "doc_type_kwd": "text"},
|
|
}
|
|
|
|
got := cropTitleChunks(ctx, mockCropEngine{}, in)
|
|
if len(got) != 2 {
|
|
t.Fatalf("len = %d, want 2", len(got))
|
|
}
|
|
img, _ := got[0]["image"].(string)
|
|
if !strings.HasPrefix(img, "data:image/png;base64,") {
|
|
t.Errorf("positioned text chunk: image = %q, want data:image/png;base64, prefix", img)
|
|
}
|
|
if got[1]["image"] != nil {
|
|
t.Errorf("chunk without positions should not be cropped, got %v", got[1]["image"])
|
|
}
|
|
if _, ok := got[0]["ck_type"]; ok {
|
|
t.Errorf("derived ck_type must not leak into output chunk: %v", got[0])
|
|
}
|
|
}
|
|
|
|
// TestCropTitleChunks_NilEnginePassthrough asserts the helper is a no-op
|
|
// when no PDF engine is available (best-effort contract).
|
|
func TestCropTitleChunks_NilEnginePassthrough(t *testing.T) {
|
|
in := []map[string]any{{"text": "hello"}}
|
|
got := cropTitleChunks(context.Background(), nil, in)
|
|
if len(got) != 1 || got[0]["text"] != "hello" {
|
|
t.Fatalf("nil engine should pass through unchanged: %v", got)
|
|
}
|
|
}
|