mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-08-05 23:24:05 +08:00
## Summary - The `eng` flag passed to `removeTOCWord`/`removeContentsTable` was hardcoded `false`, so English documents used the CJK 3-char TOC prefix instead of Python's 2-word English prefix. This caused English tables of contents to be under-deleted (left in indexed text) or over-deleted (body paragraphs sharing the 3-char prefix dropped). - `eng` is now derived from the parsed item content via `isEnglishItems` (a port of Python `is_english`/`_is_english`), mirroring Python's content heuristic. ## Changes - `internal/parser/parser/text_toc.go`: add `isEnglishItems`/`isEnglishTexts` (ASCII-ratio >80% ⇒ English, fullmatch-anchored regex). - `internal/parser/parser/docx_parser.go`: pass `isEnglishItems(sections)` / `isEnglishItems(lineItems)` to `removeTOCWord` (json + markdown paths). - `internal/parser/parser/html_parser.go`: pass `isEnglishItems(items)` to `removeContentsTable`. - `docs/migration_python_go_diff.md`: close the 1.9/1.10 `eng` residual and resolve the contradictory Parser 2.11 "Partially fixed" note. ## Notes - `remove_toc` is a Parser-stage, DSL-configured feature (`remove_toc: true/false` in the parser family setup). This change only fixes the internal English/CJK prefix decision; it does not alter the pipeline or the DSL contract. `remove_header_footer` (precise match) is unaffected. - `eng` is auto-derived from content rather than exposed as a new config knob, to stay faithful to Python behavior. ## Test plan - `CGO_ENABLED=0 go test ./internal/parser/parser/ -run 'TestRemoveContentsTable|TestIsEnglishTexts|TestRemoveTOCWordEnglishDetection'` - Added `TestIsEnglishTexts` (ASCII-ratio cases) and `TestRemoveTOCWordEnglishDetection` (English TOC no longer over-deletes "Chapter 2 Method"). --------- Co-authored-by: CodeBuddy <noreply@codebuddy.ai>
166 lines
4.7 KiB
Go
166 lines
4.7 KiB
Go
package parser
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
// TestRemoveContentsTable mirrors the Python remove_contents_table
|
|
// (rag/nlp/__init__.py:937-965). It locates a TOC heading
|
|
// (contents/目录/目次/...), drops it, then drops the following
|
|
// entries that share a common prefix with the first TOC entry.
|
|
func TestRemoveContentsTable(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
items []map[string]any
|
|
eng bool
|
|
want []map[string]any
|
|
}{
|
|
{
|
|
name: "no TOC heading → unchanged",
|
|
items: []map[string]any{{"text": "Intro"}, {"text": "Body"}},
|
|
eng: false,
|
|
want: []map[string]any{{"text": "Intro"}, {"text": "Body"}},
|
|
},
|
|
{
|
|
name: "Chinese 目录 heading + first TOC entry removed",
|
|
items: []map[string]any{
|
|
{"text": "前言"},
|
|
{"text": "目录"},
|
|
{"text": "第一章 概述"},
|
|
{"text": "第二章 方法"},
|
|
{"text": "正文开始"},
|
|
},
|
|
eng: false,
|
|
// Python remove_contents_table drops the heading and the
|
|
// first entry after it (prefix "第一章"). Subsequent
|
|
// entries with a different prefix ("第二章") are kept
|
|
// because re.match("第一章", "第二章 方法") fails.
|
|
want: []map[string]any{
|
|
{"text": "前言"},
|
|
{"text": "第二章 方法"},
|
|
{"text": "正文开始"},
|
|
},
|
|
},
|
|
{
|
|
name: "English Contents heading + first TOC entry removed",
|
|
items: []map[string]any{
|
|
{"text": "Intro"},
|
|
{"text": "Contents"},
|
|
{"text": "Chapter 1 Overview"},
|
|
{"text": "Chapter 2 Method"},
|
|
{"text": "Body starts"},
|
|
},
|
|
eng: true,
|
|
want: []map[string]any{
|
|
{"text": "Intro"},
|
|
{"text": "Chapter 2 Method"},
|
|
{"text": "Body starts"},
|
|
},
|
|
},
|
|
{
|
|
name: "目录 heading with no following entry → heading dropped only",
|
|
items: []map[string]any{
|
|
{"text": "前言"},
|
|
{"text": "目录"},
|
|
},
|
|
eng: false,
|
|
want: []map[string]any{
|
|
{"text": "前言"},
|
|
},
|
|
},
|
|
{
|
|
name: "prefix-matching subsequent entries collapse non-matching gap",
|
|
items: []map[string]any{
|
|
{"text": "前言"},
|
|
{"text": "目录"},
|
|
{"text": "第一节 概述"},
|
|
{"text": "杂项"},
|
|
{"text": "第一节 背景"},
|
|
{"text": "正文"},
|
|
},
|
|
eng: false,
|
|
// prefix="第一节"; after dropping heading + first entry,
|
|
// scan finds "第一节 背景" at j=2 (gap "杂项" at j=1);
|
|
// Python deletes [i, j) = the gap, keeps the match.
|
|
want: []map[string]any{
|
|
{"text": "前言"},
|
|
{"text": "第一节 背景"},
|
|
{"text": "正文"},
|
|
},
|
|
},
|
|
{
|
|
name: "empty input → unchanged",
|
|
items: nil,
|
|
eng: false,
|
|
want: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
got := removeContentsTable(tc.items, tc.eng)
|
|
if !reflect.DeepEqual(got, tc.want) {
|
|
t.Errorf("got %v, want %v", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestIsEnglishTexts classifies text as English when >80% of sampled segments
|
|
// are ASCII.
|
|
func TestIsEnglishTexts(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
texts []string
|
|
want bool
|
|
}{
|
|
{name: "empty", texts: nil, want: false},
|
|
{name: "all english", texts: []string{"Chapter One", "Section Two", "Body text here"}, want: true},
|
|
{name: "all chinese", texts: []string{"第一章 概述", "第二章 方法", "正文内容"}, want: false},
|
|
{name: "mostly english (>80%)", texts: []string{
|
|
"Introduction to the system", "Background and related work",
|
|
"Methodology details", "Evaluation results", "Conclusion",
|
|
"第一章", // single CJK line among 6 (>80% english)
|
|
}, want: true},
|
|
{name: "exactly 80% english", texts: []string{
|
|
"Introduction", "Background", "Method", "Conclusion", "第一章",
|
|
}, want: false}, // 4/5 == 80% is NOT > 80%
|
|
{name: "mostly chinese (<80% english)", texts: []string{
|
|
"第一章 概述", "第二章 方法", "第三章 结果", "English abstract only",
|
|
}, want: false},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := isEnglishTexts(tc.texts); got != tc.want {
|
|
t.Errorf("isEnglishTexts(%v) = %v, want %v", tc.texts, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestRemoveTOCWordEnglishDetection verifies English content uses the 2-word
|
|
// TOC prefix, so "Chapter 2 Method" is NOT over-deleted (a 3-character prefix
|
|
// would have dropped it).
|
|
func TestRemoveTOCWordEnglishDetection(t *testing.T) {
|
|
items := []map[string]any{
|
|
{"text": "Intro"},
|
|
{"text": "Contents"},
|
|
{"text": "Chapter 1 Overview"},
|
|
{"text": "Chapter 2 Method"},
|
|
{"text": "Body starts"},
|
|
}
|
|
if !isEnglishItems(items) {
|
|
t.Fatalf("expected isEnglishItems=true for English content")
|
|
}
|
|
got := removeContentsTable(items, isEnglishItems(items))
|
|
want := []map[string]any{
|
|
{"text": "Intro"},
|
|
{"text": "Chapter 2 Method"},
|
|
{"text": "Body starts"},
|
|
}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("English TOC detection: got %v, want %v", got, want)
|
|
}
|
|
}
|