mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-11 06:05:45 +08:00
d48a5622df
## Summary - register the Go `DuckDuckGo` canvas component and restore its dynamic input form metadata - align the Go component input/output surface with the current canvas usage for `query`, `channel`, and `top_n` - fix DuckDuckGo news search in Go by fetching the required `vqd` token before calling `news.js`, and add targeted regression tests ## Testing Passed: - `bash build.sh --test ./internal/agent/tool/... -run 'DuckDuckGo'` - `bash build.sh --test ./internal/agent/component/... -run 'DuckDuckGo|TestVerifyRegistration_P1'` - `bash build.sh --test ./internal/agent/component/... -run 'DuckDuckGo'` Not run: - frontend tests - frontend build - full Go test suite <img width="1776" height="1092" alt="image" src="https://github.com/user-attachments/assets/9f3f8e4b-f6b4-4915-b96c-3c5b8c7b8b30" />
89 lines
3.1 KiB
Go
89 lines
3.1 KiB
Go
package component
|
|
|
|
import (
|
|
"sort"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestVerifyRegistration_P1 verifies all components are registered,
|
|
// case-insensitive, and returned in sorted order. The expected count is
|
|
// read from plan §2.11.10 — P0 (8) + P1 (5) + P2 (4) + P3 (2) + P4 (3) = 22
|
|
// at plan completion, plus v1 fixture wrappers/stubs (including Retrieval,
|
|
// TavilySearch, TavilyExtract, ExeSQL, Google, BGPT, YahooFinance, Generate,
|
|
// Answer, Iteration, and IterationItem) registered by fixture_stubs.go to keep
|
|
// the dsl-examples and canvas tool surface compiling. The test allows counts
|
|
// between 12 (P0+P1 minus the removed ExitLoop) and 34 (the 22 plan components
|
|
// plus the wrappers/stubs currently registered by fixture_stubs.go) to roll
|
|
// forward as subsequent batches land.
|
|
//
|
|
// Note: ExitLoop is intentionally NOT in the registry anymore. The
|
|
// canvas engine (internal/agent/canvas/canvas.go's legacyNoOpNames)
|
|
// accepts the name for DSL v1 compatibility but the Go port no longer
|
|
// ships a Component implementation for it — termination is now driven
|
|
// by the loop_termination_condition predicate, not by reaching an
|
|
// ExitLoop node in the body.
|
|
func TestVerifyRegistration_P1(t *testing.T) {
|
|
names := RegisteredNames()
|
|
have := make(map[string]bool, len(names))
|
|
for _, n := range names {
|
|
have[n] = true
|
|
}
|
|
|
|
// Always-present P0+P1 (12 names — ExitLoop removed).
|
|
requiredP0P1 := []string{
|
|
"agent", "begin", "categorize", "dataoperations",
|
|
"invoke", "listoperations", "llm", "message", "stringtransform",
|
|
"switch", "variableaggregator", "variableassigner",
|
|
}
|
|
var missing []string
|
|
for _, e := range requiredP0P1 {
|
|
if !have[e] {
|
|
missing = append(missing, e)
|
|
}
|
|
}
|
|
if len(missing) > 0 {
|
|
t.Fatalf("missing P0/P1 components: %v (have %d: %v)", missing, len(names), names)
|
|
}
|
|
if got := len(names); got < 12 || got > 35 {
|
|
t.Errorf("expected 12-35 registered (current plan scope + v1 wrappers/stubs), got %d: %v", got, names)
|
|
}
|
|
|
|
// ExitLoop must NOT be in the registry (legacy compat lives at
|
|
// the canvas level, not here).
|
|
if have["exitloop"] {
|
|
t.Errorf("exitloop is registered; expected gone. The legacy no-op handling lives in canvas.legacyNoOpNames.")
|
|
}
|
|
if have["loopitem"] {
|
|
t.Errorf("loopitem is registered; expected gone. The Python-era LoopItem node is collapsed into the workflowx.AddLoopNode wrapper.")
|
|
}
|
|
|
|
// Case-insensitive lookup on a real component to prove the
|
|
// registry's name normalization works at lookup time.
|
|
if c, err := New("Message", nil); err != nil || c == nil {
|
|
t.Errorf("New(Message) failed: c=%v err=%v", c, err)
|
|
}
|
|
|
|
// Sorted output for stable error messages.
|
|
sortedCopy := make([]string, len(names))
|
|
copy(sortedCopy, names)
|
|
sort.Strings(sortedCopy)
|
|
if !equalStrings(sortedCopy, names) {
|
|
t.Errorf("RegisteredNames() not sorted: got %v", names)
|
|
}
|
|
|
|
t.Logf("OK — %d components registered, sorted, case-insensitive lookup works: %s", len(names), strings.Join(names, ", "))
|
|
}
|
|
|
|
func equalStrings(a, b []string) bool {
|
|
if len(a) != len(b) {
|
|
return false
|
|
}
|
|
for i := range a {
|
|
if a[i] != b[i] {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|