Files
ragflow/internal/dao/kb_test.go
Jack 67c3e73d70 feat: migrate DELETE /api/v1/datasets/:dataset_id/documents to Go (#15577)
## Summary

Migrate the batch document deletion endpoint from Python to Go. Two
modes supported: explicit `ids` list and `delete_all`.

## Changes

| File | Change |
|------|--------|
| `internal/dao/file2document.go` | Add `GetByDocumentID`,
`DeleteByDocumentID` |
| `internal/dao/file2document_test.go` | 5 new tests |
| `internal/dao/kb_test.go` | 2 new tests (`DecreaseDocumentNum`) |
| `internal/service/document.go` | Add `deleteDocumentFull` +
`DeleteDocuments`, refactor `DeleteDocument` |
| `internal/service/document_test.go` | 10 new tests |
| `internal/handler/document.go` | Add `documentServiceIface` +
`DeleteDocuments` handler |
| `internal/handler/document_test.go` | 7 new tests |
| `internal/router/router.go` | Register `DELETE /:dataset_id/documents`
|
| `cmd/server_main.go` | Support `RAGFLOW_DICT_PATH` env var |
| `internal/binding/rag_analyzer.go` | Use `-lpcre2-8` dynamic linking |
| `internal/dao/database.go` | Skip Error 1091/1138 during migration |
| `internal/service/llm.go` | Fix vet warning |

## Per-document cleanup

- Delete tasks from DB
- Hard-delete document + decrement KB counters
- Delete chunks from document engine (nil-guarded)
- Delete metadata from document engine (nil-guarded)
- Remove file2document mapping + file record + storage blob

## Test Results

**24 unit tests all passing** (7 DAO + 10 service + 7 handler) using
SQLite :memory: + gin.TestMode.

See [test report](docs/test_report_delete_documents.md) for manual
integration test results.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-03 20:55:53 +08:00

122 lines
3.0 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package dao
import (
"testing"
"github.com/glebarez/sqlite"
"gorm.io/gorm"
"ragflow/internal/entity"
)
// setupKBTestDB initializes an in-memory SQLite database for KB DAO tests.
func setupKBTestDB(t *testing.T) *gorm.DB {
t.Helper()
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{
TranslateError: true,
})
if err != nil {
t.Fatalf("failed to open sqlite: %v", err)
}
// Migrate knowledgebase table
if err := db.AutoMigrate(&entity.Knowledgebase{}); err != nil {
t.Fatalf("failed to migrate: %v", err)
}
return db
}
func testKnowledgebase(t *testing.T, db *gorm.DB, id string, docNum, tokenNum, chunkNum int64) *entity.Knowledgebase {
t.Helper()
kb := &entity.Knowledgebase{
ID: id,
TenantID: "tenant-1",
Name: "test-kb-" + id,
EmbdID: "embd-1",
DocNum: docNum,
TokenNum: tokenNum,
ChunkNum: chunkNum,
Status: stringPtr(string(entity.StatusValid)),
}
if err := db.Create(kb).Error; err != nil {
t.Fatalf("failed to create test kb: %v", err)
}
return kb
}
func stringPtr(s string) *string {
return &s
}
func TestKnowledgebaseDAO_DecreaseDocumentNum(t *testing.T) {
db := setupKBTestDB(t)
pushDB(t, db)
dao := NewKnowledgebaseDAO()
testKnowledgebase(t, db, "kb-1", 5, 100, 50)
err := dao.DecreaseDocumentNum("kb-1", 1, 20, 10)
if err != nil {
t.Fatalf("DecreaseDocumentNum failed: %v", err)
}
kb, err := dao.GetByID("kb-1")
if err != nil {
t.Fatalf("GetByID failed: %v", err)
}
if kb.DocNum != 4 {
t.Fatalf("doc_num: expected 4, got %d", kb.DocNum)
}
if kb.TokenNum != 90 {
t.Fatalf("token_num: expected 90, got %d", kb.TokenNum)
}
if kb.ChunkNum != 30 {
t.Fatalf("chunk_num: expected 30, got %d", kb.ChunkNum)
}
}
func TestKnowledgebaseDAO_DecreaseDocumentNum_ZeroDecrement(t *testing.T) {
db := setupKBTestDB(t)
pushDB(t, db)
dao := NewKnowledgebaseDAO()
testKnowledgebase(t, db, "kb-2", 3, 60, 15)
err := dao.DecreaseDocumentNum("kb-2", 0, 0, 0)
if err != nil {
t.Fatalf("DecreaseDocumentNum failed: %v", err)
}
kb, err := dao.GetByID("kb-2")
if err != nil {
t.Fatalf("GetByID failed: %v", err)
}
if kb.DocNum != 3 {
t.Fatalf("doc_num should be unchanged: expected 3, got %d", kb.DocNum)
}
if kb.TokenNum != 60 {
t.Fatalf("token_num should be unchanged: expected 60, got %d", kb.TokenNum)
}
if kb.ChunkNum != 15 {
t.Fatalf("chunk_num should be unchanged: expected 15, got %d", kb.ChunkNum)
}
}