Files
ragflow/test/testcases/restful_api/test_searches.py
euvre 8fc20dd9ca Test: release Go-proxy RESTful contract tests verified passing in Go mode (#17468)
### Summary

Aligns Go and Python error codes/messages so both backends honor the
same RESTful API contract, removing implementation-specific error leaks
(MySQL errors, `ValueError`, `AttributeError`, Gin validator format) in
favor of clean business error codes.

**Chat list** — invalid `orderby` now returns code 101 (was: raw Python
`AttributeError` code 100); invalid `page`/`page_size` values fall back
to defaults (was: raw `ValueError`/`ProgrammingError` code 100).

**Dataset create/update/delete** — adds UUID validation (101),
extra-field rejection (101), duplicate-id detection (101), content-type
/ JSON-syntax / object-shape checks (101), and "lacks permission" for
nonexistent datasets (IDOR). Create auto-deduplicates dataset names.
Pagerank updates tolerate a missing ES index. List response includes
`parser_config` and `pagerank`.

**Session list/update** — adds filtering, sorting, and pagination
support. Empty payloads are valid no-ops. Authorization errors map to
code 109.

**Chunk list** — doc object uses Python key names (`chunk_count`,
`dataset_id`, `chunk_method`, run text status). Add validates list
element types.

**Document update** — adds `chunk_method` alias, pydantic-style Field
error messages, metadata index auto-create with refresh, and "These
documents do not belong to dataset" messages. List validates
`metadata_condition` and reports ownership errors for unmatched name/id
filters.

**Search completion** — `kb_ids` ownership failure returns code 102
instead of 109.

Released 31 contract tests from `GO_ONLY_SKIPS` (all verified passing on
both Go and Python backends with real LLM keys).
2026-07-30 19:58:49 +08:00

153 lines
5.6 KiB
Python

#
# Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
import uuid
import pytest
from test.testcases.configs import IS_GO_PROXY
@pytest.fixture
def search_resource(rest_client):
name = f"restful_search_{uuid.uuid4().hex[:8]}"
create_res = rest_client.post("/searches", json={"name": name, "description": "restful search"})
assert create_res.status_code == 200
create_payload = create_res.json()
assert create_payload["code"] == 0, create_payload
search_id = create_payload["data"]["search_id"]
try:
yield search_id
finally:
delete_res = rest_client.delete(f"/searches/{search_id}")
assert delete_res.status_code == 200, delete_res.text
delete_payload = delete_res.json()
assert delete_payload["code"] in (0, 109), delete_payload
def _sse_events(response_text: str) -> list[str]:
return [line[5:] for line in response_text.splitlines() if line.startswith("data:")]
@pytest.mark.p2
def test_search_routes_require_auth(rest_client_noauth):
create_res = rest_client_noauth.post("/searches", json={"name": "search_noauth"})
assert create_res.status_code == 401
create_payload = create_res.json()
assert create_payload["code"] == 401, create_payload
list_res = rest_client_noauth.get("/searches")
assert list_res.status_code == 401
list_payload = list_res.json()
assert list_payload["code"] == 401, list_payload
@pytest.mark.p2
def test_search_crud_contract(rest_client, search_resource):
search_id = search_resource
list_res = rest_client.get("/searches")
assert list_res.status_code == 200
list_payload = list_res.json()
assert list_payload["code"] == 0, list_payload
assert any(item.get("id") == search_id for item in list_payload["data"]["search_apps"]), list_payload
detail_res = rest_client.get(f"/searches/{search_id}")
assert detail_res.status_code == 200
detail_payload = detail_res.json()
assert detail_payload["code"] == 0, detail_payload
assert detail_payload["data"]["id"] == search_id, detail_payload
new_name = f"search_updated_{uuid.uuid4().hex[:6]}"
update_res = rest_client.put(
f"/searches/{search_id}",
json={"name": new_name, "search_config": {"top_k": 3}},
)
assert update_res.status_code == 200
update_payload = update_res.json()
assert update_payload["code"] == 0, update_payload
assert update_payload["data"]["name"] == new_name, update_payload
@pytest.mark.p2
def test_search_create_invalid_name(rest_client):
res = rest_client.post("/searches", json={"name": ""})
assert res.status_code == 200
payload = res.json()
assert payload["code"] == 102, payload
assert "empty" in payload["message"], payload
@pytest.mark.p2
def test_search_update_invalid_search_id(rest_client):
res = rest_client.put(
"/searches/invalid_search_id",
json={"name": "invalid", "search_config": {}},
)
assert res.status_code == 200
payload = res.json()
assert payload["code"] == 109, payload
assert "no authorization" in payload["message"].lower(), payload
@pytest.mark.p2
def test_search_completion_requires_question(rest_client, search_resource):
search_id = search_resource
expected_message = "question is required" if IS_GO_PROXY else "required argument are missing: question"
completion_res = rest_client.post(f"/searches/{search_id}/completion", json={})
assert completion_res.status_code == 200
completion_payload = completion_res.json()
assert completion_payload["code"] == 101, completion_payload
assert expected_message in completion_payload["message"], completion_payload
completions_res = rest_client.post(f"/searches/{search_id}/completions", json={})
assert completions_res.status_code == 200
completions_payload = completions_res.json()
assert completions_payload["code"] == 101, completions_payload
assert expected_message in completions_payload["message"], completions_payload
@pytest.mark.p2
def test_search_completion_requires_kb_ids(rest_client, search_resource):
search_id = search_resource
for path in ("completion", "completions"):
res = rest_client.post(
f"/searches/{search_id}/{path}",
json={"question": "what is coriander?"},
)
assert res.status_code == 200
payload = res.json()
assert payload["code"] == 102, payload
assert "`kb_ids` is required" in payload["message"], payload
@pytest.mark.p2
def test_search_completion_sse_shape_when_kb_ids_provided(rest_client, search_resource):
search_id = search_resource
# Even with kb_ids provided, runtime may return an error event in-stream, but
# contract remains SSE with JSON data lines and terminal boolean event.
res = rest_client.post(
f"/searches/{search_id}/completion",
json={"question": "what is coriander?", "kb_ids": ["nonexistent_dataset"]},
timeout=60,
)
assert res.status_code == 200
payload = res.json()
assert payload["code"] == 102, payload
assert "You don't own the dataset nonexistent_dataset" in payload["message"], payload