Files
ragflow/internal/agent/tool/searxng_test.go
Hz_ d03b09b6a3 fix(go-agent): Align Go WenCai and SearXNG agent components with python (#16854)
## Summary

- Align Go WenCai and SearXNG behavior, schemas, and node parameters
with Python.
- Add the `WenCai` and `SearXNG` Canvas components and register their
tool factories.
- Match Python's current WenCai behavior by returning an empty report
while its upstream request is disabled.
- Add SearXNG request validation, SSRF-safe DNS pinning, raw result
preservation, and reference rendering.
- Support context cancellation, error envelopes, and lock-safe retrieval
references.

  ## Tests

  Passed:

  - `bash build.sh --test ./internal/agent/tool/...`
  - `bash build.sh --test ./internal/agent/component/...`
  - `bash build.sh --test ./internal/agent/runtime/...`
  - `bash build.sh --test ./internal/agent/...`
  - `cd web && npm run type-check`
  
  
<img width="1900" height="1102" alt="image"
src="https://github.com/user-attachments/assets/ec77d217-d9fd-455a-96ec-9aabf6841109"
/>
  
<img width="1900" height="1102" alt="image"
src="https://github.com/user-attachments/assets/52ac129f-cb65-453d-ae48-cc518803ac23"
/>
2026-07-13 16:50:17 +08:00

252 lines
7.4 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package tool
import (
"context"
"encoding/json"
"errors"
"net"
"net/http"
"net/http/httptest"
"net/url"
"strings"
"sync/atomic"
"testing"
)
func TestSearXNGBuildURLMatchesPythonQuery(t *testing.T) {
t.Parallel()
got := buildSearXNGURL("https://searx.example.com", "rag flow")
parsed, err := url.Parse(got)
if err != nil {
t.Fatalf("url.Parse(%q): %v", got, err)
}
if parsed.Path != "/search" {
t.Fatalf("path = %q, want /search", parsed.Path)
}
want := map[string]string{
"q": "rag flow",
"format": "json",
"categories": "general",
"language": "auto",
"safesearch": "1",
"pageno": "1",
}
for key, value := range want {
if actual := parsed.Query().Get(key); actual != value {
t.Errorf("query[%s] = %q, want %q", key, actual, value)
}
}
}
func TestSearXNGInvokableRunPreservesRawResultsAndTopN(t *testing.T) {
t.Parallel()
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, request *http.Request) {
if request.URL.Path != "/search" {
t.Errorf("path = %q, want /search", request.URL.Path)
}
if request.URL.Query().Get("q") != " ragflow search " {
t.Errorf("q = %q, want original query whitespace", request.URL.Query().Get("q"))
}
w.Header().Set("Content-Type", "application/json")
_, _ = w.Write([]byte(`{
"results": [
{"title":"RAGFlow","url":"https://ragflow.io","content":"Open source RAG engine","engine":"bing","score":0.9},
{"title":"GitHub","url":"https://github.com/infiniflow/ragflow","content":"Source code","engines":["google","bing"]},
{"title":"Dropped","url":"https://example.com","content":"top_n applies"}
]
}`))
}))
defer server.Close()
defaults := defaultSearXNGParams()
defaults.SearXNGURL = server.URL
defaults.TopN = 2
searchTool := newLocalSearXNGTool(t, defaults)
out, err := searchTool.InvokableRun(context.Background(), `{"query":" ragflow search ","searxng_url":"http://127.0.0.1:1"}`)
if err != nil {
t.Fatalf("InvokableRun: %v", err)
}
var envelope searxngEnvelope
if err := json.Unmarshal([]byte(out), &envelope); err != nil {
t.Fatalf("output is not valid JSON: %v (raw=%s)", err, out)
}
if len(envelope.Results) != 2 {
t.Fatalf("results len = %d, want 2", len(envelope.Results))
}
first := envelope.Results[0].(map[string]any)
if first["engine"] != "bing" || first["score"] != float64(0.9) {
t.Fatalf("first result lost upstream fields: %#v", first)
}
second := envelope.Results[1].(map[string]any)
if _, ok := second["engines"].([]any); !ok {
t.Fatalf("second result lost engines: %#v", second)
}
}
func TestSearXNGInfoMatchesPythonModelSchema(t *testing.T) {
t.Parallel()
info, err := NewSearXNGTool().Info(context.Background())
if err != nil {
t.Fatalf("Info: %v", err)
}
if info.Name != "searxng_search" {
t.Fatalf("Name = %q, want searxng_search", info.Name)
}
if info.Desc != searxngToolDescription {
t.Fatalf("Desc = %q, want Python description", info.Desc)
}
jsonSchema, err := info.ParamsOneOf.ToJSONSchema()
if err != nil {
t.Fatalf("ToJSONSchema: %v", err)
}
raw, err := json.Marshal(jsonSchema)
if err != nil {
t.Fatalf("marshal schema: %v", err)
}
schemaText := string(raw)
for _, key := range []string{`"query"`, `"searxng_url"`, `"required":["query"]`} {
if !strings.Contains(schemaText, key) {
t.Fatalf("schema missing %s: %s", key, schemaText)
}
}
if strings.Contains(schemaText, `"top_n"`) {
t.Fatalf("schema leaked node config top_n: %s", schemaText)
}
}
func TestSearXNGEmptyTryRunInputsSkipRequest(t *testing.T) {
t.Parallel()
searchTool := NewSearXNGTool()
var resolves atomic.Int32
searchTool.resolve = func(string) (string, net.IP, error) {
resolves.Add(1)
return "", nil, errors.New("must not resolve")
}
for _, args := range []string{
`{"query":""}`,
`{"query":" ","searxng_url":"https://example.com"}`,
`{"query":"ragflow"}`,
} {
out, err := searchTool.InvokableRun(context.Background(), args)
if err != nil {
t.Fatalf("InvokableRun(%s): %v", args, err)
}
var envelope searxngEnvelope
if err := json.Unmarshal([]byte(out), &envelope); err != nil || len(envelope.Results) != 0 || envelope.Error != "" {
t.Fatalf("InvokableRun(%s) = %s, want empty results", args, out)
}
}
if resolves.Load() != 0 {
t.Fatalf("resolver calls = %d, want 0", resolves.Load())
}
}
func TestSearXNGBuildByNameAcceptsPythonNodeParams(t *testing.T) {
t.Parallel()
built, err := BuildByName("searxng", map[string]any{
"top_n": "8",
"searxng_url": "https://searx.example.com",
})
if err != nil {
t.Fatalf("BuildByName: %v", err)
}
searchTool, ok := built.(*SearXNGTool)
if !ok {
t.Fatalf("built type = %T, want *SearXNGTool", built)
}
if searchTool.defaults.TopN != 8 || searchTool.defaults.SearXNGURL != "https://searx.example.com" {
t.Fatalf("defaults = %+v", searchTool.defaults)
}
}
func TestSearXNGBuildByNameRejectsInvalidNodeParams(t *testing.T) {
t.Parallel()
invalid := []map[string]any{
{"top_n": "abc"},
{"top_n": 0},
{"top_n": 1.5},
{"unknown": true},
}
for _, params := range invalid {
if _, err := BuildByName("searxng", params); err == nil {
t.Fatalf("BuildByName(%#v) succeeded, want validation error", params)
}
}
}
func TestSearXNGDoesNotRetryFailedRequest(t *testing.T) {
t.Parallel()
var calls atomic.Int32
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
calls.Add(1)
http.Error(w, "temporary", http.StatusServiceUnavailable)
}))
defer server.Close()
defaults := defaultSearXNGParams()
defaults.SearXNGURL = server.URL
searchTool := newLocalSearXNGTool(t, defaults)
if _, err := searchTool.InvokableRun(context.Background(), `{"query":"single attempt"}`); err == nil {
t.Fatal("InvokableRun succeeded, want upstream error")
}
if calls.Load() != 1 {
t.Fatalf("request calls = %d, want 1", calls.Load())
}
}
func TestSearXNGSSRFGuardRejectsLoopback(t *testing.T) {
t.Parallel()
defaults := defaultSearXNGParams()
defaults.SearXNGURL = "http://127.0.0.1:4000"
searchTool := newSearXNGToolWithDefaults(nil, defaults)
out, err := searchTool.InvokableRun(context.Background(), `{"query":"metadata"}`)
if err == nil || !errors.Is(err, ErrSSRFBlocked) {
t.Fatalf("err = %v, want ErrSSRFBlocked", err)
}
if !strings.Contains(out, `"_ERROR"`) {
t.Fatalf("output = %s, want _ERROR envelope", out)
}
}
func newLocalSearXNGTool(t *testing.T, defaults searxngParams) *SearXNGTool {
t.Helper()
searchTool := newSearXNGToolWithDefaults(nil, defaults)
searchTool.resolve = func(rawURL string) (string, net.IP, error) {
parsed, err := url.Parse(rawURL)
if err != nil {
return "", nil, err
}
ip := net.ParseIP(parsed.Hostname())
if ip == nil {
return "", nil, errors.New("test URL must use a literal IP")
}
return parsed.Hostname(), ip, nil
}
return searchTool
}