Files
ragflow/internal/agent/canvas/node_body_setup_override_test.go
Zhichang Yu fb42e5531d Refactor: drop dead canvas runtime selector and tokenizer embedding wiring (#16809)
Two refactors on the Go port (agent-go-port):

- Remove the dead per-tenant canvas runtime selector (write-only Redis
scaffolding with no runtime callers) and its dependent metrics/admin
code.
- Move the tokenizer embedding-model id from the shared ingestion
globals into a Tokenizer-scoped setup, and wire the production embedder
resolver in the ingestion task package.

32 files changed, 861 insertions, 1228 deletions.
2026-07-10 15:46:45 +08:00

153 lines
5.0 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package canvas
import (
"context"
"testing"
"ragflow/internal/agent/runtime"
)
// stubComponent records the params it was constructed with so a test can
// assert that buildNodeBody forwarded the merged setups. Its Invoke is a
// no-op echo.
type stubComponent struct {
params map[string]any
}
func (s *stubComponent) Invoke(_ context.Context, in map[string]any) (map[string]any, error) {
return in, nil
}
// TestBuildNodeBody_SetupOverrides asserts that a run-level setups override
// (threaded via ctx, keyed by cpnID) is merged into the component's
// `params["setups"]` before the factory is called. Only the entry for the
// component's own cpnID applies. The merge is shallow: a top-level key
// present in the override fully replaces the base entry for that key
// (no inner deep-merge), while base keys absent from the override survive.
func TestBuildNodeBody_SetupOverrides(t *testing.T) {
captured := map[string]any{}
factory := func(name string, params map[string]any) (runtime.Component, error) {
// Deep-shallow copy so later mutations by the builder don't
// hide what the factory actually received.
cp := make(map[string]any, len(params))
for k, v := range params {
cp[k] = v
}
captured = cp
return &stubComponent{params: cp}, nil
}
baseParams := map[string]any{
"setups": map[string]any{
"pdf": map[string]any{
"output_format": "one",
"parse_method": "naive",
},
"doc": map[string]any{
"output_format": "one",
},
},
}
// Run-level override is keyed by cpnID. For "cpn-parser": the whole
// "pdf" entry is replaced (parse_method is dropped), and a new "docx"
// entry is injected. "doc" is untouched because it is absent from the
// override. The entry for a different cpnID must not leak in.
override := map[string]any{
"cpn-parser": map[string]any{
"pdf": map[string]any{
"output_format": "detailed",
},
"docx": map[string]any{
"output_format": "one",
},
},
"cpn-other": map[string]any{
"pdf": map[string]any{
"output_format": "should-not-apply",
},
},
}
ctx := WithComponentFactory(context.Background(), factory)
ctx = withSetupOverrides(ctx, override)
body, err := buildNodeBody(ctx, "cpn-parser", "Parser", baseParams)
if err != nil {
t.Fatalf("buildNodeBody: %v", err)
}
if _, err := body(context.Background(), map[string]any{"x": 1}); err != nil {
t.Fatalf("body: %v", err)
}
got, ok := captured["setups"].(map[string]any)
if !ok {
t.Fatalf("factory did not receive a setups map: %#v", captured["setups"])
}
// doc is untouched (absent from the override).
if v, _ := got["doc"].(map[string]any); v == nil || v["output_format"] != "one" {
t.Errorf("doc should be preserved from base: %#v", got["doc"])
}
// docx injected by the override (was absent in base).
if v, _ := got["docx"].(map[string]any); v == nil || v["output_format"] != "one" {
t.Errorf("docx injection missing: %#v", got["docx"])
}
// pdf: the override fully replaces the base entry, so output_format is
// overridden and the base-only parse_method is dropped (shallow merge).
pdf, _ := got["pdf"].(map[string]any)
if pdf == nil {
t.Fatalf("pdf setup missing: %#v", got)
}
if pdf["output_format"] != "detailed" {
t.Errorf("pdf.output_format not overridden: %#v", pdf)
}
if _, ok := pdf["parse_method"]; ok {
t.Errorf("pdf.parse_method should be dropped by shallow merge: %#v", pdf)
}
}
// TestBuildNodeBody_SetupOverridesNilIsNoOp asserts that with no override in
// ctx the component receives exactly its base params (no spurious setups key
// injected, and the original map is untouched).
func TestBuildNodeBody_SetupOverridesNilIsNoOp(t *testing.T) {
captured := map[string]any{}
factory := func(name string, params map[string]any) (runtime.Component, error) {
cp := make(map[string]any, len(params))
for k, v := range params {
cp[k] = v
}
captured = cp
return &stubComponent{params: cp}, nil
}
baseParams := map[string]any{"name": "x"}
ctx := WithComponentFactory(context.Background(), factory)
body, err := buildNodeBody(ctx, "cpn", "Parser", baseParams)
if err != nil {
t.Fatalf("buildNodeBody: %v", err)
}
if _, err := body(context.Background(), map[string]any{}); err != nil {
t.Fatalf("body: %v", err)
}
if _, ok := captured["setups"]; ok {
t.Errorf("setups key should not be injected when no override is present: %#v", captured)
}
if _, ok := baseParams["setups"]; ok {
t.Errorf("base params map must not be mutated: %#v", baseParams)
}
}