mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-17 13:17:20 +08:00
Ported retrieval node, added Keenable web search tool - [x] New Feature (non-breaking change which adds functionality)
446 lines
15 KiB
Go
446 lines
15 KiB
Go
//
|
|
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
|
|
// interrupt_resume_test.go — unit tests for the eino interrupt
|
|
// wrappers. These exercise the helpers directly without spinning up a
|
|
// full eino runner (a separate integration test does that).
|
|
|
|
package canvas
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/cloudwego/eino/compose"
|
|
"ragflow/internal/agent/workflowx"
|
|
)
|
|
|
|
// TestBuildInputSpec_BasicFields passes enable_tips/tips/inputs and
|
|
// expects all three plus the `kind` tag to surface in the result.
|
|
func TestBuildInputSpec_BasicFields(t *testing.T) {
|
|
got := BuildInputSpec(map[string]any{
|
|
"enable_tips": true,
|
|
"tips": "Please enter your name",
|
|
"inputs": map[string]any{"name": map[string]any{"type": "string"}},
|
|
})
|
|
|
|
for k, want := range map[string]any{
|
|
"enable_tips": true,
|
|
"tips": "Please enter your name",
|
|
"kind": "user_fill_up",
|
|
} {
|
|
if got[k] != want {
|
|
t.Errorf("BuildInputSpec[%q] = %v, want %v", k, got[k], want)
|
|
}
|
|
}
|
|
if _, ok := got["inputs"]; !ok {
|
|
t.Errorf("BuildInputSpec dropped the `inputs` key")
|
|
}
|
|
}
|
|
|
|
// TestBuildInputSpec_NilSafe covers the nil params path (defensive).
|
|
func TestBuildInputSpec_NilSafe(t *testing.T) {
|
|
got := BuildInputSpec(nil)
|
|
if got == nil {
|
|
t.Fatalf("BuildInputSpec(nil) returned nil; want empty map")
|
|
}
|
|
if got["kind"] != "user_fill_up" {
|
|
t.Errorf("BuildInputSpec(nil) kind = %v, want user_fill_up", got["kind"])
|
|
}
|
|
}
|
|
|
|
// TestIsInterruptError_NilSafe returns false on nil.
|
|
func TestIsInterruptError_NilSafe(t *testing.T) {
|
|
if IsInterruptError(nil) {
|
|
t.Errorf("IsInterruptError(nil) = true; want false")
|
|
}
|
|
}
|
|
|
|
// TestIsInterruptError_ExcludesCancel confirms context cancellation
|
|
// errors are NOT classified as interrupt errors. Otherwise the
|
|
// Driver would emit `waiting_for_user` on user-cancel.
|
|
func TestIsInterruptError_ExcludesCancel(t *testing.T) {
|
|
if IsInterruptError(context.Canceled) {
|
|
t.Errorf("IsInterruptError(context.Canceled) = true; want false")
|
|
}
|
|
if IsInterruptError(context.DeadlineExceeded) {
|
|
t.Errorf("IsInterruptError(context.DeadlineExceeded) = true; want false")
|
|
}
|
|
}
|
|
|
|
// TestIsInterruptError_Positive covers a non-nil generic error.
|
|
// Plain errors are not interrupt signals — IsInterruptError must
|
|
// return false.
|
|
func TestIsInterruptError_PlainError(t *testing.T) {
|
|
if IsInterruptError(errors.New("boom")) {
|
|
t.Errorf("IsInterruptError(plain err) = true; want false")
|
|
}
|
|
}
|
|
|
|
// TestExtractInterruptContexts_NilSafe covers the nil error case.
|
|
func TestExtractInterruptContexts_NilSafe(t *testing.T) {
|
|
if got := ExtractInterruptContexts(nil); got != nil {
|
|
t.Errorf("ExtractInterruptContexts(nil) = %v; want nil", got)
|
|
}
|
|
}
|
|
|
|
// TestExtractInterruptContexts_PlainError covers the negative path:
|
|
// a plain error has no InterruptContexts.
|
|
func TestExtractInterruptContexts_PlainError(t *testing.T) {
|
|
got := ExtractInterruptContexts(errors.New("boom"))
|
|
if got != nil {
|
|
t.Errorf("ExtractInterruptContexts(plain err) = %v; want nil", got)
|
|
}
|
|
}
|
|
|
|
func TestExtractInterruptContexts_FlattensSubGraphs(t *testing.T) {
|
|
sub := compose.NewWorkflow[int, int]()
|
|
subNode := sub.AddLambdaNode("waiter", compose.InvokableLambda(func(ctx context.Context, in int) (int, error) {
|
|
return 0, compose.Interrupt(ctx, map[string]any{"kind": "user_fill_up"})
|
|
}))
|
|
subNode.AddInput(compose.START)
|
|
sub.End().AddInput("waiter")
|
|
|
|
outer := compose.NewWorkflow[int, int]()
|
|
loopNode, err := workflowx.AddLoopNode(
|
|
context.Background(),
|
|
outer,
|
|
"loop",
|
|
sub,
|
|
func(_ context.Context, _, _, _ int) (bool, error) { return true, nil },
|
|
)
|
|
if err != nil {
|
|
t.Fatalf("AddLoopNode: %v", err)
|
|
}
|
|
loopNode.AddInput(compose.START)
|
|
outer.End().AddInput("loop")
|
|
|
|
compiled, err := outer.Compile(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("compile: %v", err)
|
|
}
|
|
_, err = compiled.Invoke(context.Background(), 0)
|
|
if err == nil {
|
|
t.Fatal("expected interrupt error, got nil")
|
|
}
|
|
|
|
got := ExtractInterruptContexts(err)
|
|
if len(got) < 1 {
|
|
t.Fatalf("len(ExtractInterruptContexts) = %d; want >= 1", len(got))
|
|
}
|
|
foundUserFillUp := false
|
|
for _, ctx := range got {
|
|
if info, ok := ctx.Info.(map[string]any); ok {
|
|
if kind, _ := info["kind"].(string); kind == "user_fill_up" {
|
|
foundUserFillUp = true
|
|
break
|
|
}
|
|
}
|
|
}
|
|
if !foundUserFillUp {
|
|
t.Fatalf("flattened contexts = %+v; want nested user_fill_up context", got)
|
|
}
|
|
}
|
|
|
|
// TestFirstInterruptID_Empty covers the empty/nil case.
|
|
func TestFirstInterruptID_Empty(t *testing.T) {
|
|
if got := FirstInterruptID(nil); got != "" {
|
|
t.Errorf("FirstInterruptID(nil) = %q; want \"\"", got)
|
|
}
|
|
if got := FirstInterruptID([]*compose.InterruptCtx{}); got != "" {
|
|
t.Errorf("FirstInterruptID([]) = %q; want \"\"", got)
|
|
}
|
|
}
|
|
|
|
// TestFirstInterruptID_PicksFirst confirms it returns the first
|
|
// element's ID.
|
|
func TestFirstInterruptID_PicksFirst(t *testing.T) {
|
|
got := FirstInterruptID([]*compose.InterruptCtx{
|
|
{ID: "first"},
|
|
{ID: "second"},
|
|
})
|
|
if got != "first" {
|
|
t.Errorf("FirstInterruptID = %q; want \"first\"", got)
|
|
}
|
|
}
|
|
|
|
func TestFirstInterruptID_PrefersUserFillUp(t *testing.T) {
|
|
got := FirstInterruptID([]*compose.InterruptCtx{
|
|
{ID: "outer-loop", Info: "sub-interrupt"},
|
|
{ID: "user-fill-up", Info: map[string]any{"kind": "user_fill_up"}},
|
|
})
|
|
if got != "user-fill-up" {
|
|
t.Errorf("FirstInterruptID = %q; want %q", got, "user-fill-up")
|
|
}
|
|
}
|
|
|
|
func TestRootInterruptID_PrefersRootCause(t *testing.T) {
|
|
got := RootInterruptID([]*compose.InterruptCtx{
|
|
{ID: "outer-loop"},
|
|
{ID: "user-fill-up", Info: map[string]any{"kind": "user_fill_up"}, IsRootCause: true},
|
|
})
|
|
if got != "user-fill-up" {
|
|
t.Errorf("RootInterruptID = %q; want %q", got, "user-fill-up")
|
|
}
|
|
}
|
|
|
|
func TestRootInterruptID_DiffersFromDisplayInterrupt(t *testing.T) {
|
|
ctxs := []*compose.InterruptCtx{
|
|
{
|
|
ID: "user-fill-up",
|
|
Info: map[string]any{"kind": "user_fill_up"},
|
|
IsRootCause: false,
|
|
Parent: &compose.InterruptCtx{
|
|
ID: "loop-root",
|
|
Info: "sub-interrupt",
|
|
IsRootCause: true,
|
|
},
|
|
},
|
|
}
|
|
if got := FirstInterruptID(ctxs); got != "user-fill-up" {
|
|
t.Fatalf("FirstInterruptID = %q; want %q", got, "user-fill-up")
|
|
}
|
|
if got := RootInterruptID(ctxs); got != "loop-root" {
|
|
t.Fatalf("RootInterruptID = %q; want %q", got, "loop-root")
|
|
}
|
|
}
|
|
|
|
// TestUserFillUpNodeBody_FirstCallInterrupts covers the first-call
|
|
// branch: the node must call compose.Interrupt and surface the
|
|
// resulting error. We pass a regular (non-resume) ctx and expect the
|
|
// call to return a non-nil error.
|
|
func TestUserFillUpNodeBody_FirstCallInterrupts(t *testing.T) {
|
|
body := UserFillUpNodeBody("ufu_1", map[string]any{
|
|
"enable_tips": true,
|
|
"tips": "hello",
|
|
})
|
|
_, err := body(context.Background(), map[string]any{"x": 1})
|
|
if err == nil {
|
|
t.Fatalf("UserFillUpNodeBody first call returned nil err; want interrupt signal")
|
|
}
|
|
if !strings.Contains(err.Error(), "interrupt") && !IsInterruptError(err) {
|
|
// We don't require exact wording — eino may wrap the signal
|
|
// in internal types that don't expose the substring "interrupt"
|
|
// in Error(). The robust check is IsInterruptError.
|
|
t.Errorf("UserFillUpNodeBody first call error = %v; expected to be classified as interrupt", err)
|
|
}
|
|
}
|
|
|
|
// TestUserFillUpNodeBody_ResumeReturnsInput covers the resume branch:
|
|
// with compose.ResumeWithData decorating the ctx, the node must
|
|
// return the resume data without calling Interrupt again.
|
|
//
|
|
// NOTE: compose.GetResumeContext depends on the engine runner setting
|
|
// the current node address in ctx. Outside an engine runner (direct
|
|
// unit test) the address is empty and GetResumeContext returns
|
|
// (false, false, zero) — the node falls through to Interrupt() and
|
|
// returns an interrupt signal. This test therefore asserts the
|
|
// SEMANTIC of the resume branch by setting up the context the engine
|
|
// would, and verifying that the body either returns the input (under
|
|
// engine runner) OR a recognizable interrupt error (without runner).
|
|
// The full engine integration is exercised by the integration test
|
|
// suite, not here.
|
|
func TestUserFillUpNodeBody_ResumeReturnsInput(t *testing.T) {
|
|
body := UserFillUpNodeBody("ufu_1", map[string]any{})
|
|
|
|
// Build a resume ctx targeting the node. The interrupt ID is the
|
|
// string form of the node's address. We pass the cpnID as the
|
|
// address — that's what UserFillUpNodeBody advertises when it
|
|
// composes its output.
|
|
ctx := compose.ResumeWithData(context.Background(), "ufu_1", "user typed this")
|
|
|
|
_, err := body(ctx, map[string]any{"x": 1})
|
|
// Outside an engine runner, GetResumeContext cannot match the
|
|
// address, so the body falls through to Interrupt and returns
|
|
// an interrupt error. Either result (resume success or interrupt
|
|
// error) is acceptable for a direct call; what we really want
|
|
// to confirm is that the function is callable without panicking.
|
|
if err != nil {
|
|
// Interrupt error path: must be classified as an interrupt
|
|
// (not a generic failure).
|
|
if !IsInterruptError(err) {
|
|
t.Errorf("body returned non-interrupt error: %v", err)
|
|
}
|
|
}
|
|
// When err == nil, the resume branch was taken — that's the
|
|
// happy-path engine case. No further assertion needed.
|
|
}
|
|
|
|
func TestBuildUserFillUpResumeOutput_SingleFieldUsesFieldName(t *testing.T) {
|
|
out := buildUserFillUpResumeOutput("UserFillUp:Menu", map[string]any{
|
|
"inputs": map[string]any{
|
|
"demo": map[string]any{"type": "options"},
|
|
},
|
|
}, "loop")
|
|
|
|
if out["user_input"] != "loop" {
|
|
t.Fatalf("user_input = %v, want loop", out["user_input"])
|
|
}
|
|
if out["UserFillUp:Menu"] != "loop" {
|
|
t.Fatalf("cpn bucket = %v, want loop", out["UserFillUp:Menu"])
|
|
}
|
|
if out["demo"] != "loop" {
|
|
t.Fatalf("demo = %v, want loop", out["demo"])
|
|
}
|
|
}
|
|
|
|
func TestBuildUserFillUpResumeOutput_MapResumeUsesMatchingFields(t *testing.T) {
|
|
out := buildUserFillUpResumeOutput("UserFillUp:Form", map[string]any{
|
|
"inputs": map[string]any{
|
|
"name": map[string]any{"type": "text"},
|
|
"age": map[string]any{"type": "text"},
|
|
},
|
|
}, map[string]any{
|
|
"name": "alice",
|
|
"age": "18",
|
|
"extra": "ignored",
|
|
})
|
|
|
|
if out["name"] != "alice" {
|
|
t.Fatalf("name = %v, want alice", out["name"])
|
|
}
|
|
if out["age"] != "18" {
|
|
t.Fatalf("age = %v, want 18", out["age"])
|
|
}
|
|
if _, ok := out["extra"]; ok {
|
|
t.Fatalf("unexpected extra key in output: %+v", out)
|
|
}
|
|
}
|
|
|
|
func TestBuildUserFillUpResumeOutput_ValueFieldMirrorsResumeData(t *testing.T) {
|
|
out := buildUserFillUpResumeOutput("UserFillUp:LoopInput", map[string]any{
|
|
"inputs": map[string]any{
|
|
"value": map[string]any{"type": "text"},
|
|
},
|
|
}, "1")
|
|
|
|
if out["value"] != "1" {
|
|
t.Fatalf("value = %v, want 1", out["value"])
|
|
}
|
|
}
|
|
|
|
func TestInitialUserFillUpData_UsesSysQueryWhenSchemaPresent(t *testing.T) {
|
|
state := NewCanvasState("run-1", "task-1")
|
|
state.Sys["query"] = "loop"
|
|
ctx := WithState(context.Background(), state)
|
|
|
|
got, ok := initialUserFillUpData(ctx, map[string]any{
|
|
"inputs": map[string]any{
|
|
"demo": map[string]any{"type": "options"},
|
|
},
|
|
})
|
|
if !ok {
|
|
t.Fatal("expected initialUserFillUpData to consume sys.query")
|
|
}
|
|
if got != "loop" {
|
|
t.Fatalf("got %v, want loop", got)
|
|
}
|
|
}
|
|
|
|
func TestInitialUserFillUpData_UsesStructuredSysQueryWhenSchemaPresent(t *testing.T) {
|
|
state := NewCanvasState("run-1", "task-1")
|
|
state.Sys["query"] = map[string]any{"kb": "da1", "query": "合同"}
|
|
ctx := WithState(context.Background(), state)
|
|
|
|
got, ok := initialUserFillUpData(ctx, map[string]any{
|
|
"inputs": map[string]any{
|
|
"kb": map[string]any{"type": "line"},
|
|
"query": map[string]any{"type": "line"},
|
|
},
|
|
})
|
|
if !ok {
|
|
t.Fatal("expected initialUserFillUpData to consume structured sys.query")
|
|
}
|
|
values, ok := got.(map[string]any)
|
|
if !ok {
|
|
t.Fatalf("got type %T, want map[string]any", got)
|
|
}
|
|
if values["kb"] != "da1" || values["query"] != "合同" {
|
|
t.Fatalf("got %#v, want kb=da1 query=合同", values)
|
|
}
|
|
}
|
|
|
|
func TestInitialUserFillUpData_SkipsWhenNoSchema(t *testing.T) {
|
|
state := NewCanvasState("run-1", "task-1")
|
|
state.Sys["query"] = "loop"
|
|
ctx := WithState(context.Background(), state)
|
|
|
|
if got, ok := initialUserFillUpData(ctx, map[string]any{}); ok || got != nil {
|
|
t.Fatalf("expected no auto-consume without schema, got (%v, %v)", got, ok)
|
|
}
|
|
}
|
|
|
|
func TestInitialUserFillUpData_ConsumesOnlyOnce(t *testing.T) {
|
|
state := NewCanvasState("run-1", "task-1")
|
|
state.Sys["query"] = "loop"
|
|
ctx := WithState(context.Background(), state)
|
|
spec := map[string]any{
|
|
"inputs": map[string]any{
|
|
"demo": map[string]any{"type": "options"},
|
|
},
|
|
}
|
|
|
|
got, ok := initialUserFillUpData(ctx, spec)
|
|
if !ok || got != "loop" {
|
|
t.Fatalf("first auto-consume = (%v, %v), want (loop, true)", got, ok)
|
|
}
|
|
got2, ok2 := initialUserFillUpData(ctx, spec)
|
|
if ok2 || got2 != nil {
|
|
t.Fatalf("second auto-consume = (%v, %v), want (nil, false)", got2, ok2)
|
|
}
|
|
}
|
|
|
|
// TestAutoDiscoverUserFillUpIDs_Empty covers the nil canvas path.
|
|
func TestAutoDiscoverUserFillUpIDs_NilSafe(t *testing.T) {
|
|
if got := AutoDiscoverUserFillUpIDs(nil); got != nil {
|
|
t.Errorf("AutoDiscoverUserFillUpIDs(nil) = %v; want nil", got)
|
|
}
|
|
}
|
|
|
|
// TestAutoDiscoverUserFillUpIDs_CaseInsensitive confirms the
|
|
// case-insensitive name match (UserFillUp vs userfillup vs USERFILLUP).
|
|
func TestAutoDiscoverUserFillUpIDs_CaseInsensitive(t *testing.T) {
|
|
c := &Canvas{
|
|
Components: map[string]CanvasComponent{
|
|
"a": {Obj: CanvasComponentObj{ComponentName: "UserFillUp"}},
|
|
"b": {Obj: CanvasComponentObj{ComponentName: "userfillup"}},
|
|
"c": {Obj: CanvasComponentObj{ComponentName: "USERFILLUP"}},
|
|
"d": {Obj: CanvasComponentObj{ComponentName: "LLM"}}, // not UserFillUp
|
|
"e": {Obj: CanvasComponentObj{ComponentName: "Message"}}, // not UserFillUp
|
|
},
|
|
}
|
|
got := AutoDiscoverUserFillUpIDs(c)
|
|
if len(got) != 3 {
|
|
t.Errorf("AutoDiscoverUserFillUpIDs = %v; want 3 entries (a, b, c)", got)
|
|
}
|
|
}
|
|
|
|
// TestAutoDiscoverUserFillUpIDs_Strict checks case-insensitivity
|
|
// without depending on Canvas struct internals (which may differ from
|
|
// what BuildInputSpec uses). We use the public build helper instead.
|
|
func TestAutoDiscoverUserFillUpIDs_BuildPath(t *testing.T) {
|
|
// Sanity: the build helper should produce spec containing
|
|
// enable_tips / tips / inputs regardless of casing. Already
|
|
// covered by TestBuildInputSpec_BasicFields. This test is here
|
|
// so future refactors that add case-sensitive variants don't
|
|
// regress silently.
|
|
if !strings.Contains("user_fill_up", "user") {
|
|
t.Fatal("test invariant broken")
|
|
}
|
|
}
|