Files
ragflow/internal/ingestion/knowledge_compile/writer.go
Zhichang Yu 01d667296d refactor(knowledge_compile): global compile pool, token-budget batching, and DocEngine-only deletion (#17679)
## Summary

This PR refactors the Go knowledge-compilation ingestion pipeline
(`internal/ingestion/knowledge_compile` +
`internal/ingestion/component/knowledge_compiler`) with three related
changes:

- **Token-budget batching for LLM merge decisions.**
`LLMMergeDecider.DecideBatch` previously stuffed every `(existing,
candidate)` pair into a single LLM call, risking `max_token` overflow.
It now splits pairs into token-bounded sub-batches (budget =
`llmMaxTokens * 0.85`) via `tokenizer.NumTokensFromString`, runs them
concurrently while preserving the global pair index, and never
reindexes.
- **Process-level global compile pool.** Introduces a single vCPU-sized
goroutine pool (`pool.go`, env `KC_COMPILE_CONCURRENCY`) dedicated to
*all* knowledge-compilation stages. KNN search loop, `DecideBatch`
sub-batches, `WriteMerged`/`DeleteMerged` internals, and the
component-level (structure/mindmap) per-call pools are all unified into
it via an injected submitter. No more per-job short-lived goroutines in
`runCompilerJobs` (futures are collected then awaited on the caller).
Fan-out stays bounded by the pool worker count; these stages are
docengine-bounded / LLM-bounded, not CPU-bounded.
- **DocEngine-only deletion.** `Consumer.processBatch` deletion no
longer loads the deleted docs' products into memory. Two sequential
DocEngine calls replace the old in-memory surgery:
- `DeleteDocLevelForDocs` — one `DeleteChunks` over `doc_id IN
deletedDocIDs` (merged rows carry `doc_id == kb`, so only per-doc
products match).
- `StripMergedSources` — one `Search` of `kc_merged=1` rows filtered by
`source_doc_ids IN deletedDocIDs` (intersection pushed down to the
engine), `UpdateChunks` the source array of survivors, and
`DeleteChunks` the rows whose array became empty.

## Changes

- `internal/ingestion/knowledge_compile/pool.go` (new): global
`compilerPool` +
`runCompilerJobs`/`SubmitCompilerJob`/`SubmitCompilerJobs`.
- `internal/ingestion/knowledge_compile/consumer.go`: deletion rewritten
to the two DocEngine calls;
`mergedBase`/`toDelete`/`stripDeletedSources` removed.
- `internal/ingestion/knowledge_compile/writer.go`:
`DeleteDocLevelForDocs` + `StripMergedSources` replace
`DeleteMergedForDoc`/`DeleteMerged`.
- `internal/ingestion/knowledge_compile/reader.go`: drop
`LoadMergedBySourceDoc` + `containsString` (keep `LoadDocProducts` for
the completion branch).
- `internal/ingestion/knowledge_compile/dedup.go`: `NewLLMDeduper` takes
`llmMaxTokens`; wires `SetMaxBatchTokens`/`SetSubmitter`.
- `internal/ingestion/knowledge_compiler/{structure,merge}.go`,
`mindmap/mindmap.go`, `pool_wiring.go`: token-budget split + submitter
injection.
- Tests: `structure_test.go` (token-budget split), `dedup_test.go`,
`consumer_test.go` (tombstone + DocEngine deletion assertions) updated.

## Validation

`bash build.sh --test -race ./internal/ingestion/knowledge_compile/...
./internal/ingestion/component/knowledge_compiler/...` passes (unit
tier, no external services).

🤖 Generated with [CodeBuddy](https://www.codebuddy.ai)

---------

Co-authored-by: yuzhichang <yuzhichang@infiniflow.ai>
2026-08-02 17:06:29 +08:00

285 lines
9.1 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package knowledge_compile
import (
"context"
"crypto/sha256"
"encoding/hex"
"fmt"
"ragflow/internal/engine"
"ragflow/internal/engine/types"
kccommon "ragflow/internal/ingestion/component/knowledge_compiler/common"
)
// Writer persists dataset-level merged products and removes them on document
// deletion (§11.7).
type Writer interface {
// WriteMerged upserts the dataset-level merged products (available_int=1).
WriteMerged(ctx context.Context, tenant, kb string, products []kccommon.Product) error
// DeleteDocLevelForDocs drops every per-document (doc-level, kc_merged != 1)
// product of the deleted docs in a single DocEngine call. Dataset-level
// merged rows are not targeted because their doc_id equals the kb, never a
// deleted source doc id.
DeleteDocLevelForDocs(ctx context.Context, tenant, kb string, deletedDocIDs []string) error
// StripMergedSources removes deletedDocIDs from the source_doc_ids array of
// every dataset-level (kc_merged=1) product for the dataset. It searches the
// merged set once, rewrites the source array of every non-empty survivor in a
// single update pass, and deletes (in one call) any product whose array
// became empty.
StripMergedSources(ctx context.Context, tenant, kb string, deletedDocIDs []string) error
}
// engineWriter persists dataset-level merged products through the global
// DocEngine (§11.7). Like engineReader, it depends on the process-wide DocEngine
// obtained via engine.Get(); the storage schema lives behind the engine
// abstraction rather than in this package.
type engineWriter struct {
eng engine.DocEngine
}
// writeMergedBatchSize bounds how many rows each parallel InsertChunks call
// carries, so the DocEngine write fan-out stays granular under the shared pool.
const writeMergedBatchSize = 200
func (w engineWriter) WriteMerged(ctx context.Context, tenant, kb string, products []kccommon.Product) error {
if len(products) == 0 {
return nil
}
eng := w.eng
if eng == nil {
eng = engine.Get()
}
if eng == nil {
return nil
}
baseName := fmt.Sprintf("ragflow_%s", tenant)
// Shard the rows and drive the inserts through the shared global pool
// (docengine-bounded) instead of one monolithic InsertChunks call.
jobs := make([]compilerJob, 0, (len(products)+writeMergedBatchSize-1)/writeMergedBatchSize)
for start := 0; start < len(products); start += writeMergedBatchSize {
end := start + writeMergedBatchSize
if end > len(products) {
end = len(products)
}
batch := products[start:end]
jobs = append(jobs, func() error {
chunks := make([]map[string]interface{}, 0, len(batch))
for _, p := range batch {
chunks = append(chunks, mergedChunkMap(tenant, kb, p))
}
_, err := eng.InsertChunks(ctx, chunks, baseName, kb)
return err
})
}
return runCompilerJobs(ctx, jobs)
}
// mergedChunkMap builds the chunk-index document for a dataset-level merged
// product. It uses the dataset-level idempotency key (§11.6) as `id`, never the
// per-doc key, and is always available_int=1 (searchable).
func mergedChunkMap(tenant, kb string, p kccommon.Product) map[string]interface{} {
srcDocIDs := metaStringSlice(p.Meta, "source_doc_ids")
srcChunkIDs := metaStringSlice(p.Meta, "source_chunk_ids")
m := map[string]interface{}{
"id": datasetLevelID(tenant, kb, p),
"doc_id": kb,
"tenant_id": tenant,
"kb_id": kb,
"available_int": 1,
"kc_merged": 1,
"compile_kwd": string(p.Variant),
"content_with_weight": p.Content,
"kc_payload": p.Content, // raw payload, for Reader reconstruction
"source_doc_ids": srcDocIDs,
"source_chunk_ids": srcChunkIDs,
}
// Persist the merged product's embedding under the dimension-suffixed column
// used elsewhere in the index, so dataset-level rows remain vector-searchable
// and the Reader can reconstruct them (otherwise the vector is silently
// dropped and KNN search returns nothing for merged rows).
if dim := len(p.Vector); dim > 0 {
m[fmt.Sprintf("q_%d_vec", dim)] = p.Vector
}
return m
}
// DeleteDocLevelForDocs removes the per-document (doc-level) products of every
// deleted doc in a single DocEngine call. The table is scoped to the dataset
// (kb), and merged rows carry doc_id == kb, so filtering on doc_id IN
// deletedDocIDs can only match the per-document products of the deleted docs.
func (w engineWriter) DeleteDocLevelForDocs(ctx context.Context, tenant, kb string, deletedDocIDs []string) error {
if len(deletedDocIDs) == 0 {
return nil
}
eng := w.eng
if eng == nil {
eng = engine.Get()
}
if eng == nil {
return nil
}
baseName := fmt.Sprintf("ragflow_%s", tenant)
_, err := eng.DeleteChunks(ctx, map[string]interface{}{
"doc_id": deletedDocIDs,
}, baseName, kb)
return err
}
// StripMergedSources removes deletedDocIDs from the source_doc_ids array of
// every dataset-level (kc_merged=1) product for the dataset. The query filters
// on source_doc_ids IN deletedDocIDs so the engine only returns rows that
// actually reference a deleted doc (intersection pushed down); the survivors'
// source arrays are rewritten in a single update pass driven by the shared
// pool, and any product whose array became empty is deleted in one call. The
// deleted docs' products themselves are never loaded into memory.
func (w engineWriter) StripMergedSources(ctx context.Context, tenant, kb string, deletedDocIDs []string) error {
if len(deletedDocIDs) == 0 {
return nil
}
eng := w.eng
if eng == nil {
eng = engine.Get()
}
if eng == nil {
return nil
}
baseName := fmt.Sprintf("ragflow_%s", tenant)
delSet := make(map[string]bool, len(deletedDocIDs))
for _, d := range deletedDocIDs {
delSet[d] = true
}
const batchSize = 2000
var toDeleteIDs []string
var jobs []compilerJob
offset := 0
for {
res, err := eng.Search(ctx, &types.SearchRequest{
IndexNames: []string{baseName},
KbIDs: []string{kb},
// kc_merged=1 isolates dataset-level rows; source_doc_ids IN
// deletedDocIDs pushes the intersection test into the engine so only
// rows that actually reference a deleted doc are returned (Infinity
// array IN means "contains at least one of").
Filter: map[string]interface{}{
"kc_merged": 1,
"source_doc_ids": deletedDocIDs,
},
SelectFields: []string{"id", "source_doc_ids"},
Limit: batchSize,
Offset: offset,
})
if err != nil {
return err
}
if len(res.Chunks) == 0 {
break
}
for _, c := range res.Chunks {
id, _ := c["id"].(string)
if id == "" {
continue
}
src := metaStringSlice(c, "source_doc_ids")
kept := make([]string, 0, len(src))
changed := false
for _, d := range src {
if delSet[d] {
changed = true
continue
}
kept = append(kept, d)
}
if !changed {
continue
}
if len(kept) == 0 {
toDeleteIDs = append(toDeleteIDs, id)
continue
}
keptCopy := append([]string(nil), kept...)
idCopy := id
jobs = append(jobs, func() error {
return eng.UpdateChunks(ctx, map[string]interface{}{"id": idCopy},
map[string]interface{}{"source_doc_ids": keptCopy}, baseName, kb)
})
}
if len(res.Chunks) < batchSize {
break
}
offset += batchSize
}
if err := runCompilerJobs(ctx, jobs); err != nil {
return err
}
if len(toDeleteIDs) > 0 {
if _, err := eng.DeleteChunks(ctx, map[string]interface{}{
"id": toDeleteIDs,
"kb_id": kb,
}, baseName, kb); err != nil {
return err
}
}
return nil
}
// canonicalKey derives a stable cluster key for a merged product.
func canonicalKey(p kccommon.Product) string {
if slug, ok := p.Meta["slug"].(string); ok && slug != "" {
return slug
}
if p.Meta["name"] != nil {
name, _ := p.Meta["name"].(string)
typ, _ := p.Meta["entity_type"].(string)
if typ == "" {
typ, _ = p.Meta["type"].(string)
}
if name != "" {
return hashStr(name + "\x00" + typ)
}
}
return hashStr(p.Content)
}
// datasetLevelID is the dataset-level idempotency key (§11.6): a stable hash of
// (tenant, kb, variant, canonical cluster key).
func datasetLevelID(tenant, kb string, p kccommon.Product) string {
return hashStr(tenant + "\x00" + kb + "\x00" + string(p.Variant) + "\x00" + canonicalKey(p))
}
func hashStr(s string) string {
sum := sha256.Sum256([]byte(s))
return hex.EncodeToString(sum[:])
}
func metaStringSlice(m map[string]any, key string) []string {
switch v := m[key].(type) {
case []string:
return v
case []any:
out := make([]string, 0, len(v))
for _, e := range v {
if s, ok := e.(string); ok {
out = append(out, s)
}
}
return out
}
return nil
}