Files
ragflow/internal/agent/tool/exesql_unsupported_test.go
Zhichang Yu 4c54cefd29 Port 14 upstream agent security / correctness fixes to Go canvas (#16455)
Mirrors 14 merged upstream PRs into the Go agent port.

PRs ported:
  - #15609 ExeSQL SSRF guard + DNS pin
  - #15436 HTTP timeout on external API tools
  - #16363 be_output restore + DeepL error path
  - #15644 switch no longer matches empty condition
  - #15374 session_id bind to path agent_id (DAO idor guard)
  - #16169 sandbox artifact ownership gate
  - #15457 tenant ownership on agentbots
  - #15145 rerun agent document access check
- #15446 thinking switch (component portion; provider policy lives in
internal/llm)
  - #15426 Invoke URL/proxy SSRF + DNS pin + no-redirects
  - #15238 agentbot thinking-logs beta endpoint
  - #14589 UserFillUp SSE event propagation
  - #14890 anonymous webhook opt-in
- #15068 PipelineChunker new component (text/file_ref/parser_id
dispatch; file-format extraction is a follow-up)

40 files, +2355 / -58 lines. 33 new tests, all targeted package suites
pass (1721 + 4 skipped); 1 pre-existing flaky test unrelated.
2026-06-30 16:28:48 +08:00

71 lines
2.7 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package tool
import (
"context"
"errors"
"testing"
)
// TestExeSQL_TrinoDriverMissing verifies Trino is now routed through the
// Trino DSN path. In this workspace we do not register a real "trino"
// database/sql driver, so InvokableRun should fail at sql.Open with an
// unknown-driver error rather than the old unsupported-db sentinel.
func TestExeSQL_TrinoDriverMissing(t *testing.T) {
conn := exesqlConnParams{DBType: "trino", Host: "1.1.1.1", Port: 8080, Database: "d", Username: "u"}
tool := NewExeSQLTool(conn)
_, err := tool.InvokableRun(context.Background(), `{"sql":"SELECT 1"}`)
if err == nil {
t.Fatal("expected driver error for trino")
}
if errors.Is(err, ErrExeSQLUnsupportedDB) {
t.Fatalf("err=%v, did not want ErrExeSQLUnsupportedDB after trino wiring", err)
}
}
// TestExeSQL_IBMDB2Unsupported: same as above for IBM DB2.
func TestExeSQL_IBMDB2Unsupported(t *testing.T) {
conn := exesqlConnParams{DBType: "ibm db2", Host: "1.1.1.1", Port: 50000, Database: "d", Username: "u"}
tool := NewExeSQLTool(conn)
_, err := tool.InvokableRun(context.Background(), `{"sql":"SELECT 1"}`)
if err == nil {
t.Fatal("expected ErrExeSQLUnsupportedDB for ibm db2")
}
if !errors.Is(err, ErrExeSQLUnsupportedDB) {
t.Errorf("err=%v, want ErrExeSQLUnsupportedDB", err)
}
}
// TestExeSQL_UnknownDB: an unrecognised db_type returns a clear error
// (not a panic). Today this surfaces a plain "unknown db_type"
// error string rather than wrapping ErrExeSQLUnsupportedDB; a
// follow-up should normalize the error. The regression guard here
// is "doesn't panic, returns a non-nil error".
func TestExeSQL_UnknownDB(t *testing.T) {
conn := exesqlConnParams{DBType: "fake-db", Host: "1.1.1.1", Port: 1234, Database: "d", Username: "u"}
tool := NewExeSQLTool(conn)
_, err := tool.InvokableRun(context.Background(), `{"sql":"SELECT 1"}`)
if err == nil {
t.Fatal("expected error for unknown db_type")
}
// Note: today this returns "ExeSQL: unknown db_type ..." rather
// than ErrExeSQLUnsupportedDB. A follow-up should wrap; the
// regression guard just ensures the call returns an error and
// doesn't panic.
}