Files
ragflow/internal/dao/user_canvas_version_test.go
Zhichang Yu 3fa15c0e2f feat(agent): Go port — canvas engine, 22 components, DSL v2, 13 endpoints (#15952)
Ports the agent canvas subsystem from Python to Go.

## What's included

### Canvas Engine (Phase 0/1)
- State engine, scheduler, variable resolver, Redis checkpoint store,
cancel protocol
- **209 tests** across canvas / component / io packages

### 22 Components (P0–P4)
| Tier | Components |
|---|---|
| P0 T1+T2+T3 | LLM, Agent, ExitLoop, Switch, Categorize, Begin,
Message, Invoke |
| P1 T3 | VariableAggregator, VariableAssigner, StringTransform,
ListOperations, DataOperations |
| P2 T3 | Iteration, IterationItem, Loop, LoopItem |
| P3 T3 | UserFillUp, Fillup |
| P4 T5 | Browser, ExcelProcessor, DocsGenerator |

### DSL v2 Schema (Phase 2.5)
- Typed v2 in-memory model with v1-to-v2 auto-detect converter
- v1 legacy field stripping per plan §2.11.7

### HTTP Endpoints & Bug Fixes (Plans PR1–PR3)
- **DELETE SQL bug fix**: gorm v2 `Where("id = ?", id).Delete(...)`
pattern
- **CreateAgent validation**: title/DSL required, duplicate check, 103
envelope
- **13 new endpoints**: templates, prompts, tags, sessions CRUD,
chat/completions (SSE + non-stream stubs), rerun, test_db_connection,
logs, webhook/logs
- **756 Go unit tests** (745 → 756, +18)
- **17 → 0 Python integration test failures** (test_agents.py +
test_session_management/)

### Tools
21 eino tools: HTTPHelper, search tools, financial/data tools, mandatory
stubs

### Infrastructure
OTel observability, NATS message queue, DeepDoc gRPC client, SSRF
guards, IDOR mitigation
2026-06-12 22:58:28 +08:00

84 lines
3.3 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package dao
import (
"errors"
"testing"
"ragflow/internal/entity"
)
// TestUserCanvasVersionDAO_Constructor verifies the DAO constructor returns
// a non-nil, callable value and that the struct is stateless (two calls
// produce equivalent instances).
func TestUserCanvasVersionDAO_Constructor(t *testing.T) {
dao1 := NewUserCanvasVersionDAO()
dao2 := NewUserCanvasVersionDAO()
if dao1 == nil || dao2 == nil {
t.Fatalf("NewUserCanvasVersionDAO returned nil")
}
// Stateless: both DAOs must be usable in the same way.
_ = dao1
_ = dao2
}
// TestUserCanvasVersionDAO_NotFoundSentinel verifies the sentinel error is
// exposed and not equal to gorm.ErrRecordNotFound. The service layer relies
// on this distinct sentinel to map 404 responses.
func TestUserCanvasVersionDAO_NotFoundSentinel(t *testing.T) {
if ErrUserCanvasVersionNotFound == nil {
t.Fatal("ErrUserCanvasVersionNotFound must be a non-nil sentinel")
}
// Sentinel must be distinct from arbitrary error literals so that
// the service layer can map it back to a stable 404.
if ErrUserCanvasVersionNotFound == errors.New("not found") {
t.Fatal("ErrUserCanvasVersionNotFound must be a stable package-level sentinel, not a fresh error")
}
// A string-only wrap (without %w) does not establish an errors.Is chain.
// Confirming that here documents the expected propagation contract.
wrapped := errors.New("wrapped: " + ErrUserCanvasVersionNotFound.Error())
if errors.Is(wrapped, ErrUserCanvasVersionNotFound) {
t.Fatal("a string-only wrap should not satisfy errors.Is(ErrUserCanvasVersionNotFound)")
}
}
// daoInterface is the contract that handler/service code consumes from
// UserCanvasVersionDAO. Asserting at compile time that the concrete DAO
// satisfies it prevents accidental signature drift in future refactors.
type daoInterface interface {
Create(v *entity.UserCanvasVersion) error
GetByID(id string) (*entity.UserCanvasVersion, error)
ListByCanvasID(canvasID string) ([]*entity.UserCanvasVersion, error)
GetLatest(canvasID string) (*entity.UserCanvasVersion, error)
Delete(id string) error
DeleteByCanvasID(canvasID string) (int64, error)
}
var _ daoInterface = (*UserCanvasVersionDAO)(nil)
// TestUserCanvasVersionDAO_InterfaceSatisfied is a runtime marker for the
// compile-time assertion above. Any future removal of a method will fail
// compilation in this file before this test ever runs.
func TestUserCanvasVersionDAO_InterfaceSatisfied(t *testing.T) {
// The compile-time `var _ daoInterface = (*UserCanvasVersionDAO)(nil)`
// above is the actual check. This function exists so the file has at
// least one explicit test bound to a method, not just a sentinel.
d := NewUserCanvasVersionDAO()
_ = daoInterface(d)
}