Files
ragflow/internal/agent/tool/google_scholar_test.go
Zhichang Yu 3fa15c0e2f feat(agent): Go port — canvas engine, 22 components, DSL v2, 13 endpoints (#15952)
Ports the agent canvas subsystem from Python to Go.

## What's included

### Canvas Engine (Phase 0/1)
- State engine, scheduler, variable resolver, Redis checkpoint store,
cancel protocol
- **209 tests** across canvas / component / io packages

### 22 Components (P0–P4)
| Tier | Components |
|---|---|
| P0 T1+T2+T3 | LLM, Agent, ExitLoop, Switch, Categorize, Begin,
Message, Invoke |
| P1 T3 | VariableAggregator, VariableAssigner, StringTransform,
ListOperations, DataOperations |
| P2 T3 | Iteration, IterationItem, Loop, LoopItem |
| P3 T3 | UserFillUp, Fillup |
| P4 T5 | Browser, ExcelProcessor, DocsGenerator |

### DSL v2 Schema (Phase 2.5)
- Typed v2 in-memory model with v1-to-v2 auto-detect converter
- v1 legacy field stripping per plan §2.11.7

### HTTP Endpoints & Bug Fixes (Plans PR1–PR3)
- **DELETE SQL bug fix**: gorm v2 `Where("id = ?", id).Delete(...)`
pattern
- **CreateAgent validation**: title/DSL required, duplicate check, 103
envelope
- **13 new endpoints**: templates, prompts, tags, sessions CRUD,
chat/completions (SSE + non-stream stubs), rerun, test_db_connection,
logs, webhook/logs
- **756 Go unit tests** (745 → 756, +18)
- **17 → 0 Python integration test failures** (test_agents.py +
test_session_management/)

### Tools
21 eino tools: HTTPHelper, search tools, financial/data tools, mandatory
stubs

### Infrastructure
OTel observability, NATS message queue, DeepDoc gRPC client, SSRF
guards, IDOR mitigation
2026-06-12 22:58:28 +08:00

189 lines
5.2 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package tool
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"net/url"
"strings"
"testing"
)
const cannedScholarHTML = `<html><body>
<div class="gs_r gs_or gs_scl" style="display:none"></div>
<div class="gs_r">
<div class="gs_ri">
<h3 class="gs_rt">
<a href="https://example.com/paper1">Attention is all you need</a>
</h3>
<div class="gs_a">Ashish Vaswani, Noam Shazeer, Niki Parmar - NeurIPS 2017</div>
<div class="gs_rs">The dominant sequence transduction models are based on complex recurrent or convolutional neural networks.</div>
</div>
</div>
<div class="gs_r">
<div class="gs_ri">
<h3 class="gs_rt">
<a href="https://example.com/paper2">BERT: Pre-training of Deep Bidirectional Transformers</a>
</h3>
<div class="gs_a">Jacob Devlin, Ming-Wei Chang - NAACL 2019</div>
<div class="gs_rs">We introduce a new language representation model called BERT.</div>
</div>
</div>
</body></html>`
func TestGoogleScholar_BuildURL(t *testing.T) {
t.Parallel()
cases := []struct {
name string
query string
max int
wantNum string
wantHost string
wantQuery string
}{
{
name: "default",
query: "transformer",
max: 0,
wantNum: "5",
wantHost: "scholar.google.com",
wantQuery: "transformer",
},
{
name: "clamped high",
query: "x",
max: 99,
wantNum: "20",
wantHost: "scholar.google.com",
wantQuery: "x",
},
{
name: "explicit",
query: "a b",
max: 3,
wantNum: "3",
wantHost: "scholar.google.com",
wantQuery: "a b",
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
got := buildGoogleScholarURL(tc.query, tc.max)
u, err := url.Parse(got)
if err != nil {
t.Fatalf("url.Parse(%q): %v", got, err)
}
if u.Host != tc.wantHost {
t.Errorf("host = %q, want %q", u.Host, tc.wantHost)
}
if u.Path != "/scholar" {
t.Errorf("path = %q, want /scholar", u.Path)
}
q := u.Query()
if q.Get("q") != tc.wantQuery {
t.Errorf("q = %q, want %q", q.Get("q"), tc.wantQuery)
}
if q.Get("num") != tc.wantNum {
t.Errorf("num = %q, want %q", q.Get("num"), tc.wantNum)
}
})
}
}
func TestGoogleScholar_ParseResults(t *testing.T) {
t.Parallel()
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/html; charset=UTF-8")
_, _ = w.Write([]byte(cannedScholarHTML))
}))
defer srv.Close()
helper := NewHTTPHelper().WithClient(&http.Client{
Transport: rewriteHostTransport(srv.URL),
})
tool := NewGoogleScholarToolWith(helper)
out, err := tool.InvokableRun(context.Background(),
`{"query":"transformer","max_results":5}`)
if err != nil {
t.Fatalf("InvokableRun: %v", err)
}
var env googleScholarEnvelope
if jerr := json.Unmarshal([]byte(out), &env); jerr != nil {
t.Fatalf("output is not valid JSON: %v (raw=%s)", jerr, out)
}
if env.Error != "" {
t.Errorf("Error = %q, want empty", env.Error)
}
if len(env.Results) != 2 {
t.Fatalf("Results len = %d, want 2", len(env.Results))
}
if !strings.Contains(env.Results[0].Title, "Attention") {
t.Errorf("Results[0].Title = %q, want to contain Attention", env.Results[0].Title)
}
if env.Results[0].Link != "https://example.com/paper1" {
t.Errorf("Results[0].Link = %q, want https://example.com/paper1", env.Results[0].Link)
}
if !strings.Contains(env.Results[0].Authors, "Vaswani") {
t.Errorf("Results[0].Authors = %q, want to contain Vaswani", env.Results[0].Authors)
}
if env.Results[0].Year != "2017" {
t.Errorf("Results[0].Year = %q, want 2017", env.Results[0].Year)
}
if !strings.Contains(env.Results[0].Snippet, "sequence transduction") {
t.Errorf("Results[0].Snippet = %q, want snippet", env.Results[0].Snippet)
}
if env.Results[1].Year != "2019" {
t.Errorf("Results[1].Year = %q, want 2019", env.Results[1].Year)
}
}
func TestGoogleScholar_RequiresQuery(t *testing.T) {
t.Parallel()
tool := NewGoogleScholarTool()
_, err := tool.InvokableRun(context.Background(), `{"query":""}`)
if err == nil {
t.Fatal("expected error for empty query")
}
if !strings.Contains(err.Error(), "query") {
t.Errorf("err = %v, want to mention query", err)
}
}
func TestGoogleScholar_Info(t *testing.T) {
t.Parallel()
tool := NewGoogleScholarTool()
info, err := tool.Info(context.Background())
if err != nil {
t.Fatalf("Info: %v", err)
}
if info.Name != "google_scholar" {
t.Errorf("Name = %q, want google_scholar", info.Name)
}
if !strings.Contains(info.Desc, "Scholar") {
t.Errorf("Desc = %q, want to mention Scholar", info.Desc)
}
}