Files
ragflow/internal/agent/component/userfillup_test.go
Zhichang Yu e45659868a feat(agent): ship the Go agent canvas port — eino interrupt/resume + Redis check-pointing (#16035)
Replaces the Python agent canvas runtime with a Go implementation that
runs inside `cmd/server_main`.

The canvas compiles into an eino Workflow that pauses on wait-for-user
via native Interrupt/Resume (no sentinel flag) and resumes from a
Redis-backed CheckPointStore.

All 21 Python agent components and ~35 tools are ported with functional
parity.

Sandbox providers now read their JSON config from the admin-panel
system_settings table with env fallback.

234 files / +35,413 / -6,111. All Go files are gofmt-clean (CI gate
added); drops the v2 DSL E2E step and the gap-analysis plan (both
redundant after the port ships).

## Type of change

- [x] Refactoring
- [x] New feature
- [x] Bug fix

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-06-17 13:24:03 +08:00

162 lines
5.2 KiB
Go

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package component
import (
"context"
"testing"
"ragflow/internal/agent/canvas"
)
// TestUserFillUp_RendersTips verifies the canonical happy path: a
// single {{name}} placeholder in the tips template is resolved against
// the inputs[name].value entry. The "tips" output key must hold the
// rendered string.
func TestUserFillUp_RendersTips(t *testing.T) {
c, _ := New(componentNameUserFillUp, map[string]any{
"enable_tips": true,
"tips": "Hello {{name}}",
})
state := canvas.NewCanvasState("run-1", "task-1")
ctx := withStateForTest(context.Background(), state)
out, err := c.Invoke(ctx, map[string]any{
"inputs": map[string]any{
"name": map[string]any{"value": "World"},
},
})
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if got, _ := out["tips"].(string); got != "Hello World" {
t.Errorf("tips: got %q, want %q", got, "Hello World")
}
}
// TestUserFillUp_DisableTips asserts that turning tips off removes the
// "tips" key entirely from the output. The form-field passthrough still
// runs.
func TestUserFillUp_DisableTips(t *testing.T) {
c, _ := New(componentNameUserFillUp, map[string]any{
"enable_tips": false,
"tips": "Should not render",
})
state := canvas.NewCanvasState("run-2", "task-2")
ctx := withStateForTest(context.Background(), state)
out, err := c.Invoke(ctx, map[string]any{
"inputs": map[string]any{
"name": map[string]any{"value": "World"},
},
})
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if _, ok := out["tips"]; ok {
t.Errorf("tips key must be absent when enable_tips=false, got %v", out["tips"])
}
// Passthrough still applies.
if got, _ := out["name"].(string); got != "World" {
t.Errorf("name passthrough: got %q, want %q", got, "World")
}
}
// TestUserFillUp_PassesThroughInputs asserts the multi-field
// passthrough contract: every non-file field appears in the output
// with its inner `value` extracted. This is the contract the downstream
// LLM/Retrieval nodes rely on to consume the form's answers.
func TestUserFillUp_PassesThroughInputs(t *testing.T) {
c, _ := New(componentNameUserFillUp, map[string]any{"enable_tips": false})
state := canvas.NewCanvasState("run-3", "task-3")
ctx := withStateForTest(context.Background(), state)
out, err := c.Invoke(ctx, map[string]any{
"inputs": map[string]any{
"q": map[string]any{"value": "What is RAGFlow?"},
"top_k": map[string]any{"value": 5},
"deep": map[string]any{"value": true},
},
})
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if got, _ := out["q"].(string); got != "What is RAGFlow?" {
t.Errorf("q: got %q, want %q", got, "What is RAGFlow?")
}
if got, _ := out["top_k"].(int); got != 5 {
t.Errorf("top_k: got %v, want 5", out["top_k"])
}
if got, _ := out["deep"].(bool); !got {
t.Errorf("deep: got %v, want true", out["deep"])
}
}
// TestUserFillUp_FileInputStub pins the file-typed input stub
// contract: a file-typed input must be replaced by the "<file:key>"
// stub in both the per-field output and any reference inside the
// tips template.
func TestUserFillUp_FileInputStub(t *testing.T) {
c, _ := New(componentNameUserFillUp, map[string]any{
"enable_tips": true,
"tips": "Upload {{cv}} please",
})
state := canvas.NewCanvasState("run-4", "task-4")
ctx := withStateForTest(context.Background(), state)
out, err := c.Invoke(ctx, map[string]any{
"inputs": map[string]any{
"cv": map[string]any{
"value": []any{"file-1", "file-2"},
"type": "file",
},
},
})
if err != nil {
t.Fatalf("Invoke: %v", err)
}
if got, _ := out["cv"].(string); got != "<file:cv>" {
t.Errorf("cv stub: got %q, want %q", got, "<file:cv>")
}
if got, _ := out["tips"].(string); got != "Upload <file:cv> please" {
t.Errorf("tips with file stub: got %q, want %q", got, "Upload <file:cv> please")
}
}
// TestUserFillUp_ParamCheck covers the ParamBase surface used by the
// orchestrator: defaults, Update, Check, AsDict. This is the contract
// the registry's editor tool relies on when round-tripping configs.
func TestUserFillUp_ParamCheck(t *testing.T) {
var p userFillUpParam
if err := p.Update(map[string]any{}); err != nil {
t.Fatalf("Update(empty): %v", err)
}
if !p.EnableTips {
t.Error("Update with empty conf should default enable_tips=true")
}
if p.Tips != defaultUserFillUpTips {
t.Errorf("Update with empty conf should default tips=%q, got %q", defaultUserFillUpTips, p.Tips)
}
if err := p.Check(); err != nil {
t.Errorf("Check: %v", err)
}
d := p.AsDict()
if d["enable_tips"] != true || d["tips"] != defaultUserFillUpTips || d["layout_recognize"] != "" {
t.Errorf("AsDict: %v", d)
}
}