mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-06-29 15:31:05 +08:00
14174b2364
### What problem does this PR solve? Closes #15435 Several agent tools call external HTTP APIs through `requests` with no request timeout. When an upstream host accepts the connection but never responds (a slow or overloaded API, a half open connection, a stuck load balancer), the call blocks forever. These tools run inside agent canvas execution, so a single stalled socket freezes the entire agent run with no recovery. Ten call sites were affected: - `agent/tools/qweather.py` (4 calls) - `agent/tools/jin10.py` (4 calls) - `agent/tools/tushare.py` (1 call) - `agent/tools/github.py` (1 call) The `github.py` tool already carried the `@timeout` decorator from `common/connection_utils.py`, but that does not protect against this case. In the default configuration the decorator waits on its result queue with no timeout, and a daemon thread blocked inside a socket read cannot be killed, so the run still hangs. The per request timeout added here is what actually bounds the call. This is the same bug class as the merged Go stream timeout fix, surfacing in the Python tool layer. Changes: - Pass `timeout=DEFAULT_TIMEOUT` on all 10 calls, reusing the existing shared constant in `common/http_client.py` (configurable via `HTTP_CLIENT_TIMEOUT`) so there is one source of truth rather than scattered literals. - Add an AST based unit test at `test/unit_test/agent/tools/test_http_timeout.py` that scans every tool module and fails if any `requests` or `httpx` request call omits a `timeout`, guarding current and future call sites. Verification: - Reproduced the indefinite block against a stalling local server, and confirmed that adding a timeout raises `ReadTimeout` promptly. - Confirmed the `@timeout` decorator does not interrupt a blocked no timeout request in its default configuration. - The new test flags exactly the 10 original call sites on the pre fix code and passes (22 modules) after the fix. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) - [ ] New Feature (non-breaking change which adds functionality) - [ ] Documentation Update - [ ] Refactoring - [ ] Performance Improvement - [ ] Other (please describe): --------- Co-authored-by: Zhichang Yu <yuzhichang@gmail.com>
86 lines
3.0 KiB
Python
86 lines
3.0 KiB
Python
#
|
|
# Copyright 2024 The InfiniFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
import json
|
|
from abc import ABC
|
|
import pandas as pd
|
|
import time
|
|
import requests
|
|
from agent.component.base import ComponentBase, ComponentParamBase
|
|
from common.http_client import DEFAULT_TIMEOUT
|
|
|
|
|
|
class TuShareParam(ComponentParamBase):
|
|
"""
|
|
Define the TuShare component parameters.
|
|
"""
|
|
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.token = "xxx"
|
|
self.src = "eastmoney"
|
|
self.start_date = "2024-01-01 09:00:00"
|
|
self.end_date = time.strftime("%Y-%m-%d %H:%M:%S", time.localtime())
|
|
self.keyword = ""
|
|
|
|
def check(self):
|
|
self.check_valid_value(self.src, "Quick News Source",
|
|
["sina", "wallstreetcn", "10jqka", "eastmoney", "yuncaijing", "fenghuang", "jinrongjie"])
|
|
|
|
|
|
class TuShare(ComponentBase, ABC):
|
|
component_name = "TuShare"
|
|
|
|
def _run(self, history, **kwargs):
|
|
if self.check_if_canceled("TuShare processing"):
|
|
return
|
|
|
|
ans = self.get_input()
|
|
ans = ",".join(ans["content"]) if "content" in ans else ""
|
|
if not ans:
|
|
return TuShare.be_output("")
|
|
|
|
try:
|
|
if self.check_if_canceled("TuShare processing"):
|
|
return
|
|
|
|
tus_res = []
|
|
params = {
|
|
"api_name": "news",
|
|
"token": self._param.token,
|
|
"params": {"src": self._param.src, "start_date": self._param.start_date,
|
|
"end_date": self._param.end_date}
|
|
}
|
|
response = requests.post(url="http://api.tushare.pro", data=json.dumps(params).encode('utf-8'), timeout=DEFAULT_TIMEOUT)
|
|
response = response.json()
|
|
if self.check_if_canceled("TuShare processing"):
|
|
return
|
|
if response['code'] != 0:
|
|
return TuShare.be_output(response['msg'])
|
|
df = pd.DataFrame(response['data']['items'])
|
|
df.columns = response['data']['fields']
|
|
if self.check_if_canceled("TuShare processing"):
|
|
return
|
|
tus_res.append({"content": (df[df['content'].str.contains(self._param.keyword, case=False)]).to_markdown()})
|
|
except Exception as e:
|
|
if self.check_if_canceled("TuShare processing"):
|
|
return
|
|
return TuShare.be_output("**ERROR**: " + str(e))
|
|
|
|
if not tus_res:
|
|
return TuShare.be_output("")
|
|
|
|
return pd.DataFrame(tus_res)
|