// // Copyright 2026 The InfiniFlow Authors. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // package chunker import ( "context" "strings" "testing" "ragflow/internal/agent/runtime" "ragflow/internal/ingestion/component/schema" ) // TestTitleChunker_Registered asserts the registry has a CategoryIngestion // entry for TitleChunker. func TestTitleChunker_Registered(t *testing.T) { factory, cat, meta, ok := runtime.DefaultRegistry.Lookup("TitleChunker") if !ok { t.Fatal("TitleChunker: registry miss") } if cat != runtime.CategoryIngestion { t.Errorf("category = %q, want %q", cat, runtime.CategoryIngestion) } if factory == nil { t.Error("factory is nil") } if len(meta.Inputs) == 0 { t.Errorf("inputs metadata is empty") } if len(meta.Outputs) == 0 { t.Errorf("outputs metadata is empty") } } // TestTitleChunker_InputsOutputs_NonEmpty asserts metadata is // populated for both ends. func TestTitleChunker_InputsOutputs_NonEmpty(t *testing.T) { _, _, meta, ok := runtime.DefaultRegistry.Lookup("TitleChunker") if !ok { t.Fatal("registry miss") } if len(meta.Inputs) == 0 { t.Error("inputs metadata is empty") } if len(meta.Outputs) == 0 { t.Error("outputs metadata is empty") } } // TestTitleChunker_NewRejectsBadMethod enforces the method check. func TestTitleChunker_NewRejectsBadMethod(t *testing.T) { if _, err := NewTitleChunker(map[string]any{ "method": "unknown", "levels": [][]string{{"^# "}}, }); err == nil { t.Fatal("expected error, got nil") } } // TestTitleChunker_NewRejectsHierarchyWithoutHierarchyParam enforces // the hierarchy branch's required-field check. func TestTitleChunker_NewRejectsHierarchyWithoutHierarchyParam(t *testing.T) { if _, err := NewTitleChunker(map[string]any{ "method": "hierarchy", "levels": [][]string{{"^# "}}, }); err == nil { t.Fatal("expected error, got nil") } } // TestTitleChunker_InvokeEmptyInput returns empty chunks for an // empty payload. func TestTitleChunker_InvokeEmptyInput(t *testing.T) { c, err := NewTitleChunker(map[string]any{ "method": "group", "levels": [][]string{{"^# "}}, }) if err != nil { t.Fatalf("NewTitleChunker: %v", err) } out, err := c.Invoke(context.Background(), nil, map[string]any{}) if err != nil { t.Fatalf("Invoke: %v", err) } if got, want := out["output_format"], "chunks"; got != want { t.Errorf("output_format = %v, want %v", got, want) } chunks, _ := out["chunks"].([]map[string]any) if len(chunks) != 0 { t.Errorf("chunks = %d, want 0", len(chunks)) } } // TestTitleChunker_Headings_ASCII is the golden-file parity check // for the markdown detector: a # heading + body + ## subheading + body // is recognized at least one chunked partition boundary. // // Note: the title strategy is dispatched to the underlying strategy // (`group` by default, or `hierarchy` when configured). Each // strategy test lives in its own file; this test routes through // both via the dispatcher. func TestTitleChunker_Headings_ASCII(t *testing.T) { c, err := NewTitleChunker(map[string]any{ "method": "group", "levels": [][]string{ {`^# `}, {`^## `}, {`^### `}, }, }) if err != nil { t.Fatalf("NewTitleChunker: %v", err) } input := "# Top\nFirst body line under Top.\nSecond body.\n## Sub\nBody under Sub heading.\n# TopTwo\nBody under TopTwo." out, err := c.Invoke(context.Background(), nil, map[string]any{ "name": "doc.md", "text": input, }) if err != nil { t.Fatalf("Invoke: %v", err) } if got, want := out["output_format"], "chunks"; got != want { t.Errorf("output_format = %v, want %v", got, want) } chunks, _ := out["chunks"].([]map[string]any) if len(chunks) == 0 { t.Fatal("chunks: want >=1, got 0") } for i, ck := range chunks { if text, _ := ck["text"].(string); text == "" { t.Errorf("chunk[%d] text is empty", i) } } } // TestTitleChunker_NoHeadings_FallsBack feeds plain text without any // markdown heading; the chunker should still produce a chunk // containing the body text (single chunk fallback). func TestTitleChunker_NoHeadings_FallsBack(t *testing.T) { c, err := NewTitleChunker(map[string]any{ "method": "group", "levels": [][]string{{"^# "}}, }) if err != nil { t.Fatalf("NewTitleChunker: %v", err) } out, err := c.Invoke(context.Background(), nil, map[string]any{ "name": "doc.txt", "text": "alpha line one\nalpha line two", }) if err != nil { t.Fatalf("Invoke: %v", err) } chunks, _ := out["chunks"].([]map[string]any) if len(chunks) == 0 { t.Fatal("chunks: want >=1, got 0") } } // TestTitleChunker_DispatcherHierarchy routes to the hierarchy // strategy without panicking. func TestTitleChunker_DispatcherHierarchy(t *testing.T) { c, err := NewTitleChunker(map[string]any{ "method": "hierarchy", "hierarchy": 1, "levels": [][]string{{`^# `}, {`^## `}}, }) if err != nil { t.Fatalf("NewTitleChunker: %v", err) } if _, ok := c.(*TitleChunkerComponent); !ok { t.Fatalf("NewTitleChunker returned %T", c) } _, err = c.Invoke(context.Background(), nil, map[string]any{ "name": "doc.md", "text": "# Top\nFirst body.\n# TopTwo\nBody under TopTwo.", }) if err != nil { t.Fatalf("Invoke: %v", err) } } // TestTitleChunker_InvokeDeterministic runs the heading detector // 10 times and asserts the chunks list is identical. func TestTitleChunker_InvokeDeterministic(t *testing.T) { c, err := NewTitleChunker(map[string]any{ "method": "group", "levels": [][]string{ {`^# `}, {`^## `}, }, }) if err != nil { t.Fatalf("NewTitleChunker: %v", err) } inputs := map[string]any{ "name": "doc.md", "text": "# A\nbody a line 1\nbody a line 2\n# B\nbody b line 1\n# C\nbody c line 1", } var firstLen int var firstTexts []string for run := 0; run < 10; run++ { out, err := c.Invoke(context.Background(), nil, inputs) if err != nil { t.Fatalf("Invoke run %d: %v", run, err) } chunks, _ := out["chunks"].([]map[string]any) texts := make([]string, len(chunks)) for i, ck := range chunks { texts[i], _ = ck["text"].(string) } if run == 0 { firstLen = len(chunks) firstTexts = texts continue } if firstLen != len(chunks) { t.Fatalf("run %d: chunk count changed (%d vs %d)", run, len(chunks), firstLen) } for i := range chunks { if firstTexts[i] != texts[i] { t.Fatalf("run %d: chunk[%d] text changed", run, i) } } } } // TestNewLevelContext_MostLevelIsMode pins Gap A: most_level is the // most-frequent non-body heading level (the mode), matching python // Counter(levels).most_common(). The old loop iterated map values and // returned the smallest count, which skewed the group fallback target. func TestNewLevelContext_MostLevelIsMode(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", Levels: [][]string{{`^# `, `^## `, `^### `}}, }} records := []lineRecord{ {text: "# a", docType: "text"}, {text: "## b", docType: "text"}, {text: "## c", docType: "text"}, {text: "### d", docType: "text"}, } lc := newLevelContext(records, nil, p) // selectLevelGroup picks the single 3-pattern family; per-line // levels are [1,2,2,3], so the mode (most frequent heading level) // is level 2. if lc.mostLevel != 2 { t.Errorf("mostLevel = %d, want 2 (the most frequent heading level)", lc.mostLevel) } } // TestNotBullet pins Gap B: the port of rag/nlp.not_bullet must reject // numbered/bulleted list lines so they are not promoted to headings. func TestNotBullet(t *testing.T) { bullet := []string{ "0", "1 2个", "1... trailing", "1.2.3.4的", "2.3.4中", "0.5 section", } for _, s := range bullet { if !notBullet(s) { t.Errorf("notBullet(%q) = false, want true", s) } } heading := []string{ "# Heading", "## Subheading", "Section 1", "Article 12", "1.2 Normal sentence", "1.2.3 without marker", } for _, s := range heading { if notBullet(s) { t.Errorf("notBullet(%q) = true, want false", s) } } } // TestNotTitle pins the port of rag/nlp.not_title used by the layout // fallback: long/no-space/punctuated lines are "not a title", while // the 第…条 exception and short title-like lines are titles. func TestNotTitle(t *testing.T) { longLine := "one two three four five six seven eight nine ten eleven twelve thirteen" if !notTitle(longLine) { t.Errorf("notTitle(>12 words) = false, want true") } noSpace := strings.Repeat("x", 40) if !notTitle(noSpace) { t.Errorf("notTitle(no space, >=32 chars) = false, want true") } if !notTitle("This, is a body line") { t.Errorf("notTitle(comma line) = false, want true") } if notTitle("第三条 关于某某规定") { t.Errorf("notTitle(第…条) = true, want false (exception)") } if notTitle("Chapter One") { t.Errorf("notTitle(Chapter One) = true, want false") } } // TestResolveTitleLevels_NonTextPinnedToBody pins Gap D: a non-text // record whose caption would match a heading regex is still pinned to // BODY_LEVEL, because python never runs regex/layout detection for // doc_type_kwd != "text". func TestResolveTitleLevels_NonTextPinnedToBody(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", Levels: [][]string{{`^# `}}, }} records := []lineRecord{ {text: "# Real Heading", docType: "text"}, {text: "# image caption that matches", docType: "image"}, {text: "body line", docType: "text"}, } levels := resolveTitleLevels(records, p) if levels[0] != 1 { t.Errorf("text heading level = %d, want 1", levels[0]) } if levels[1] != bodyLevel { t.Errorf("non-text caption level = %d, want bodyLevel (%d)", levels[1], bodyLevel) } if levels[2] != bodyLevel { t.Errorf("body level = %d, want bodyLevel", levels[2]) } } // TestResolveTitleLevels_LayoutFallback pins Gap C: a text record that // misses every regex but whose layout flags it as a section/title/head // and whose text passes not_title is promoted to fallback_level = // len(selected_group) + 1. The group must have at least one regex hit // (here "# Real Heading") so it is selected; with one pattern the // fallback_level is 2. func TestResolveTitleLevels_LayoutFallback(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", Levels: [][]string{{`^# `}}, }} records := []lineRecord{ {text: "# Real Heading", docType: "text", layout: "title"}, {text: "Chapter One Overview", docType: "text", layout: "title"}, {text: "Some body paragraph text here.", docType: "text", layout: "text"}, } levels := resolveTitleLevels(records, p) if levels[0] != 1 { t.Errorf("regex heading level = %d, want 1", levels[0]) } if levels[1] != 2 { t.Errorf("layout title level = %d, want 2 (fallback_level)", levels[1]) } if levels[2] != bodyLevel { t.Errorf("plain body level = %d, want bodyLevel", levels[2]) } } // TestResolveOutlineLevels covers Chunker-1.5: a text line that matches a // PDF outline entry by character-bigram similarity (>0.8) is assigned the // outline level+1; lines that do not match stay BODY_LEVEL. The non-text // record is pinned to BODY_LEVEL regardless. func TestResolveOutlineLevels(t *testing.T) { outline := []outlineEntry{ {title: "第一章 概述", level: 0}, {title: "第二章 方法", level: 1}, } records := []lineRecord{ {text: "第一章 概述", docType: "text"}, {text: "本章介绍背景。", docType: "text"}, // no outline match {text: "figure caption", docType: "image"}, // non-text } levels, mostLevel, ok := resolveOutlineLevels(records, outline) if !ok { t.Fatalf("resolveOutlineLevels ok = false, want true") } if levels[0] != 1 { // outline level 0 + 1 t.Errorf("matched line level = %d, want 1", levels[0]) } if levels[1] != bodyLevel { t.Errorf("unmatched body level = %d, want bodyLevel", levels[1]) } if levels[2] != bodyLevel { t.Errorf("non-text level = %d, want bodyLevel", levels[2]) } if mostLevel != 1 { // max(1, max outline level 1) t.Errorf("mostLevel = %d, want 1", mostLevel) } } // TestResolveOutlineLevels_SparseGuard ensures a too-sparse outline (ratio // <= 0.03) is rejected so detection falls back to frequency branch. func TestResolveOutlineLevels_SparseGuard(t *testing.T) { outline := []outlineEntry{{title: "唯一的章节标题", level: 0}} // 100 body records: 1/100 = 0.01 <= 0.03 -> rejected. records := make([]lineRecord, 100) for i := range records { records[i] = lineRecord{text: "body paragraph", docType: "text"} } if _, _, ok := resolveOutlineLevels(records, outline); ok { t.Errorf("sparse outline ok = true, want false") } if _, _, ok := resolveOutlineLevels(records, nil); ok { t.Errorf("nil outline ok = true, want false") } } // TestNewLevelContext_OutlineBranch pins Chunker-1.5 end-to-end: when an // outline is supplied, newLevelContext prefers the outline branch over the // regex/frequency branch. func TestNewLevelContext_OutlineBranch(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", Levels: [][]string{{`^# `}}, }} outline := []outlineEntry{{title: "前言", level: 0}} records := []lineRecord{ {text: "前言", docType: "text"}, // matches outline -> level 1 {text: "普通正文段落。", docType: "text"}, // no outline -> BODY_LEVEL } lc := newLevelContext(records, outline, p) if got := lc.Levels(); got[0] != 1 || got[1] != bodyLevel { t.Errorf("outline levels = %v, want [1, bodyLevel]", got) } } // TestOutlineFromInputs verifies the parser-supplied file.outline is parsed // into outlineEntry, tolerating float64-encoded levels (runtime JSON path). func TestOutlineFromInputs(t *testing.T) { inputs := map[string]any{ "file": map[string]any{ "outline": []any{ map[string]any{"title": "第一章", "level": float64(0), "page_number": float64(1)}, map[string]any{"title": "第二章", "level": float64(1), "page_number": float64(3)}, }, }, } out := outlineFromInputs(inputs) if len(out) != 2 { t.Fatalf("outline len = %d, want 2", len(out)) } if out[0].title != "第一章" || out[0].level != 0 { t.Errorf("entry 0 = %+v, want {第一章 0}", out[0]) } if out[1].title != "第二章" || out[1].level != 1 { t.Errorf("entry 1 = %+v, want {第二章 1}", out[1]) } // No file / no outline -> nil (frequency fallback). if got := outlineFromInputs(map[string]any{}); got != nil { t.Errorf("empty inputs outline = %v, want nil", got) } } // TestResolveTitleLevels_BulletFallback covers Chunker-1.7: when // frequency-based detection assigns bodyLevel to every record, the // BULLET_PATTERN bullet-fallback scans the text for numbered/bulleted // list entries and assigns structural levels, mirroring Python's // bullets_category + title_frequency. func TestResolveTitleLevels_BulletFallback(t *testing.T) { // All subtests use empty Levels to ensure no regex group matches, // so the bullet fallback is the only level signal. t.Run("ChineseLegalGroups0", func(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", }} records := []lineRecord{ {text: "第一条 定义", docType: "text"}, {text: "第二条 适用范围", docType: "text"}, {text: "这是普通正文内容。", docType: "text"}, } levels := resolveTitleLevels(records, p) // "第一条" matches group-0 index-3 (r"第...条") -> level = 3+1 = 4. if lvl := levels[0]; lvl >= bodyLevel || lvl <= 0 { t.Errorf("bullet line '第一条' level = %d, want non-body positive", lvl) } if lvl := levels[1]; lvl >= bodyLevel || lvl <= 0 { t.Errorf("bullet line '第二条' level = %d, want non-body positive", lvl) } if levels[2] != bodyLevel { t.Errorf("plain body line level = %d, want bodyLevel", levels[2]) } }) t.Run("NumberingGroup1", func(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", }} records := []lineRecord{ {text: "1. Introduction", docType: "text"}, {text: "2. Methods", docType: "text"}, {text: "3. Results", docType: "text"}, {text: "Plain body paragraph here.", docType: "text"}, } levels := resolveTitleLevels(records, p) for i := 0; i < 3; i++ { if lvl := levels[i]; lvl >= bodyLevel || lvl <= 0 { t.Errorf("numbered line index %d level = %d, want non-body positive", i, lvl) } } if levels[3] != bodyLevel { t.Errorf("plain body line level = %d, want bodyLevel", levels[3]) } }) t.Run("NotBulletExcluded", func(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", }} records := []lineRecord{ {text: "0", docType: "text"}, {text: "1 2 3", docType: "text"}, {text: "第一条 定义", docType: "text"}, } levels := resolveTitleLevels(records, p) // "0" and "1 2 3" are not-bullet -> bodyLevel. if levels[0] != bodyLevel { t.Errorf("notBullet '0' level = %d, want bodyLevel", levels[0]) } if levels[1] != bodyLevel { t.Errorf("notBullet '1 2 3' level = %d, want bodyLevel", levels[1]) } if lvl := levels[2]; lvl >= bodyLevel || lvl <= 0 { t.Errorf("genuine bullet '第一条' level = %d, want non-body positive", lvl) } }) t.Run("RegexMatchGuardsBulletFallback", func(t *testing.T) { p := &titleChunkerParam{TitleChunkerParam: schema.TitleChunkerParam{ Method: "group", Levels: [][]string{{`^第[零一二三四五六七八九十百0-9]+章`}}, }} records := []lineRecord{ {text: "第一章 概述", docType: "text"}, {text: "第一条 定义", docType: "text"}, } levels := resolveTitleLevels(records, p) // "第一章" matches the user-supplied regex -> level 1 from regex. // Because regex matched, bullet fallback must NOT fire. // "第一条" should still be bodyLevel (not promoted by bullet fallback). if levels[0] >= bodyLevel { t.Errorf("regex match '第一章' level = %d, want non-body (regex)", levels[0]) } if levels[1] != bodyLevel { t.Errorf("non-matching '第一条' level = %d, want bodyLevel (bullet fallback must not override regex path)", levels[1]) } }) }