From ff685d3131b4bef6c8706bc78f46c4a5bf679d43 Mon Sep 17 00:00:00 2001 From: Wang Qi Date: Wed, 13 May 2026 15:57:44 +0800 Subject: [PATCH] Delete duplicate route (#14883) ### What problem does this PR solve? The delete /graph is duplicated of `/datasets//`, delete it. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) --- api/apps/restful_apis/dataset_api.py | 20 +++---------------- .../test_knowledge_graph.py | 2 +- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/api/apps/restful_apis/dataset_api.py b/api/apps/restful_apis/dataset_api.py index 459bf786b8..df1862592c 100644 --- a/api/apps/restful_apis/dataset_api.py +++ b/api/apps/restful_apis/dataset_api.py @@ -559,21 +559,6 @@ async def get_knowledge_graph(tenant_id, dataset_id): return get_error_data_result(message="Internal server error") -@manager.route("/datasets//graph", methods=["DELETE"]) # noqa: F821 -@login_required -@add_tenant_id_to_kwargs -def delete_knowledge_graph(tenant_id, dataset_id): - try: - success, result = dataset_api_service.delete_knowledge_graph(dataset_id, tenant_id) - if success: - return get_result(data=result) - else: - return get_result(data=False, message=result, code=RetCode.AUTHENTICATION_ERROR) - except Exception as e: - logging.exception(e) - return get_error_data_result(message="Internal server error") - - @manager.route("/datasets//index", methods=["POST"]) # noqa: F821 @login_required @add_tenant_id_to_kwargs @@ -613,10 +598,11 @@ def trace_index(tenant_id, dataset_id): @manager.route("/datasets//", methods=["DELETE"]) # noqa: F821 +@manager.route("/datasets//index", methods=["DELETE"]) # noqa: F821 @login_required @add_tenant_id_to_kwargs -def delete_index(tenant_id, dataset_id, index_type): - index_type = index_type.lower() +def delete_index(tenant_id, dataset_id, index_type=None): + index_type = (index_type or request.args.get("type", "")).lower() if index_type not in dataset_api_service._VALID_INDEX_TYPES: return get_error_argument_result(f"Invalid index type '{index_type}'") # `wipe` controls whether the persisted index artefacts (graph rows / diff --git a/test/testcases/test_http_api/test_dataset_management/test_knowledge_graph.py b/test/testcases/test_http_api/test_dataset_management/test_knowledge_graph.py index 0398f77239..f2ada816a5 100644 --- a/test/testcases/test_http_api/test_dataset_management/test_knowledge_graph.py +++ b/test/testcases/test_http_api/test_dataset_management/test_knowledge_graph.py @@ -50,4 +50,4 @@ class TestKnowledgeGraph: dataset_id = add_dataset_func res = delete_knowledge_graph(HttpApiAuth, dataset_id) assert res["code"] == 0, res - assert res["data"] is True, res + assert res["data"] is not None, res